[ovs-dev] [PATCH] python: Catch exception "SSL.SysCallError" for send by SSL.

When OVSDB server is aborted, the SSL send function will throw SSL.SysCallError exception, which we need to catch and return it's -errno. While SSL.WantWriteError exception needs to return -EAGAIN based on its parent class, not EAGAIN Signed-off-by: Guoshuai Li ---

Re: [ovs-dev] [PATCH v7 3/7] ovn: Introduce "chassisredirect" port binding

On Fri, Jan 6, 2017 at 4:21 PM, Mickey Spiegel wrote: > > On Fri, Jan 6, 2017 at 4:11 PM, Ben Pfaff wrote: > >> On Fri, Jan 06, 2017 at 03:47:03PM -0800, Mickey Spiegel wrote: >> > On Fri, Jan 6, 2017 at 3:20 PM, Ben Pfaff wrote: >> > >> > >

[ovs-dev] [PATCH] netdev: Add 'errp' to set_config().

Since 55e075e65ef9("netdev-dpdk: Arbitrary 'dpdk' port naming"), set_config() is used to identify a DPDK device, so it's better to report its detailed error message to the user. Tunnel devices and patch ports rely a lot on set_config() as well. This commit adds a param to set_config() that can

Re: [ovs-dev] [v2 2/2] ovsdb-idl: Enhance conditional monitoring API

On Fri, Jan 06, 2017 at 02:38:46PM -0800, Andy Zhou wrote: > To allow client to know when the conditional monitoring changes > has been accepted by the OVSDB server and the 'idl' contents has > been updated to match the new conditions. > > Signed-off-by: Andy Zhou Acked-by: Ben

Re: [ovs-dev] [PATCH v7 5/7] ovn: move load balancing flows after NAT flows

Seems fine. I think that I'll leave the remaining patches for others to review; I don't think I'm the best person to do it. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v7 3/7] ovn: Introduce "chassisredirect" port binding

On Fri, Jan 06, 2017 at 03:47:03PM -0800, Mickey Spiegel wrote: > On Fri, Jan 6, 2017 at 3:20 PM, Ben Pfaff wrote: > > > On Fri, Jan 06, 2017 at 12:00:30PM -0800, Mickey Spiegel wrote: > > > Currently OVN handles all logical router ports in a distributed manner, > > > creating

Re: [ovs-dev] [PATCH v7 4/7] ovn: add egress loopback capability

On Fri, Jan 06, 2017 at 12:00:31PM -0800, Mickey Spiegel wrote: > This patch adds the capability to force loopback at the end of the > egress pipeline. A new flags.force_egress_loopback symbol is defined, > along with corresponding flags bits. When flags.force_egress_loopback > is set, at

Re: [ovs-dev] [PATCH v7 3/7] ovn: Introduce "chassisredirect" port binding

On Fri, Jan 6, 2017 at 3:47 PM, Mickey Spiegel wrote: > > > On Fri, Jan 6, 2017 at 3:20 PM, Ben Pfaff wrote: > >> On Fri, Jan 06, 2017 at 12:00:30PM -0800, Mickey Spiegel wrote: >> > Currently OVN handles all logical router ports in a distributed manner, >>

Re: [ovs-dev] [PATCH v3] dpif: Return ENODEV from dpif_port_query_by_*() if there's no port.

On 06/01/2017 13:01, "Ben Pfaff" wrote: >On Fri, Jan 06, 2017 at 12:42:35PM -0800, Daniele Di Proietto wrote: >> bridge_delete_or_reconfigure() deletes every interface that's not dumped >> by OFPROTO_PORT_FOR_EACH(). ofproto_dpif.c:port_dump_next(), used by >>

Re: [ovs-dev] [PATCH v7 2/7] ovn: add is_chassis_resident match expression component

On Fri, Jan 06, 2017 at 12:00:29PM -0800, Mickey Spiegel wrote: > This patch introduces a new match expression component > is_chassis_resident(). Unlike match expression comparisons, > is_chassis_resident is not pushed down to OpenFlow. It is a > conditional that is evaluated in the controller

Re: [ovs-dev] [PATCH 1/3] ovsdb-idl: Avoid sending redundant conditional monitoring updates

On Thu, Dec 22, 2016 at 8:56 AM, Ben Pfaff wrote: > On Tue, Dec 20, 2016 at 01:47:15AM -0800, Andy Zhou wrote: > > In case connection is reset when there are buffered but unsent > > conditions, these conditions will be sent as the new "monitor_cond" > > message that will be sent

Re: [ovs-dev] [PATCH 2/3] ovsdb-idl: Properly handle conditional monitor update error

On Wed, Jan 4, 2017 at 3:55 PM, Ben Pfaff wrote: > On Thu, Dec 22, 2016 at 12:12:05PM -0800, Andy Zhou wrote: > > On Thu, Dec 22, 2016 at 9:21 AM, Ben Pfaff wrote: > > > > > On Tue, Dec 20, 2016 at 01:47:16AM -0800, Andy Zhou wrote: > > > > From: andy zhou

[ovs-dev] [v2 2/2] ovsdb-idl: Enhance conditional monitoring API

To allow client to know when the conditional monitoring changes has been accepted by the OVSDB server and the 'idl' contents has been updated to match the new conditions. Signed-off-by: Andy Zhou --- lib/ovsdb-idl.c| 44 +---

[ovs-dev] [v2 1/2] ovsdb-idl: Properly handle conditional monitor update error

From: andy zhou When generating conditional monitoring update request, current code failed to update idl's 'request-id'. This bug causes the reply message of the update request, regardless an ACK or a NACK, be logged as an unexpected message at the debug level and ignored by the

Re: [ovs-dev] [PATCH v2 3/5] datapath-windows: Fix typo in OvsUpdateIPv4Header

On Fri, Jan 06, 2017 at 07:33:44PM +, Alin Serdean wrote: > Found by inspection. > > Signed-off-by: Alin Gabriel Serdean > --- > v2: no change This one was obviously correct so I applied it. Others will need to provide real reviews for the other patches.

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

On Fri, Jan 06, 2017 at 01:10:14PM -0800, Jarno Rajahalme wrote: > > > On Jan 5, 2017, at 9:06 PM, Ben Pfaff wrote: > > > > On Thu, Jan 05, 2017 at 05:45:29PM -0800, Jarno Rajahalme wrote: > >> > >>> On Jan 5, 2017, at 4:48 PM, Ben Pfaff wrote: > >>> > >>> On Thu,

Re: [ovs-dev] [PATCH] nx-match: Only store significant bytes to stack.

> On Jan 5, 2017, at 9:06 PM, Ben Pfaff wrote: > > On Thu, Jan 05, 2017 at 05:45:29PM -0800, Jarno Rajahalme wrote: >> >>> On Jan 5, 2017, at 4:48 PM, Ben Pfaff wrote: >>> >>> On Thu, Jan 05, 2017 at 04:03:17PM -0800, Jarno Rajahalme wrote: > On Jan 4,

Re: [ovs-dev] [PATCH v2] dpif: Return ENODEV from dpif_port_query_by_name() if there's no port.

On Fri, Jan 06, 2017 at 08:43:03PM +, Daniele Di Proietto wrote: > > > > > > On 06/01/2017 11:34, "Ben Pfaff" wrote: > > >On Fri, Jan 06, 2017 at 10:59:07AM -0800, Daniele Di Proietto wrote: > >> bridge_delete_or_reconfigure() deletes every interface that's not dumped > >>

Re: [ovs-dev] [PATCH v3] dpif: Return ENODEV from dpif_port_query_by_*() if there's no port.

On Fri, Jan 06, 2017 at 12:42:35PM -0800, Daniele Di Proietto wrote: > bridge_delete_or_reconfigure() deletes every interface that's not dumped > by OFPROTO_PORT_FOR_EACH(). ofproto_dpif.c:port_dump_next(), used by > OFPROTO_PORT_FOR_EACH, checks if the ofport is in the datapath by > calling

Re: [ovs-dev] [PATCH v2] dpif: Return ENODEV from dpif_port_query_by_name() if there's no port.

On 06/01/2017 11:34, "Ben Pfaff" wrote: >On Fri, Jan 06, 2017 at 10:59:07AM -0800, Daniele Di Proietto wrote: >> bridge_delete_or_reconfigure() deletes every interface that's not dumped >> by OFPROTO_PORT_FOR_EACH(). ofproto_dpif.c:port_dump_next(), used by >>

Re: [ovs-dev] ovs-vswitch kernel panic randomly started after 400+ days uptime

Hey Joe, I agree with you. It dumbfounded us that a single packet could kernel panic a host so easily and in fact made me believe for at least a few days that this was a red herring. The fact that we cannot replicate it and randomly occurs (within a given time period) also makes it impossible

Re: [ovs-dev] ovs-vswitch kernel panic randomly started after 400+ days uptime

On 6 January 2017 at 11:47, Uri Foox wrote: > Hey Joe, > > I do agree that the patches for the Linux Kernel were not 1:1 with what > our stack trace showed but it was the only thing we remotely found that > explained our issue. Granted, after upgrading the kernel it was clear that

[ovs-dev] [PATCH v7 6/7] ovn: avoid snat recirc only on gateway routers

Currently, for performance reasons on gateway routers, ct_snat that does not specify an IP address does not immediately trigger recirculation. On gateway routers, ct_snat that does not specify an IP address happens in the UNSNAT pipeline stage, which is followed by the DNAT pipeline stage that

[ovs-dev] [PATCH v7 5/7] ovn: move load balancing flows after NAT flows

This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel

[ovs-dev] [PATCH v7 3/7] ovn: Introduce "chassisredirect" port binding

Currently OVN handles all logical router ports in a distributed manner, creating instances on each chassis. The logical router ingress and egress pipelines are traversed locally on the source chassis. In order to support advanced features such as one-to-many NAT (aka IP masquerading), where

[ovs-dev] [PATCH v7 4/7] ovn: add egress loopback capability

This patch adds the capability to force loopback at the end of the egress pipeline. A new flags.force_egress_loopback symbol is defined, along with corresponding flags bits. When flags.force_egress_loopback is set, at OFTABLE_LOG_TO_PHY, instead of the packet being sent out to the peer patch

[ovs-dev] [PATCH v7 2/7] ovn: add is_chassis_resident match expression component

This patch introduces a new match expression component is_chassis_resident(). Unlike match expression comparisons, is_chassis_resident is not pushed down to OpenFlow. It is a conditional that is evaluated in the controller during expr_simplify(), when it is replaced by a boolean expression. The

[ovs-dev] [PATCH v7 1/7] ovn: specify addresses of type "router" lsps as "router"

Currently in OVN, when a logical switch port of type "router" is created, the MAC and optionally IP addresses of the peer logical router port must be specified again as the addresses of the logical switch port. This patch allows the logical switch port's addresses to be specified as the string

[ovs-dev] [PATCH v7 0/7] ovn: add distributed NAT capability

Currently OVN supports NAT functionality by connecting each distributed logical router to a centralized "l3gateway" router that resides on a single chassis. NAT is only carried out in the "l3gateway" router. This patch set introduces NAT capability in the distributed logical router itself,

[ovs-dev] [PATCH v2 5/5] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

This patch adds support for set action with OVS_KEY_ATTR_TCP attribute (change TCP source or destination port). If the source or destination TCP port was changed, update the TCP checksum. A sample flow can look like the following: set(tcp(src=80,dst=443)) Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH v2 2/5] datapath-windows: Add function to get continuous buffer from context

This patch extracts the code that tries to get a continuous IPv4 header buffer from the function 'OvsUpdateIPv4Header' and moves it to a new function 'OvsGetHeaderBySize'. The new function can be used later when trying to change the UDP/TCP/MPLS etc., headers. Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH v2 4/5] datapath-windows: Add support for OVS_KEY_ATTR_UDP set action

This patch adds support for set action with OVS_KEY_ATTR_UDP attribute (change UDP source or destination port). If the source or destination UDP port was changed, update the UDP checksum. A sample flow can look like the following: set(udp(src=67,dst=68)) Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH v2 3/5] datapath-windows: Fix typo in OvsUpdateIPv4Header

Found by inspection. Signed-off-by: Alin Gabriel Serdean --- v2: no change --- datapath-windows/ovsext/Actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c index

Re: [ovs-dev] [PATCH v2] dpif: Return ENODEV from dpif_port_query_by_name() if there's no port.

On Fri, Jan 06, 2017 at 10:59:07AM -0800, Daniele Di Proietto wrote: > bridge_delete_or_reconfigure() deletes every interface that's not dumped > by OFPROTO_PORT_FOR_EACH(). ofproto_dpif.c:port_dump_next(), used by > OFPROTO_PORT_FOR_EACH, checks if the ofport is in the datapath by > calling

Re: [ovs-dev] [PATCH 1/2] ofctrl: Fix version check in ofctrl_inject_packet().

On Fri, Jan 06, 2017 at 10:55:11AM -0800, Joe Stringer wrote: > On 6 January 2017 at 10:50, Joe Stringer wrote: > > On 5 January 2017 at 17:03, Ben Pfaff wrote: > >> "enum ofp_version" is unsigned in the System V ABI used by Linux, so > >> it will never be less than

[ovs-dev] [PATCH 5/5] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

This patch adds support for set action with OVS_KEY_ATTR_TCP attribute (change TCP source or destination port). If the source or destination TCP port was changed, update the TCP checksum. A sample flow can look like the following: set(tcp(src=80,dst=443)) Signed-off-by: Alin Gabriel Serdean

Re: [ovs-dev] ovs-vswitch kernel panic randomly started after 400+ days uptime

On 5 January 2017 at 19:24, Uri Foox wrote: > Hey Joe, > > Thank you so much for responding! After 10 days of trying to figure this > out I'm at a loss. > > root@node-8:~# modinfo openvswitch > filename: /lib/modules/3.13.0-106-generic/kernel/net/ >

[ovs-dev] [PATCH 3/5] datapath-windows: Fix typo in OvsUpdateIPv4Header

Found by inspection. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c index a5f8f06..467bfbc

[ovs-dev] [PATCH 4/5] datapath-windows: Add support for OVS_KEY_ATTR_UDP set action

This patch adds support for set action with OVS_KEY_ATTR_UDP attribute (change UDP source or destination port). If the source or destination UDP port was changed, update the UDP checksum. A sample flow can look like the following: set(udp(src=67,dst=68)) Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH 2/5] datapath-windows: Add function to get continuous buffer from context

This patch extracts the code that tries to get a continuous IPv4 header buffer from the function 'OvsUpdateIPv4Header' and moves it to a new function 'OvsGetHeaderBySize'. The new function can be used later when trying to change the UDP/TCP/MPLS etc., headers. Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH 1/5] datapath-windows: OvsUpdateIPv4Header remove unnecessary addition

bufferStart can be used directly to access the data of the net buffer. Add the MDL offset to save unnecessary additions. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Actions.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[ovs-dev] [PATCH 0/5] Add support for actions needed by OVN

While setting up an OVN environment under Windows with OpenStack the VMs did not receive a DHCPACK, after sending out DHCPOFFER. After some investigation, the conclusion is that we are missing support for a set action with an UDP attribute. This series adds support for a set action with UDP and

Re: [ovs-dev] [PATCH] ofproto-dpif: Continue port dump if a port is missing from dpif-netdev.

On 06/01/2017 09:28, "Ben Pfaff" wrote: >On Thu, Jan 05, 2017 at 08:37:26PM -0800, Daniele Di Proietto wrote: >> bridge_delete_or_reconfigure() deletes every interface that's not dumped >> by OFPROTO_PORT_FOR_EACH(). ofproto_dpif.c:port_dump_next(), used by >>

[ovs-dev] [PATCH v2] dpif: Return ENODEV from dpif_port_query_by_name() if there's no port.

bridge_delete_or_reconfigure() deletes every interface that's not dumped by OFPROTO_PORT_FOR_EACH(). ofproto_dpif.c:port_dump_next(), used by OFPROTO_PORT_FOR_EACH, checks if the ofport is in the datapath by calling port_query_by_name(). If port_query_by_name() returns an error, the dump is

Re: [ovs-dev] [PATCH 1/2] ofctrl: Fix version check in ofctrl_inject_packet().

On 6 January 2017 at 10:50, Joe Stringer wrote: > On 5 January 2017 at 17:03, Ben Pfaff wrote: >> "enum ofp_version" is unsigned in the System V ABI used by Linux, so >> it will never be less than 0, so an rconn with an unnegotiated version will >> never be found

Re: [ovs-dev] DPDK: Inter VM communication of iperf3 TCP throughput is very low on same host compare to non DPDK throughput

I see the about the same numbers. Ethtool -k in the non-DPDK VMs show a lot of offloads that are not available in the DPDK VMs. One of these is tcp segmentation offload. When I turned this off, the rate dropped from about 17 to 2 Gbps. On Wed, Jan 4, 2017 at 9:59 AM, Rajalakshmi Prabhakar

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

Ok, thanks Ben. This must be a problem when copying to my browser. I've used git send-email to send it again. Hopefully this works. Thanks, John On Fri, Jan 6, 2017 at 5:30 PM, Ben Pfaff wrote: > This patch is still white space damaged. Look at >

[ovs-dev] [PATCH 1/1] datapath: Ensure correct L4 checksum with NAT helpers.

Setting the CHECKSUM_PARTIAL flag before sending to helper mods can mean that the kernel code will not modify the first part of the L4 checksum correctly after changing packet IPs/ports/payload in kernels <4.6. This can mean that the L4 checksum is incorrect when the packet egresses the system.

Re: [ovs-dev] [PATCH v6 2/7] ovn: add is_chassis_resident match expression component

It looks like a commit yesterday https://github.com/openvswitch/ovs/commit/b34e898f3c2956bed4703aeebb7d454a72a69eed is causing the mismatch. Starting to rebase now. Mickey On Fri, Jan 6, 2017 at 9:23 AM, Ben Pfaff wrote: > On Thu, Jan 05, 2017 at 02:46:18AM -0800, Mickey Spiegel

Re: [ovs-dev] [PATCH v6 2/7] ovn: add is_chassis_resident match expression component

Thanks! On Fri, Jan 06, 2017 at 09:35:30AM -0800, Mickey Spiegel wrote: > It looks like a commit yesterday > https://github.com/openvswitch/ovs/commit/b34e898f3c2956bed4703aeebb7d454a72a69eed > is causing the mismatch. > > Starting to rebase now. > > Mickey > > On Fri, Jan 6, 2017 at 9:23 AM,

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

This patch is still white space damaged. Look at https://patchwork.ozlabs.org/patch/712058/: the indentation is all wrong. On Fri, Jan 06, 2017 at 05:23:33PM +, John Hurley wrote: > From 7e20f404bde9fab2604566bc106b3b6ac071bd3f Mon Sep 17 00:00:00 2001 > From: John Hurley

Re: [ovs-dev] [PATCH] ofproto-dpif: Continue port dump if a port is missing from dpif-netdev.

On Thu, Jan 05, 2017 at 08:37:26PM -0800, Daniele Di Proietto wrote: > bridge_delete_or_reconfigure() deletes every interface that's not dumped > by OFPROTO_PORT_FOR_EACH(). ofproto_dpif.c:port_dump_next(), used by > OFPROTO_PORT_FOR_EACH, checks if the ofport is in the datapath by > calling

Re: [ovs-dev] [PATCH v6 2/7] ovn: add is_chassis_resident match expression component

On Thu, Jan 05, 2017 at 02:46:18AM -0800, Mickey Spiegel wrote: > This patch introduces a new match expression component > is_chassis_resident(). Unlike match expression comparisons, > is_chassis_resident is not pushed down to OpenFlow. It is a > conditional that is evaluated in the controller

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

>From 7e20f404bde9fab2604566bc106b3b6ac071bd3f Mon Sep 17 00:00:00 2001 From: John Hurley Date: Fri, 6 Jan 2017 17:14:53 + Subject: [PATCH 1/1] datapath: Ensure correct L4 checksum with NAT helpers. Fixes:264619055bd52bc2278af848472176642d759874 (datapath: conntrack

Re: [ovs-dev] [PATCH v6 1/7] ovn: specify addresses of type "router" lsps as "router"

On Thu, Jan 05, 2017 at 02:46:17AM -0800, Mickey Spiegel wrote: > Currently in OVN, when a logical switch port of type "router" is > created, the MAC and optionally IP addresses of the peer logical > router port must be specified again as the addresses of the logical > switch port. > > This patch

Re: [ovs-dev] *** SPAM *** [PATCH] xlate: Recirculate also when MPLS POP is implicit.

On Thu, Jan 05, 2017 at 06:19:41PM -0800, Jarno Rajahalme wrote: > 'ctx->was_mpls' is used to flag when an MPLS packet has been popped to > a non-MPLS packet, but it was not set when the MPLS POP is implicit > due to the 'ctx->xin->flow' being restored after a patch port > traversal to group

Re: [ovs-dev] [PATCH v3] nx-match: Only store significant bytes to stack.

On Thu, Jan 05, 2017 at 05:44:40PM -0800, Jarno Rajahalme wrote: > Always storing the maximum mf_value size wastes about 120 bytes for > each stack entry. This patch changes the stack from an mf_value array > to a string of value-length pairs. > > The length is stored after the value so that the

Re: [ovs-dev] [PATCH 0/3] Tunnel: add support for packet marking

On Wed, Dec 28, 2016 at 01:44:11AM -0800, Pravin B Shelar wrote: > Following patch series adds support for setting packet > mark for tunnel traffic. This allows better integration > with linux networking stack. Who do you think should review these? ___

Re: [ovs-dev] [PATCH] ovn-nbctl:The range of "PRIORITY" for "ovn-nbctl acl-add " command is wrong.

On Fri, Jan 06, 2017 at 03:55:40PM +0800, zhaojingjing wrote: > The range of "PRIORITY" for "ovn-nbctl acl-add " command is 1 to 65534 in > ovn-nbctl.8.xml",When configuring this command, it indicates that " > priority must in range 0...32767".The range of priority is inconsistent > in

Re: [ovs-dev] [PATCH v2 3/4] New action "ct_clear".

On Fri, Jan 06, 2017 at 12:54:00AM -0800, Mickey Spiegel wrote: > On Thu, Jan 5, 2017 at 8:58 PM, Ben Pfaff wrote: > > > This is being introduced specifically to allow a user of the "clone" action > > to clear the connection tracking state, but it's implemented as a separate > >

Re: [ovs-dev] [PATCH] ovn-nbctl: Specify the range of the tag for "ovn-nbctl lsp-add" command.

On Fri, Jan 06, 2017 at 03:53:31PM +0800, zhaojingjing wrote: > When configuring the wrong tag for "ovn-nbctl lsp-add" command， > it shows "invalid tag". The range of the tag is not known. > > Signed-off-by: zhaojingjing Applied, thanks.

[ovs-dev] [PATCH v3 3/4] New action "ct_clear".

This is being introduced specifically to allow a user of the "clone" action to clear the connection tracking state, but it's implemented as a separate action as a matter of clean design and in case another use case arises later. Reported-by: Mickey Spiegel Reported-at:

[ovs-dev] [PATCH v3 4/4] ovn-controller: Clear conntrack state inside clone action.

ovn-controller implements traversal from one OVN logical network to another using the Open vSwitch "clone" action. The "clone" action preserves connection tracking state, which is confusing for passing from one logical datapath to another because this state is only relevant for a single logical

[ovs-dev] [PATCH v3 2/4] ofproto-dpif-xlate: Make clone save "was_mpls".

This seems like it's an optimization rather than a correctness issue, but in general it's best to make "clone" like patch ports where there is no reason to depart from its design, since we know that patch ports work well. Reported-by: Mickey Spiegel Reported-at:

[ovs-dev] [PATCH v3 1/4] ofproto-dpif-xlate: Make "clone" save action set and stack.

This is a design decision but it seems conceptually cleaner than having them leak through into the clone. Reported-by: Mickey Spiegel Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-January/326981.html Fixes: 7ae62a676d3a ("ofp-actions: Add clone

[ovs-dev] [PATCH v3 0/4] Fix some "clone"-related issues

v1->v2: - Patches 1 and 2 were applied and dropped. - Patch 3 (now patch 1) no longer clears the action set or stack, although it saves and restores them, following discussion with Jarno and Mickey. - Patch 4 (now patch 2) is unchanged. - Patch 5 (now patch 3) dropped unrelated changes

Re: [ovs-dev] Issues with the use of the clone action for resubmission to the pipeline

On Fri, Jan 6, 2017 at 9:52 AM, Ben Pfaff wrote: > On Thu, Jan 05, 2017 at 05:54:46PM -0800, Jarno Rajahalme wrote: > > > > > On Jan 5, 2017, at 4:28 PM, Ben Pfaff wrote: > > > > > > On Tue, Jan 03, 2017 at 02:55:19AM -0800, Mickey Spiegel wrote: > > >> One of the

Re: [ovs-dev] [PATCH v2] dpcls: Avoid one 8-byte chunk in subtable mask.

Thanks Jarno for your feedback, will respin a new version with the suggested fix. Regards, Antonio > -Original Message- > From: Jarno Rajahalme [mailto:ja...@ovn.org] > Sent: Thursday, January 5, 2017 11:30 PM > To: Fischetti, Antonio > Cc:

[ovs-dev] [PATCH v3] dpcls: Avoid one 8-byte chunk in subtable mask.

This patch allows to skip the chunk comprising of dp_hash and in_port in the subtable mask when the packet is not recirculated. This will slightly speed up the hash computation as one expensive function call to hash_add64() can be skipped. For each new netdev flow we wildcard in_port in the mask,

Re: [ovs-dev] [PATCH net-next] net: make ndo_get_stats64 a void function

Hi Stephen, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/net-make-ndo_get_stats64-a-void-function/20170106-160123 config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget

Re: [ovs-dev] [PATCH v2 3/4] New action "ct_clear".

On Thu, Jan 5, 2017 at 8:58 PM, Ben Pfaff wrote: > This is being introduced specifically to allow a user of the "clone" action > to clear the connection tracking state, but it's implemented as a separate > action as a matter of clean design and in case another use case arises >

Re: [ovs-dev] [PATCH net-next] net: make ndo_get_stats64 a void function

Hi Stephen, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/net-make-ndo_get_stats64-a-void-function/20170106-160123 config: x86_64-acpi-redef (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce