Re: [ovs-dev] [PATCH v2] dpif-netdev: Change definitions of 'idle' & 'processing' cycles

2017-01-20 5:59 GMT-08:00 Jan Scheurich : > > > On 2017-01-18 17:32, Kevin Traynor wrote: >> >> On 01/18/2017 01:34 AM, Daniele Di Proietto wrote: >>> >>> 2017-01-17 11:43 GMT-08:00 Kevin Traynor : On 01/17/2017 05:43 PM, Ciara Loftus wrote:

[ovs-dev] [userspace clone v3 4/4] xlate: Generate of datapath clone action when supported

Add logic to detect whether datapath support clone. Enhance the xlate logic to make use of it. Added logic to turn on/off clone support for testing. Signed-off-by: Andy Zhou Acked-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 38

[ovs-dev] [userspace clone v3 3/4] dpif-netdev: Add clone action

Add support for userspace datapath clone action. The clone action provides an action envelope to enclose an action list. For example, with actions A, B, C and D, and an action list: A, clone(B, C), D The clone action will ensure that: - D will see the same packet, and any meta states,

Re: [ovs-dev] [PATCH v2 6/7] actions: Make "next" action able to jump from egress to ingress pipeline.

On Fri, Jan 20, 2017 at 2:48 PM, Ben Pfaff wrote: > This feature is useful for centralized gateways. > > Signed-off-by: Ben Pfaff > Acked-by: Mickey Spiegel I think there is some missing functionality in ovn-trace.c. It looks to me like

Re: [ovs-dev] [PATCH v2 4/7] actions: Omit table number when possible for formatting "next" action.

On Fri, Jan 20, 2017 at 2:48 PM, Ben Pfaff wrote: > Until now, formatting the "next" action has always required including > the table number, because the action struct didn't include enough context > so that the formatter could decide whether the table number was the next > table

Re: [ovs-dev] [PATCH 00/10] Add actions for egress loopback

On Fri, Jan 20, 2017 at 3:33 PM, Ben Pfaff wrote: > On Fri, Jan 20, 2017 at 03:17:19PM -0800, Mickey Spiegel wrote: > > On Fri, Jan 20, 2017 at 2:43 PM, Ben Pfaff wrote: > > > > > On Fri, Jan 20, 2017 at 12:29:49PM -0800, Mickey Spiegel wrote: > > > > On Fri, Jan 20,

Re: [ovs-dev] [PATCH 00/10] Add actions for egress loopback

On Fri, Jan 20, 2017 at 03:17:19PM -0800, Mickey Spiegel wrote: > On Fri, Jan 20, 2017 at 2:43 PM, Ben Pfaff wrote: > > > On Fri, Jan 20, 2017 at 12:29:49PM -0800, Mickey Spiegel wrote: > > > On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff wrote: > > > > > > > I believe

[ovs-dev] [PATCH v2] ofp-actions: Fix variable length meta-flow field usage in flow actions.

Previously, if a flow action that involves a tunnel metadata meta-flow field is dumped from vswitchd, the replied field length in the OXM header is filled with the maximum possible field length, instead of the length configured in the tunnel TLV mapping table. To solve this issue, this patch

[ovs-dev] [PATCH v2 6/7] actions: Make "next" action able to jump from egress to ingress pipeline.

This feature is useful for centralized gateways. Signed-off-by: Ben Pfaff --- include/ovn/actions.h | 63 -- ovn/controller/lflow.c| 7 +++-- ovn/lib/actions.c | 70 ---

[ovs-dev] [PATCH v2 5/7] actions: Introduce enum ovnact_pipeline.

This isn't used yet by the actions code, but an upcoming commit will introduce a user. This commit just adjusts ovn-trace to use this common type instead of its own local type. Signed-off-by: Ben Pfaff Acked-by: Mickey Spiegel --- include/ovn/actions.h

[ovs-dev] [PATCH v2 3/7] actions: Separate action structures for "next" and "ct_next".

These actions aren't very similar but until now they both had the same action structure. These structures are going to diverge in an upcoming commit, so separate them now. Signed-off-by: Ben Pfaff Acked-by: Mickey Spiegel --- include/ovn/actions.h | 10

[ovs-dev] [PATCH v2 0/7] Add actions for egress loopback

I believe that, with these patches, egress loopback as proposed by Mickey's patches can be implemented with: clone { inport = outport; outport = ""; flags = 0; reg0 = 0; reg1 = 0; ... regN = 0; next(pipeline=ingress, table=0); } v1->v2: - Patches 1, 2, and 3 applied

Re: [ovs-dev] [PATCH 00/10] Add actions for egress loopback

On Fri, Jan 20, 2017 at 12:29:49PM -0800, Mickey Spiegel wrote: > On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff wrote: > > > I believe that, with these patches, egress loopback as proposed by Mickey's > > patches can be implemented with: > > clone { inport = outport; outport = "";

Re: [ovs-dev] [PATCH 03/10] actions: Make "arp { drop; }; " acceptable.

On Fri, Jan 20, 2017 at 09:16:25AM -0800, Ben Pfaff wrote: > Before this commit, the OVN action parser would accept "arp {};" and then > the formatter would format it back as "arp { drop; };", but the parser > didn't accept the latter. There were basically two choices: make the > parser accept

Re: [ovs-dev] [PATCH 07/10] actions: Omit table number when possible for formatting "next" action.

I did a bad job on this patch. I've rewritten it and will repost. On Fri, Jan 20, 2017 at 11:51:56AM -0800, Mickey Spiegel wrote: > On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff wrote: > > > Until now, formatting the "next" action has always required including > > the table number,

Re: [ovs-dev] [PATCH 05/10] actions: Add new OVN action "clone".

On Fri, Jan 20, 2017 at 11:17:53AM -0800, Mickey Spiegel wrote: > On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > > > Acked-by: Mickey Spiegel > > One comment below, found a copy/paste error in

Re: [ovs-dev] [userspace clone v2 1/4] dpif-netdev: Avoid sending probe packets

On Fri, Jan 20, 2017 at 11:06 AM, Jarno Rajahalme wrote: > > > On Jan 19, 2017, at 11:07 PM, Andy Zhou wrote: > > > > When ofproto probe for datapath features, no packets should actually > > be sent to the network. This pactch fixes the userspace by dropping > >

Re: [ovs-dev] [PATCH 00/10] Add actions for egress loopback

On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff wrote: > I believe that, with these patches, egress loopback as proposed by Mickey's > patches can be implemented with: > clone { inport = outport; outport = ""; flags.loopback = 0; > reg0 = 0; reg1 = 0; ... regN = 0; >

[ovs-dev] Calendario de Capacitación Febrero

Estimado Cliente: Le hacemos llegar el programa de capacitación correspondiente al mes de Febrero del ao en curso. - Auditorías para la adquisición de empresas: Due Diligence - 2 de Febrero - Matemáticas Financieras y Evaluación de Proyectos de Inversión - 3 de Febrero - Habilidades de

Re: [ovs-dev] [PATCH 07/10] actions: Omit table number when possible for formatting "next" action.

On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff wrote: > Until now, formatting the "next" action has always required including > the table number, because the action struct didn't include enough context > so that the formatter could decide whether the table number was the next > table

Re: [ovs-dev] [PATCH 05/10] actions: Add new OVN action "clone".

On Fri, Jan 20, 2017 at 9:16 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > Acked-by: Mickey Spiegel One comment below, found a copy/paste error in ovn-sb.xml. --- > include/ovn/actions.h | 5 ++-- > ovn/lib/actions.c | 61

Re: [ovs-dev] [userspace clone v2 4/4] xlate: Generate of datapath clone action when supported

Acked-by: Jarno Rajahalme > On Jan 19, 2017, at 11:07 PM, Andy Zhou wrote: > > Add logic to detect whether datapath support clone. > Enhance the xlate logic to make use of it. > Added logic to turn on/off clone support for testing. > > Signed-off-by: Andy Zhou

Re: [ovs-dev] [userspace clone v2 3/4] dpif-netdev: Add clone action

> On Jan 19, 2017, at 11:07 PM, Andy Zhou wrote: > > Add support for userspace datapath clone action. The clone action > provides an action envelope to enclose an action list. > For example, with actions A, B, C and D, and an action list: > A, clone(B, C), D > > The clone

Re: [ovs-dev] [userspace clone v2 1/4] dpif-netdev: Avoid sending probe packets

> On Jan 19, 2017, at 11:07 PM, Andy Zhou wrote: > > When ofproto probe for datapath features, no packets should actually > be sent to the network. This pactch fixes the userspace by dropping > probe packets before action execution. > > Signed-off-by: Andy Zhou >

Re: [ovs-dev] ARP reply does not lead to revalidate

On Fri, Jan 20, 2017 at 03:38:11PM +, László Sürü wrote: > Thanks! It looks working for the first tests. Thanks. I applied this to master and the branches back to 2.5.x. > In plus I propose to add some more printouts to the error cases in > build_tunnel_send() which helped me to understand

Re: [ovs-dev] [PATCH v10 4/8] ovn: add egress_loopback action

On Tue, Jan 17, 2017 at 01:45:05AM -0800, Mickey Spiegel wrote: > This patch adds an action that loops a clone of the packet back to the > beginning of the ingress pipeline with logical inport equal to the value > of the current logical outport. The following actions are executed on > the clone:

[ovs-dev] [PATCH 10/10] actions: Add new "ct_clear" action.

Signed-off-by: Ben Pfaff --- include/ovn/actions.h | 1 + ovn/lib/actions.c | 16 ovn/ovn-sb.xml| 4 ovn/utilities/ovn-trace.c | 1 + tests/ovn.at | 4 5 files changed, 26 insertions(+) diff --git

[ovs-dev] [PATCH 09/10] actions: Make "next" action able to jump from egress to ingress pipeline.

This feature is useful for centralized gateways. Signed-off-by: Ben Pfaff --- include/ovn/actions.h | 63 +++-- ovn/controller/lflow.c| 7 +++-- ovn/lib/actions.c | 72 ---

[ovs-dev] [PATCH 08/10] actions: Introduce enum ovnact_pipeline.

This isn't used yet by the actions code, but an upcoming commit will introduce a user. This commit just adjusts ovn-trace to use this common type instead of its own local type. Signed-off-by: Ben Pfaff --- include/ovn/actions.h | 6 ++ ovn/utilities/ovn-trace.c | 42

[ovs-dev] [PATCH 07/10] actions: Omit table number when possible for formatting "next" action.

Until now, formatting the "next" action has always required including the table number, because the action struct didn't include enough context so that the formatter could decide whether the table number was the next table or some other table. This is more or less OK, but an upcoming commit will

[ovs-dev] [PATCH 06/10] actions: Separate action structures for "next" and "ct_next".

These actions aren't very similar but until now they both had the same action structure. These structures are going to diverge in an upcoming commit, so separate them now. Signed-off-by: Ben Pfaff --- include/ovn/actions.h | 10 -- ovn/lib/actions.c | 11 ---

[ovs-dev] [PATCH 05/10] actions: Add new OVN action "clone".

Signed-off-by: Ben Pfaff --- include/ovn/actions.h | 5 ++-- ovn/lib/actions.c | 61 --- ovn/ovn-sb.xml| 10 ovn/utilities/ovn-trace.c | 21 +++- tests/ovn.at | 5 5 files

[ovs-dev] [PATCH 04/10] actions: Make "free" functions per-struct, not per-action.

In some cases multiple kinds of OVN action share the same structure. In all of these cases, a given kind of structure is freed one particular way (it would be confusing if this were not the case), so there's no benefit in having per-action free functions. Therefore, this commit switches to a

[ovs-dev] [PATCH 02/10] lex: Make lexer_force_match() work for LEX_T_END.

Without this change, lexer_force_match(lex, LEX_T_END) mostly works, except that in the failure case it emits an error that says "expecting `$'", which is a surprising error message. Arguably, lexer_force_end() could be removed entirely, but I don't see a real problem with the existing

[ovs-dev] [PATCH 03/10] actions: Make "arp { drop; }; " acceptable.

Before this commit, the OVN action parser would accept "arp {};" and then the formatter would format it back as "arp { drop; };", but the parser didn't accept the latter. There were basically two choices: make the parser accept "arp { drop; };" or make the formatter output "arp {};" (or both).

[ovs-dev] [PATCH 00/10] Add actions for egress loopback

I believe that, with these patches, egress loopback as proposed by Mickey's patches can be implemented with: clone { inport = outport; outport = ""; flags.loopback = 0; reg0 = 0; reg1 = 0; ... regN = 0; next(pipeline=ingress, table=0); } Ben Pfaff (10): actions: Fix

[ovs-dev] [PATCH 01/10] actions: Fix "arp" and "nd_na" followed by another action.

OVN logical actions are supposed to be padded to a multiple of 8 bytes, but the code for parsing "arp" and "nd_na" actions didn't do this properly. The result was that it worked OK if one of these actions was the last one in a sequence of logical actions, but failed badly if they were in the

Re: [ovs-dev] ARP reply does not lead to revalidate

Thanks! It looks working for the first tests. In plus I propose to add some more printouts to the error cases in build_tunnel_send() which helped me to understand the root cause. What would be the next step for the correction? Best regards Laszlo -Original Message- From: Ben Pfaff

Re: [ovs-dev] [PATCH 0/1] dpif-netdev: Conditional EMC insert

> > On 01/12/2017 04:49 PM, Ciara Loftus wrote: > > This patch is part of the OVS-DPDK performance optimizations presented > > on the OVS fall conference > > (http://openvswitch.org/support/ovscon2016/8/1400-gray.pdf) > > > > The Exact Match Cache does not perform well in use cases with a high >

[ovs-dev] [PATCH v2 1/2] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

From: Sugesh Chandran Openvswitch datapath recirculates packets for tunneling, i.e. the incoming packets are encapsulated at first pass. Further actions are applied on encapsulated packets on the second pass after recirculating. The proposed patch compute and append

[ovs-dev] [PATCH v2 2/2] Fix test suite failures on tunneling CLONE action.

From: Sugesh Chandran Following tunneling specific test cases are failing due to the introduction of new CLONE action for the tunnel push. 769: tunnel_push_pop_ipv6 - action FAILED (tunnel-push-pop-ipv6.at:92) 767: tunnel_push_pop - action

[ovs-dev] [PATCH v2 0/2] tunneling : Improving tunneling performance by avoiding the recirculation on datapath.

From: Sugesh Chandran MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch set removes the recirculation of encapsulated tunnel packets by computing the post tunnel actions at the time of translation.