Re: [ovs-dev] [PATCH v1 4/6] ovn util: Refactor dhcp_opts_map to make it generic

2017-06-19 Thread Numan Siddique
On Fri, Jun 16, 2017 at 7:42 PM, Brian Haley wrote: > On 06/15/2017 04:39 AM, nusid...@redhat.com wrote: > >> From: Numan Siddique >> >> Renamed 'struct dhcp_opts_map' to 'struct gen_opts_map' and >> renamed ovn-dhcp.h to ovn-l7.h. An upcoming commit

[ovs-dev] [PATCH] rstp: Show root bridge info.

2017-06-19 Thread nickcooper-zhangtonghao
When we use the 'ovs-appctl rstp/show', the root bridge of rstp is always 'unknown root port'. We don't expect that. The reason is that the committer added the check for var 'p'. In the rstp, if a bridge is root bridge, there is not root port, and we don't use the root port 'p', 'rstp/show' in the

Re: [ovs-dev] [PATCH 3/6] dpctl: Skip invoking qsort on empty list

2017-06-19 Thread Ben Pfaff
On Mon, Jun 19, 2017 at 07:54:01PM +0100, Bhanuprakash Bodireddy wrote: > Clang reports "Argument with 'nonnull' attribute passed null" warning. > > Signed-off-by: Bhanuprakash Bodireddy Thanks! Applied to master and branch-2.7.

Re: [ovs-dev] [PATCH 1/6] process: Consolidate process related APIs.

2017-06-19 Thread Ben Pfaff
On Mon, Jun 19, 2017 at 07:53:59PM +0100, Bhanuprakash Bodireddy wrote: > As part of retrieving system statistics, process status APIs along with > helper functions were implemented. Some of them are very generic and can > be reused by other subsystems. > > Move the APIs in system-stats.c to

[ovs-dev] [PATCH 2/2] odp-util: Use port names in output in more places.

2017-06-19 Thread Ben Pfaff
Until now, ODP output only showed port names for in_port matches. This commit shows them in other places port numbers appear. Signed-off-by: Ben Pfaff --- lib/dpctl.c | 8 ++-- lib/dpif-netdev.c| 2 +- lib/dpif.c | 4 +-

[ovs-dev] [PATCH v3 3/7] userspace: Add OXM field MFF_PACKET_TYPE

2017-06-19 Thread Ben Pfaff
From: Jan Scheurich Allow packet type namespace OFPHTN_ETHERTYPE as alternative pre-requisite for matching L3 protocols (MPLS, IP, IPv6, ARP etc). Change the meta-flow definition of packet_type field to use the new custom format MFS_PACKET_TYPE representing

[ovs-dev] [PATCH v3 7/7] userspace: Introduce packet_type in OF 1.5 packet-out

2017-06-19 Thread Ben Pfaff
From: Zoltán Balogh Introducing packet_type in OF 1.5 packet-out. Partly based on Jean Tourrilhes's work. Add test cases for OF1.5 packet-out Add negative test case for OF1.5 packet-out Modify wildcarding and packet-out test printout. Signed-off-by: Jean Tourrilhes

[ovs-dev] [PATCH v3 5/7] tests: Added unit tests in packet-type-aware.at

2017-06-19 Thread Ben Pfaff
From: Jan Scheurich ptap - create packet-type-aware bridge ptap - legal flow entries in ptap bridge ptap - triangle bridge setup with L2 and L3 GRE tunnels First and second unit tests perform basic verification. The third one is a triangular bridge setup test

[ovs-dev] [PATCH v3 4/7] userspace: Handling of versatile tunnel ports

2017-06-19 Thread Ben Pfaff
In netdev_gre_build_header(), GRE protocol and VXLAN next_potocol is set based on packet_type of flow. If it's about an Ethernet packet, it is set to ETP_TYPE_TEB. Otherwise, if the name space is OFPHTN_ETHERNET, it is set according to the name space type. Signed-off-by: Jan Scheurich

[ovs-dev] [PATCH v3 6/7] userspace: Complete Packet In handling

2017-06-19 Thread Ben Pfaff
From: Jan Scheurich Send packet_in for non-Ethernet packets. Include packet_type in Packet In for ptap bridges. Signed-off-by: Jan Scheurich Signed-off-by: Ben Pfaff --- lib/flow.c | 4

[ovs-dev] [PATCH v3 2/7] nx-match: Add context argument to nxm_put__().

2017-06-19 Thread Ben Pfaff
An upcoming commit will need to pass an extra piece of data from nx_put_raw() into all of its direct and indirect calls to nxm_put__(). This commit prepares for that by switching from a "struct ofpbuf *" parameter to a context structure that, currently, contains just a struct ofpbuf *. The

[ovs-dev] [PATCH v3 1/7] ofpbuf: New function ofpbuf_insert().

2017-06-19 Thread Ben Pfaff
This will receive its first users in an upcoming commit. Signed-off-by: Ben Pfaff --- include/openvswitch/ofpbuf.h | 1 + lib/ofpbuf.c | 18 ++ 2 files changed, 19 insertions(+) diff --git a/include/openvswitch/ofpbuf.h

[ovs-dev] [PATCH v3 0/7] Packet type aware pipeline

2017-06-19 Thread Ben Pfaff
This series is based on Zoltan Balogh's series here: https://patchwork.ozlabs.org/patch/770490/ https://patchwork.ozlabs.org/patch/770487/ https://patchwork.ozlabs.org/patch/770495/ https://patchwork.ozlabs.org/patch/770498/ https://patchwork.ozlabs.org/patch/770488/

Re: [ovs-dev] [PATCH v2 08/12] userspace: Handling of versatile tunnel ports

2017-06-19 Thread Ben Pfaff
Thanks for reporting that. I changed this paragraph to: Open vSwitch 2.8 and later implement the ``packet type-aware pipeline'' concept introduced in OpenFlow 1.5. Such a pipeline does not have any root fields. Instead, a new metadata field, , indicates the basic type of the

Re: [ovs-dev] [PATCH v2 11/12] userspace: Introduce packet_type in OF 1.5 packet-out

2017-06-19 Thread Ben Pfaff
Thanks. I'll fold that in for the next version. On Mon, Jun 19, 2017 at 03:53:31PM +, Zoltán Balogh wrote: > Hi Ben, > > The bridge property 'other-config:legacy-l3-pipeline' is obsolete, so the 3 > lines starting at line 4197 in ofproto.at can be removed. > > > +AT_CHECK([ > > +

Re: [ovs-dev] [PATCH] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2017-06-19 Thread Ben Pfaff
On Mon, Jun 19, 2017 at 01:26:54PM +0530, Satyavalli Rama wrote: > Hi Ben, > > Much Thanks for your initial reveiw comments. > We have addressed almost all problems and re-submitted the patch except the > below two lines. > > "checkpatch" reports: > > warning: 1 line adds whitespace

Re: [ovs-dev] [PATCH v2 07/12] userspace: Add OXM field MFF_PACKET_TYPE

2017-06-19 Thread Ben Pfaff
On Mon, Jun 19, 2017 at 04:11:01PM +, Zoltán Balogh wrote: > Hi Ben, > > I've been testing L2/L3 tunneling and ptap ports receiving/transmitting L2 > and L3 packets. > I observed, that 'ovs-appctl dpctl/dump-flows' prints out packet_type 'id' in > decimal format. > For instance, in case of

Re: [ovs-dev] [PATCH V11 09/33] dpif: Save added ports in a port map for netdev flow api use

2017-06-19 Thread Joe Stringer
On 13 June 2017 at 08:03, Roi Dayan wrote: > From: Paul Blakey > > To use netdev flow offloading api, dpifs needs to iterate over > added ports. This addition inserts the added dpif ports in a hash map, > The map will also be used to translate dpif ports to

Re: [ovs-dev] [PATCH v2 00/12] Packet type aware pipeline

2017-06-19 Thread Ben Pfaff
On Mon, Jun 19, 2017 at 02:29:47PM +, Jan Scheurich wrote: > Thanks, Ben, for the updated series. > > I suggest to decouple the port name related patches. > We will test and review the remaining patches and have a look at the PTAP > unit tests and provide fixes to the test (or bugfixes to

Re: [ovs-dev] [PATCH v2 01/12] ofp-util: Remove prototype for unimplemented function.

2017-06-19 Thread Ben Pfaff
Thanks Jan and Nick, I applied this to master. On Mon, Jun 19, 2017 at 01:02:17PM +, Jan Scheurich wrote: > Acked-by: Jan Scheurich > > > -Original Message- > > From: ovs-dev-boun...@openvswitch.org > > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf

Re: [ovs-dev] [PATCH v2 00/12] Packet type aware pipeline

2017-06-19 Thread Ben Pfaff
On Mon, Jun 19, 2017 at 10:26:56AM +, Zoltán Balogh wrote: > > > > A new concern came up while thinking about this series. The > > OVS_ATTR_PACKET_TYPE does not appear to be implemented in the kernel > > module, and what's more, because of #ifdefs, OVS_ATTR_PACKET_TYPE will > > actually have

[ovs-dev] [PATCH] openvswitch.h: OVS_KEY_ATTR_PACKET_TYPE is userspace-only.

2017-06-19 Thread Ben Pfaff
This wasn't clear before. Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-June/334271.html Signed-off-by: Ben Pfaff --- datapath/linux/compat/include/linux/openvswitch.h | 4 1 file changed, 4 insertions(+) diff --git

Re: [ovs-dev] [PATCH] Documentation/topics/dpdk/vhost-user.rst small fixes

2017-06-19 Thread Ben Pfaff
On Mon, Jun 19, 2017 at 07:59:39PM +0100, William Stevenson wrote: > A few trivial fixes to vhost-user documentation including a syntax > error in the included xml file. > > Signed-off-by: William Stevenson Thanks! I applied this to master and branch-2.7.

Re: [ovs-dev] [PATCH 2/2] tc: Tidy up includes.

2017-06-19 Thread Joe Stringer
On 19 June 2017 at 15:05, Greg Rose wrote: > On 06/19/2017 02:33 PM, Joe Stringer wrote: >> >> Fix minor style variations and unnecessary includes. >> >> Signed-off-by: Joe Stringer >> --- >> lib/netdev-linux.c | 1 + >> lib/netdev-tc-offloads.c | 11

Re: [ovs-dev] [PATCH 2/2] tc: Tidy up includes.

2017-06-19 Thread Greg Rose
On 06/19/2017 02:33 PM, Joe Stringer wrote: Fix minor style variations and unnecessary includes. Signed-off-by: Joe Stringer --- lib/netdev-linux.c | 1 + lib/netdev-tc-offloads.c | 11 ++- lib/tc.c | 6 -- lib/tc.h | 4

Re: [ovs-dev] [PATCH V3] compat: Restrict __ro_after_init usage

2017-06-19 Thread Greg Rose
On 06/19/2017 01:36 PM, Joe Stringer wrote: On 19 June 2017 at 11:44, Joe Stringer wrote: > On 16 June 2017 at 16:37, Greg Rose wrote: >> The attribute __ro_after_init was introduced in Linux kernel 4.5. If >> a data structure is given this attribute then

[ovs-dev] [PATCH 1/2] tc: Fix compile with Glibc < 2.24 and Linux > 4.5.

2017-06-19 Thread Joe Stringer
linux/pkt_cls.h indirectly includes linux/stddef.h, which may define __always_inline when using Linux kernel headers 4.6 or later. netinet/in.h indirectly includes sys/cdefs.h, which before Glibc 2.24 would unconditionally define __always_inline. This combination of headers causes compilation

[ovs-dev] [PATCH 2/2] tc: Tidy up includes.

2017-06-19 Thread Joe Stringer
Fix minor style variations and unnecessary includes. Signed-off-by: Joe Stringer --- lib/netdev-linux.c | 1 + lib/netdev-tc-offloads.c | 11 ++- lib/tc.c | 6 -- lib/tc.h | 4 ++-- 4 files changed, 13 insertions(+), 9

[ovs-dev] [PATCH 2/2] openvswitch-switch.postinst: Avoid getting redirected to systemctl.

2017-06-19 Thread Gurucharan Shetty
When the openvswitch-switch package is installed, postinst script is used to make a call to /etc/init.d/openvswitch-switch with "restart" as the command. openvswitch-switch.init inturn would carefully restart OVS by saving the openflow flows and replacing the kernel module only when needed. With

[ovs-dev] [PATCH 1/2] openvswitch-switch.init: Add some aliases.

2017-06-19 Thread Gurucharan Shetty
The most recent version of debian (and Ubuntu) has moved towards systemd in a way that many calls to openvswitch startup scripts get redirected to runtime generated systemd files. For e.g commands like 'service openvswitch-switch restart' or 'invoke-rc.d openvswitch-switch restart' etc will call

Re: [ovs-dev] [PATCH V3] compat: Restrict __ro_after_init usage

2017-06-19 Thread Joe Stringer
On 19 June 2017 at 11:44, Joe Stringer wrote: > On 16 June 2017 at 16:37, Greg Rose wrote: >> The attribute __ro_after_init was introduced in Linux kernel 4.5. If >> a data structure is given this attribute then after the driver module >> loads the memory

[ovs-dev] Supply Chain Management

2017-06-19 Thread Amy Spencer
Hi, Would you be interested in an email lead list of Supply Chain Executives? We can help you reach out to key Top decision makers like: Title includes: * VP of Supply Chain * Director of Supply Chain * Supply Chain Manager * Purchasing Manager * Purchasing Director *

Re: [ovs-dev] [PATCH 2/3] ovn: Ability to skip some IP addresses for SNAT.

2017-06-19 Thread Guru Shetty
On 19 June 2017 at 12:16, Manoj Sharma wrote: > Hi Guru, > > It looked very useful patch. Do you plan to commit it into main? > Was there any reason to not merge it so far? > Is there a use case for which you want to use it? What is the use case? This is an old patch

Re: [ovs-dev] [PATCH] docs: Document that hw-offload is experimental.

2017-06-19 Thread Joe Stringer
On 19 June 2017 at 05:26, Flavio Leitner wrote: > On Thu, Jun 15, 2017 at 04:36:49PM -0700, Joe Stringer wrote: >> Currently, the set of flows that may be offloaded is very small compared >> to the overall capabilities of the OpenFlow support in OVS. In the >> majority of

Re: [ovs-dev] [PATCH 2/3] ovn: Ability to skip some IP addresses for SNAT.

2017-06-19 Thread Manoj Sharma
Hi Guru, It looked very useful patch. Do you plan to commit it into main? Was there any reason to not merge it so far? Regards - Manoj On 11/3/16, 3:46 AM, "dev on behalf of Gurucharan Shetty" wrote: >We currently have the ability to

[ovs-dev] [PATCH] Documentation/topics/dpdk/vhost-user.rst small fixes

2017-06-19 Thread William Stevenson
A few trivial fixes to vhost-user documentation including a syntax error in the included xml file. Signed-off-by: William Stevenson --- Documentation/topics/dpdk/vhost-user.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[ovs-dev] [PATCH 5/6] test-conntrack: Fix dead store reported by clang.

2017-06-19 Thread Bhanuprakash Bodireddy
Clang reports that value store to 'batch_size' is never read. Signed-off-by: Bhanuprakash Bodireddy --- tests/test-conntrack.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/test-conntrack.c b/tests/test-conntrack.c index f79a9fc..5d2f8b8 100644 ---

[ovs-dev] [PATCH 6/6] netdev: Fix null pointer dereference reported by clang.

2017-06-19 Thread Bhanuprakash Bodireddy
Clang reports that array access from 'dumps' variable result in null pointer dereference. Signed-off-by: Bhanuprakash Bodireddy --- lib/netdev.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/lib/netdev.c b/lib/netdev.c

[ovs-dev] [PATCH 4/6] dpif-netlink-rtnl: Fix dead store reported by clang.

2017-06-19 Thread Bhanuprakash Bodireddy
Clang reports variable 'ifmsg' never been used in the function. Signed-off-by: Bhanuprakash Bodireddy --- lib/dpif-netlink-rtnl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/dpif-netlink-rtnl.c b/lib/dpif-netlink-rtnl.c index

[ovs-dev] [PATCH 3/6] dpctl: Skip invoking qsort on empty list

2017-06-19 Thread Bhanuprakash Bodireddy
Clang reports "Argument with 'nonnull' attribute passed null" warning. Signed-off-by: Bhanuprakash Bodireddy --- lib/dpctl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index 7f44d02..2ad475b 100644 ---

[ovs-dev] [PATCH 1/6] process: Consolidate process related APIs.

2017-06-19 Thread Bhanuprakash Bodireddy
As part of retrieving system statistics, process status APIs along with helper functions were implemented. Some of them are very generic and can be reused by other subsystems. Move the APIs in system-stats.c to process.c and util.c and make them available. This patch doesn't change any

[ovs-dev] [PATCH 2/6] dpif-netdev: Skip invoking qsort on empty list.

2017-06-19 Thread Bhanuprakash Bodireddy
sorted_poll_list() returns the sorted list of rxqs mapped to PMD thread along with the rxq count. Skip sorting the list if there are no rxqs mapped to the PMD thread. This can be reproduced with manual pinning and 'dpif-netdev/pmd-rxq-show' command. Also Clang reports that null argument is passed

Re: [ovs-dev] [PATCH 2/3] netdev-linux: make tap devices persistent.

2017-06-19 Thread Flavio Leitner
Hi Vishal, On Thu, Jun 08, 2017 at 02:22:38PM -0300, Flavio Leitner wrote: > On Thu, Jun 08, 2017 at 11:24:58AM +, Vishal Deep Ajmera wrote: > > Hi Flavio, > > > > I am facing some issue with ovs-master on Ubuntu 14.04 system. Here are the > > steps I followed and the error message I get.

Re: [ovs-dev] [PATCH V3] compat: Restrict __ro_after_init usage

2017-06-19 Thread Joe Stringer
On 16 June 2017 at 16:37, Greg Rose wrote: > The attribute __ro_after_init was introduced in Linux kernel 4.5. If > a data structure is given this attribute then after the driver module > loads the memory page where the data resides will be marked read only. > > The compat

Re: [ovs-dev] [PATCH v2 07/12] userspace: Add OXM field MFF_PACKET_TYPE

2017-06-19 Thread Zoltán Balogh
Hi Ben, I've been testing L2/L3 tunneling and ptap ports receiving/transmitting L2 and L3 packets. I observed, that 'ovs-appctl dpctl/dump-flows' prints out packet_type 'id' in decimal format. For instance, in case of receiving a L3 MPLS packet on a ptap port results in:

Re: [ovs-dev] [PATCH v2 11/12] userspace: Introduce packet_type in OF 1.5 packet-out

2017-06-19 Thread Zoltán Balogh
Hi Ben, The bridge property 'other-config:legacy-l3-pipeline' is obsolete, so the 3 lines starting at line 4197 in ofproto.at can be removed. > +AT_CHECK([ > +ovs-vsctl set bridge br0 other-config:legacy-l3-pipeline=false > +], [0]) Best regards, Zoltan > -Original Message- >

Re: [ovs-dev] [PATCH v2 08/12] userspace: Handling of versatile tunnel ports

2017-06-19 Thread Zoltán Balogh
Hi Ben, In the lib/meta-flow.xml, you introduced the 'packet type-aware pipeline' concept. You mentioned, controllers can turn off legacy behavior by setting 'other-config:packet-type' bridge property to 'ptap'. As far as I know, you discussed on Friday, there will be only one property for

Re: [ovs-dev] ifup locked when start ovs in debian9 with systemd

2017-06-19 Thread Guru Shetty
What OVS version is this? What is the platform version? i.e Debian/Ubuntu etc. Does your OVS have the following fix? https://github.com/openvswitch/ovs/commit/15af3d44c65eb3cd724378ce1b30c51aa87f4f69 On 19 June 2017 at 07:17, ychen wrote: > 1. phenomenon >ifup: waiting

[ovs-dev] [RFC PATCH v2] make logs not readable by other

2017-06-19 Thread Timothy Redaelli
The Open vSwitch log directory and files are currently set world readable. However, since only Open vSwitch users and processes need to access this directory and these files there is no need to allow the world to access them, since it can result in the exposure of sensitive information.

[ovs-dev] ifup locked when start ovs in debian9 with systemd

2017-06-19 Thread ychen
1. phenomenon ifup: waiting for lock on /run/network/ifstate.br-int 2. configurations /etc/network/interfaces allow-ovs br-int iface br-int inet manual ovs_type OVSBridge ovs_ports tap111 allow-br-int tap111 iface ngwintp inet manual ovs_bridge br-int ovs_type OVSIntPort 3.

Re: [ovs-dev] [PATCH v2 00/12] Packet type aware pipeline

2017-06-19 Thread Jan Scheurich
Thanks, Ben, for the updated series. I suggest to decouple the port name related patches. We will test and review the remaining patches and have a look at the PTAP unit tests and provide fixes to the test (or bugfixes to the code). BR, Jan > -Original Message- > From:

Re: [ovs-dev] [PATCH v2 02/12] openvswitch.h: Use odp_port_t for port numbers in userspace-only structs.

2017-06-19 Thread Jan Scheurich
Acked-by: Jan Scheurich > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Monday, 19 June, 2017 01:30 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject:

Re: [ovs-dev] [PATCH v2 01/12] ofp-util: Remove prototype for unimplemented function.

2017-06-19 Thread Jan Scheurich
Acked-by: Jan Scheurich > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Monday, 19 June, 2017 01:30 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject:

Re: [ovs-dev] [PATCH] docs: Document that hw-offload is experimental.

2017-06-19 Thread Flavio Leitner
On Thu, Jun 15, 2017 at 04:36:49PM -0700, Joe Stringer wrote: > Currently, the set of flows that may be offloaded is very small compared > to the overall capabilities of the OpenFlow support in OVS. In the > majority of cases, if a user attempts to enable this flag they are > unlikely to observe a

Re: [ovs-dev] [RFC PATCH v1] net-dpdk: Introducing TX tcp HW checksum offload support for DPDK pnic

2017-06-19 Thread Gao Zhenyu
Thanks for that comments. [Sugesh] Any reason, why this patch does only the TCP checksum offload?? The command line option says tx_checksum offload (it could be mistakenly considered for full checksum offload). [Zhenyu Gao] DPDK nic supports many hw offload feature like IPv4,IPV6,TCP,

Re: [ovs-dev] [PATCH v2 00/12] Packet type aware pipeline

2017-06-19 Thread Yang, Yi Y
Hi, guys I'm working on NSH patches for kernel path, I think we can change it with new NSH kernel patches together. You ovs guys have confirmed several times userspace part can be merged before kernel part isn't there. So I propose we review and merge userspace part first, kernel part will be

Re: [ovs-dev] [PATCH v2 00/12] Packet type aware pipeline

2017-06-19 Thread Zoltán Balogh
> > A new concern came up while thinking about this series. The > OVS_ATTR_PACKET_TYPE does not appear to be implemented in the kernel > module, and what's more, because of #ifdefs, OVS_ATTR_PACKET_TYPE will > actually have a different value in the kernel module than in userspace. > What's the

[ovs-dev] [PATCH 3/4] conntrack: pass current time to conntrack_execute.

2017-06-19 Thread antonio . fischetti
From: Antonio Fischetti Current time is passed to conntrack_execute so it doesn't have to recompute it again. Signed-off-by: Antonio Fischetti --- lib/conntrack.c| 4 ++-- lib/conntrack.h| 3 ++- lib/dpif-netdev.c

[ovs-dev] [PATCH 1/4] dpif-netdev: Avoid reading RSS hash when EMC is disabled.

2017-06-19 Thread antonio . fischetti
From: Antonio Fischetti When EMC is disabled the reading of RSS hash is skipped. For packets that are not recirculated it retrieves the hash value without considering the recirc id. This is mostly a preliminary change for the next patch in this series.

Re: [ovs-dev] [RFC PATCH 00/21] Add OVS DPDK keep-alive functionality

2017-06-19 Thread Bodireddy, Bhanuprakash
Hi Aaron, >> >>I've been playing with this a little bit; is it too late to consider tracking >'threads' >>instead of 'cores'? I'm not sure what it means for a particular core >>ID to be 'healthy' - but I know what 'pmd24' not responding means. > >That's an interesting input. It's not late and

Re: [ovs-dev] [RFC PATCH v1] net-dpdk: Introducing TX tcp HW checksum offload support for DPDK pnic

2017-06-19 Thread Chandran, Sugesh
Hi Zhenyu, Thank you for working on this, I have couple of questions in this patch. Regards _Sugesh > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Zhenyu Gao > Sent: Friday, June 16, 2017 1:54 PM > To: b...@ovn.org;

Re: [ovs-dev] [PATCH 0/6 V2] netdev-dpdk: Use intermediate queue during packet transmission.

2017-06-19 Thread Bodireddy, Bhanuprakash
>-Original Message- >From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy >Sent: Sunday, June 18, 2017 8:56 PM >To: d...@openvswitch.org >Subject: [ovs-dev] [PATCH 0/6 V2] netdev-dpdk: Use intermediate queue >during packet

[ovs-dev] [PATCH net-next v3 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses

2017-06-19 Thread Matthias Schiffer
As link-local addresses are only valid for a single interface, we can allow to use the same VNI for multiple independent VXLANs, as long as the used interfaces are distinct. This way, VXLANs can always be used as a drop-in replacement for VLANs with greater ID space. This also extends VNI lookup

[ovs-dev] [PATCH net-next v3 5/6] vxlan: fix snooping for link-local IPv6 addresses

2017-06-19 Thread Matthias Schiffer
If VXLAN is run over link-local IPv6 addresses, it is necessary to store the ifindex in the FDB entries. Otherwise, the used interface is undefined and unicast communication will most likely fail. Support for link-local IPv4 addresses should be possible as well, but as the semantics aren't as

[ovs-dev] [PATCH net-next v3 4/6] vxlan: check valid combinations of address scopes

2017-06-19 Thread Matthias Schiffer
* Multicast addresses are never valid as local address * Link-local IPv6 unicast addresses may only be used as remote when the local address is link-local as well * Don't allow link-local IPv6 local/remote addresses without interface We also store in the flags field if link-local addresses are

[ovs-dev] [PATCH net-next v3 3/6] vxlan: improve validation of address family configuration

2017-06-19 Thread Matthias Schiffer
Address families of source and destination addresses must match, and changelink operations can't change the address family. In addition, always use the VXLAN_F_IPV6 to check if a VXLAN device uses IPv4 or IPv6. Signed-off-by: Matthias Schiffer --- Notes: v2:

[ovs-dev] [PATCH net-next v3 2/6] vxlan: get rid of redundant vxlan_dev.flags

2017-06-19 Thread Matthias Schiffer
There is no good reason to keep the flags twice in vxlan_dev and vxlan_config. Signed-off-by: Matthias Schiffer --- Notes: v2: new patch v3: rebase drivers/net/vxlan.c | 76 +-- include/net/vxlan.h

[ovs-dev] [PATCH net-next v3 1/6] vxlan: refactor verification and application of configuration

2017-06-19 Thread Matthias Schiffer
The vxlan_dev_configure function was mixing validation and application of the vxlan configuration; this could easily lead to bugs with the changelink operation, as it was hard to see if the function wcould return an error after parts of the configuration had already been applied. This commit

[ovs-dev] [PATCH net-next v3 0/6] vxlan: cleanup and IPv6 link-local support

2017-06-19 Thread Matthias Schiffer
Running VXLANs over IPv6 link-local addresses allows to use them as a drop-in replacement for VLANs, avoiding to allocate additional outer IP addresses to run the VXLAN over. Since v1, I have added a lot more consistency checks to the address configuration, making sure address families and scopes

Re: [ovs-dev] [PATCH] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2017-06-19 Thread Satyavalli Rama
Hi Ben, Much Thanks for your initial reveiw comments. We have addressed almost all problems and re-submitted the patch except the below two lines. "checkpatch" reports: warning: 1 line adds whitespace errors. WARNING: Line length is >79-characters long #137 FILE:

[ovs-dev] [PATCH] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2017-06-19 Thread SatyaValli
commit 49a3592b2878a33033e5fd2e6e5ce82ebccef780 Author: Satya Valli Co-authored-by: Lavanya Harivelam Co-authored-by: Surya Muttamsetty OpenVswitch: OF1.5/EXT-334 Extensible Flow Entry Statistics OpenFlow 1.5