Re: [ovs-dev] Wir geben jährlich Darlehen für 2% Zinsen aus

2017-06-21 Thread Bernhard Stöckl
Wir vergeben Kredite mit einem Zinssatz von jährlich 2%. Die Bearbeitung des Antrags erfolgt rasch, wir verlangen keine Gebühren, was sie beantragen werden wir annehmen. Wir bewilligen Kredite von bis zu 40 Millionen Euro und von mindestens 15.000 Euro. Sie können einen geschäftlichen oder

Re: [ovs-dev] [PATCH v3 0/7] Packet type aware pipeline

2017-06-21 Thread Ben Pfaff
On Tue, Jun 20, 2017 at 04:28:20PM +, Jan Scheurich wrote: > Hi Ben, > > Do you plan to you spin another v4 series with the fixes Zoltan and I have > provided? > Zoltan is working on one more fix on the system-userspace suite test for ptap. > > Then we'll start to rebase the generic

Re: [ovs-dev] [PATCH] datapath-windows: Add validations for IP_HEADER_LEN

2017-06-21 Thread Shashank Ram
Hi Guru, can you apply this as well? Thanks! Shashank From: Nithin Raju Sent: Wednesday, June 21, 2017 12:25:33 PM To: Shashank Ram Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Add validations for IP_HEADER_LEN > On Jun 15,

Re: [ovs-dev] [PATCH v2] datapath-windows: Add support for UPDATE events in Conntrack

2017-06-21 Thread Guru Shetty
On 21 June 2017 at 13:33, Anand Kumar wrote: > Introduce a new event type OVS_EVENT_CT_UPDATE to send a conntrack event > whenever a MARK and/or LABEL gets changed for an existing conntrack entry. > > - Parse netlink conntrack attribute OVS_CT_ATTR_EVENTMASK, which is

Re: [ovs-dev] [PATCH] datapath-windows: Fix switch-case alignments in Conntrack.c

2017-06-21 Thread Guru Shetty
On 21 June 2017 at 11:20, Sairam Venugopal wrote: > Minor - Fix the switch case alignments. Found by inspection. > > Signed-off-by: Sairam Venugopal > Applied. > --- > datapath-windows/ovsext/Conntrack.c | 83 ++ > --- >

[ovs-dev] [PATCH] pkt reassemble: fix kernel panic for ovs reassemble

2017-06-21 Thread 王志克
Ovs and kernel stack would add frag_queue to same netns_frags list. As result, ovs and kernel may access the fraq_queue without correct lock. Also the struct ipq may be different on kernel(older than 4.3), which leads to invalid pointer access. The fix creates specific netns_frags for ovs.

Re: [ovs-dev] [PATCH] tests: switch from signed to unsigned when formatting

2017-06-21 Thread Guru Shetty
On 20 June 2017 at 12:44, Alin Serdean wrote: > x->errline is a signed int > (https://github.com/openvswitch/ovs/blob/934386dd129a3f15b2546562a775f2 > f43dd3aac6/tests/test-sflow.c#L88) > Flagged by static code analysis. > > Signed-off-by: Alin Gabriel Serdean

Re: [ovs-dev] [PATCH v2] datapath-windows: Fix potential memory leak while creating conntrack entry

2017-06-21 Thread Guru Shetty
On 21 June 2017 at 10:08, Sairam Venugopal wrote: > OvsCtAddEntry returns TRUE or FALSE depending on whether > OvsNatTranslateCtEntry was successful or not. In the case of an > unsuccesful NAT translation, this will fail to insert the newly created > entry to the Conntrack

[ovs-dev] 答复: [ovs-discuss] rpmbuild failure for ovs_dpdk

2017-06-21 Thread 王志克
Hi Darrell, I checked my config.status, and it was correct. ./config.status:S["OVS_LDFLAGS"]=" -L/usr/share/dpdk/x86_64-default-linuxapp-gcc/lib" Any more idea about the failure? Did someone successfully build it? Thanks BTW, I am using Centos 7.2 Wang Zhike -邮件原件- 发件人: Darrell Ball

Re: [ovs-dev] [PATCH v2] datapath-windows: Add support for UPDATE events in Conntrack

2017-06-21 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 6/21/17, 1:33 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote: >Introduce a new event type OVS_EVENT_CT_UPDATE to send a conntrack event >whenever a

Re: [ovs-dev] [PATCH] distclean: Fix ovs-vtep and docker drivers.

2017-06-21 Thread Joe Stringer
On 21 June 2017 at 17:04, Ben Pfaff wrote: > On Wed, Jun 21, 2017 at 04:25:19PM -0700, Joe Stringer wrote: >> Commit b49a959bac47 ("Use @PYTHON@ directly instead of "#! /usr/bin/env"") >> broke distclean, as it doesn't clean up the generated python scripts >> after building. Fix by

Re: [ovs-dev] [PATCH] distclean: Fix ovs-vtep and docker drivers.

2017-06-21 Thread Ben Pfaff
On Wed, Jun 21, 2017 at 04:25:19PM -0700, Joe Stringer wrote: > Commit b49a959bac47 ("Use @PYTHON@ directly instead of "#! /usr/bin/env"") > broke distclean, as it doesn't clean up the generated python scripts > after building. Fix by adding the new script files to CLEANFILES. > > Fixes:

[ovs-dev] [PATCH] distclean: Fix ovs-vtep and docker drivers.

2017-06-21 Thread Joe Stringer
Commit b49a959bac47 ("Use @PYTHON@ directly instead of "#! /usr/bin/env"") broke distclean, as it doesn't clean up the generated python scripts after building. Fix by adding the new script files to CLEANFILES. Fixes: b49a959bac47 ("Use @PYTHON@ directly instead of "#! /usr/bin/env"")

Re: [ovs-dev] [PATCH] ofp-actions: Store raw type for NXAST_LEARN2.

2017-06-21 Thread Joe Stringer
On 21 June 2017 at 15:30, Yi-Hung Wei wrote: > Thanks for the patch. I think it does address the aforementioned issue. > The testcase may not verify the action re-encoding. We can always > figure out a new testcase and an easier way to verify action re-encoding > later on.

Re: [ovs-dev] [PATCH] ofp-actions: Store raw type for NXAST_LEARN2.

2017-06-21 Thread Yi-Hung Wei
Thanks for the patch. I think it does address the aforementioned issue. The testcase may not verify the action re-encoding. We can always figure out a new testcase and an easier way to verify action re-encoding later on. Acked-by: Yi-Hung Wei On Tue, Jun 20, 2017 at 3:17

[ovs-dev] Negociando a través de las emociones

2017-06-21 Thread Neuro - Ventas
Lo más importante: Usted podrá cursarla en Vivo desde la comodidad de su casa u oficina con todas las ventajas que le ofrece un curso presencial de manera remota, ¡y en Tiempo real! NEURO - VENTAS (Negociando a través de las emociones) ¡Prepárese para llevar las Ventas al siguiente nivel!

Re: [ovs-dev] [PATCH 2/3] ovn: Ability to skip some IP addresses for SNAT.

2017-06-21 Thread Manoj Sharma
On 20 June 2017 at 14:52, Manoj Sharma > wrote: Hi Guru, Please see my answer below: On 19 June 2017 at 23:17, Manoj Sharma > wrote: The use case is if someone wants to access

Re: [ovs-dev] [PATCH 3/3] ofproto/trace: Add --ct-next option to ofproto/trace

2017-06-21 Thread Darrell Ball
On 6/21/17, 11:06 AM, "ovs-dev-boun...@openvswitch.org on behalf of Yi-Hung Wei" wrote: Previous patch enables ofproto/trace to automatically trace a flow that involves multiple recirculation on conntrack. However, it

[ovs-dev] [PATCH v2] datapath-windows: Add support for UPDATE events in Conntrack

2017-06-21 Thread Anand Kumar
Introduce a new event type OVS_EVENT_CT_UPDATE to send a conntrack event whenever a MARK and/or LABEL gets changed for an existing conntrack entry. - Parse netlink conntrack attribute OVS_CT_ATTR_EVENTMASK, which is used to set the mask of bits specifying which conntrack events (IPCT_*)

Re: [ovs-dev] [PATCH] Use @PYTHON@ directly instead of "#! /usr/bin/env"

2017-06-21 Thread Joe Stringer
On 20 June 2017 at 10:53, Timothy Redaelli wrote: > In some installed python scripts /usr/bin/env is unnecessarily used in > shebang, replace it directly with @PYTHON@. > > This will also avoid implicit dependency to /usr/bin/env in RPM distributions > and it will correctly

Re: [ovs-dev] [PATCH 3/3] ofproto/trace: Add --ct-next option to ofproto/trace

2017-06-21 Thread Joe Stringer
On 21 June 2017 at 11:06, Yi-Hung Wei wrote: > Previous patch enables ofproto/trace to automatically trace a flow > that involves multiple recirculation on conntrack. However, it always > sets the ct_state to trk|est when it processes recirculated conntrack flows. > With

Re: [ovs-dev] [PATCH 2/3] ofproto/trace: Add support for tracing conntrack recirculation

2017-06-21 Thread Joe Stringer
On 21 June 2017 at 11:06, Yi-Hung Wei wrote: > Previously, a user need to run ofproto/trace multiple times to derive the > final datapath actions if a flow hit conntrack actions that involves > recirculation. To improve the usability of ofproto/trace, in this patch, > we

Re: [ovs-dev] [PATCH v2] datapath-windows: Fix potential memory leak while creating conntrack entry

2017-06-21 Thread Nithin Raju
Acked-by: Nithin Raju > Thanks, -- Nithin R Manager, NSBU On Jun 21, 2017, at 10:08 AM, Sairam Venugopal > wrote: OvsCtAddEntry returns TRUE or FALSE depending on whether OvsNatTranslateCtEntry was

Re: [ovs-dev] [PATCH] datapath-windows: Add validations for IP_HEADER_LEN

2017-06-21 Thread Nithin Raju
> On Jun 15, 2017, at 3:15 PM, Shashank Ram wrote: > > Adds validations in OvsGetIp() to make sure the IHL is > within valid bounds. If IHL is invalid, then the packet > is dropped by the callers of this function. > > Signed-off-by: Shashank Ram Acked-by:

Re: [ovs-dev] [PATCH 2/3] ofproto/trace: Add support for tracing conntrack recirculation

2017-06-21 Thread Darrell Ball
On 6/21/17, 11:06 AM, "ovs-dev-boun...@openvswitch.org on behalf of Yi-Hung Wei" wrote: Previously, a user need to run ofproto/trace multiple times to derive the final datapath actions if a flow hit conntrack actions

[ovs-dev] [PATCH] datapath-windows: Fix switch-case alignments in Conntrack.c

2017-06-21 Thread Sairam Venugopal
Minor - Fix the switch case alignments. Found by inspection. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Conntrack.c | 83 ++--- 1 file changed, 41 insertions(+), 42 deletions(-) diff --git

Re: [ovs-dev] [PATCH 1/3] conntrack: Move ct_state parsing to lib/conntrack.c

2017-06-21 Thread Darrell Ball
On 6/21/17, 11:06 AM, "ovs-dev-boun...@openvswitch.org on behalf of Yi-Hung Wei" wrote: This patch moves conntrack state parsing function from ovn-trace.c to lib/conntrack.c, because it will be used by ofproto/trace

[ovs-dev] [PATCH 3/3] ofproto/trace: Add --ct-next option to ofproto/trace

2017-06-21 Thread Yi-Hung Wei
Previous patch enables ofproto/trace to automatically trace a flow that involves multiple recirculation on conntrack. However, it always sets the ct_state to trk|est when it processes recirculated conntrack flows. With this patch, users can customize the expected next ct_state in the

[ovs-dev] [PATCH 2/3] ofproto/trace: Add support for tracing conntrack recirculation

2017-06-21 Thread Yi-Hung Wei
Previously, a user need to run ofproto/trace multiple times to derive the final datapath actions if a flow hit conntrack actions that involves recirculation. To improve the usability of ofproto/trace, in this patch, we keep track of the conntrack actions, and automatically run the recirculation

[ovs-dev] [PATCH 1/3] conntrack: Move ct_state parsing to lib/conntrack.c

2017-06-21 Thread Yi-Hung Wei
This patch moves conntrack state parsing function from ovn-trace.c to lib/conntrack.c, because it will be used by ofproto/trace unixctl command later on. It also updates the ct_state checking logic, since we no longer assume CS_TRACKED is enable by default. Signed-off-by: Yi-Hung Wei

[ovs-dev] [PATCH 0/3] ofproto/trace: Add support for tracing conntrack recirc

2017-06-21 Thread Yi-Hung Wei
This patch series enhances the usability of ofproto/trace when a flow hit conntrack actions that involves recirculation. Instead of asking users to run ofproto/trace multiple times to derive the final datapath actions, we keep track of the conntrack actions, and automatically run the recirculation

Re: [ovs-dev] [PATCH v2] datapath-windows: Fix potential memory leak while creating conntrack entry

2017-06-21 Thread Shashank Ram
From: ovs-dev-boun...@openvswitch.org on behalf of Sairam Venugopal Sent: Wednesday, June 21, 2017 10:08 AM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH v2] datapath-windows: Fix potential

Re: [ovs-dev] [PATCH] datapath-windows: Fix potential memory leak while creating conntrack entry

2017-06-21 Thread Sairam Venugopal
I have addressed this in V2. The invalid label is not necessary. On 6/20/17, 2:46 PM, "Shashank Ram" wrote: >Thanks for the patch, please find comments inline. > >From: ovs-dev-boun...@openvswitch.org

[ovs-dev] [PATCH v2] datapath-windows: Fix potential memory leak while creating conntrack entry

2017-06-21 Thread Sairam Venugopal
OvsCtAddEntry returns TRUE or FALSE depending on whether OvsNatTranslateCtEntry was successful or not. In the case of an unsuccesful NAT translation, this will fail to insert the newly created entry to the Conntrack Table. This entry needs to be freed and the states should be accordingly in the

[ovs-dev] Fail to netdev_open internal iface with error "File exists"

2017-06-21 Thread Huanle Han
Hi,all I get this problem with latest(dbd8112) branch-2.7 code on my Ubuntu. root@ubuntu:/var/log/# ovs-vsctl show adf2ea99-0c53-4180-914f-7dadaa71302b Bridge test Port test Interface test type: internal Bridge "manage" Port "manage"

[ovs-dev] incorrect revalidated action for igmp

2017-06-21 Thread Huanle Han
In "Normal" action, igmp report packet is expected to processed in slow path. However, the igmp_type(flow->tp_src) is not supported to be masked in datapath. Then ovs-vswitchd revalidate the flow with igmp_type(flow->tp_src) == 0. It leads to a "multicast traffic, flooding" action and overwrites

Re: [ovs-dev] [PATCH] datapath-windows: Fix potential memory leak while creating conntrack entry

2017-06-21 Thread Sairam Venugopal
Hi Yin, I would keep it separate. The main intent of this patch is to fix the memory leak and reduce the redundancy in the OvsCtCreateEntry switch cases. Thanks, Sairam From: Yin Lin Date: Tuesday, June 20, 2017 at 3:54 PM To: Sairam Venugopal,

Re: [ovs-dev] [PATCH 2/3] ovn: Ability to skip some IP addresses for SNAT.

2017-06-21 Thread Guru Shetty
On 20 June 2017 at 14:52, Manoj Sharma wrote: > Hi Guru, > > Please see my answer below: > > On 19 June 2017 at 23:17, Manoj Sharma wrote: > >> The use case is if someone wants to access a VM from on-prem then it is >> an l3vpn and we should

Re: [ovs-dev] [RFC PATCH 00/21] Add OVS DPDK keep-alive functionality

2017-06-21 Thread Aaron Conole
"Bodireddy, Bhanuprakash" writes: > Hi Aaron, > >>> >>>I've been playing with this a little bit; is it too late to consider >>>tracking >>'threads' >>>instead of 'cores'? I'm not sure what it means for a particular core >>>ID to be 'healthy' - but I know what

Re: [ovs-dev] [PATCH V11 09/33] dpif: Save added ports in a port map for netdev flow api use

2017-06-21 Thread Roi Dayan
On 20/06/2017 03:07, Joe Stringer wrote: On 13 June 2017 at 08:03, Roi Dayan wrote: From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will

[ovs-dev] IT Service To All Faculty And Staffs

2017-06-21 Thread Paul Michael (UK)
To All, If you are a faculty or staff member who has not yet had their email migrated to the present Web-Mail to create space for 2017 Outlook Web Access which has a high visual definition and creates more space and easy access to email, Please kindly update your account by clicking on the

Re: [ovs-dev] [Q]what is 'may_steal' for in netdev API?

2017-06-21 Thread Gao Zhenyu
* If 'may_steal' is false, the caller retains ownership of all the * packets. If 'may_steal' is true, the caller transfers ownership of all * the packets to the network device, regardless of success. * * If 'concurrent_txq' is true, the caller may perform concurrent calls

Re: [ovs-dev] [Q]what is 'may_steal' for in netdev API?

2017-06-21 Thread Joo Kim
Hello experts, Can somebody help answer? On Fri, Dec 30, 2016 at 3:00 AM, Joo Kim wrote: > Hello, > > I got following gdb backtrace for ovs2.6. And netdev_dpdk_send__() > definition is shown at bottom. > I try to understand what 'may_steal' is for but not clear yet.

Re: [ovs-dev] [RFC PATCH v1] net-dpdk: Introducing TX tcp HW checksum offload support for DPDK pnic

2017-06-21 Thread Gao Zhenyu
I get it. Maybe caculating it in OVS part is doable as well. So, how about adding more options to let people choose HW-tcp-cksum(reduce cpu cycles) or SW-tcp-cksum(may be better performance)? Then we have NO-TCP-CKSUM, SW-TCP-CKSUM, HW-TCP-CKSUM. BTW, when will DPDK support tx checksum offload

Re: [ovs-dev] [RFC PATCH v1] net-dpdk: Introducing TX tcp HW checksum offload support for DPDK pnic

2017-06-21 Thread Chandran, Sugesh
Regards _Sugesh From: Gao Zhenyu [mailto:sysugaozhe...@gmail.com] Sent: Monday, June 19, 2017 1:23 PM To: Chandran, Sugesh Cc: b...@ovn.org; u9012...@gmail.com; ktray...@redhat.com; Kavanagh, Mark B ; d...@openvswitch.org Subject: Re: