> On Jun 24, 2017, at 2:12 AM, Joe Stringer wrote:
>
>> On 23 June 2017 at 05:38, Russell Bryant wrote:
>>> On Thu, Jun 8, 2017 at 12:12 PM, Ben Pfaff wrote:
On Thu, Jun 08, 2017 at 04:36:21AM +0530, Numan Siddique wrote:
Is it possible
On 6/23/17, 4:08 PM, "ovs-dev-boun...@openvswitch.org on behalf of Joe
Stringer" wrote:
On 17 June 2017 at 15:53, Darrell Ball wrote:
> ALG infra and FTP (both V4 and V6) support is added to the userspace
On 17 June 2017 at 15:53, Darrell Ball wrote:
> ALG infra and FTP (both V4 and V6) support is added to the userspace
> datapath. Also, NAT support is included.
>
> Signed-off-by: Darrell Ball
> ---
Hi Darrell, thanks for the patch.
I wasn't able to test
Hi Billy, thanks for your review.
Replies inline.
/Antonio
> -Original Message-
> From: O Mahony, Billy
> Sent: Friday, June 23, 2017 2:27 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH 4/4] dp-packet: Use memcpy to copy
Acked-by: Sairam Venugopal
On 6/23/17, 2:05 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar"
wrote:
>In conntrack lookup, ICMP type and code fields were not being used to
>determine a
Hi Billy, thanks for your suggestion, it makes the code more clean
and readable.
Once I get back from vacation I'll give it a try and check if this
still gives a performance benefit.
/Antonio
> -Original Message-
> From: O Mahony, Billy
> Sent: Friday, June 23, 2017 5:23 PM
> To:
Thanks a lot Billy, really appreciate your feedback.
My replies inline.
/Antonio
> -Original Message-
> From: O Mahony, Billy
> Sent: Friday, June 23, 2017 6:39 PM
> To: Fischetti, Antonio ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH RFC 2/4]
Hi Anand,
Please do not change NAT code to include other fields in ct_endpoint. NAT
doesn't care about those fields. As long as the address and port are
identical, we will reverse NAT it. For example, even if we receive an ICMP
reply, we will match it against a ICMP request entry to do the
Update OvsNatKeyAreSame() and OvsHashNatKey() to include ICMP type and code
fields, so that ICMP_ECHO_REQUEST packets are not matched with ICMP_ECHO_REPLY
packets and vice versa.
Signed-off-by: Anand Kumar
---
datapath-windows/ovsext/Conntrack-nat.c | 32
DIRIGIDO A: Contadores, Administradores, Abogados,
Empresarios, Estudiantes, Público en General.
Implicaciones de la Nueva Obligación de CFDI de Pagos y los Últimos Cambios en
la FACTURA ELECTRÓNICA
El 5 de diciembre de 2016, el Servicio de Administración Tributaria (SAT) de
México publicó de
Hi Wang Zhike,
I'd like if others like Greg could take a look as well, since this
code is delicate. The more review it gets, the better. It seems like
maybe the version of your email that goes to the list does not get the
attachment. Perhaps you could try sending the patch using git
send-email or
In conntrack lookup, ICMP type and code fields were not being used to
determine a matching entry. As a result, ICMP4_ECHO_REQUEST packet could
be tracked as ICMP4_ECHO_REPLY packet and vice versa, which is invalid.
To fix this, add ICMP type and code fields for matching a conntrack entry.
Thanks for the review.
I will split up the patch and send out Conntract-Nat.c changes in a separate
patch.
Regards,
Anand Kumar
On 6/23/17, 1:50 PM, "Sairam Venugopal" wrote:
Hi Anand,
Can you split this patch up instead to handle Conntrack.c and
On 06/22/2017 05:53 PM, 王志克 wrote:
Hi Joe,
Please check the attachment. Thanks.
The attachment is only this:
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
And the patch listed does not apply.
Hi Anand,
Can you split this patch up instead to handle Conntrack.c and Conntrack-Nat.c
in a separate one? This way we can keep the testing isolated to the changes.
Acking Conntrack.c change:
Acked-by: Sairam Venugopal
On 6/22/17, 11:54 AM,
Please authenticate your card number
[American Express logo]
Hello, there
[American Express Card]
[Service shadow]
[Fraud Protection]
Card Failure
Hello there,
You need to authenticate your card number immediately if you wish to continue
using it for future
On 23 June 2017 at 05:38, Russell Bryant wrote:
> On Thu, Jun 8, 2017 at 12:12 PM, Ben Pfaff wrote:
>> On Thu, Jun 08, 2017 at 04:36:21AM +0530, Numan Siddique wrote:
>>> Is it possible to tag the 2.7 branch with v2.7.1. Recently there were many
>>> back ports to
Hi Antonio,
This is a really interesting patch. Comments inline below.
Thanks,
/Billy.
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of antonio.fische...@intel.com
> Sent: Monday, June 19, 2017 11:12 AM
> To:
On 6/21/17, 4:27 AM, "ovs-dev-boun...@openvswitch.org on behalf of Roi Dayan"
wrote:
On 20/06/2017 03:07, Joe Stringer wrote:
> On 13 June 2017 at 08:03, Roi Dayan wrote:
>> From: Paul
Hardware offload introduced extra tracking of netdev ports. This
included ovs-netdev, which is really for internal infra usage for
the userpace datapath. This breaks cleanup of the userspace
datapath. One effect is that all userspace datapath system tests
fail except for the first one run.
Introducing packet_type in OF 1.5 packet-out.
Partly based on Jean Tourrilhes's work.
Add test cases for OF1.5 packet-out
Add negative test case for OF1.5 packet-out
Signed-off-by: Jean Tourrilhes
Signed-off-by: Zoltan Balogh
Co-authored-by: Jan
From: Jan Scheurich
First and second unit tests perform basic verification.
The third one is a triangular bridge setup test case. It tests dataplane
in non-PTAP and ptap bridges in conjunction with L2 and L3 GRE tunnels.
It uses veth ports, therefore requires root
From: Jan Scheurich
Send packet_in for non-Ethernet packets.
Include packet_type in Packet In for ptap bridges.
Signed-off-by: Jan Scheurich
Signed-off-by: Ben Pfaff
---
lib/flow.c | 4
From: Jan Scheurich
Allow packet type namespace OFPHTN_ETHERTYPE as alternative pre-requisite
for matching L3 protocols (MPLS, IP, IPv6, ARP etc).
Change the meta-flow definition of packet_type field to use the new
custom format MFS_PACKET_TYPE representing
From: Ben Pfaff
In netdev_gre_build_header(), GRE protocol and VXLAN next_potocol is set based
on packet_type of flow. If it's about an Ethernet packet, it is set to
ETP_TYPE_TEB. Otherwise, if the name space is OFPHTN_ETHERNET, it is set
according to the name space type.
From: Ben Pfaff
An upcoming commit will need to pass an extra piece of data from
nx_put_raw() into all of its direct and indirect calls to nxm_put__().
This commit prepares for that by switching from a "struct ofpbuf *"
parameter to a context structure that, currently, contains
From: Ben Pfaff
This will receive its first users in an upcoming commit.
Signed-off-by: Ben Pfaff
---
include/openvswitch/ofpbuf.h | 1 +
lib/ofpbuf.c | 18 ++
2 files changed, 19 insertions(+)
diff --git
This series was started by Ben Pfaff, v3 can be found here:
https://patchwork.ozlabs.org/patch/778070/
https://patchwork.ozlabs.org/patch/778071/
https://patchwork.ozlabs.org/patch/778076/
https://patchwork.ozlabs.org/patch/778072/
https://patchwork.ozlabs.org/patch/778074/
On 06/20/2017 12:53 AM, Ilya Maximets wrote:
Since commit ff073a71f9bb ("dpif-netdev: Use hmap instead of
list+array for tracking ports."), 'is_valid_port_number()' is
equal to 'port_no != ODPP_NONE', and the expression below will
never be true.
Signed-off-by: Ilya Maximets
Hi Antonio,
> -Original Message-
> From: Fischetti, Antonio
> Sent: Friday, June 23, 2017 3:10 PM
> To: O Mahony, Billy ; d...@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH 1/4] dpif-netdev: Avoid reading RSS hash
> when EMC is disabled.
>
> Hi Billy,
> thanks
On 06/19/2017 04:30 PM, Ben Pfaff wrote:
This wasn't clear before.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-June/334271.html
Signed-off-by: Ben Pfaff
---
datapath/linux/compat/include/linux/openvswitch.h | 4
1 file changed, 4 insertions(+)
diff
-Wimplicit-fallthrough warns when a switch case falls through and since this
warning is enabled by -Wextra it breaks building with --enable-Werror.
Added "/* fall through */" comment when needed in order to avoid the warning.
Signed-off-by: Timothy Redaelli
---
>From GCC
On 06/23/2017 04:31 PM, Ciara Loftus wrote:
> emc_conditional_insert uses pmd->last_cycles and the packet's RSS hash
> to generate a random number used to determine whether or not an emc
> entry should be inserted. This works for single-packet bursts as
> last_cycles is updated for each burst.
emc_conditional_insert uses pmd->last_cycles and the packet's RSS hash
to generate a random number used to determine whether or not an emc
entry should be inserted. This works for single-packet bursts as
last_cycles is updated for each burst. However, for bursts > 1 packet,
where the packets in
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Sugesh Chandran
> Sent: Tuesday, May 30, 2017 7:47 PM
> To: d...@openvswitch.org; ktray...@redhat.com
> Subject: [ovs-dev] [RFC PATCH 1/1] dpif-netdev : Include Rxq
Oops, one suggestion I forgot per coding standards
Use
+if (min && random_uint32() <= min) {
instead of
+if (min && (random_uint32() <= min)) {
Darrell
On 6/23/17, 8:19 AM, "ovs-dev-boun...@openvswitch.org on behalf of Darrell
Ball"
Hi Antonio,
Thank you for the patches,
Please find my comments below.
Regards
_Sugesh
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Fischetti, Antonio
> Sent: Tuesday, June 6, 2017 5:15 PM
> To: Darrell Ball
Thanks for the V2
Acked-by: Darrell Ball
On 6/23/17, 8:07 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ciara
Loftus"
wrote:
emc_conditional_insert uses pmd->last_cycles and the packet's RSS hash
On 6/23/17, 1:26 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff"
wrote:
On Thu, Jun 22, 2017 at 09:27:11PM -0700, Darrell Ball wrote:
> Hardware offload introduced extra tracking of netdev ports. This
>
emc_conditional_insert uses pmd->last_cycles and the packet's RSS hash
to generate a random number used to determine whether or not an emc
entry should be inserted. This works for single-packet bursts as
last_cycles is updated for each burst. However, for bursts > 1 packet,
where the packets in
If we fail to set the priority, we should return the err code
and not return 0.
> On Jun 23, 2017, at 4:51 AM, Bhanuprakash Bodireddy
> wrote:
>
> Increase the DPDK pmd thread scheduling priority by lowering the nice
> value. This will advise the kernel
Hi Billy,
thanks a lot for you suggestions. Those would really help re-factoring
the code by avoiding duplications.
The thing is that this patch 1/4 is mainly a preparation for the
next patch 2/4. So I did these changes with the next patch 2/4 in mind.
The final result I meant to achieve in
Hi Antonio,
In this patch of the patchset there are three lines removed from the direct
command flow:
-miniflow_extract(packet, >mf);
-key->hash = dpif_netdev_packet_get_rss_hash(packet, >mf);
-flow = (cur_min == 0) ? NULL: emc_lookup(flow_cache, key);
Which are then
On Thu, Jun 8, 2017 at 12:12 PM, Ben Pfaff wrote:
> On Thu, Jun 08, 2017 at 04:36:21AM +0530, Numan Siddique wrote:
>> Is it possible to tag the 2.7 branch with v2.7.1. Recently there were many
>> back ports to 2.7 branch. OVS 2.7 is required for RDO [1] and the RDO
>> community is
From: Antonio Fischetti
With the command:
ovs-appctl dpctl/ct-bkts
shows the number of connections per bucket.
By using a threshold:
ovs-appctl dpctl/ct-bkts gt=N
for each bucket shows the number of connections when they
are greater than N.
Signed-off-by: Antonio
From: Antonio Fischetti
Adds CT stats to report number of connections grouped by
protocol.
By using
utilities/ovs-appctl dpctl/ct-stats-show
it can display something like:
Connections Stats:
Total: 1808
TCP: 1808
With the verbose options:
From: Antonio Fischetti
Fixes some lines exceeding 80 chars and a couple of typos.
Signed-off-by: Antonio Fischetti
---
lib/conntrack.c | 2 +-
lib/dpctl.c | 6 --
lib/dpif-netdev.c | 2 +-
utilities/ovs-dpctl.c
> Add netdev_dpdk_vhost_txq_flush(), that flushes packets on vHost User
> port queues. Also add netdev_dpdk_vhost_tx_burst() function that
> uses rte_vhost_enqueue_burst() to enqueue burst of packets on vHost User
> ports.
>
> Signed-off-by: Bhanuprakash Bodireddy
> Signed-off-by: Antonio
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy
> Sent: Thursday, June 22, 2017 10:09 PM
> To: d...@openvswitch.org
> Subject: [ovs-dev] [PATCH] packets: Do not initialize ct_orig_tuple.
>
>
On Fri, 2017-06-23 at 12:13 +0200, Matthias Schiffer wrote:
>
> I was told the extended netlink error facilities were not ready yet,
> has that changed since the last release?
Yes, the facility is in the kernel tree now.
> Anyways, I will gladly work on improving the error handling if
> someone
>From: Michael Qiu [mailto:qdy220091...@gmail.com]
>Sent: Monday, June 19, 2017 6:29 AM
>To: d...@openvswitch.org
>Cc: Kavanagh, Mark B ; b...@ovn.org;
>db...@vmware.com; Michael Qiu
>
>Subject: [PATCH 1/5] lib/dp-packet: init the mbuf to zero when
On 06/23/2017 10:52 AM, Jiri Benc wrote:
> This patchset looks good overall (would send my Acked-by for most of
> this but I'm late).
>
> On Mon, 19 Jun 2017 10:03:55 +0200, Matthias Schiffer wrote:
>> Log messages in these
>> functions are removed, as it is generally unexpected to find error
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Mark Kavanagh
> Sent: Monday, June 12, 2017 12:05 PM
> To: ovs-dev@openvswitch.org; Varghese, Vipin ;
> acon...@redhat.com
> Subject: [ovs-dev]
>From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
>On Behalf Of
>Bhanuprakash Bodireddy
>Sent: Monday, June 19, 2017 7:54 PM
>To: d...@openvswitch.org
>Subject: [ovs-dev] [PATCH 6/6] netdev: Fix null pointer dereference reported
>by clang.
>
>Clang reports that
>From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
>On Behalf Of
>Bhanuprakash Bodireddy
>Sent: Monday, June 19, 2017 7:54 PM
>To: d...@openvswitch.org
>Subject: [ovs-dev] [PATCH 5/6] test-conntrack: Fix dead store reported by
>clang.
>
>Clang reports that value
>From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org]
>On Behalf Of
>Bhanuprakash Bodireddy
>Sent: Monday, June 19, 2017 7:54 PM
>To: d...@openvswitch.org
>Subject: [ovs-dev] [PATCH 4/6] dpif-netlink-rtnl: Fix dead store reported by
>clang.
>
>Clang reports variable
Thanks for looking at these and testing them. I applied them to master.
(There is still some room for improvement in these areas, but I think
that this is a useful step forward.)
On Fri, Jun 23, 2017 at 08:11:50AM +, Jan Scheurich wrote:
> Acked-by: Jan Scheurich
Acked-by: Billy O'Mahony
> -Original Message-
> From: Bodireddy, Bhanuprakash
> Sent: Thursday, June 22, 2017 9:51 PM
> To: d...@openvswitch.org
> Cc: O Mahony, Billy ; Bodireddy, Bhanuprakash
>
>
This patchset looks good overall (would send my Acked-by for most of
this but I'm late).
On Mon, 19 Jun 2017 10:03:55 +0200, Matthias Schiffer wrote:
> Log messages in these
> functions are removed, as it is generally unexpected to find error output
> for netlink requests in the kernel log.
On 06/23/2017 02:12 AM, Ben Pfaff wrote:
On Thu, Jun 22, 2017 at 04:04:44PM -0300, Flavio Leitner wrote:
On Thu, Jun 22, 2017 at 01:04:59AM +0800, Huanle Han wrote:
Hi,all
I get this problem with latest(dbd8112) branch-2.7 code on my Ubuntu.
root@ubuntu:/var/log/# ovs-vsctl show
On Thu, Jun 22, 2017 at 09:27:11PM -0700, Darrell Ball wrote:
> Hardware offload introduced extra tracking of netdev ports. This
> included ovs-netdev, which is really for internal infra usage for
> the userpace datapath. This breaks cleanup of the userspace
> datapath. There is no need to do
Acked-by: Jan Scheurich
Tested-by: Jan Scheurich
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org
> [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Tuesday, 20 June, 2017 04:26
> To:
Thanks for implementing this!
It's a great usability improvement for trouble-shooting datapath issues and
makes it easier to write unit test cases checking on datapath flows.
Acked-by: Jan Scheurich
Tested-by: Jan Scheurich
>
Regards
_Sugesh
From: Gao Zhenyu [mailto:sysugaozhe...@gmail.com]
Sent: Wednesday, June 21, 2017 9:32 AM
To: Chandran, Sugesh
Cc: b...@ovn.org; u9012...@gmail.com; ktray...@redhat.com; Kavanagh, Mark B
; d...@openvswitch.org
Subject: Re:
Hi All,
thanks for your feedback. We published a patchset v1 at
http://patchwork.ozlabs.org/patch/775505/
please feel free to review.
Thanks,
Antonio
> -Original Message-
> From: Wang, Yipeng1
> Sent: Wednesday, May 3, 2017 12:04 AM
> To: Darrell Ball ;
Package: openvswitch-switch
Version: 2.6.2~pre+git20161223-3
I ran a jessie to stretch upgrade
When dpkg was setting up openvswitch-switch it became stuck
Looking at the process table I found:
23766 ?S 0:00 ifup --allow=ovs ovsbr0
The interface was already up and I was accessing
66 matches
Mail list logo