Re: [ovs-dev] OVSDB Replication: Clarifications required

2017-07-07 Thread Arunkumar Rg
Requesting your time to help on my queries. Thanks, Arun. On Wed, Jul 5, 2017 at 11:22 AM, Arunkumar Rg wrote: > Hi, > > Got few clarifications on OVSDB replication. Please let me know your > inputs on it. > > 1. From the ovsdb-server code(main_loop()), it seems that the standby > ovsdb-server

Re: [ovs-dev] [PATCH 0/5] dpif-netdev: Cuckoo-Distributor implementation

2017-07-07 Thread Darrell Ball
I just noticed this patch set has not had much discussion since the RFC version. It would be nice if the discussion can be revived. Thanks Darrell On 6/13/17, 4:09 PM, "ovs-dev-boun...@openvswitch.org on behalf of yipeng1.w...@intel.com" wrote: From: Yipeng Wang The Datapath Cla

Re: [ovs-dev] [PATCH 1/6] userspace: Add support for NSH MD1 match fields

2017-07-07 Thread Yang, Yi Y
Joe, NSH for kernel datapath will be coming once this series is merged, do we need to do so yet? -Original Message- From: Joe Stringer [mailto:j...@ovn.org] Sent: Friday, July 7, 2017 6:04 PM To: Yang, Yi Y Cc: ovs dev ; Li, Ricky ; Mengke Liu Subject: Re: [ovs-dev] [PATCH 1/6] usersp

Re: [ovs-dev] [PATCH v2 1/3] ovn-controller: decouple localnet_port update from patch_run

2017-07-07 Thread Ben Pfaff
On Wed, Jun 07, 2017 at 09:32:45AM -0700, Han Zhou wrote: > We figure out local datapaths in binding_run() but update the field > localnet_port for each local datapath that has localnet port in > patch_run(). This patch updates the localnet_port field in binding_run > directly and removes the logic

Re: [ovs-dev] [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when deleted

2017-07-07 Thread Ben Pfaff
On Thu, Jun 15, 2017 at 09:58:57AM +0800, fukaige wrote: > tart a virtual machine with its backend tap device attached to a brought up > linux bridge. > If we delete the linux bridge when vm is still running, we'll get the > following error when > trying to create a ovs bridge with the same name.

[ovs-dev] Servicio al Cliente Estilo Disney

2017-07-07 Thread Aproveche Nuestra Promo del Mes
Las 4 C’s: curiosidad, confianza, coraje y constancia La Creatividad de Disney OBJETIVOS: - Diseñar modelos de servicio y atención por medio del uso de la creatividad que tenía Walt Disney y que lo llevó a la innovación. - Comprenderán técnicas comprobadas de innovación y calidad en el servicio

Re: [ovs-dev] [PATCH v3 6/6] ovn: l3ha, gratuitous ARP for HA router

2017-07-07 Thread Russell Bryant
On Wed, Jul 5, 2017 at 9:45 AM, Miguel Angel Ajo wrote: > From: Venkata Anil Kommaddi > > This patch extends gratuitous ARP support for NAT addresses so that it > applies to centralized NAT rules on a HA router. > Gratuitous ARP packets for centralized NAT rules on a HA router > are only generate

Re: [ovs-dev] ovn-nbctl and patch ports for logical routers

2017-07-07 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Lance Richardson" > Cc: ovs-dev@openvswitch.org, "Qi Jun Ding" > Sent: Thursday, 6 July, 2017 6:42:06 PM > Subject: Re: [ovs-dev] ovn-nbctl and patch ports for logical routers > > On Fri, May 12, 2017 at 09:47:46AM -0400, Lance Richardson wrote: > > With branch-2.6, w

Re: [ovs-dev] [PATCH v3 5/6] ovn: l3ha, make is_chassis_active aware of gateway_chassis

2017-07-07 Thread Russell Bryant
Only a couple really small suggestions on this one. On Wed, Jul 5, 2017 at 9:45 AM, Miguel Angel Ajo wrote: > is_chassis_active now is only true for redirect-chassis ports > in the case of the specific lport being active on the > local chassis. > > This will naturally make the ARP responder / red

Re: [ovs-dev] [PATCH v2 2/4] ovn: l3ha, enable bfd between tunnel endpoints

2017-07-07 Thread Russell Bryant
On Thu, Jun 8, 2017 at 10:05 AM, wrote: > From: venkata anil > > This patch enables bfd protocol between gateways and transport nodes, > all gateway nodes with any HA chassisredirect port will enable BFD > to all tunnel endpoints, while transport nodes will enable BFD > to all tunnel endpoints h

Re: [ovs-dev] [PATCH v3 3/6] ovn: l3ha, handling of multiple gateway chassis

2017-07-07 Thread Russell Bryant
review part 2 of this one ... On Wed, Jul 5, 2017 at 9:45 AM, Miguel Angel Ajo wrote: > This patch handles multiple gateway_chassis with in chassisredirect > ports, any gateway with a chassis redirect port will implement the > rules to de-encapsulate incomming packets for such port. > > And hosts

Re: [ovs-dev] [PATCH 0/4] system-traffic: Add basic IPv6 underlay tunnel tests

2017-07-07 Thread Ben Pfaff
On Wed, Jun 07, 2017 at 07:54:23PM -0400, Eric Garver wrote: > Currently there is no system-traffic coverage for tunnels with IPv6 underlays. > This series adds very basic ping tests for VXLANv6 and GENEVEv6. > > Note: GREv6 is not added by this series due to some incompatibilities between > OVS a

Re: [ovs-dev] [PATCH 1/1] netdev-vport: reject concomitant incompatible tunnels

2017-07-07 Thread Ben Pfaff
On Fri, Jun 09, 2017 at 11:09:08AM +0200, Eelco Chaudron wrote: > This is a follow up patch for an earlier patch send by Cascardo, > however I think this patch might not be needed... > > This patch will make sure VXLAN tunnels with and without the group > based policy (gbp) option enabled can not

Re: [ovs-dev] [PATCH] ofp-util: fix memory leak in ofputil_pull_ofp11_buckets

2017-07-07 Thread Ben Pfaff
On Wed, Jun 28, 2017 at 05:14:41PM +0800, zhongbaisong wrote: > Signed-off-by: zhongbaisong Thanks for the fix! I applied this to master and backported as far as branch-2.2. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman

Re: [ovs-dev] [PATCH v2] configure: Fix check for rte_config.h to handle cross-compilation.

2017-07-07 Thread Ben Pfaff
Thanks. I applied this to master and branch-2.7. On Fri, Jul 07, 2017 at 04:49:41PM +, Darrell Ball wrote: > I tested my version yesterday, which your version seems to be in sync with > today. > > Acked-by: Darrell Ball > > > On 7/7/17, 9:16 AM, "ovs-dev-boun...@openvswitch.org on behalf

Re: [ovs-dev] [PATCH v2 2/3] dpif-netdev: Avoid port's reconfiguration on pmd-cpu-mask changes.

2017-07-07 Thread Darrell Ball
On 7/6/17, 11:11 PM, "Ilya Maximets" wrote: On 07.07.2017 08:08, Darrell Ball wrote: > > > On 5/30/17, 7:12 AM, "Ilya Maximets" wrote: > > Reconfiguration of HW NICs may lead to packet drops. > In current model all physical ports will be reconfigured each

Re: [ovs-dev] [PATCH] ofp-util: Check length of buckets in ofputil_pull_ofp15_group_mod().

2017-07-07 Thread Ben Pfaff
Thanks! I applied this to master and backported as far as branch-2.4. On Fri, Jul 07, 2017 at 10:01:30AM -0700, Yi-Hung Wei wrote: > Acked-by: Yi-Hung Wei > > On Thu, Jul 6, 2017 at 4:46 PM, Ben Pfaff wrote: > > On Fri, May 26, 2017 at 12:59:06PM -0700, Ben Pfaff wrote: > >> This code blindly

Re: [ovs-dev] [PATCH] ofp-print: Don't abort on unknown reason in role status message.

2017-07-07 Thread Ben Pfaff
Thanks. I pushed this to master and backported as far as branch-2.1. On Fri, Jul 07, 2017 at 10:08:53AM -0700, Yi-Hung Wei wrote: > Acked-by: Yi-Hung Wei > > On Thu, Jul 6, 2017 at 4:47 PM, Ben Pfaff wrote: > > On Fri, May 26, 2017 at 01:22:26PM -0700, Ben Pfaff wrote: > >> A buggy or maliciou

Re: [ovs-dev] [PATCH v3 3/6] ovn: l3ha, handling of multiple gateway chassis

2017-07-07 Thread Russell Bryant
(re-adding the list) On Fri, Jul 7, 2017 at 6:50 AM, Miguel Angel Ajo Pelayo wrote: > > Thank you!, I'll start tackling those today. > > On Fri, Jul 7, 2017 at 3:48 AM, Russell Bryant wrote: >> >> I'm not done reviewing this, but I figured I'd send out what I have so >> far. I'll continue tomor

Re: [ovs-dev] [PATCH v3 1/3] dpif-netdev: Incremental addition/deletion of PMD threads.

2017-07-07 Thread Darrell Ball
On 7/6/17, 10:50 PM, "Ilya Maximets" wrote: On 07.07.2017 07:33, Darrell Ball wrote: > > > On 6/15/17, 4:36 AM, "Ilya Maximets" wrote: > > Currently, change of 'pmd-cpu-mask' is very heavy operation. > It requires destroying of all the PMD threads and cre

Re: [ovs-dev] [PATCH v3 2/6] ovn: l3ha, ovn-northd gateway chassis propagation

2017-07-07 Thread Russell Bryant
(re-adding mailing list, since I assume you meant to include it) On Fri, Jul 7, 2017 at 7:15 AM, Miguel Angel Ajo Pelayo wrote: > > > On Thu, Jul 6, 2017 at 11:30 PM, Russell Bryant wrote: >> >> On Wed, Jul 5, 2017 at 9:45 AM, Miguel Angel Ajo >> wrote: >> > The redirect-chassis option of logic

Re: [ovs-dev] [PATCH] ofp-print: Don't abort on unknown reason in role status message.

2017-07-07 Thread Yi-Hung Wei
Acked-by: Yi-Hung Wei On Thu, Jul 6, 2017 at 4:47 PM, Ben Pfaff wrote: > On Fri, May 26, 2017 at 01:22:26PM -0700, Ben Pfaff wrote: >> A buggy or malicious switch could send a role status message with a bad >> reason code, which if printed by OVS would cause it to abort. This fixes >> the probl

Re: [ovs-dev] [PATCH] ofp-util: Check length of buckets in ofputil_pull_ofp15_group_mod().

2017-07-07 Thread Yi-Hung Wei
Acked-by: Yi-Hung Wei On Thu, Jul 6, 2017 at 4:46 PM, Ben Pfaff wrote: > On Fri, May 26, 2017 at 12:59:06PM -0700, Ben Pfaff wrote: >> This code blindly read forward for the number of bytes specified by the >> message without checking that it was in range. >> >> This bug is part of OpenFlow 1.5

Re: [ovs-dev] [PATCH v4 0/7] Packet type aware pipeline

2017-07-07 Thread Darrell Ball
A few points worth noting: 1/ This test only uses the ping application and there are no advanced options, so my first guess is distro should not matter, but I could be wrong. 2/ This will not be fixed by increasing the sleep time before the check below; there are extra drops for broad

Re: [ovs-dev] [PATCH v2] configure: Fix check for rte_config.h to handle cross-compilation.

2017-07-07 Thread Darrell Ball
I tested my version yesterday, which your version seems to be in sync with today. Acked-by: Darrell Ball On 7/7/17, 9:16 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: The check for rte_config.h in acinclude.m4 used AC_CHECK_FILE, but this macro is intended to c

Re: [ovs-dev] [PATCH] Makefiles: Fail build for flake8 only when configured with --enable-Werror.

2017-07-07 Thread Ben Pfaff
On Thu, Jul 06, 2017 at 09:00:50PM -0400, Russell Bryant wrote: > On Thu, Jul 6, 2017 at 6:12 PM, Ben Pfaff wrote: > > flake8 checking is useful. Until now, it always failed the build for any > > flake8 errors. This is too aggressive, for the same reason that always > > failing the build for any

Re: [ovs-dev] offset of 0x10001 in dpif_netlink_queue_to_priority

2017-07-07 Thread Ben Pfaff
On Fri, Jul 07, 2017 at 08:56:14AM +0200, Matthias May wrote: > On 06/07/17 17:25, Ben Pfaff wrote: > > On Thu, Jul 06, 2017 at 08:39:21AM +0200, Matthias May wrote: > >> On 06/07/17 02:24, Ben Pfaff wrote: > >>> On Tue, Jul 04, 2017 at 05:09:21PM +0200, Matthias May wrote: > Hi > >

Re: [ovs-dev] RFC: ovs-dump-flows utility

2017-07-07 Thread Ben Pfaff
On Fri, Jul 07, 2017 at 07:54:51AM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Mon, May 08, 2017 at 11:47:46AM -0400, Aaron Conole wrote: > >> Hi Ben, > >> > >> Thanks for the look! > >> > >> Ben Pfaff writes: > >> > >> > On Fri, Apr 28, 2017 at 04:44:32PM -0400, Aaron Conole wrot

Re: [ovs-dev] [PATCH] configure: Fix check for rte_config.h to handle cross-compilation.

2017-07-07 Thread Ben Pfaff
On Fri, Jul 07, 2017 at 09:11:27AM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > Can someone review this please? > > > > On Mon, May 01, 2017 at 10:30:27AM -0700, Ben Pfaff wrote: > >> Hemant, does this fix the problem you reported? > >> > >> On Fri, Apr 14, 2017 at 09:14:55PM -0700, Ben

Re: [ovs-dev] [PATCH] configure: Fix check for rte_config.h to handle cross-compilation.

2017-07-07 Thread Ben Pfaff
On Thu, Jul 06, 2017 at 09:48:58PM +, Darrell Ball wrote: > > > On 7/6/17, 2:36 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" > wrote: > > Can someone review this please? > > On Mon, May 01, 2017 at 10:30:27AM -0700, Ben Pfaff wrote: > > Hemant, does this fi

[ovs-dev] [PATCH v2] configure: Fix check for rte_config.h to handle cross-compilation.

2017-07-07 Thread Ben Pfaff
The check for rte_config.h in acinclude.m4 used AC_CHECK_FILE, but this macro is intended to check for a file on the host system, not the build system, which means that it fails unconditionally in a cross-compilation environment. However, the intended check here is for a header file, which is part

Re: [ovs-dev] [RFC PATCH 1/1] dpif-netdev : Include Rxq processing cycles

2017-07-07 Thread Chandran, Sugesh
Hi Ian, Thank you for the review comments, Regards _Sugesh > -Original Message- > From: Stokes, Ian > Sent: Friday, June 23, 2017 4:29 PM > To: Chandran, Sugesh ; > d...@openvswitch.org; ktray...@redhat.com > Subject: RE: [ovs-dev] [RFC PATCH 1/1] dpif-netdev : Include Rxq processing >

Re: [ovs-dev] [PATCH repost] dpdk: Refactor and simplify calculating vhost socket dir.

2017-07-07 Thread Darrell Ball
On 7/7/17, 5:58 AM, "ovs-dev-boun...@openvswitch.org on behalf of Aaron Conole" wrote: Ben Pfaff writes: > It took me a few minutes to figure out what the code for deciding on the > vhost socket directory was doing, because it was needlessly complicated. > This simplifies

[ovs-dev] Bug#863662: openvswitch: CVE-2017-9265

2017-07-07 Thread Ben Pfaff
On Thu, Jul 06, 2017 at 10:49:30PM +0200, Moritz Muehlenhoff wrote: > On Mon, May 29, 2017 at 10:16:50PM +0200, Salvatore Bonaccorso wrote: > > Source: openvswitch > > Version: 2.6.2~pre+git20161223-3 > > Severity: normal > > Tags: upstream patch security > > > > Hi, > > > > the following vulnera

Re: [ovs-dev] [PATCH v2 0/4] rhel/fedora: non-root OvS out of the box

2017-07-07 Thread Aaron Conole
Aaron Conole writes: > This series attempts to introduce the ability to start and use > Open vSwitch 'out of the box' as a non-root user. It does this by > modifying the service files to pass the recently introduced --ovs-user > argument around, and by making some minor tweaks to the passwd, gr

Re: [ovs-dev] [PATCH v2] dpif-netlink: convert packet_type netlink attribute

2017-07-07 Thread Zoltán Balogh
Hi Eric, I agree, my last patch did not help at all. We have reworked it with Jan, removed the unneeded code parts, it's simpler now. This way, removal of the PACKET_TYPE netlink attribute and adding of ETHER_TYPE netlink attribute happens at the same place. Could you have a look at it and test

Re: [ovs-dev] [PATCH v2] dpif-netlink: convert packet_type netlink attribute

2017-07-07 Thread Jan Scheurich
Hi Eric, Doing the kernel datapath tweak in the ofproto translation logic certainly works but should only be our last resort as it is so ugly. Zoltan will send you an corrected/simplified version of our patch in the next hour or so. It intercepts the flow and mask netlink keys before transmissi

Re: [ovs-dev] [PATCH] configure: Fix check for rte_config.h to handle cross-compilation.

2017-07-07 Thread Aaron Conole
Ben Pfaff writes: > Can someone review this please? > > On Mon, May 01, 2017 at 10:30:27AM -0700, Ben Pfaff wrote: >> Hemant, does this fix the problem you reported? >> >> On Fri, Apr 14, 2017 at 09:14:55PM -0700, Ben Pfaff wrote: >> > The check for rte_config.h in acinclude.m4 used AC_CHECK_FIL

Re: [ovs-dev] [PATCH repost] dpdk: Refactor and simplify calculating vhost socket dir.

2017-07-07 Thread Aaron Conole
Ben Pfaff writes: > It took me a few minutes to figure out what the code for deciding on the > vhost socket directory was doing, because it was needlessly complicated. > This simplifies it. > > Build tested only. > > Signed-off-by: Ben Pfaff > --- > This is a repost of a patch first posted in Ap

Re: [ovs-dev] [PATCH v2] dpif-netlink: convert packet_type netlink attribute

2017-07-07 Thread Eric Garver
On Fri, Jul 07, 2017 at 02:16:12AM +, Yang, Yi Y wrote: > Eric, I verified this one, ptap unit tests and nsh tests passed without any > change, so it seems it is better than the original one you did. Thanks for verifying. I'll post it along with my layer3-rtnetlink series. Hopefully in the n

Re: [ovs-dev] RFC: ovs-dump-flows utility

2017-07-07 Thread Aaron Conole
Ben Pfaff writes: > On Mon, May 08, 2017 at 11:47:46AM -0400, Aaron Conole wrote: >> Hi Ben, >> >> Thanks for the look! >> >> Ben Pfaff writes: >> >> > On Fri, Apr 28, 2017 at 04:44:32PM -0400, Aaron Conole wrote: >> >> Greetings dev, >> >> >> >> I have whipped up a quick little utility (fin

Re: [ovs-dev] [PATCH v1] vswitchd: Fix IFACE_STAT name error in iface_refresh_stats

2017-07-07 Thread Greg Rose
On Mon, Jun 26, 2017 at 12:29 PM, Zhenyu Gao wrote: > The element of rx_1024_to_1522_packets has wrong > name(rx_1024_to_1518_packets). > Change it from rx_1024_to_1518_packets to rx_1024_to_1522_packets, it should > record packets between 1024 to 1522. > > The element of tx_1024_to_1522_packets

Re: [ovs-dev] [PATCH v3] netdev-dpdk: use rte_eth_dev_set_mtu

2017-07-07 Thread Kavanagh, Mark B
>From: Chandran, Sugesh >Sent: Friday, July 7, 2017 10:44 AM >To: Kavanagh, Mark B ; ovs-dev@openvswitch.org; >Varghese, Vipin ; acon...@redhat.com >Subject: RE: [ovs-dev] [PATCH v3] netdev-dpdk: use rte_eth_dev_set_mtu > >Hi Mark, >Thank you for the information. >Please find my comments below. > >

Re: [ovs-dev] [PATCH 1/6] userspace: Add support for NSH MD1 match fields

2017-07-07 Thread Joe Stringer
On 4 July 2017 at 20:45, Yi Yang wrote: > From: Jan Scheurich > > This patch adds support for NSH packet header fields to the OVS > control plane and the userspace datapath. Initially we support the > fields of the NSH base header as defined in > https://www.ietf.org/id/draft-ietf-sfc-nsh-12.txt

Re: [ovs-dev] GTP support to OVS upstream

2017-07-07 Thread Joe Stringer
Yep, so there's definitely some arguments there and particularly if you're coming from an OVS-centric perspective then the logic follows. However, OVS doesn't operate as an island. My point is that the Linux kernel already has generic UDP tunnel common code which is shared between various tunnel de

Re: [ovs-dev] [PATCH v3] netdev-dpdk: use rte_eth_dev_set_mtu

2017-07-07 Thread Chandran, Sugesh
Hi Mark, Thank you for the information. Please find my comments below. Regards _Sugesh > -Original Message- > From: Kavanagh, Mark B > Sent: Wednesday, July 5, 2017 10:20 AM > To: Chandran, Sugesh ; ovs- > d...@openvswitch.org; Varghese, Vipin ; > acon...@redhat.com > Subject: RE: [ovs-

Re: [ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release.

2017-07-07 Thread Stokes, Ian
> > On Jul 6, 2017, at 2:11 AM, Stokes, Ian wrote: > > > >> Great. I've pushed it to "branch-2.7" and it will be part of the > >> 2.7.1 release, which I plan to release shortly. > >> > >> Since the master branch still references 16.11.1, I'd think you'd > >> also like to apply this patch there, t

[ovs-dev] Congratulations!!

2017-07-07 Thread peteremeka7000
Attn: Having reviewed all the obstacles and problems surrounding the transfer of your $4.5Million and your inability to meet up with some charges levied against you due to the past transfer options, We the Board of Directors, United Bank Of Africa (UBA) has ordered our Foreign Payment Remittance U

Re: [ovs-dev] [PATCH v4 0/7] Packet type aware pipeline

2017-07-07 Thread Zoltán Balogh
Hi, The script seems to be stopped at line 344 in system-userspace-packet-type-aware.at. Checking root privilege happens before that. There is a "sleep 1" command before line 344. Maybe it's too short on some systems. Darell, could you share the log file of this test case, please? It should be