Re: [ovs-dev] [PATCH v2 0/2] nsh: rework NSH netlink keys and actions

On Thu, Aug 24, 2017 at 04:24:07PM -0700, Ben Pfaff wrote: > > > > Ok, I'll send patch 1 without datapath actions name change and netlink > > change, but it isn't a good result if people see encap_nsh and decep_nsh > > in 2.8 and see they are changed to push_nsh and pop_nsh in 2.9 and > > later.

[ovs-dev] [PATCH v4 3/3] nsh: add dec_nsh_ttl action

IETF NSH spec defines a ttl field in NSH header, it is a 6-bit field ranged from 0 to 63, it should be decremented by 1 every hop, if it is 0 or it is so after decremented, the packet should be dropped and a packet-in message is sent to main controller. Signed-off-by: Yi Yang

[ovs-dev] [PATCH v4 2/3] nsh: add new flow key 'ttl'

IETF NSH draft will be approved by end of August, NSH header format has been finalized and won't be change anymore, so we need to follow this final spec to implement nsh. kernel data path also needs finalized uAPIs, they can't be changed once they are merged. This patch adds new nsh key 'ttl',

[ovs-dev] [PATCH v4 1/3] nsh: fix an implicit bug in nsh_hdr_len

Operator '*' will be executed prior to operator '>>', but we expect operator '>>' is executed prior to '*', this patch fixed the issue. Signed-off-by: Yi Yang --- include/openvswitch/nsh.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH v4 0/3] nsh: add new nsh key ttl and action dec_nsh_ttl

v3->v4 - Add new action dec_nsh_ttl - Remove encap_nsh and decap_nsh changes - Remove netlink rework to adapt to OVS 2.8 - Dynamically allocate struct ovs_action_encap_nsh and put appropriate size for ENCAP_NSH netlink message. v2->v3 - Fix several comments Jan Scheurich v1->v2 -

[ovs-dev] 带客服功能的营销型官网，只要160元！

我经营企业20多年，现在都50多岁了，却越来越不知道该如何往下走了！ 官网、1688、微信公众号、微博…… 让我眼花缭乱。 90后同事说，都做了吧！于是，就都做了！ 我慢慢发现，似乎没什么价值呀！ 1688上没几个单！公众号没粉丝！微博没关注！ 还是官网比较靠谱，至少还拿到了客户。 点此下载APP免费创建营销型官网 不知道你们都是怎么做的？ 反正，我觉得官网很重要！营销型的官网更重要！ 最好，还带着客服功能！哈哈，我太贪心了！ 点此下载APP免费创建营销型官网 不是81难吗？不是一难一集的吗？我一直都这么认为的

Re: [ovs-dev] [PATCH] Fix: vhost user port status

Hi Darrell, Thanks for your comment. I just create a new patch accordingly. Yes, I am testing vhost user client port. After ovs-vswitchd restarts, I did nothing. I just used command "ovs-ofctl show br" to get the port status, and found the status is "LINK DOWN". With the patch, the status is 0

[ovs-dev] [PATCH] netdev-dpdk: update vhost user client port status.

After ovs-vswitchd reboots, vhost user cient port status is displayed as LINK DOWN though the traffic is OK. The problem is that the port may be udpated while the vhost_reconfigured is false. Then the vhost_reconfigured is updated to true. As a result, the vhost user status is kept as LINK-DOWN.

[ovs-dev] [PATCH] netdev-dpdk: vhost get stats fix

1. "+=" should be "=" 2. tx_errors is a generic param, and should be 0 since vhost does not create such error. Or some app, like libvirt will complain for failure to find this key. Signed-off-by: wangzhike --- lib/netdev-dpdk.c | 7 --- 1 file changed, 4

Re: [ovs-dev] [ovs-discuss] OVS+DPDK QoS rate limit issue

Hi Ian Did you have any suggestions for this fix or is it ok as is ? Thanks Darrell On 8/24/17, 7:16 PM, "ovs-dev-boun...@openvswitch.org on behalf of 王志克" wrote: Hi Lance, Your patch works. Thanks.

Re: [ovs-dev] [ovs-discuss] OVS+DPDK QoS rate limit issue

Hi Lance, Your patch works. Thanks. BR, Wang Zhike -Original Message- From: Lance Richardson [mailto:lrich...@redhat.com] Sent: Thursday, August 24, 2017 8:10 PM To: 王志克 Cc: ovs-dev@openvswitch.org; ovs-disc...@openvswitch.org Subject: Re: [ovs-discuss] OVS+DPDK QoS rate limit issue

[ovs-dev] 答复: Re: 答复: Re: [PATCH v2] ovn: Support for taas(tap-as-a-service) function

Hi zhenyu, Thanks for your opinion. The mirror flag is not always exist, so I do not think add a new geneve option is a good idea. Thanks. Gao Zhenyu 2017/08/25 09:34 收件人：wang.qia...@zte.com.cn, 抄送： Russell Bryant , ovs

[ovs-dev] 答复: Re: [PATCH v2] ovn: Support for taas(tap-as-a-service) function

Hi Russell, Thanks for your review. When the mirror destination is in other chassis, the mirror flag which used to mark the packet need be transmitted to the destination chassis. We could use the inport, geneve option or new type of out port to indicate the packet as a mirrored packet. When

Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

> From: ovs-dev-boun...@openvswitch.org on > behalf of Ben Pfaff > Sent: Wednesday, August 2, 2017 11:35 AM > To: Alin Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 00/40] Fix static

Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

On Thu, Aug 24, 2017 at 11:15:35PM +, Shashank Ram wrote: > > > > From: ovs-dev-boun...@openvswitch.org on > behalf of Ben Pfaff > Sent: Wednesday, August 2, 2017 11:35 AM > To: Alin Serdean > Cc:

[ovs-dev] [PATCH v6 6/6] dpif-netdev: Add ovs-appctl dpif-netdev/pmd-rxq-rebalance.

Rxqs consumed processing cycles are used to improve the balance of how rxqs are assigned to pmds. Currently some reconfiguration is needed to perform a reassignment. Add an ovs-appctl command to perform a new assignment in order to balance based on the latest rxq processing cycle information.

[ovs-dev] [PATCH v6 5/6] dpif-netdev: Change pmd selection order.

Up to his point rxqs are sorted by processing cycles they consumed and assigned to pmds in a round robin manner. Ian pointed out that on wrap around the most loaded pmd will be the next one to be assigned an additional rxq and that it would be better to reverse the pmd order when wraparound

[ovs-dev] [PATCH v6 4/6] dpif-netdev: Change rxq_scheduling to use rxq processing cycles.

Previously rxqs were assigned to pmds by round robin in port/queue order. Now that we have the processing cycles used for existing rxqs, use that information to try and produced a better balanced distribution of rxqs across pmds. i.e. given multiple pmds, the rxqs which have consumed the largest

[ovs-dev] [PATCH v6 3/6] dpif-netdev: Count the rxq processing cycles for an rxq.

Count the cycles used for processing an rxq during the pmd rxq interval. As this is an in flight counter and pmds run independently, also store the total cycles used during the last full interval. Signed-off-by: Kevin Traynor --- lib/dpif-netdev.c | 75

[ovs-dev] [PATCH v6 2/6] dpif-netdev: Add rxq processing cycle counters.

Add counters to dp_netdev_rxq which will later be used for storing the processing cycles of an rxq. Processing cycles will be stored in reference to a defined time interval. We will store the cycles of the current in progress interval, a number of completed intervals and the sum of the completed

Re: [ovs-dev] [PATCH v5 5/6] dpif-netdev: Change pmd selection order.

On 08/24/2017 09:51 AM, Darrell Ball wrote: > > > On 8/23/17, 6:34 AM, "Kevin Traynor" wrote: > > Up to his point rxqs are sorted by processing cycles they > consumed and assigned to pmds in a round robin manner. > > Ian pointed

Re: [ovs-dev] [PATCH v5 4/6] dpif-netdev: Change rxq_scheduling to use rxq processing cycles.

On 08/24/2017 10:06 AM, Darrell Ball wrote: > > > On 8/24/17, 1:47 AM, "Darrell Ball" wrote: > > There is a minor checkpatch warning > > > == Checking >

Re: [ovs-dev] [PATCH v5 3/6] dpif-netdev: Count the rxq processing cycles for an rxq.

On 08/24/2017 09:44 AM, Darrell Ball wrote: > > On 8/23/17, 6:34 AM, "Kevin Traynor" wrote: > > Count the cycles used for processing an rxq during the > pmd rxq interval. As this is an in flight counter and > pmds run independently, also

Re: [ovs-dev] [PATCH v5 2/6] dpif-netdev: Add rxq processing cycle counters.

Darrell, Thank you for the very thorough review. All look fine. Brief reply to comments inline. thanks, Kevin. On 08/24/2017 09:34 AM, Darrell Ball wrote: > > > On 8/23/17, 6:34 AM, "Kevin Traynor" wrote: > > Add counters to dp_netdev_rxq which will

Re: [ovs-dev] [PATCH v2 0/2] nsh: rework NSH netlink keys and actions

On Fri, Aug 25, 2017 at 06:43:49AM +0800, Yang, Yi wrote: > On Fri, Aug 25, 2017 at 01:39:29AM +0800, Ben Pfaff wrote: > > > do the below changes: > > > > > > 1. change ecanp_nsh and decap_nsh to push_nsh and pop_nsh > > > 2. Use nested OVS_KEY_ATTR_NSH to handle push_nsh. > > > > > > Patch 1 is

Re: [ovs-dev] [PATCH 00/40] Fix static code analysis warnings.

From: ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff Sent: Wednesday, August 2, 2017 11:35 AM To: Alin Serdean Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH 00/40] Fix static code analysis

Re: [ovs-dev] [PATCH v2 0/2] nsh: rework NSH netlink keys and actions

On Fri, Aug 25, 2017 at 01:39:29AM +0800, Ben Pfaff wrote: > > do the below changes: > > > > 1. change ecanp_nsh and decap_nsh to push_nsh and pop_nsh > > 2. Use nested OVS_KEY_ATTR_NSH to handle push_nsh. > > > > Patch 1 is precisely doing this way. > > Since this is targeted at 2.8, I'm only

Re: [ovs-dev] [PATCH v2] ovn: Support for taas(tap-as-a-service) function

Sorry for the delay in getting back to this ... On Tue, Aug 15, 2017 at 4:28 AM, wrote: > Taas was designed to provide tenants and service providers a means of > monitoring the traffic flowing in their Neutron provisioned virtual > networks. It is useful for network

Re: [ovs-dev] [PATCH] conntrack: Fix ct-clean thread crash bug

On 8/24/17, 11:03 AM, "Darrell Ball" wrote: Thanks for testing. I’ll look at in detail and get back to you today. Darrell On 8/24/17, 3:36 AM, "ovs-dev-boun...@openvswitch.org on behalf of huanglili"

Re: [ovs-dev] [PATCH v2] ovn: Check for known logical switch port types.

On Thu, Aug 24, 2017 at 2:13 PM, Mark Michelson wrote: > OVN is lenient with the types of logical switch ports. Maybe too > lenient. This patch attempts to solve this problem on two fronts: > > 1) In ovn-nbctl, if you attempt to set the port type to an unknown > type, the

Re: [ovs-dev] [PATCH v2] ovn: Fix BFD error config on gateway

Thanks for the patch! I applied this to master and branch-2.8. On Wed, Aug 23, 2017 at 5:35 AM, Anil Venkata wrote: > Reviewed change and it looks fine. Also tested the test case. > > On Sun, Aug 20, 2017 at 8:07 PM, Zhenyu Gao wrote: >> >> The

Re: [ovs-dev] [PATCH] conntrack: Fix ct-clean thread crash bug

Thanks for testing. I’ll look at in detail and get back to you today. Darrell On 8/24/17, 3:36 AM, "ovs-dev-boun...@openvswitch.org on behalf of huanglili" wrote: From: Lili Huang

Re: [ovs-dev] OVN: IPv6 Periodic Router Advertisement Plan

On Tue, Aug 22, 2017 at 09:43:29PM +, Mark Michelson wrote: > For a while now, in a "learn the OVN project from scratch" project, I've > been investigating what it would take in order to allow for OVN to send > periodic router advertisements (RAs) as part of a greater goal of rounding > out

Re: [ovs-dev] [PATCH 1/4] netdev: Add set_ingress_sched to netdev api

>From: O Mahony, Billy >Sent: Wednesday, August 16, 2017 5:16 PM >To: Kavanagh, Mark B ; d...@openvswitch.org >Subject: RE: [ovs-dev] [PATCH 1/4] netdev: Add set_ingress_sched to netdev api > >Hi Mark, Hey Billy, Apologies for the delayed response - comments inline

[ovs-dev] [PATCH V2 6/6] datapath: fix skb_panic due to the incorrect actions attrlen

Upstream commit: commit 494bea39f3201776cdfddc232705f54a0bd210c4 Author: Liping Zhang Date: Wed Aug 16 13:30:07 2017 +0800 openvswitch: fix skb_panic due to the incorrect actions attrlen For sw_flow_actions, the actions_len only represents the kernel

[ovs-dev] [PATCH V2 5/6] datapath: Remove unnecessary newlines from OVS_NLERR uses

Upstream commit: commit 0ed80da518a1f27562a013f106505e495e891fe4 Author: Joe Perches Date: Fri Aug 11 04:26:26 2017 -0700 openvswitch: Remove unnecessary newlines from OVS_NLERR uses OVS_NLERR already adds a newline so these just add blank lines to

[ovs-dev] [PATCH V2 4/6] datapath: Optimize operations for OvS flow_stats.

Upstream commit: commit c4b2bf6b4a35348fe6d1eb06928eb68d7b9d99a9 Author: Tonghao Zhang Date: Mon Jul 17 23:28:06 2017 -0700 openvswitch: Optimize operations for OvS flow_stats. When calling the flow_free() to free the flow, we call many times

[ovs-dev] [PATCH V2 3/6] datapath: Optimize updating for OvS flow_stats.

Upstream commit: commit c57c054eb5b1ccf230c49f736f7a018fcbc3e952 Author: Tonghao Zhang Date: Mon Jul 17 23:28:05 2017 -0700 openvswitch: Optimize updating for OvS flow_stats. In the ovs_flow_stats_update(), we only use the node var to alloc

[ovs-dev] [PATCH V2 2/6] datapath: Remove all references to SKB_GSO_UDP.

Upstream commit: commit 880388aa3c07fdea4f9b85e35641753017b1852f Author: David S. Miller Date: Mon Jul 3 07:29:12 2017 -0700 net: Remove all references to SKB_GSO_UDP. Such packets are no longer possible. Signed-off-by: David S. Miller

[ovs-dev] [PATCH V2 1/6] acinclude: Check for SKB_GSO_UDP

Removed in kernel 4.13 Signed-off-by: Greg Rose --- acinclude.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/acinclude.m4 b/acinclude.m4 index 74cc046..9bd1c49 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -763,6 +763,9 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Implement TCP/UDP TX cksum in ovs-dpdk side

Thanks for the comments! Yes, the best way is calculating cksum if destination need cksum. But in current ovs-dpdk process, it is hard to tell whether this whole batch packets need cksum or not when delivering to destination. If we check(check PKT_TX_L4_MASK and has l4 header) packets one by one

Re: [ovs-dev] [PATCH] controller: Remote connection option to OpenFlow switch.

> From: "JaiSingh Rana" > To: "Jai Singh Rana" , d...@openvswitch.org > Sent: Thursday, August 24, 2017 9:50:51 AM > Subject: Re: [ovs-dev] [PATCH] controller: Remote connection option to > OpenFlow switch. > > Hi, > > > Any feedback on

[ovs-dev] [PATCH] netdev-dpdk: use 64-bit arithmetic when converting rates

Force 64-bit arithmetic to be used when converting uint32_t rate and burst parameters from kilobits per second to bytes per second, avoiding incorrect behavior for rates exceeding UINT_MAX bits per second. Reported-by: "王志克" Fixes: 9509913aa722 ("netdev-dpdk.c: Add

[ovs-dev] [RFC PATCH 2/2] sflow: export extended NAT data

With addition of sFlow output sampling, it is possible to export additional data, which isn't available during input sampling. This patch introduces support for exporting extend NAT data. Signed-off-by: Przemyslaw Szczerbik --- ofproto/ofproto-dpif-sflow.c | 37

Re: [ovs-dev] [ovs-discuss] OVS+DPDK QoS rate limit issue

> From: "王志克" > To: ovs-dev@openvswitch.org, ovs-disc...@openvswitch.org > Sent: Wednesday, August 23, 2017 11:41:05 PM > Subject: [ovs-discuss] OVS+DPDK QoS rate limit issue > > > > Hi All, > > > > I am using OVS2.7.0 and DPDK 16.11, and testing rate limit function. > >

[ovs-dev] [PATCH] conntrack: Fix ct-clean thread crash bug

From: Lili Huang Conn should be removed from the list before freed. This crash will be triggered when a established flow do ct(nat) again, like "ip,actions=ct(table=1) table=1,in_port=1,ip,actions=ct(commit,nat(dst=5.5.5.5)),2

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Implement TCP/UDP TX cksum in ovs-dpdk side

Hi Gao, Thanks for working on this. Lack of checksum offload is big difference between ovs and ovs-dpdk when using linux stack in the guest. The thing that struck me was that rather than immediately calculating the L4 checksum in the host on vhost rx that the calculation should be delayed

Re: [ovs-dev] [PATCH v5 4/6] dpif-netdev: Change rxq_scheduling to use rxq processing cycles.

On 8/24/17, 1:47 AM, "Darrell Ball" wrote: There is a minor checkpatch warning == Checking "/home/dball/Desktop/patches/ovs-dev-v5-4-6-dpif-netdev-Change-rxq_scheduling-to-use-rxq-processing-cycles..patch" == WARNING: Line lacks whitespace around

Re: [ovs-dev] [PATCH v5 4/6] dpif-netdev: Change rxq_scheduling to use rxq processing cycles.

There is a minor checkpatch warning == Checking "/home/dball/Desktop/patches/ovs-dev-v5-4-6-dpif-netdev-Change-rxq_scheduling-to-use-rxq-processing-cycles..patch" == WARNING: Line lacks whitespace around operator #170 FILE: lib/dpif-netdev.c:3456: Round-robin on the NUMA nodes

Re: [ovs-dev] [PATCH v5 2/6] dpif-netdev: Add rxq processing cycle counters.

On 8/23/17, 6:34 AM, "Kevin Traynor" wrote: Add counters to dp_netdev_rxq which will later be used for storing the processing cycles of an rxq. Processing cycles will be stored in reference to a defined time interval. We will store the

Re: [ovs-dev] [PATCH 3/4] tc: Add header rewrite using tc pedit action

On 23/08/2017 03:20, Joe Stringer wrote: On 22 August 2017 at 13:31, Paul Blakey wrote: On 22/08/2017 23:07, Paul Blakey wrote: On 21/08/2017 20:45, Joe Stringer wrote: On 20 August 2017 at 01:50, Paul Blakey wrote: On 18/08/2017 00:52,