[ovs-dev] Auditorías Administrativas - En línea

2017-09-20 Thread Sistemas Eficaces de Control
En línea y en Vivo / Para todo su Equipo con una sola Conexión Sistemas Eficaces de Control a través de AUDITORÍAS ADMINISTRATIVAS 12 de octubre - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00 Hrs La elevada competitividad en el mundo empresarial, obliga a toda organización, sin importar

Re: [ovs-dev] [PATCH 14/15] Documentation: Update NEWS and FAQ.

2017-09-20 Thread Andy Zhou
On Mon, Sep 11, 2017 at 10:56 AM, Greg Rose wrote: > Document Open vSwitch Linux kernel support for the 4.13 kernel > release. > > Signed-off-by: Greg Rose > --- > Documentation/faq/releases.rst | 2 +- > NEWS | 2 ++ > 2

Re: [ovs-dev] [dpdk-users] adding dpdk ports sharing same pci address to ovs-dpdk bridge

2017-09-20 Thread Thomas Monjalon
20/09/2017 19:33, Kevin Traynor: > On 09/08/2017 10:56 AM, Loftus, Ciara wrote: > >> Hi, > >> > >> I have compiled and built ovs-dpdk using DPDK v17.08 and OVS v2.8.0. The > >> NIC that I am using is Mellanox ConnectX-3 Pro, which is a dual port 10G > >> NIC. The problem with this NIC is that it

[ovs-dev] [PATCH v3 2/2] ofp-util: Fix memory leaks on error cases in ofputil_decode_group_mod().

2017-09-20 Thread Ben Pfaff
Found by libFuzzer. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff --- lib/ofp-util.c | 82 ++ 1 file changed, 48 insertions(+), 34 deletions(-) diff --git a/lib/ofp-util.c

[ovs-dev] [PATCH v3 1/2] ofp-util: Fix buffer overread in ofputil_decode_bundle_add().

2017-09-20 Thread Ben Pfaff
A buffer overread of up to 4 bytes was possible given a malformed message. The message was discarded following the overread. Found by libFuzzer. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff --- lib/ofp-util.c | 3 +++ 1 file changed,

[ovs-dev] [PATCH v3 0/2] Fix memory leaks and overreads in ofp-util

2017-09-20 Thread Ben Pfaff
v1->v2: Add memory leak fix. v2->v3: Extend memory leak fix. Ben Pfaff (2): ofp-util: Fix buffer overread in ofputil_decode_bundle_add(). ofp-util: Fix memory leaks on error cases in ofputil_decode_group_mod(). lib/ofp-util.c | 85

Re: [ovs-dev] [PATCH 1/5] conntrack: add commands to r/w conntrack parameters.

2017-09-20 Thread Fischetti, Antonio
Sure Kevin, I'll add a cover letter to the new version I'm going to rework. Basically these are two new commands to allow read/adjust some of the CT configuration parameter. So that the user can try to find a better tuning for his/her setup. Thanks, Antonio > -Original Message- > From:

Re: [ovs-dev] [PATCH 3/5] conntrack: r/w clean-up interval.

2017-09-20 Thread Fischetti, Antonio
> -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, September 19, 2017 9:28 PM > To: Fischetti, Antonio ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 3/5] conntrack: r/w clean-up interval. > > Hi Antonio > > What is

Re: [ovs-dev] [PATCH 2/5] conntrack: r/w upper limit value for connections.

2017-09-20 Thread Fischetti, Antonio
> -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, September 19, 2017 9:05 AM > To: Fischetti, Antonio ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 2/5] conntrack: r/w upper limit value for > connections. > > > >

Re: [ovs-dev] [PATCH 1/5] conntrack: add commands to r/w conntrack parameters.

2017-09-20 Thread Fischetti, Antonio
Thanks Darrell for your comments, I'll re-spin a V2 based on your feedback. Other details inline below. -Antonio > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, September 19, 2017 8:50 AM > To: Fischetti, Antonio ;

Re: [ovs-dev] [dpdk-users] adding dpdk ports sharing same pci address to ovs-dpdk bridge

2017-09-20 Thread Kevin Traynor
On 09/08/2017 10:56 AM, Loftus, Ciara wrote: >> Hi, >> >> I have compiled and built ovs-dpdk using DPDK v17.08 and OVS v2.8.0. The >> NIC that I am using is Mellanox ConnectX-3 Pro, which is a dual port 10G >> NIC. The problem with this NIC is that it provides only one PCI address for >> both the

Re: [ovs-dev] [PATCH] Debian: Update package dependency

2017-09-20 Thread Ben Warren via dev
Thanks for doing this. > On Sep 20, 2017, at 9:30 AM, Yi-Hung Wei wrote: > > Given that it is libopenvswitch-dev not libopenvswitch that depends on > libssl-dev, this patch updates debian/control file to reflect that > libopenvswitch-dev depends on libssl-dev, and

[ovs-dev] [PATCH v2 2/2] ofp-util: Fix memory leaks on error cases in ofputil_pull_ofp11_buckets().

2017-09-20 Thread Ben Pfaff
Found by libFuzzer. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff --- lib/ofp-util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index e915cb2ab2d7..8c294727bfa3 100644 --- a/lib/ofp-util.c +++

[ovs-dev] [PATCH v2 1/2] ofp-util: Fix buffer overread in ofputil_decode_bundle_add().

2017-09-20 Thread Ben Pfaff
A buffer overread of up to 4 bytes was possible given a malformed message. The message was discarded following the overread. Found by libFuzzer. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff --- lib/ofp-util.c | 3 +++ 1 file changed,

[ovs-dev] [PATCH] Debian: Update package dependency

2017-09-20 Thread Yi-Hung Wei
Given that it is libopenvswitch-dev not libopenvswitch that depends on libssl-dev, this patch updates debian/control file to reflect that libopenvswitch-dev depends on libssl-dev, and libopenvswitch depends on openssl. Tested on Ubuntu 16.04 and 14.04. VMWare-BZ: #1953215 CC: Ben Warren

Re: [ovs-dev] [PATCH] dpif-netdev: Set MAX_RECIRC_DEPTH to 10.

2017-09-20 Thread Darrell Ball
On 9/20/17, 4:45 AM, "Guoshuai Li" wrote: yes, Distributed gateway. I config my gateway router port with 'redirect-chassis'option in ovn-nb. Logical_Router_Port table _uuidenabled external_ids gateway_chassis mac

[ovs-dev] [PATCH v2] ovn: Fix remote not receive GARP, when localnet Port has vlan tag.

2017-09-20 Thread Guoshuai Li
When sending a localnet port with vlan, the GARP packet needs push_vlan. --- v2: Add check vlan vaid. Add update localnet vlan tag process. --- ovn/controller/pinctrl.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/ovn/controller/pinctrl.c

Re: [ovs-dev] [PATCH RFC 2/2] dpif-netdev: Use microseconds granularity for output-max-latency.

2017-09-20 Thread Jan Scheurich
Hi Ilya, I have spent some more time on analyzing and thinking through your latest propose patch set for time-based Tx batching: > (Ilya-6): Time-based output batching with us resolution using > CLOCK_MONOTONIC > (master) + [PATCH v3 1-3/4] Output packet batching + >

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-20 Thread Gao Zhenyu
" But, if an ovn port in foo (chassis A) wants to talk to alice1 (chassis B), wouldn't all that E/W routing will happen virtually and the end result is just a tunneled packet between chassis A and chassis B ? " [ Now the hash function base on dst IP, if foo1 only talks to alice1, and it is the

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-20 Thread Miguel Angel Ajo Pelayo
I forgot to say thank you very much for the explanation and diagrams. On Wed, Sep 20, 2017 at 4:07 PM, Miguel Angel Ajo Pelayo < majop...@redhat.com> wrote: > But, if an ovn port in foo (chassis A) wants to talk to alice1 (chassis > B), > wouldn't all that E/W routing will happen virtually and

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-20 Thread Miguel Angel Ajo Pelayo
But, if an ovn port in foo (chassis A) wants to talk to alice1 (chassis B), wouldn't all that E/W routing will happen virtually and the end result is just a tunneled packet between chassis A and chassis B ? What's the benefit of multipath there if the possible failing link is always the

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-20 Thread Gao Zhenyu
You can take a look at this patch that implement a testcase : https://patchwork.ozlabs.org/patch/815475/ In the testcase, we have R1, R2, R3. R1 and R2 that are connected to each other via LS "join" in 20.0.0.0/24 network. R1 and R3 that are connected to each other via LS "join2" in

Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config

2017-09-20 Thread Chandran, Sugesh
Regards _Sugesh > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Thursday, September 14, 2017 6:46 PM > To: Chandran, Sugesh ; Yuanhan Liu > > Cc: Finn Christensen ; d...@openvswitch.org >

Re: [ovs-dev] [PATCH 00/10] Use DP_PACKET_BATCH_FOR_EACH macro.

2017-09-20 Thread Bodireddy, Bhanuprakash
Hi Darrell, >You have many instances where you want to use >DP_PACKET_BATCH_FOR_EACH You have another series partially about this: >https://patchwork.ozlabs.org/patch/813007/ > >Also, this series mixes in other changes like creating new variables for >clarity, I >guess, and removing unneeded

[ovs-dev] [PATCH v2 11/12] dpif-netdev: Remove 'cnt' in dp_netdev_input__().

2017-09-20 Thread Bhanuprakash Bodireddy
There is little use of 'cnt' variable in dp_netdev_input__(). Get rid of it and use dp_packet_batch_size() to initialize PKT_ARRAY_SIZE. Signed-off-by: Bhanuprakash Bodireddy --- lib/dpif-netdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[ovs-dev] [PATCH v2 10/12] odp-execute: Use const qualifer for batch size.

2017-09-20 Thread Bhanuprakash Bodireddy
It is recommended to use const qualifer for 'num' that tracks the packet batch count. This way 'num' can't be modified by iterator. Signed-off-by: Bhanuprakash Bodireddy --- lib/odp-execute.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH v2 12/12] dpif-netdev: Fix comments for pmd_load_cached_ports.

2017-09-20 Thread Bhanuprakash Bodireddy
Commit 57eebbb4c315 replaces thread local 'pmd->port_cache' with 'pmd->tnl_port_cache' and 'pmd->send_port_cache' maps. Update the comments accordingly. Fixes: 57eebbb4c315 ("Don't try to output on a device without txqs") Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH v2 09/12] netdev-dpdk: Minor cleanup of netdev_dpdk_send__.

2017-09-20 Thread Bhanuprakash Bodireddy
The variable 'cnt' is initialized and reused in multiple function calls inside netdev_dpdk_send__() and is confusing sometimes. Instead introduce 'batch_cnt' to hold the original packet count and 'tx_cnt' to store the final packet count resulting after filtering and qos operations. Finally

[ovs-dev] [PATCH v2 05/12] dpif-netdev: Use DP_PACKET_BATCH_FOR_EACH in dp_netdev_run_meter.

2017-09-20 Thread Bhanuprakash Bodireddy
Use DP_PACKET_BATCH_FOR_EACH macro in dp_netdev_run_meter(). Signed-off-by: Bhanuprakash Bodireddy --- lib/dpif-netdev.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index

[ovs-dev] [PATCH v2 08/12] netdev-dpdk: Cleanup dpdk_do_tx_copy.

2017-09-20 Thread Bhanuprakash Bodireddy
Cleanup dpdk_do_tx_copy(). Signed-off-by: Bhanuprakash Bodireddy --- lib/netdev-dpdk.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 60ec528..60887e5 100644 ---

[ovs-dev] [PATCH v2 04/12] netdev-bsd: Use DP_PACKET_BATCH_FOR_EACH in netdev_bsd_send.

2017-09-20 Thread Bhanuprakash Bodireddy
Use DP_PACKET_BATCH_FOR_EACH macro in netdev_bsd_send(). Signed-off-by: Bhanuprakash Bodireddy --- lib/netdev-bsd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 8a4cdb3..96ba71c 100644 ---

[ovs-dev] [PATCH v2 03/12] netdev-dpdk: Use DP_PACKET_BATCH_FOR_EACH in netdev_dpdk_ring_send

2017-09-20 Thread Bhanuprakash Bodireddy
Use DP_PACKET_BATCH_FOR_EACH macro in netdev_dpdk_ring_send(). Signed-off-by: Bhanuprakash Bodireddy --- lib/netdev-dpdk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 648d719..60ec528

[ovs-dev] [PATCH v2 02/12] netdev-linux: Use DP_PACKET_BATCH_FOR_EACH in netdev_linux_tap_batch_send.

2017-09-20 Thread Bhanuprakash Bodireddy
Use DP_PACKET_BATCH_FOR_EACH macro in netdev_linux_tap_batch_send(). Signed-off-by: Bhanuprakash Bodireddy --- lib/netdev-linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index

[ovs-dev] [PATCH v2 01/12] conntrack: Use DP_PACKET_BATCH_FOR_EACH macro.

2017-09-20 Thread Bhanuprakash Bodireddy
Use DP_PACKET_BATCH_FOR_EACH macro in conntrack_execute(). Signed-off-by: Bhanuprakash Bodireddy --- lib/conntrack.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 419cb1d..019092e

[ovs-dev] [PATCH v2 00/12] Use packet batch macro and APIs.

2017-09-20 Thread Bhanuprakash Bodireddy
DP_PACKET_BATCH_FOR_EACH macro was introduced early this year as part of enhancing packet batch APIs. Commit '72c84bc2' implemented this macro and replaced most of the calling sites with macros and simplified the logic. However there are still many APIs that needs to be fixed. This patch series

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-20 Thread Miguel Angel Ajo Pelayo
Can you share an example of how this would benefit E/W routing. I'm just not seeing the specific use case myself out of ignorance. It'd be great if you could explain how would it work between several ports in the networks and routers (may be a diagram?) otherwise I can't be really helpful

[ovs-dev] [PATCH v2] ovn: OVN Support QoS meter

2017-09-20 Thread Guoshuai Li
ovn-northd modify: add bandwidth column in NB's QOS table. add QOS_METER stages in Logical switch ingress/egress. add set_meter() action in SB's LFlow table. ovn-controller modify: add meter_table for meter action process openflow meter table. This feature is only supported in DPDK. --- v2: Fix

Re: [ovs-dev] [PATCH] dpif-netdev: Set MAX_RECIRC_DEPTH to 10.

2017-09-20 Thread Guoshuai Li
yes, Distributed gateway. I config my gateway router port with 'redirect-chassis'option in ovn-nb. Logical_Router_Port table _uuidenabled external_ids gateway_chassis mac name networks options

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-20 Thread Gao Zhenyu
Thanks for the suggestions! Not all Logical port has a real ofp_port connect with it. And bundle_load/bundle actions need real ovs port. Especially in ovn router port, all router port are virtual port which just a number/reg in our ovs-flows. This implement of multipath can seperate ovn

Re: [ovs-dev] 答复: [PATCH v1 1/3] Add multipath static router in OVN northd and north-db

2017-09-20 Thread Miguel Angel Ajo Pelayo
I'm not very familiar with multipath implementations, but would it be possible to use bundle( ouput action with hrw algorithm instead of multipath calculation to a register?. I say this, because if you look at lib/multipath.c lib/bundle.c you will find that bundle.c is going to consider the

Re: [ovs-dev] [PATCH] ovn: Discard flows for non-local ports.

2017-09-20 Thread Miguel Angel Ajo Pelayo
Wow, amazing, that makes sense. I also ran manual tests locally and everything seemed fine. On Tue, Sep 19, 2017 at 6:22 PM, Russell Bryant wrote: > On Tue, Sep 19, 2017 at 9:38 AM, Russell Bryant wrote: > > On Mon, Sep 18, 2017 at 7:31 PM, Han Zhou

Re: [ovs-dev] ovs_dpdk: dpdk-socket-mem usage question

2017-09-20 Thread 王志克
Thanks Billy. I will tune it during my test while trying to reading related code to understand the logic. Br, Wang Zhike -Original Message- From: O Mahony, Billy [mailto:billy.o.mah...@intel.com] Sent: Tuesday, September 19, 2017 9:07 PM To: 王志克; ovs-dev@openvswitch.org;

Re: [ovs-dev] [PATCH V2] netdev-tc-offloads: Fix vxlan tunnel offloading

2017-09-20 Thread Simon Horman
On Wed, Sep 13, 2017 at 05:04:58PM +0300, Roi Dayan wrote: > From: Paul Blakey > > This commit fixes offloading when tunnel id is 0 by checking > for valid tunnel dst ipv4 or ipv6, like done in the normal flow. > > Also need to reset the tunnel mask outside the condition >