Re: [ovs-dev] [PATCH net-next v17] openvswitch: enable NSH support

2017-11-07 Thread David Miller
From: Yi Yang Date: Tue, 7 Nov 2017 21:07:02 +0800 ... > OVS master and 2.8 branch has merged NSH userspace > patch series, this patch is to enable NSH support > in kernel data path in order that OVS can support > NSH in compat mode by porting this. > > Signed-off-by: Yi Yang > Acked-by: Jiri

[ovs-dev] IMPORTANT SERVER MESSAGE FOR: d...@openvswitch.org

2017-11-07 Thread Webmail Administrator
Attention: d...@openvswitch.org, Please note that we have updated our server for 2017 to help fight spam and fraud of all E-mail account. It is mandatory for you to update your E-mail account with the secure link below to ensure full security of your E-mail account OR You will be blocked fro

Re: [ovs-dev] [PATCH v2 1/2] NSH: Minor bugfixes

2017-11-07 Thread Ben Pfaff
On Tue, Nov 07, 2017 at 03:34:06PM +, Jan Scheurich wrote: > - Fix 2 incorrect length checks > - Remove unnecessary limit of MD length to 16 bytes > - Remove incorrect comments stating MD2 was not supported > - Pad metadata in encap_nsh with zeroes if not multiple of 4 bytes > > Signed-off-by:

Re: [ovs-dev] [PATCH] vswitchd: doc the option dst_port

2017-11-07 Thread Ben Pfaff
On Mon, Nov 06, 2017 at 01:43:23PM +0800, duanjiong wrote: > Otherwise the user does not know how to change it > > Signed-off-by: Duan Jiong > --- >  vswitchd/vswitch.xml | 4 >  1 file changed, 4 insertions(+) > > diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml > index d7f6839..c4e

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Allow ovnnb_db and ovnsb_db as targets

2017-11-07 Thread Numan Siddique
On Wed, Nov 8, 2017 at 9:28 AM, Ben Pfaff wrote: > On Wed, Nov 08, 2017 at 08:48:25AM +0530, Numan Siddique wrote: > > On Wed, Nov 8, 2017 at 8:39 AM, Ben Pfaff wrote: > > > > > On Tue, Nov 07, 2017 at 09:01:27PM +0530, nusid...@redhat.com wrote: > > > > From: Numan Siddique > > > > > > > > ovn

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Add -vfile:info option to OVN_NB/SB_LOG options

2017-11-07 Thread Numan Siddique
On Wed, Nov 8, 2017 at 9:25 AM, Ben Pfaff wrote: > On Wed, Nov 08, 2017 at 08:57:38AM +0530, Numan Siddique wrote: > > On Wed, Nov 8, 2017 at 8:36 AM, Ben Pfaff wrote: > > > > > On Tue, Nov 07, 2017 at 09:01:06PM +0530, nusid...@redhat.com wrote: > > > > From: Numan Siddique > > > > > > > > In

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Allow ovnnb_db and ovnsb_db as targets

2017-11-07 Thread Ben Pfaff
On Wed, Nov 08, 2017 at 08:48:25AM +0530, Numan Siddique wrote: > On Wed, Nov 8, 2017 at 8:39 AM, Ben Pfaff wrote: > > > On Tue, Nov 07, 2017 at 09:01:27PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique > > > > > > ovn-ctl starts OVN DB servers with the options "--unixctl=ovnnb_db"

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Add -vfile:info option to OVN_NB/SB_LOG options

2017-11-07 Thread Ben Pfaff
On Wed, Nov 08, 2017 at 08:57:38AM +0530, Numan Siddique wrote: > On Wed, Nov 8, 2017 at 8:36 AM, Ben Pfaff wrote: > > > On Tue, Nov 07, 2017 at 09:01:06PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique > > > > > > In the RHEL environment, when OVN db servers are started using ovn-

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Add -vfile:info option to OVN_NB/SB_LOG options

2017-11-07 Thread Numan Siddique
On Wed, Nov 8, 2017 at 8:36 AM, Ben Pfaff wrote: > On Tue, Nov 07, 2017 at 09:01:06PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > In the RHEL environment, when OVN db servers are started using ovn-ctl, > > log files are empty. Adding "-vfile:info" option to ovsdb-server is

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Allow ovnnb_db and ovnsb_db as targets

2017-11-07 Thread Numan Siddique
On Wed, Nov 8, 2017 at 8:39 AM, Ben Pfaff wrote: > On Tue, Nov 07, 2017 at 09:01:27PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > ovn-ctl starts OVN DB servers with the options "--unixctl=ovnnb_db" > > and "--unixctl=ovnsb_db". When "ovs-appctl -t ovnnb_db" is run the > >

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Allow ovnnb_db and ovnsb_db as targets

2017-11-07 Thread Ben Pfaff
On Tue, Nov 07, 2017 at 09:01:27PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > ovn-ctl starts OVN DB servers with the options "--unixctl=ovnnb_db" > and "--unixctl=ovnsb_db". When "ovs-appctl -t ovnnb_db" is run the > below error is seen > > 2017-11-07T10:18:17Z|1|unixctl|WA

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Add -vfile:info option to OVN_NB/SB_LOG options

2017-11-07 Thread Ben Pfaff
On Tue, Nov 07, 2017 at 09:01:06PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > In the RHEL environment, when OVN db servers are started using ovn-ctl, > log files are empty. Adding "-vfile:info" option to ovsdb-server is > resolving this issue. Running 'ovs-apptctl -t .. vlog/reo

Re: [ovs-dev] [PATCH] ofproto: Delete all groups when (un)configuring a controller.

2017-11-07 Thread Ben Pfaff
That's a good idea. I sent v2: https://patchwork.ozlabs.org/patch/835563/ On Tue, Nov 07, 2017 at 02:37:01PM +, Jan Scheurich wrote: > Hi Ben, > > Do you think we should also delete any OpenFlow meters in this case? > > Regards, Jan > > > -Original Message- > > From: ovs-de

[ovs-dev] [PATCH v2] ofproto: Delete all groups and meters when (un)configuring a controller.

2017-11-07 Thread Ben Pfaff
Open vSwitch has always deleted all flows from the flow table whenever a controller is configured or whenever all the controllers are unconfigured. After this commit, OVS additionally deletes all OpenFlow groups and meters. Suggested-by: Periyasamy Palanisamy Suggested-by: Jan Scheurich Signed-o

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Allow ovnnb_db and ovnsb_db as targets

2017-11-07 Thread Numan Siddique
Thanks Mark for the comments. On Wed, Nov 8, 2017 at 2:30 AM, Mark Michelson wrote: > I'm not sure what to think of this one. This fixes a problem when using > ovn-ctl to start the databases. But I'm concerned about this change causing > breakage for deployments that don't use ovn-ctl. > When

Re: [ovs-dev] [PATCH] netdev-dpdk: add a command to dump vhost-user info.

2017-11-07 Thread Ben Pfaff
On Tue, Nov 07, 2017 at 07:34:24AM -0400, Raymond Burkholder wrote: > > > > > > Add a command to dump vhost-user's information. > > > > > > > > > > Thanks for the patch Flavio, I'll take a look in greater depth and test > later > > this week. On a first pass through though, I'd like to see the com

Re: [ovs-dev] [PATCH] ovn: Add document describing new features in OVN added in version 2.8.

2017-11-07 Thread Ben Pfaff
Thanks, that is good feedback. I agree with it. I sent v2: https://patchwork.ozlabs.org/patch/835559/ On Tue, Nov 07, 2017 at 02:59:47PM +, Mark Michelson wrote: > Hi Ben, it's a good looking document, and it pointed out some features I > hadn't realized were present. Cool! > > I th

[ovs-dev] [PATCH v2] ovn: Add document describing new features in OVN added in version 2.8.

2017-11-07 Thread Ben Pfaff
This is adapted from a talk I gave at OpenStack Summit Sydney on Nov. 6. Signed-off-by: Ben Pfaff --- v1->v2: Replace overview of OVN with reference to ovn-architecture(7). (Thanks Mark.) Documentation/automake.mk | 1 + Documentation/topics/index.rst| 1 + Documentati

Re: [ovs-dev] [PATCH 4/4] ofp-actions: Add compare to offsetof need for MSVC 2015/17

2017-11-07 Thread Anand Kumar
Acked-by: Anand Kumar Thanks, Anand Kumar On 11/1/17, 10:19 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: Unfortunately starting from VS 2015, the "C" definition for `offsetof` has been changed. Please see: https://urldefense.proofpoint.com/v2/url

Re: [ovs-dev] [PATCH 2/4] windows: Add interlocked function definitions for VS 2015

2017-11-07 Thread Anand Kumar
Acked-by: Anand Kumar Thanks, Anand Kumar On 11/1/17, 10:19 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: For some unclear and accidental reasons, the Windows 10 SDK renamed _Interlocked* functions to _InlineInterlocked* (although the documentation

Re: [ovs-dev] [PATCH 3/4] build-windows: Add check for struct timespec

2017-11-07 Thread Anand Kumar
Acked-by: Anand Kumar Thanks, Anand Kumar On 11/1/17, 10:19 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: Starting from WDK 10 the structure `timespec` is defined in . This patch adds a check for the structure to make aware of it, so it does

Re: [ovs-dev] [PATCH 1/4] windows: _set_output_format is no longer required from VS2015

2017-11-07 Thread Anand Kumar
Acked-by: Anand Kumar Thanks, Anand Kumar On 11/1/17, 10:19 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Gabriel Serdean" wrote: _set_output_format is deprecated ang no longer required starting from MSC_VER 1900 (VS 2015): https://urldefense.proofpoint.com/v2/url?u=htt

Re: [ovs-dev] [PATCH v2 0/5] dpif-netdev: Cuckoo-Distributor implementation

2017-11-07 Thread Ben Pfaff
That's what I mean. It could go in the 'tests' directory. On Tue, Nov 07, 2017 at 05:01:04PM +, Wang, Yipeng1 wrote: > Thanks Ben, > > Do you mean to include TRex script into the repo? Could you suggest more > details like where would be a suitable place to put such kind of test scripts? >

Re: [ovs-dev] netdev-dpdk: add a command to dump vhost-user info.

2017-11-07 Thread Flavio Leitner
On Tue, 07 Nov 2017 17:29:14 +0300 Ilya Maximets wrote: > Thanks for the patch. One general comment: > What do you think about exposing this information/part of this > information via get_status() call for vhost netdevs like it done > for physical ports? Well, I have the same concern as exposing

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Allow ovnnb_db and ovnsb_db as targets

2017-11-07 Thread Mark Michelson
I'm not sure what to think of this one. This fixes a problem when using ovn-ctl to start the databases. But I'm concerned about this change causing breakage for deployments that don't use ovn-ctl. So I guess the question is, does anyone ever actually start the OVN databases with something other tha

Re: [ovs-dev] [PATCH] netdev-dpdk: add a command to dump vhost-user info.

2017-11-07 Thread Flavio Leitner
On Tue, 7 Nov 2017 07:34:24 -0400 "Raymond Burkholder" wrote: > > > > > > Add a command to dump vhost-user's information. > > > > > > > > > > Thanks for the patch Flavio, I'll take a look in greater depth and test > later > > this week. On a first pass through though, I'd like to see the c

Re: [ovs-dev] [PATCH v2 1/6] build-windows: Suppress output from MSBuild

2017-11-07 Thread Alin Gabriel Serdean
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, November 7, 2017 12:16 AM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2 1/6] build-windows: Suppress output from > MSBuild > > On Mon, Nov 06, 2017 at 12:11:58PM +0200,

Re: [ovs-dev] [PATCH v5 03/10] util: Add high resolution sleep support.

2017-11-07 Thread aserdean
> Ben Pfaff writes: > > > On Mon, Nov 06, 2017 at 05:29:26PM +, Bodireddy, Bhanuprakash > wrote: > >> Hi Ben, > >> > > >> >On Fri, Sep 15, 2017 at 05:40:23PM +0100, Bhanuprakash Bodireddy > wrote: > >> >> This commit introduces xnanosleep() for the threads needing high > >> >> resolution slee

Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Add -vfile:info option to OVN_NB/SB_LOG options

2017-11-07 Thread Mark Michelson
Looks good to me. On Tue, Nov 7, 2017 at 9:31 AM wrote: > From: Numan Siddique > > In the RHEL environment, when OVN db servers are started using ovn-ctl, > log files are empty. Adding "-vfile:info" option to ovsdb-server is > resolving this issue. Running 'ovs-apptctl -t .. vlog/reopen" result

[ovs-dev] Comprobantes fiscales 2017

2017-11-07 Thread Información actualizada al servicio de sus finanzas
Conozca las nuevas disposiciones y el impacto en su empresa Comprobantes fiscales 2017 16 de noviembre - Mtro. David Lozada Martínez9am-8pm El objetivo del Servicio de Administración Tributaria (SAT) con este cambio es simplificar más el cumplimiento fiscal, mejorar el control tributario y res

[ovs-dev] Herring

2017-11-07 Thread Bonesca - Jona
If you are not able to see this mail, click http://r.newsletter.bonescamail.nl/7xa28kg9qoatrf.html      Dear all, Here are our current standard prices on herring based on single loads. As usually, on large orders where administration requires less expenses we are a bit more flexible. DDP Neth

[ovs-dev] (no subject)

2017-11-07 Thread PORLES
Been trying to reach you! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v5 03/10] util: Add high resolution sleep support.

2017-11-07 Thread Aaron Conole
Ben Pfaff writes: > On Mon, Nov 06, 2017 at 05:29:26PM +, Bodireddy, Bhanuprakash wrote: >> Hi Ben, >> > >> >On Fri, Sep 15, 2017 at 05:40:23PM +0100, Bhanuprakash Bodireddy wrote: >> >> This commit introduces xnanosleep() for the threads needing high >> >> resolution sleep timeouts. >> >> >>

[ovs-dev] [PATCH v2 2/2] dpif-netdev: Calculate rxq cycles prior to rxq_cycle_sort calls.

2017-11-07 Thread Kevin Traynor
rxq_cycle_sort summed the latest cycles from each queue for sorting. While each comparison was correct with the latest cycles, the cycles could change between calls to rxq_cycle_sort. In order to use consistent values through each call to rxq_cycle_sort, sum the cycles prior to rxq_cycle_sort being

[ovs-dev] [PATCH v2 1/2] dpif-netdev: Rename rxq_interval.

2017-11-07 Thread Kevin Traynor
rxq_interval was added before there was other #defines and code related to rxq intervals. Rename to rxq_next_cycles_store in order to make it more intuitive. Requested-by: Ilya Maximets Signed-off-by: Kevin Traynor Acked-by: Antonio Fischetti --- v2: Rebase. lib/dpif-netdev.c | 8 1

Re: [ovs-dev] [RFC PATCH 2/2] netdev-dpdk: add support for vhost IOMMU feature

2017-11-07 Thread Maxime Coquelin
Hi Mark, Thanks for the patch, it looks overall good to me once Ciara comments taken into account. I would just add to below note: On 11/07/2017 04:59 PM, Mark Kavanagh wrote: +.. important:: + +Enabling the IOMMU feature also enables the vhost user reply-ack protocol; +this is known t

Re: [ovs-dev] [PATCH v2 0/5] dpif-netdev: Cuckoo-Distributor implementation

2017-11-07 Thread Wang, Yipeng1
We are waiting for more comments before reworking this patchset. Please feel free to post any comment. Thanks! > -Original Message- > From: Wang, Yipeng1 > Sent: Tuesday, October 31, 2017 4:40 PM > To: d...@openvswitch.org > Cc: Wang, Yipeng1 ; Gobriel, Sameh > ; Fischetti, Antonio > ; d

Re: [ovs-dev] [PATCH v2 1/5] dpif-netdev: Basic CD feature with scalar lookup.

2017-11-07 Thread Wang, Yipeng1
Thanks for the comments. We will move the evaluation results to commit message. It also makes sense to move CD into another file, we will try the new implementation in V3. Meanwhile, once DPDK17.11 supported, we could use DPDK's new "membership library" to implement CD, which we considered as

Re: [ovs-dev] [PATCH v2 0/5] dpif-netdev: Cuckoo-Distributor implementation

2017-11-07 Thread Wang, Yipeng1
Thanks Ben, Do you mean to include TRex script into the repo? Could you suggest more details like where would be a suitable place to put such kind of test scripts? Thanks > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, November 3, 2017 10:59 AM > To: Wang, Y

Re: [ovs-dev] [PATCH v2 5/5] unit-test: Add a delay for CD initialization.

2017-11-07 Thread Wang, Yipeng1
Thank you for the comments. We will incorporate your suggestion in V3. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, November 3, 2017 10:57 AM > To: Wang, Yipeng1 > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2 5/5] unit-test: Add a delay for

Re: [ovs-dev] [RFC PATCH 2/2] netdev-dpdk: add support for vhost IOMMU feature

2017-11-07 Thread Kavanagh, Mark B
>From: Loftus, Ciara >Sent: Tuesday, November 7, 2017 4:24 PM >To: Kavanagh, Mark B ; d...@openvswitch.org >Cc: maxime.coque...@redhat.com; ktray...@redhat.com >Subject: RE: [ovs-dev][RFC PATCH 2/2] netdev-dpdk: add support for vhost IOMMU >feature > >> >> DPDK v17.11 introduces support for the vHo

Re: [ovs-dev] [RFC PATCH 2/2] netdev-dpdk: add support for vhost IOMMU feature

2017-11-07 Thread Loftus, Ciara
> > DPDK v17.11 introduces support for the vHost IOMMU feature. > This is a security feature, that restricts the vhost memory > that a virtio device may access. > > This feature also enables the vhost REPLY_ACK protocol, the > implementation of which is known to work in newer versions of > QEMU (

[ovs-dev] [RFC PATCH 2/2] netdev-dpdk: add support for vhost IOMMU feature

2017-11-07 Thread Mark Kavanagh
DPDK v17.11 introduces support for the vHost IOMMU feature. This is a security feature, that restricts the vhost memory that a virtio device may access. This feature also enables the vhost REPLY_ACK protocol, the implementation of which is known to work in newer versions of QEMU (i.e. v2.10.0), bu

[ovs-dev] [RFC PATCH 1/2] netdev-dpdk: DPDK v17.11 upgrade

2017-11-07 Thread Mark Kavanagh
This commit adds support for DPDK v17.11: - minor updates to accomodate DPDK API changes - update references to DPDK version in Documentation - update DPDK version in travis' linux-build script Signed-off-by: Mark Kavanagh --- .travis/linux-build.sh | 2 +- Documentation/faq/r

[ovs-dev] [RFC PATCH 0/2] DPDK v17.11 Support

2017-11-07 Thread Mark Kavanagh
This patchset presents a preliminary look at DPDK v17.11 support for OvS-DPDK, and was generated against the following commits: - OvS: 1acb986 ("packets: Move declarations inside extern "C") - DPDK: 116ff44 ("crypto/dpaa_sec: rename mbuf physical address to IOVA") I'm particularly interested in c

[ovs-dev] [PATCH] netdev-tc-offloads: update stats properly on flow deletion

2017-11-07 Thread Paolo Abeni
Currently, when an offloaded DP flow is deleted, the related stats are unconditionally cleared. As a result the counters for the originating open flow are corrupted. This change addresses the issue updating the DP stats with the current values provided by the flower APIs before deleting the tc fil

[ovs-dev] [PATCH v2 2/2] NSH: Adjust NSH wire format to the latest IETF draft

2017-11-07 Thread Jan Scheurich
This commit adjusts the NSH user space implementation in OVS to the latest wire format defined in draft-ietf-sfc-nsh-28 (November 3 2017). The NSH_MDTYPE field was reduced from 8 to 4 bits. The FLAGS field is reduced from 8 to 2 bits. A new 6 bit TTL header field is added. The TTL field is set to 6

[ovs-dev] [PATCH v2 1/2] NSH: Minor bugfixes

2017-11-07 Thread Jan Scheurich
- Fix 2 incorrect length checks - Remove unnecessary limit of MD length to 16 bytes - Remove incorrect comments stating MD2 was not supported - Pad metadata in encap_nsh with zeroes if not multiple of 4 bytes Signed-off-by: Jan Scheurich --- datapath/linux/compat/include/linux/openvswitch.h | 6

[ovs-dev] [PATCH v2 0/2]: NSH: Align with latest IETF draft and fix some bugs

2017-11-07 Thread Jan Scheurich
This series adapts the userspace implementation for NSH in OVS to the wire-format specified in the latest NSH IETF draft and fixes a few minor bugs in the implementation. The corrections are minimal and primarily meant to be backported to branch-2.8. The NSH userspace support on master will be

[ovs-dev] [PATCH 2/2] ovs-appctl: Allow ovnnb_db and ovnsb_db as targets

2017-11-07 Thread nusiddiq
From: Numan Siddique ovn-ctl starts OVN DB servers with the options "--unixctl=ovnnb_db" and "--unixctl=ovnsb_db". When "ovs-appctl -t ovnnb_db" is run the below error is seen 2017-11-07T10:18:17Z|1|unixctl|WARN|failed to connect to /var/run/openvswitch/ovnnb_db.29536.ctl. This patch allows

[ovs-dev] [PATCH 1/2] ovn-ctl: Add -vfile:info option to OVN_NB/SB_LOG options

2017-11-07 Thread nusiddiq
From: Numan Siddique In the RHEL environment, when OVN db servers are started using ovn-ctl, log files are empty. Adding "-vfile:info" option to ovsdb-server is resolving this issue. Running 'ovs-apptctl -t .. vlog/reopen" results in the logs appearing in the log files. This issue is seen with 2.

[ovs-dev] [PATCH 0/2] OVN DB log fixes

2017-11-07 Thread nusiddiq
From: Numan Siddique In Openstack deployment with OVN HA (with v2.7.2) in RHEL, we see that OVN DB log files are empty after deployment. Adding "-vfile:info" option when starting ovsdb-servers fixes this issue. Another issue seen is when openvswitch logrotate script [1] is called, it doesn't init

Re: [ovs-dev] [PATCH] ovn: Add document describing new features in OVN added in version 2.8.

2017-11-07 Thread Mark Michelson
Hi Ben, it's a good looking document, and it pointed out some features I hadn't realized were present. Cool! I think the "Overview of OVN" section can be removed from this. It seems out of place in a document that is supposed to be talking about new features in a release of OVN. Presumably, if som

Re: [ovs-dev] [PATCH] ofproto: Delete all groups when (un)configuring a controller.

2017-11-07 Thread Jan Scheurich
Hi Ben, Do you think we should also delete any OpenFlow meters in this case? Regards, Jan > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 07 November, 2017 05:56 > To: d...@openvswitch.org >

Re: [ovs-dev] netdev-dpdk: add a command to dump vhost-user info.

2017-11-07 Thread Ilya Maximets
Thanks for the patch. One general comment: What do you think about exposing this information/part of this information via get_status() call for vhost netdevs like it done for physical ports? At least this will provide invariant way to check "numa_id" for any dpdk interface. Implementation comments

[ovs-dev] [PATCH v2 3/3] netdev-dpdk: Remove unused MAX_NB_MBUF.

2017-11-07 Thread Ilya Maximets
CC: Robert Wojciechowicz Fixes: d555d9bded5f ("netdev-dpdk: Create separate memory pool for each port.") Signed-off-by: Ilya Maximets Acked-by: Antonio Fischetti --- lib/netdev-dpdk.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib

[ovs-dev] [PATCH v2 2/3] netdev-dpdk: Factor out struct dpdk_mp.

2017-11-07 Thread Ilya Maximets
Since commit d555d9bded5f ("netdev-dpdk: Create separate memory pool for each port."), struct dpdk_mp is redundant because each mempool can be used by single port only and this port already contains all the information we store in dpdk_mp. There is no need to duplicate the information. Fields of th

[ovs-dev] [PATCH v2 1/3] netdev-dpdk: Fix dpdk_mp leak in case of EEXIST.

2017-11-07 Thread Ilya Maximets
CC: Robert Wojciechowicz CC: Antonio Fischetti Fixes: d555d9bded5f ("netdev-dpdk: Create separate memory pool for each port.") Fixes: b6b26021d2e2 ("netdev-dpdk: fix management of pre-existing mempools.") Signed-off-by: Ilya Maximets Acked-by: Antonio Fischetti --- lib/netdev-dpdk.c | 6 ++

[ovs-dev] [PATCH v2 0/3] netdev-dpdk: mempool management: Leaks & Refactoring.

2017-11-07 Thread Ilya Maximets
Fixed memory leak in mempool management code + a big clean up. First patch is simple fix for leaks while the second one simplifies the whole mempool management by removing redundant struct dpdk_mp. To be honest, patch #2 removes all the buggy conditions fixed in the first patch, but I think that

[ovs-dev] [PATCH 2/2] netdev-dpdk: Add comment about variables naming convention.

2017-11-07 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- lib/netdev-dpdk.c | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 872b133..9423109 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -330,6 +330,23 @@ enum dpdk_hw_ol_features { NETDEV

[ovs-dev] [PATCH 1/2] netdev-dpdk: Fix variables naming in set_admin_state function.

2017-11-07 Thread Ilya Maximets
Function 'netdev_dpdk_set_admin_state()' was missed while fixing variables naming according to the following convention: 'struct netdev':'netdev' 'struct netdev_dpdk':'dev' 'struct netdev_rxq':'rxq' 'struct netdev_rxq_dpdk':'rx' Fixes: d46285a2206f ("netdev-dpdk: Consistent variab

[ovs-dev] [PATCH 0/2] netdev-dpdk: Fix and document variables naming.

2017-11-07 Thread Ilya Maximets
Ilya Maximets (2): netdev-dpdk: Fix variables naming in set_admin_state function. netdev-dpdk: Add comment about variables naming convention. lib/netdev-dpdk.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) -- 2.7.4 _

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Yang, Yi
On Tue, Nov 07, 2017 at 05:01:28AM -0800, Pravin Shelar wrote: > On Tue, Nov 7, 2017 at 3:55 AM, Yang, Yi wrote: > > On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: > >> On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: > >> > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar w

[ovs-dev] [PATCH net-next v17] openvswitch: enable NSH support

2017-11-07 Thread Yi Yang
v16->17 - Fixed disputed check code: keep them in nsh_push and nsh_pop but also add them in __ovs_nla_copy_actions v15->v16 - Add csum recalculation for nsh_push, nsh_pop and set_nsh pointed out by Pravin - Move nsh key into the union with ipv4 and ipv6 and add check for nsh key in mat

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Pravin Shelar
On Tue, Nov 7, 2017 at 3:55 AM, Yang, Yi wrote: > On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: >> On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: >> > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: >> >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: >> >> > O

Re: [ovs-dev] [PATCH 1/8] netlink: provide network namespace id from a msg.

2017-11-07 Thread Flavio Leitner
On Fri, 3 Nov 2017 11:26:47 -0700 Ben Pfaff wrote: > On Thu, Nov 02, 2017 at 05:05:02PM -0200, Flavio Leitner wrote: > > The netlink notification's ancillary data contains the network > > namespace id (netnsid) needed to identify the device correctly. > > (ifindex and netnsid). > > > > Signed-of

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Yang, Yi
On Tue, Nov 07, 2017 at 03:58:35AM -0800, Pravin Shelar wrote: > On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: > > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: > >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > >> > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote:

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Pravin Shelar
On Tue, Nov 7, 2017 at 3:28 AM, Yang, Yi wrote: > On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: >> On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: >> > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: >> >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Yang, Yi
On Tue, Nov 07, 2017 at 06:57:30PM +0800, Pravin Shelar wrote: > On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: > >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) > >> > +{ > >> > + struct nshhdr *nh; > >> >

Re: [ovs-dev] [PATCH] netdev-dpdk: add a command to dump vhost-user info.

2017-11-07 Thread Raymond Burkholder
> > > > Add a command to dump vhost-user's information. > > > > > > > Thanks for the patch Flavio, I'll take a look in greater depth and test later > this week. On a first pass through though, I'd like to see the command being > added to the OVS DPDK vHost user how to also in documentation, just t

Re: [ovs-dev] [PATCH] netdev-dpdk: add a command to dump vhost-user info.

2017-11-07 Thread Flavio Leitner
On Mon, 6 Nov 2017 20:50:01 + "Stokes, Ian" wrote: > > Add a command to dump vhost-user's information. > > > > Thanks for the patch Flavio, I'll take a look in greater depth and test later > this week. On a first pass through though, I'd like to see the command being > added to the OVS

Re: [ovs-dev] [PATCH net-next v15] openvswitch: enable NSH support

2017-11-07 Thread Pravin Shelar
On Mon, Nov 6, 2017 at 4:22 AM, Jiri Benc wrote: > On Sat, 4 Nov 2017 07:29:46 -0700, Pravin Shelar wrote: >> > +int nsh_push(struct sk_buff *skb, const struct nshhdr *pushed_nh) >> > +{ >> > + struct nshhdr *nh; >> > + size_t length = nsh_hdr_len(pushed_nh); >> > + u8 next_proto

Re: [ovs-dev] [dpdk-users] adding dpdk ports sharing same pci address to ovs-dpdk bridge

2017-11-07 Thread Yuanhan Liu
On Tue, Oct 10, 2017 at 06:26:51PM +0530, devendra rawat wrote: > > Hi Everyone, > > > > Anything finalized for sorting out this issue, do you need any more > > information regarding this issue ? > > Hi, > > I put together a very rough RFC that aims to work-around the issu