Re: [ovs-dev] [PATCH v11 1/3] netdev: Add optional qfill output parameter to rxq_recv()

2018-04-12 Thread Jan Scheurich
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, 12 April, 2018 18:37 > > On Thu, Apr 12, 2018 at 05:32:11PM +0200, Jan Scheurich wrote: > > If the caller provides a non-NULL qfill pointer and the netdev > > implemementation supports reading the rx queue fill

Re: [ovs-dev] Imperative vs. Declarative abstraction at the SB DB

2018-04-12 Thread Ben Pfaff
On Thu, Apr 12, 2018 at 10:50:55PM +0300, Liran Schour wrote: > Ben Pfaff wrote on 06/04/2018 11:05:24 PM: > > On Fri, Mar 30, 2018 at 05:15:57AM +0200, Liran Schour wrote: > > > I wanted to raise a question that I came a cross. Maybe the community > > > already dealt with it. > >

Re: [ovs-dev] Imperative vs. Declarative abstraction at the SB DB

2018-04-12 Thread Liran Schour
Ben Pfaff wrote on 06/04/2018 11:05:24 PM: > On Fri, Mar 30, 2018 at 05:15:57AM +0200, Liran Schour wrote: > > I wanted to raise a question that I came a cross. Maybe the community > > already dealt with it. > > > > The ovn-northd translates the CMS's commands that resides in the

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-04-12 Thread Ben Pfaff
On Wed, Apr 11, 2018 at 11:29:28PM -0700, Han Zhou wrote: > On Tue, Apr 10, 2018 at 6:21 PM, Han Zhou wrote: > > > > > > > > On Tue, Apr 10, 2018 at 5:04 PM, Ben Pfaff wrote: > > > > > > On Fri, Apr 06, 2018 at 02:40:21PM -0700, Han Zhou wrote: > > > > On Fri,

Re: [ovs-dev] [PATCH v11 1/3] netdev: Add optional qfill output parameter to rxq_recv()

2018-04-12 Thread Ben Pfaff
On Thu, Apr 12, 2018 at 05:32:11PM +0200, Jan Scheurich wrote: > If the caller provides a non-NULL qfill pointer and the netdev > implemementation supports reading the rx queue fill level, the rxq_recv() > function returns the remaining number of packets in the rx queue after > reception of the

Re: [ovs-dev] [PATCH v10 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

2018-04-12 Thread Jan Scheurich
> > I would not say this is expected behavior. > > > > It seems that you are executing on a somewhat slower system (tsc clock > > seems to be 100/us = 0.1 GHz) and that, even with only 5 > lines logged before and after, the logging output is causing so much slow > down of the PMD that it

Re: [ovs-dev] [PATCH v2 1/2] netdev-dpdk: Free mempool only when no in-use mbufs.

2018-04-12 Thread Ilya Maximets
On 10.04.2018 21:12, Kevin Traynor wrote: > DPDK mempools are freed when they are no longer needed. > This can happen when a port is removed or a port's mtu > is reconfigured so that a new mempool is used. > > It is possible that an mbuf is attempted to be returned > to a freed mempool from NIC

[ovs-dev] [PATCH v11 0/3] dpif-netdev: Detailed PMD performance metrics and supervision

2018-04-12 Thread Jan Scheurich
The run-time performance of PMDs is often difficult to understand and trouble-shoot. The existing PMD statistics counters only provide a coarse grained average picture. At packet rates of several Mpps sporadic drops of packet bursts happen at sub-millisecond time scales and are impossible to

[ovs-dev] [PATCH v11 1/3] netdev: Add optional qfill output parameter to rxq_recv()

2018-04-12 Thread Jan Scheurich
If the caller provides a non-NULL qfill pointer and the netdev implemementation supports reading the rx queue fill level, the rxq_recv() function returns the remaining number of packets in the rx queue after reception of the packet burst to the caller. If the implementation does not support this,

[ovs-dev] [PATCH v11 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

2018-04-12 Thread Jan Scheurich
This patch enhances dpif-netdev-perf to detect iterations with suspicious statistics according to the following criteria: - iteration lasts longer than US_THR microseconds (default 250). This can be used to capture events where a PMD is blocked or interrupted for such a period of time that

[ovs-dev] [PATCH v11 2/3] dpif-netdev: Detailed performance stats for PMDs

2018-04-12 Thread Jan Scheurich
This patch instruments the dpif-netdev datapath to record detailed statistics of what is happening in every iteration of a PMD thread. The collection of detailed statistics can be controlled by a new Open_vSwitch configuration parameter "other_config:pmd-perf-metrics". By default it is disabled.

Re: [ovs-dev] Mempool issue for OVS 2.9

2018-04-12 Thread Ilya Maximets
On 11.04.2018 20:55, Kevin Traynor wrote: > On 04/10/2018 11:12 AM, Stokes, Ian wrote: > -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Monday, 29 January, 2018 09:35 > To: Jan Scheurich ; Venkatesan Pradeep

Re: [ovs-dev] [PATCH net-next 1/6] netdev-dpdk: Allow vswitchd to parse devargs as dpdk-bond args

2018-04-12 Thread Ilya Maximets
On 12.04.2018 17:18, Jan Scheurich wrote: >>> The bond of openvswitch has not good performance. >> >> Any examples? > > For example, balance-tcp bond mode for L34 load sharing still requires a > recirculation after dp_hash. dp_hash is lightweight action now since we're using rss hash for it.

Re: [ovs-dev] [PATCH net-next 1/6] netdev-dpdk: Allow vswitchd to parse devargs as dpdk-bond args

2018-04-12 Thread Tonghao Zhang
On Thu, Apr 12, 2018 at 10:18 PM, Jan Scheurich wrote: >> > The bond of openvswitch has not good performance. >> >> Any examples? > > For example, balance-tcp bond mode for L34 load sharing still requires a > recirculation after dp_hash. Yes, we need more bond modes

Re: [ovs-dev] [PATCH net-next 1/6] netdev-dpdk: Allow vswitchd to parse devargs as dpdk-bond args

2018-04-12 Thread Jan Scheurich
> > The bond of openvswitch has not good performance. > > Any examples? For example, balance-tcp bond mode for L34 load sharing still requires a recirculation after dp_hash. I believe that it would definitely be interesting to compare bond performance between DPDK bonding and OVS bonding with

Re: [ovs-dev] [PATCH net-next 0/6] Add dpdk-bond support

2018-04-12 Thread Jan Scheurich
Hi Tonghao, Thanks for working on this. That was on my backlog to try out for a while. One immediate feedback: This is a pure OVS user space patch. Please remove the "net-next" tag from your patches in the next version. "net-next" is reserved for OVS kernel module patches that are first

Re: [ovs-dev] [PATCH v8 2/6] dpif-netdev: retrieve flow directly from the flow mark

2018-04-12 Thread Stokes, Ian
> Tuesday, April 10, 2018 10:58 PM, Stokes, Ian: > > Subject: RE: [PATCH v8 2/6] dpif-netdev: retrieve flow directly from > > the flow mark > > > > > Subject: [PATCH v8 2/6] dpif-netdev: retrieve flow directly from the > > > flow mark > > > > > > From: Yuanhan Liu > > > > >

[ovs-dev] [PATCH net-next 1/6] netdev-dpdk: Allow vswitchd to parse devargs as dpdk-bond args

2018-04-12 Thread Ilya Maximets
> From: Tonghao Zhang > > The bond of openvswitch has not good performance. Any examples? > In some > cases we would recommend that you use Linux bonds instead > of Open vSwitch bonds. In userspace datapath, we wants use > bond to improve bandwidth. The DPDK has implemented it as lib. You

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: fix RX jumbo for NICs not supporting scatter

2018-04-12 Thread Stokes, Ian
> On 10/04/18 21:08, Stokes, Ian wrote: > >> Currently to RX jumbo packets fails for NICs not supporting scatter. > >> Scatter is not strictly needed for jumbo support on RX. This change > >> fixes the issue by only enabling scatter for NICs supporting it. > >> > >> Reported-by: Louis Peens

[ovs-dev] [PATCH v2] flow: Extend 5-tuple hash calculation for non-IP packets

2018-04-12 Thread Gabor Halász
In real-world vSwitch deployments, handling a few thousand flows, EMC is quickly saturated, so it's optimal usage is critical to reach the highest packet forwarding speed of the vSwitch. EMC lookup is initiated based on the hash value of the packet. In case the packet does not already have a

Re: [ovs-dev] [RFC] [PATCH] 1/1 Add multi-column index support for the Python IDL

2018-04-12 Thread Flavio Leitner
On Wed, Apr 11, 2018 at 03:54:24PM -0500, Terry Wilson wrote: > On Wed, Apr 11, 2018 at 12:52 PM, Flavio Leitner wrote: > > On Wed, Apr 11, 2018 at 07:23:07PM +0200, Timothy Redaelli wrote: > >> On Tue, 10 Apr 2018 15:20:54 -0700 > >> Ben Pfaff wrote: > >> > >> >

[ovs-dev] [PATCH net-next 6/6] netdev-dpdk: Add dpdk-bond mode setting

2018-04-12 Thread xiangxia . m . yue
From: Tonghao Zhang This patch allows users to set the dpdk-bond mode, such as round_robin, active_backup and balance and so on. ovs-vsctl add-port br0 dpdk0 -- \ set Interface dpdk0 type=dpdk \ options:dpdk-devargs=:06:00.0,:06:00.1

[ovs-dev] [PATCH net-next 5/6] netdev-dpdk: Add check whether dpdk-port is used

2018-04-12 Thread xiangxia . m . yue
From: Tonghao Zhang Extend the function, when looking up the dpdk netdev by port id, if the port id is a slave port id, return its master device. The patch changes the function 'netdev_dpdk_lookup_by_port_id'. Signed-off-by: Tonghao Zhang

[ovs-dev] [PATCH net-next 4/6] netdev-dpdk: Add dpdk-bond support

2018-04-12 Thread xiangxia . m . yue
From: Tonghao Zhang This patch implements, mostly the dpdk-bond support. vswitchd try to parse devargs as dpdk-bond device. If success, create a bond device and add slave ports to it. And the bond device id will be set to dev->port_id as a normal interface. * check

[ovs-dev] [PATCH net-next 3/6] netdev-dpdk: Add netdev_dpdk_bond struct

2018-04-12 Thread xiangxia . m . yue
From: Tonghao Zhang netdev_dpdk_bond struct will be a member in netdev_dpdk struct. and its init/uinit will be done in the common_construct/destruct. By default, the mode of bond device is active-backup mode. Signed-off-by: Tonghao Zhang ---

[ovs-dev] [PATCH net-next 2/6] netdev-dpdk: Allow dpdk-ethdev not support setting mtu

2018-04-12 Thread xiangxia . m . yue
From: Tonghao Zhang The bond device in dpdk-17.11 does not support setting mtu, but dpdk upstream supports it now. For more information, see: http://dpdk.org/browse/dpdk/commit/?id=55b58a7374554cd1c86f4a13a0e2f54e9ba6fe4d This patch allows to create bond devices which

[ovs-dev] [PATCH net-next 1/6] netdev-dpdk: Allow vswitchd to parse devargs as dpdk-bond args

2018-04-12 Thread xiangxia . m . yue
From: Tonghao Zhang If users set the interface options with multi-pci or device names with ',' as a separator, we try to parse it as dpdk-bond args. For example, set an interface as: ovs-vsctl add-port br0 dpdk0 -- \ set Interface dpdk0 type=dpdk \

[ovs-dev] [PATCH net-next 0/6] Add dpdk-bond support

2018-04-12 Thread xiangxia . m . yue
From: Tonghao Zhang The bond of openvswitch has not good performance. In some cases we would recommend that you use Linux bonds instead of Open vSwitch bonds. In userspace datapath, we wants use bond to improve bandwidth. The DPDK has implemented it as lib. These

[ovs-dev] Good News You are a Millionaire Respond To :lorealcharitei...@zoho.com

2018-04-12 Thread Charity Grant
Hello Sir/Madam your 7.4 million USD deposit from (L'Oréal) Philanthropic Grant respond to the details below Email::lorealcharitei...@zoho.com ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] netdev-dpdk: fix MAC address in port addr example

2018-04-12 Thread O Mahony, Billy
Hi Marcelo, Apologies. It wasn't clear that you had actually hands on experience of the issue. Regards, Billy. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of O Mahony, Billy > Sent: Wednesday, April 11, 2018 10:32

Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

2018-04-12 Thread Daniel Alvarez Sanchez
Acked-by: Daniel Alvarez Thanks Han! Everything LGTM and the tests pass okay against current master. On Thu, Apr 5, 2018 at 2:51 AM, Han Zhou wrote: > Address sets are automatically generated from corresponding port > groups, and can be used directly in

Re: [ovs-dev] [PATCH v2 1/1] netdev-vport: reject concomitant incompatible tunnels

2018-04-12 Thread Eelco Chaudron
Any feedback on this patch? On 09/02/18 15:42, Eelco Chaudron wrote: This patch will make sure VXLAN tunnels with and without the group based policy (GBP) option enabled can not coexist on the same destination UDP port. In theory, VXLAN tunnel with and without GBP enables can be multiplexed on

Re: [ovs-dev] [PATCH v2 1/2] ovn: Support port groups in ACLs

2018-04-12 Thread Daniel Alvarez Sanchez
Acked-by: Daniel Alvarez Thanks Han! Everything LGTM and the test pass okay against current master. On Thu, Apr 5, 2018 at 2:51 AM, Han Zhou wrote: > This patch enables using port group names in ACL match conditions. > Users can create a port group in

Re: [ovs-dev] [PATCH 3/3] rhel: add "force-reload-kmod" support in "ovs-systemd-reload"

2018-04-12 Thread Timothy Redaelli
On Wed, 11 Apr 2018 12:43:44 -0700 Guru Shetty wrote: > On 11 April 2018 at 11:03, Timothy Redaelli > wrote: > > > On Wed, 11 Apr 2018 10:05:53 -0700 > > Guru Shetty wrote: > > > > > On 22 December 2017 at 07:00, Timothy Redaelli > > >

Re: [ovs-dev] [ovs-dev 0/2] Add offloading of multiple outputs

2018-04-12 Thread Chris Mi
Hi Simon, > -Original Message- > From: Simon Horman [mailto:simon.hor...@netronome.com] > Sent: Thursday, April 12, 2018 5:13 PM > To: Chris Mi > Cc: d...@openvswitch.org; Roi Dayan ; Paul Blakey > > Subject: Re: [ovs-dev 0/2]

Re: [ovs-dev] [ovs-dev 0/2] Add offloading of multiple outputs

2018-04-12 Thread Simon Horman
On Tue, Apr 10, 2018 at 02:18:07PM +0900, Chris Mi wrote: > This patchset adds the offloading support of multiple outputs. > > The first patch makes the actions order consistent. In previous > implementation, the actions order is lost when offloading. If there > is only one output, there is on

Re: [ovs-dev] [Suspected-Phishing] [ovs-dev 0/2] Add offloading of multiple outputs

2018-04-12 Thread Chris Mi
On 4/12/2018 4:20 PM, Simon Horman wrote: On 12 April 2018 at 09:29, Chris Mi > wrote: A reminder. Thanks Chris, this is on my todo list. Thanks for your help, Simon. ___ dev mailing list

Re: [ovs-dev] [Suspected-Phishing] [ovs-dev 0/2] Add offloading of multiple outputs

2018-04-12 Thread Simon Horman
On 12 April 2018 at 09:29, Chris Mi wrote: > A reminder. > Thanks Chris, this is on my todo list. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v10 3/3] dpif-netdev: Detection and logging of suspicious PMD iterations

2018-04-12 Thread Ilya Maximets
On 11.04.2018 20:45, Jan Scheurich wrote: > Hi Ilya, > > I would not say this is expected behavior. > > It seems that you are executing on a somewhat slower system (tsc clock seems > to be 100/us = 0.1 GHz) and that, even with only 5 lines logged before and > after, the logging output is

Re: [ovs-dev] [Suspected-Phishing] [ovs-dev 0/2] Add offloading of multiple outputs

2018-04-12 Thread Chris Mi
A reminder. Thanks, Chris On 4/10/2018 1:18 PM, Chris Mi wrote: This patchset adds the offloading support of multiple outputs. The first patch makes the actions order consistent. In previous implementation, the actions order is lost when offloading. If there is only one output, there is on

Re: [ovs-dev] [PATCH 1/2] dpdk docs: Drop qemu-kvm for qemu-system-x86_64.

2018-04-12 Thread Lam, Tiago
On 11/04/2018 14:53, Aaron Conole wrote: Tiago Lam writes: When explaining on how to add vhost-user ports to a guest, using libvirt, point to the qemu-system-x86_64 binary by default, instead of using qemu-kvm. The latter has been made obsolete and dropped from a number

Re: [ovs-dev] [PATCH 2/2] dpdk docs: Drop file share in libvirt config.

2018-04-12 Thread Lam, Tiago
On 11/04/2018 15:03, Stephen Finucane wrote: On Wed, 2018-04-11 at 09:54 -0400, Aaron Conole wrote: Tiago Lam writes: When explaining on how to add vhost-user ports to a guest, using libvirt, the following piece of configuration is used:

Re: [ovs-dev] [PATCH v2] ovn: Avoid nb_cfg update notification flooding

2018-04-12 Thread Han Zhou
On Tue, Apr 10, 2018 at 6:21 PM, Han Zhou wrote: > > > > On Tue, Apr 10, 2018 at 5:04 PM, Ben Pfaff wrote: > > > > On Fri, Apr 06, 2018 at 02:40:21PM -0700, Han Zhou wrote: > > > On Fri, Apr 6, 2018 at 1:54 PM, Ben Pfaff wrote: > > > > > > > >

Re: [ovs-dev] [PATCH] Adding cli for displaying LACP counters

2018-04-12 Thread Nitin Katiyar
Hi Ben, Thanks for reviewing it. Will update the documentation and NEWS item soon. Regards, Nitin -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Sunday, April 01, 2018 6:06 AM To: Nitin Katiyar Cc: d...@openvswitch.org Subject: Re: [ovs-dev]