Thanks a lot Han for the review. Just sent the v2 with the test fixed.
I'll leave the hash index for a follow up as I'm short in time but if
you want to edit my patch feel free to do it or send another one.
Thanks again for the Port Groups implementation! :)
Cheers,
Daniel
On Wed, Jun 20, 2018
When using Port Groups, the pre ACLs were not applied so the
conntrack action was not performed. This patch takes Port Groups
into account when processing the pre ACLs.
As a follow up, we could enhance this patch by creating an index
from lswitch to port groups.
Signed-off-by: Daniel Alvarez
On Tue, Jun 19, 2018 at 5:49 PM, Ben Pfaff wrote:
>
> On Tue, Jun 19, 2018 at 05:27:20PM -0700, Han Zhou wrote:
> > All looks good to me except that the test case "ovn -- ACLs on Port
Groups"
> > is broken with this change. I think it is because conntrack is not
> > supported in the dummy
On Tue, Jun 19, 2018 at 05:27:20PM -0700, Han Zhou wrote:
> All looks good to me except that the test case "ovn -- ACLs on Port Groups"
> is broken with this change. I think it is because conntrack is not
> supported in the dummy datapath and so the stateful ACL would not work in
> the test
On Tue, Jun 19, 2018 at 5:27 PM, Han Zhou wrote:
>
>
>
> On Tue, Jun 19, 2018 at 3:46 PM, Daniel Alvarez
wrote:
> >
> > When using Port Groups, the pre ACLs were not applied so the
> > conntrack action was not performed. This patch takes Port Groups
> > into account when processing the pre ACLs.
On Tue, Jun 19, 2018 at 3:46 PM, Daniel Alvarez wrote:
>
> When using Port Groups, the pre ACLs were not applied so the
> conntrack action was not performed. This patch takes Port Groups
> into account when processing the pre ACLs.
>
> Signed-off-by: Daniel Alvarez
> ---
>
From: Andy Zhou
Upstream commit:
commit cd8a6c33693c1b89d2737ffdbf9611564e9ac907
Author: Andy Zhou
Date: Fri Nov 10 12:09:43 2017 -0800
openvswitch: Add meter action support
Implements OVS kernel meter action support.
Signed-off-by: Andy Zhou
Signed-off-by:
Hi Shahaf,
Thanks for setting up VXLAN env. and trying to reproduce, appreciate!!
As you suggested, I moved to DPDK17.11.3 stable and OvS 2.9.0, still observed
same issue.
An attached Vxlan_diagram.jpg, to get clear idea, we are seeing issue while
traffic injected from Traffic
When using Port Groups, the pre ACLs were not applied so the
conntrack action was not performed. This patch takes Port Groups
into account when processing the pre ACLs.
Signed-off-by: Daniel Alvarez
---
ovn/northd/ovn-northd.c | 100 +++-
1 file
Hi Ilya,
This issue is a release blocker for us, just wanted to check check if you
need more details from us? Anything to expedite or root cause the problem
we can help
Please let us know
Thanks Shahaji
On Mon, Jun 18, 2018 at 10:20 AM Shahaji Bhosle
wrote:
> Thanks Ilya, I will look at the
Greetings list,
I've set up a robot that pulls series information from patchwork, and
runs a jenkins task that does a few basic sanity checks on the patch,
and emails the mailing list if it detects things are incorrect.
The robot will send from ro...@bytheb.org for now (unless someone wants
to
On Tue, Jun 19, 2018 at 05:20:08PM -0400, 0-day Robot wrote:
> Bleep bloop. Greetings Vishal Deep Ajmera, I am a robot and I have tried out
> your patch
> with message ID
> <1529202111-20855-1-git-send-email-vishal.deep.ajm...@ericsson.com>
> Thanks for your contribution.
Watch out. It's a
0-day Robot writes:
> Bleep bloop. Greetings Vishal Deep Ajmera, I am a robot and I have tried out
> your patch
> with message ID
> <1529202111-20855-1-git-send-email-vishal.deep.ajm...@ericsson.com>
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See
Bleep bloop. Greetings Vishal Deep Ajmera, I am a robot and I have tried out
your patch
with message ID
<1529202111-20855-1-git-send-email-vishal.deep.ajm...@ericsson.com>
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
==
Signed-off-by: Justin Pettit
---
datapath/vport-internal_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c
index 3fa86815c7fa..629965eab19f 100644
--- a/datapath/vport-internal_dev.c
+++
On Tue, Jun 19, 2018 at 11:51:00AM -0700, Cpp Code wrote:
> Do we need licensing information in these sample files?
>
> On Mon, Jun 18, 2018 at 8:53 PM, Ben Pfaff wrote:
>
> > On Sun, Jun 17, 2018 at 04:24:34AM -0700, Toms Atteka wrote:
> > > created sample python scripts, which helps to learn
Hi,
On Tue, Jun 19, 2018 at 12:27 AM Ilya Maximets
wrote:
> Hi,
> According to your log, your NIC has limited size of tx queues:
>
> 2018-06-19T04:34:46.106Z|00089|dpdk|ERR|PMD: Unsupported size of TX queue
>(max size: 1024)
>
> This means that
Do we need licensing information in these sample files?
On Mon, Jun 18, 2018 at 8:53 PM, Ben Pfaff wrote:
> On Sun, Jun 17, 2018 at 04:24:34AM -0700, Toms Atteka wrote:
> > created sample python scripts, which helps to learn how to use OVSDB
> library
> >
> > Signed-off-by: Toms Atteka
>
>
Hello There,
Those who say it can not be done, should not interrupt those doing it. Am sorry
for encroaching your privacy, I have a mammoth business proposal which you
might be interested. Kindly reply to sarah.orengo...@gmail.com for more info...
Sincerely,
Sarah Orengo
Hi Alin,
Thanks for running the code analysis on the patch series.
As discussed in the Hyper-V meeting, I have addressed them and send out a v4 of
my patch series.
Thanks,
Anand Kumar
On 6/19/18, 9:14 AM, "Alin Serdean" wrote:
Thanks a lot for the series and the benchmarks .
Conntrack 5-tuple consists of src address, dst address, src port,
dst port and protocol which will be unique to a ct session.
Use this information along with zone to compute hash.
Also re-factor conntrack code related to parsing netlink attributes.
Testing:
Verified loading/unloading the driver
This patch primarily replaces existing ndis RWlock based implementaion
for NAT in conntrack with a spinlock based implementation inside NAT,
module along with some conntrack optimization.
- The 'ovsNatTable' and 'ovsUnNatTable' tables are shared
between cleanup threads and packet processing
This patch mainly changes a ndis RW lock for conntrack entry to a
spinlock along with some minor refactor in conntrack. Using
spinlock instead of RW lock as RW locks causes performance hits
when acquired/released multiple times.
- Use NdisInterlockedXX wrapper api's instead of InterlockedXX.
-
This patch series is primarily to refactor conntrack code for
better throughput with conntrack.
With this patch series TCP throughput with conntrack increased
by ~50%.
Anand Kumar (3):
datapath-windows: Use spinlock instead of RW lock for ct entry
datapath-windows: Implement locking in
On Mon, Jun 18, 2018 at 11:31:03PM +0200, Thomas Goirand wrote:
> On 06/18/2018 09:56 PM, Ben Pfaff wrote:
> > Hi Thomas. Thanks for the latest upload of the Open vSwitch packages to
> > Debian.
> >
> > I'm no longer interested in being a maintainer for the downstream Debian
> > packages of Open
Thanks a lot for the series and the benchmarks .
This is not an actual review. I applied the patches and ran the code analysis
and I get the following:
ovs\datapath-windows\ovsext\conntrack-nat.c(151): warning C28167: The function
'OvsNatCleanup' changes the IRQL and does not restore the IRQL
On Tue, Jun 19, 2018 at 10:58:36AM +0300, Ilya Maximets wrote:
> On 18.06.2018 22:24, Ben Pfaff wrote:
> > On Mon, Jun 18, 2018 at 06:34:13PM +0300, Ilya Maximets wrote:
> >> On 18.06.2018 18:07, Ben Pfaff wrote:
> >>> On Mon, Jun 18, 2018 at 05:18:49PM +0300, Ilya Maximets wrote:
> > On Wed,
Thanks guys for the review! Have sent revised one @
https://patchwork.ozlabs.org/patch/931665/ . Please review and let me know.
Regards,
On Tue, Jun 19, 2018 at 3:35 AM, Numan Siddique wrote:
> On Tue, Jun 19, 2018 at 6:14 AM, Han Zhou wrote:
>
> >
> >
> > On Fri, Jun 8, 2018 at 12:32 PM,
load balancer to manage ovndb clusters via pacemaker.
This is will allow setting inactivity probe on the master node.
For pacemaker to manage ovndb resources via LB, we skipped creating connection
table and hence the inactivity probe was getting set to 5000 by default.
In order to over-ride it we
Brauchen Sie einen Investor?
Benötigen Sie geschäftliche oder private Kredite?
Wir geben Darlehen an jeden einzelnen und Unternehmen mit 3% Zinssatz
jährlich. Für weitere Informationen, kontaktieren Sie uns per e-Mail Dank ich
hoffe,
von Ihnen zu hören
On 06/19/2018 12:16 PM, Kevin Traynor wrote:
> On 06/19/2018 12:11 PM, Kevin Traynor wrote:
>>> +if (per_port_mp && rte_errno == EEXIST) {
>>> +LIST_FOR_EACH (next, list_node, _mp_list) {
>>> +if (dmp->mp == next->mp) {
>>> +
On 06/19/2018 12:11 PM, Kevin Traynor wrote:
>> +if (per_port_mp && rte_errno == EEXIST) {
>> +LIST_FOR_EACH (next, list_node, _mp_list) {
>> +if (dmp->mp == next->mp) {
>> +rte_free(dmp);
>> +dmp =
On 06/11/2018 05:37 PM, Ian Stokes wrote:
> This commit re-introduces the concept of shared mempools as the default
> memory model for DPDK devices. Per port mempools are still available but
> must be enabled explicitly by a user.
>
Hi Ian, thanks for v2, comments below
> OVS previously used a
Dear Team,
1 . How ovs has implemented the Queue mechanism in Kernel mode ?
2 . Which part of the code is or module is dealing withe Ingress and
Outgress Ports ?
3. How does Open Flow table differs with Filtering database used in IEEE
802.1Q ?
List Please give your views for the above query's
On Tue, Jun 19, 2018 at 6:14 AM, Han Zhou wrote:
>
>
> On Fri, Jun 8, 2018 at 12:32 PM, aginwala wrote:
> >
> > so that we can adjust inactivity_probe for master node, while still not
> > listening on TCP on slave node using use_remote_in_db in ovn-ctl.
> >
>
> Minor comment: the commit message
> I looked into the code and the logic seems good to me.
> But reordering in dataplane also has performance implications especially
> considering non-TCP traffic. Also, the packets came to OvS may already been
> out-of-ordered. Could you provide some performance data points showing when
>
On 18.06.2018 22:24, Ben Pfaff wrote:
> On Mon, Jun 18, 2018 at 06:34:13PM +0300, Ilya Maximets wrote:
>> On 18.06.2018 18:07, Ben Pfaff wrote:
>>> On Mon, Jun 18, 2018 at 05:18:49PM +0300, Ilya Maximets wrote:
> On Wed, May 23, 2018 at 09:28:59PM -0700, Ben Pfaff wrote:
>> On Wed, May 23,
On 18.06.2018 22:25, Ben Pfaff wrote:
> On Mon, Jun 18, 2018 at 09:31:43AM -0700, Han Zhou wrote:
>> On Mon, Jun 18, 2018 at 8:34 AM, Ilya Maximets
>> wrote:
>>>
>>> On 18.06.2018 18:07, Ben Pfaff wrote:
On Mon, Jun 18, 2018 at 05:18:49PM +0300, Ilya Maximets wrote:
>> On Wed, May 23,
Hi,
According to your log, your NIC has limited size of tx queues:
2018-06-19T04:34:46.106Z|00089|dpdk|ERR|PMD: Unsupported size of TX queue
(max size: 1024)
This means that you have to configure 'n_txq_desc' <= 1024 in order to
configure your NIC
Conntrack 5-tuple consists of src address, dst address, src port,
dst port and protocol which will be unique to a ct session.
Use this information along with zone to compute hash.
Also re-factor conntrack code related to parsing netlink attributes.
Testing:
Verified loading/unloading the driver
This patch primarily replaces existing ndis RWlock based implementaion
for NAT in conntrack with a spinlock based implementation inside NAT,
module along with some conntrack optimization.
- The 'ovsNatTable' and 'ovsUnNatTable' tables are shared
between cleanup threads and packet processing
This patch series is primarily to refactor conntrack code for
better throughput with conntrack.
With this patch series TCP throughput with conntrack increased
by ~50%.
Anand Kumar (3):
datapath-windows: Use spinlock instead of RW lock for ct entry
datapath-windows: Implement locking in
This patch mainly changes a ndis RW lock for conntrack entry to a
spinlock along with some minor refactor in conntrack. Using
spinlock instead of RW lock as RW locks causes performance hits
when acquired/released multiple times.
- Use NdisInterlockedXX wrapper api's instead of InterlockedXX.
-
Hi Ilya,
Thanx for taking a look. Please see inline.
Thanx
Manu
On 18/06/18, 4:04 PM, "Ilya Maximets" wrote:
> Hi
Hi,
I just wanted to clarify few things about RSS hash. See inline.
One more thing:
Despite of usual OVS bonding, this implementation doesn't
44 matches
Mail list logo
