On Mon, Jul 02, 2018 at 12:49:56PM +0200, Jakub Sitnicki wrote:
> This patch series is preparatory work for turning any of the tools from db-ctl
> family (ovs-vsctl, vtep-ctl, ovn-nbctl, or ovn-sbctl) into a long-lived
> server/daemon that processes database commands on client request.
>
> The
On Mon, Jul 02, 2018 at 12:57:47PM +0200, Jakub Sitnicki wrote:
> Also, error propagation forces us to to free up any resources that previously
> went unreleased because we were terminating the process. This could be
> avoided
> with help of the compiler and the __attribute__((cleanup))
Thanks! I will improve the patch based on the suggestions and will post it soon.
-Qiuyu
On Tue, Jul 3, 2018 at 1:00 PM, Ben Pfaff wrote:
> On Wed, Jun 27, 2018 at 10:58:42AM -0700, Qiuyu Xiao wrote:
>> From: Ansis Atteka
>>
>> This patch reintroduces ovs-monitor-ipsec daemon that
>> was
Thanks for the review! I will on adding this documentation soon.
-Qiuyu
On Tue, Jul 3, 2018 at 1:13 PM, Ben Pfaff wrote:
> On Mon, Jul 02, 2018 at 02:50:04PM -0700, Qiuyu Xiao wrote:
>> This patch adds IPsec support for OVN tunnel. Basically, OVN offers a
>> binary option to its user for
On Mon, Jul 02, 2018 at 02:50:04PM -0700, Qiuyu Xiao wrote:
> This patch adds IPsec support for OVN tunnel. Basically, OVN offers a
> binary option to its user for encryption configuration. If the IPsec
> option is turned on, all tunnels will be encrypted. Otherwise, no tunnel
> will be encrypted.
On Wed, Jun 27, 2018 at 10:58:44AM -0700, Qiuyu Xiao wrote:
> This patch modifies ovs-pki to generate x.509 version 3 certificate.
> Compared with the x.509 v1 certificate generated by ovs-pki, version 3
> certificate adds subjectAltName field and sets its value the same as
> common name (CN). The
On Wed, Jun 27, 2018 at 10:58:42AM -0700, Qiuyu Xiao wrote:
> From: Ansis Atteka
>
> This patch reintroduces ovs-monitor-ipsec daemon that
> was previously removed by commit 2b02d770 ("openvswitch:
> Allow external IPsec tunnel management.")
>
> The reason for removal at the time was that there
Ben Pfaff writes:
> On Wed, Jun 27, 2018 at 04:00:00PM -0400, Aaron Conole wrote:
>> Thanks for the patch. It's really cool to see IPSec being
>> re-integrated. Just a few quick comments inline.
>>
>> Qiuyu Xiao writes:
>>
>> > From: Ansis Atteka
>> >
>> > This patch reintroduces
On Wed, Jun 27, 2018 at 04:00:00PM -0400, Aaron Conole wrote:
> Thanks for the patch. It's really cool to see IPSec being
> re-integrated. Just a few quick comments inline.
>
> Qiuyu Xiao writes:
>
> > From: Ansis Atteka
> >
> > This patch reintroduces ovs-monitor-ipsec daemon that
> > was
On Wed, Jun 27, 2018 at 08:40:04PM -0400, Aaron Conole wrote:
> The separator line always starts with three dashes on a line, optionally
> followed by either white-space, OR a single space and a filename. The
> regex would previously match on any three dashes in a row. This means
> that a patch
On Tue, Jul 03, 2018 at 11:14:45PM +0530, Keshav Gupta wrote:
> Currently in OvS if we hit "Table-miss" rules (associated with Controller
> action) then we send PACKET_IN message to controller with reason as
> OFPR_NO_MATCH.
>
> “Table-miss” rule is one whose priority is 0 and its catch all rule.
check_logs ignores some log messages, but it wasn't smart enough to ignore
the messages that said that the ignored messages had been rate-limited.
This fixes the problem.
It's OK to ignore all rate-limiting messages because they only appear if at
least one message was not rate-limited, which
Thank you for the response.
I will try to build with dpdk-26.11.
Original Message
Subject: Re: [EXTERNAL] Re: [ovs-dev] openvswitch-2.7.6 with dpdk build failing
in Centos 7
From: Ben Pfaff
Date: 3 Jul 2018, 23:12
To: "Maheshwari, Shagun"
Then that's the problem. OVS 2.7.x
Then that's the problem. OVS 2.7.x only works with DPDK 16.11, as
documented.
On Tue, Jul 03, 2018 at 04:43:44PM +, Maheshwari, Shagun wrote:
> No, I m using dpdk-17.11.
>
>
> Original Message
> Subject: [EXTERNAL] Re: [ovs-dev] openvswitch-2.7.6 with dpdk build failing
No, I m using dpdk-17.11.
Original Message
Subject: [EXTERNAL] Re: [ovs-dev] openvswitch-2.7.6 with dpdk build failing in
Centos 7
From: Ben Pfaff
Date: 3 Jul 2018, 21:31
To: "Veetil, Vyshnav"
On Tue, Jul 03, 2018 at 10:48:35AM +, Veetil, Vyshnav wrote:
> While building
On 6/17/2018 3:21 AM, Vishal Deep Ajmera wrote:
OVS reads packets in batches from a given port and packets in the
batch are subjected to potentially 3 levels of lookups to identify
the datapath megaflow entry (or flow) associated with the packet.
Each megaflow entry has a dedicated buffer in
On Tue, Jul 03, 2018 at 10:48:35AM +, Veetil, Vyshnav wrote:
> While building openvswitch-2.7.6 with dpdk in Centos 7, I was getting below
> errors.
> So can you please give a solution for this.
Did you use DPDK 16.11?
___
dev mailing list
On Mon, Jun 25, 2018 at 09:18:54AM +, Manohar Krishnappa Chidambaraswamy
wrote:
> Hi Ben,
>
> Does this patch apply without issues?
>
> Would you be able to look at 2/2 of this series as well?
The series is confusing. In v1, both patches had the same title. In
v2, there is only one
On Mon, Jun 18, 2018 at 08:32:23AM +, Manohar Krishnappa Chidambaraswamy
wrote:
> Ben,
>
> Here are the v2 diffs. Hope this applies without any issue.
>
> Thanx
> Manu
Doesn't apply:
Applying: Fix packet drops on LACP bond after link up
error: patch failed: lib/lacp.c:154
error:
On Tue, Jul 03, 2018 at 10:33:13AM +, Veetil, Vyshnav wrote:
> Can you please share the steps to build the openvswitch-2.7.6 package with
> dpdk in Centos7.
Read Documentation/intro/install/dpdk.rst.
___
dev mailing list
d...@openvswitch.org
Anyone got any time to review this patch?
Thanks!
On Mon, 25 Jun 2018 at 11:19, Manohar Krishnappa Chidambaraswamy <
manohar.krishnappa.chidambarasw...@ericsson.com> wrote:
> Hi Ben,
>
> Does this patch apply without issues?
>
> Would you be able to look at 2/2 of this series as well?
>
> Thanx
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
> The following tests are added to the DPDK testsuite to add some
> coverage for the multi-segment mbufs:
> - Check that multi-segment mbufs are disabled by default;
> - Check that providing `other_config:dpdk-multi-seg-mbufs=true` indeed
> enables
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
> As it stands, OVS_DPDK_START() won't allow other configs to be set
> before starting the ovs-vswitchd daemon. This is a problem since some
> configs, such as the "dpdk-multi-seg-mbufs=true" for enabling the
> multi-segment mbufs, need to be set
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
> In order to create a minimal environment that allows the tests to get
> mbufs from an existing mempool, the following approach is taken:
> - EAL is initialised (by using the main dpdk_init()) and a (very) small
> mempool is instantiated (mimicking
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
> From: Mark Kavanagh
>
> Currently, jumbo frame support for OvS-DPDK is implemented by
> increasing the size of mbufs within a mempool, such that each mbuf
> within the pool is large enough to contain an entire jumbo frame of
> a user-defined size.
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
> From: Mark Kavanagh
>
> Currently, packets are only copied to a single segment in the function
> dpdk_do_tx_copy(). This could be an issue in the case of jumbo frames,
> particularly when multi-segment mbufs are involved.
>
> This patch calculates
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
> From: Michael Qiu
>
> When doing packet clone, if packet source is from DPDK driver,
> multi-segment must be considered, and copy the segment's data one by
> one.
>
> Also, lots of DPDK mbuf's info is missed during a copy, like packet
> type,
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
> When enabled with DPDK OvS relies on mbufs allocated by mempools to
> receive and output data on DPDK ports. Until now, each OvS dp_packet has
> had only one mbuf associated, which is allocated with the maximum
> possible size, taking the MTU into
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
> In its current implementation dp_packet_shift() is also unaware of
> multi-seg mbufs (that holds data in memory non-contiguously) and assumes
> that data exists contiguously in memory, memmove'ing data to perform the
> shift.
>
> To add support for
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
> Most helper functions in dp-packet assume that the data held by a
> dp_packet is contiguous, and perform operations such as pointer
> arithmetic under that assumption. However, with the introduction of
> multi-segment mbufs, where data is
Hi ,
While building openvswitch-2.7.6 with dpdk in Centos 7, I was getting below
errors.
So can you please give a solution for this.
Error logs:
---
lib/netdev-dpdk.c:34:28: fatal error:
Hi ,
Can you please share the steps to build the openvswitch-2.7.6 package with dpdk
in Centos7.
Regards,
Vyshnav
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks Nitin.
Hi Ilya,
Looks like regression was in 2.8.x itself as per Nitin's email. We will
update our results as well. Thanks, Shahaji
On Tue, Jul 3, 2018 at 12:29 AM, Nitin Katiyar
wrote:
> Hi,
> I had tested 2.8.1/2 earlier which uses 17.05.01 or 17.05.02 and found
> around 10% drop for
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
When a dp_packet is from a DPDK source, and it contains multi-segment
mbufs, the data_len is not equal to the packet size, pkt_len. Instead,
the data_len of each mbuf in the chain should be considered while
distributing the new (provided) size.
To
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise
allocation and free operations by non-pmd threads on a given mempool.
free_dpdk_buf() has been modified to make use of the introduced mutex.
Signed-off-by: Tiago Lam
---
Currently in OvS if we hit "Table-miss" rules (associated with Controller
action) then we send PACKET_IN message to controller with reason as
OFPR_NO_MATCH.
“Table-miss” rule is one whose priority is 0 and its catch all rule.
But if we hit same "Table-miss" rule after executing group entry we
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
> From: Mark Kavanagh
>
> dp_packets are created using xmalloc(); in the case of OvS-DPDK, it's
> possible the the resultant mbuf portion of the dp_packet contains
> random data. For some mbuf fields, specifically those related to
> multi-segment
On 28 Jun 2018, at 17:41, Tiago Lam wrote:
> From: Mark Kavanagh
>
> There are numerous factors that must be considered when calculating
> the size of an mbuf:
> - the data portion of the mbuf must be sized in accordance With Rx
> buffer alignment (typically 1024B). So, for example, in order
On Mon, 2 Jul 2018 10:44:17 -0400
Mark Michelson wrote:
> I'm not sure why you went with a different approach on this compared to
> the other functions. I would have expected you would change
> get_row_by_id() to return a string (NULL if no error, otherwise an error
> string). Then return the
On 7/2/2018 8:29 PM, Flavio Leitner wrote:
On Wed, Jun 20, 2018 at 10:39:46AM +0100, Ian Stokes wrote:
Modify travis linux build script to use the latest
DPDK stable release 17.11.3. Update docs for latest
DPDK stable releases.
Signed-off-by: Ian Stokes
---
.travis/linux-build.sh
Hi Mark,
Thanks for starting the review.
On Mon, 2 Jul 2018 10:55:01 -0400
Mark Michelson wrote:
> Your cover letter still hasn't come through, so feel free to tell me if
> my comments here are misguided.
Looks like the cover letter has arrived now.
> I'm guessing that you did not remove
Bleep bloop. Greetings Keshav Gupta, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Too many signoffs; are you missing Co-authored-by lines?
WARNING: Line is 84 characters
Currently in OvS if we hit "Table-miss" rules (associated with Controller
action) then we send PACKET_IN message to controller with reason as
OFPR_NO_MATCH.
“Table-miss” rule is one whose priority is 0 and its catch all rule.
But if we hit same "Table-miss" rule after executing group entry we
43 matches
Mail list logo
