Re: [ovs-dev] [ovs-dev, v1] utilities: check datapath exists before conntrack flush

Bleep bloop. Greetings Martin Xu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: depbase=`echo ovn/controller/lflow.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\ gcc -std=gnu99

Re: [ovs-dev] [PATCH] ofproto: Return error codes for Rule insertions

> Currently, rule_insert() API does not have return value. There are some possible > scenarios where rule insertions can fail at run-time even though the static > checks during rule_construct() had passed previously. > Some possible scenarios for failure of rule insertions: > **) Rule insertions

[ovs-dev] [PATCH v1] utilities: check datapath exists before conntrack flush

As part of "force-reload-kmod," conntrack flush command is issued as 'action "ovs-appctl dpctl/flush-conntrack"'. In case no datapath exists yet when issuing "force-reload-kmod," there is an error message "ovs-vswitchd: no datapaths exist\ ovs-appctl: ovs-vswitchd: server returned an error", which

Re: [ovs-dev] [ACL Meters 4/7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

> On Jul 30, 2018, at 11:40 AM, Mark Michelson wrote: > > Hi Justin, > > I took a look through the patch series, and this is the only one that I had > some immediate feedback on. > > First, it would be nice if we could refer to Meters by name when issuing DB > commands. For instance

Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

> On Jul 30, 2018, at 12:55 PM, Ben Pfaff wrote: > > On Sun, Jul 29, 2018 at 11:46:38PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Besides the comments I gave on patch 6 (oops), I suggest the following > for more consistent formatting: > > diff --git a/ovn/lib/actions.c

Re: [ovs-dev] [ACL Meters 6/7] ofproto: Add support for specifying a meter in controller actions.

> On Jul 30, 2018, at 12:49 PM, Ben Pfaff wrote: > > On Sun, Jul 29, 2018 at 11:46:37PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > In ofproto_check_ofpacts(), the other checks, if they fail, return an > error and prevent the flow from being added. The new one doesn't;

Re: [ovs-dev] [PATCH v1] rhel: bug fix kmod-openvswitch spec file, rhel6

Thanks, Ben! On Mon, Jul 30, 2018 at 4:17 PM, Ben Pfaff wrote: > OK, I spent some time staring at 89dd5819cf18 and finally got it. I > applied this to master and branch-2.10. I added an appropriate Fixes > tag to the commit. > > On Mon, Jul 30, 2018 at 01:34:19PM -0700, Martin Xu wrote: > >

Re: [ovs-dev] [PATCH v1] rhel: bug fix kmod-openvswitch spec file, rhel6

OK, I spent some time staring at 89dd5819cf18 and finally got it. I applied this to master and branch-2.10. I added an appropriate Fixes tag to the commit. On Mon, Jul 30, 2018 at 01:34:19PM -0700, Martin Xu wrote: > Hi Ben, > > I meant to say the previously merged patch. It was 89dd5819cf18

Re: [ovs-dev] [ACL Meters 5/7] ovn: Support configuring meters through SB Meter table.

> On Jul 30, 2018, at 11:44 AM, Ben Pfaff wrote: > > On Sun, Jul 29, 2018 at 11:46:36PM -0700, Justin Pettit wrote: >> Add the ability to configure meters through the newly introduced Meter >> table in the Southbound database. Previously, meters were configured by >> providing strings to

Re: [ovs-dev] [ACL Meters 4/7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

> On Jul 30, 2018, at 11:26 AM, Ben Pfaff wrote: > > On Sun, Jul 29, 2018 at 11:46:35PM -0700, Justin Pettit wrote: >> Add support for configuring meters through the Meter and Meter_Band >> tables in the Northbound database. This commit also has ovn-northd >> sync those tables between the

[ovs-dev] Project Management

Dirigir y gestionar la ejecución del proyecto Project Management - Agosto 09 Introducción: Este curso va dirigido a todo profesional que participe en el desarrollo de proyectos, donde es requerido homologar criterios, métodos y herramientas para el debido establecimiento del plan de

Re: [ovs-dev] [ACL Meters 3/7] ovn-controller: Add "group-table-list" ovs-appctl command.

On Mon, Jul 30, 2018 at 01:09:12PM -0700, Justin Pettit wrote: > > > On Jul 30, 2018, at 10:43 AM, Ben Pfaff wrote: > > > > On Sun, Jul 29, 2018 at 11:46:34PM -0700, Justin Pettit wrote: > >> Signed-off-by: Justin Pettit > > > > Thanks for the patches! > > > > I think that group_table_list()

Re: [ovs-dev] [PATCH v1] rhel: bug fix kmod-openvswitch spec file, rhel6

Hi Ben, I meant to say the previously merged patch. It was 89dd5819cf18 (rhel: support kmod-openvswitch build against multiple kernels, rhel6). This patch is meant to fix a bug introduced by 89dd5819cf18. Martin On Mon, Jul 30, 2018 at 1:28 PM, Ben Pfaff wrote: > On Sun, Jul 29, 2018 at

Re: [ovs-dev] [PATCH v1] rhel: bug fix kmod-openvswitch spec file, rhel6

On Sun, Jul 29, 2018 at 12:02:57AM -0700, Martin Xu wrote: > Previous patch removed the if condition for postun script by > mistake. The weak-update symlinks should be removed only for > uninstallation not upgrade. > > VMware-BZ: #2169383 > > Signed-off-by: Martin Xu > CC: Greg Rose > CC: Ben

Re: [ovs-dev] [PATCH] debian: Add ovn-detrace to ovn-common package.

Thanks Han (and aginwala). Applied to master. On Mon, Jul 30, 2018 at 11:38:49AM -0700, aginwala wrote: > Thanks for adding this. > > Acked-by: aginwala > > On Sun, Jul 29, 2018 at 4:27 PM Han Zhou wrote: > > > Signed-off-by: Han Zhou > > --- > > debian/ovn-common.install | 1 + > >

Re: [ovs-dev] [ACL Meters 3/7] ovn-controller: Add "group-table-list" ovs-appctl command.

> On Jul 30, 2018, at 10:43 AM, Ben Pfaff wrote: > > On Sun, Jul 29, 2018 at 11:46:34PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Thanks for the patches! > > I think that group_table_list() is very similar or identical to > meter_table_list() in the previous patch. Is

Re: [ovs-dev] [PATCHv2 2/2] dpif-netlink: Add meter support.

> On Jul 30, 2018, at 12:59 PM, Ben Pfaff wrote: > > On Fri, Jul 27, 2018 at 02:19:13PM -0700, Justin Pettit wrote: >> From: Andy Zhou >> >> To work with kernel datapath that supports meter. >> >> Signed-off-by: Andy Zhou >> Co-authored-by: Justin Pettit >> Signed-off-by: Justin Pettit

[ovs-dev] MPLS performance question

I recently tried pushing MPLS labels using OVS in a lab. Before adding MPLS push to the mix, I had four hosts: two pairs, each connected to a different set of TOR switches running VRRP. OVS (using kernel datapath) had a flow to write the VRRP mac address and output to a bond port. The bond is a

Re: [ovs-dev] [ACL Meters 1/7] ovn: Use C strings instead of ds for extended tables.

On Sun, Jul 29, 2018 at 11:46:32PM -0700, Justin Pettit wrote: > Dynamic strings are not needed for the most part and are introduing > additional conversions back and forth with C strings. > > Signed-off-by: Justin Pettit For the series, assuming you think my comments are reasonable: Acked-by:

Re: [ovs-dev] [PATCHv2 2/2] dpif-netlink: Add meter support.

On Fri, Jul 27, 2018 at 02:19:13PM -0700, Justin Pettit wrote: > From: Andy Zhou > > To work with kernel datapath that supports meter. > > Signed-off-by: Andy Zhou > Co-authored-by: Justin Pettit > Signed-off-by: Justin Pettit > Acked-by: Alin Gabriel Serdean > --- > v1->v2: Addressed Ben's

Re: [ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

On Sun, Jul 29, 2018 at 11:46:38PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Besides the comments I gave on patch 6 (oops), I suggest the following for more consistent formatting: diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c index 6d4ed1e2c4ed..4f3cd48ce713 100644 ---

Re: [ovs-dev] [PATCH 0/4] Kernel backports from net-next

> On Jul 16, 2018, at 5:55 PM, Yi-Hung Wei wrote: > > This patch series backports the following patches from net-next that modify > ./net/openvswitch/* from the previous backport commit, > 46e371f0 ("openvswitch: fix vport packet length check."). > > 1) b2d6cee1 Merge

Re: [ovs-dev] [ACL Meters 6/7] ofproto: Add support for specifying a meter in controller actions.

On Mon, Jul 30, 2018 at 12:49:51PM -0700, Ben Pfaff wrote: > On Sun, Jul 29, 2018 at 11:46:37PM -0700, Justin Pettit wrote: > > Signed-off-by: Justin Pettit > > In ofproto_check_ofpacts(), the other checks, if they fail, return an > error and prevent the flow from being added. The new one

Re: [ovs-dev] [ACL Meters 6/7] ofproto: Add support for specifying a meter in controller actions.

On Sun, Jul 29, 2018 at 11:46:37PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit In ofproto_check_ofpacts(), the other checks, if they fail, return an error and prevent the flow from being added. The new one doesn't; is the difference intentional? Similarly, is there anything that

Re: [ovs-dev] [PATCH v1] rhel: support kmod build against mulitple kernel versions, fedora

On Fri, Jul 27, 2018 at 11:19:58AM -0700, Martin Xu wrote: > Hi Flavio, > > Thanks for the review. I was thinking of using this to prevent a user to > directly install openvswitch-kmod rpm built with the fedora spec file when > the system already has the kmod-openvswitch built from rhel6 spec

Re: [ovs-dev] [PATCH] dpif-netdev: Fix zero length keys insertion to EMC.

> 'key.len' should be calculated before inserting to EMC, otherwise > resulting entry will match with any packet with the same hash. > > CC: Yipeng Wang > Fixes: 60d8ccae135f ("dpif-netdev: Add SMC cache after EMC cache") > Signed-off-by: Ilya Maximets Thanks Ilya, I'll apply this to dpdk

Re: [ovs-dev] [PATCHv2] netdev-dpdk: Fix failure to configure flow control at netdev-init.

> Configuring flow control at ixgbe netdev-init is throwing error in port > start. > > For eg: without this fix, user cannot configure flow control on ixgbe dpdk > port as below, > > " > ovs-vsctl add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk \ >

Re: [ovs-dev] [ACL Meters 5/7] ovn: Support configuring meters through SB Meter table.

On Sun, Jul 29, 2018 at 11:46:36PM -0700, Justin Pettit wrote: > Add the ability to configure meters through the newly introduced Meter > table in the Southbound database. Previously, meters were configured by > providing strings to describe the meter in the extended meter table. > This patch

Re: [ovs-dev] [ACL Meters 4/7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

Hi Justin, I took a look through the patch series, and this is the only one that I had some immediate feedback on. First, it would be nice if we could refer to Meters by name when issuing DB commands. For instance `ovn-nbctl add Meter bands UUID>`. Second, I noticed that the algorithm for

Re: [ovs-dev] [PATCH] debian: Add ovn-detrace to ovn-common package.

Thanks for adding this. Acked-by: aginwala On Sun, Jul 29, 2018 at 4:27 PM Han Zhou wrote: > Signed-off-by: Han Zhou > --- > debian/ovn-common.install | 1 + > debian/ovn-common.manpages | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/debian/ovn-common.install

Re: [ovs-dev] [ACL Meters 4/7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

On Sun, Jul 29, 2018 at 11:46:35PM -0700, Justin Pettit wrote: > Add support for configuring meters through the Meter and Meter_Band > tables in the Northbound database. This commit also has ovn-northd > sync those tables between the Northbound and Southbound databases. > > Add support for

Re: [ovs-dev] [ACL Meters 3/7] ovn-controller: Add "group-table-list" ovs-appctl command.

On Sun, Jul 29, 2018 at 11:46:34PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Thanks for the patches! I think that group_table_list() is very similar or identical to meter_table_list() in the previous patch. Is it possible to write both of them in terms of a common helper

Re: [ovs-dev] [PATCH v3 1/6] datapath: add transport ports in route lookup to enable IPsec policy match.

Greg gave me Reviewed-by and Tested-by tags. I will add those to commit messages. Thanks, Qiuyu On Mon, Jul 30, 2018 at 9:49 AM, Ben Pfaff wrote: > On Fri, Jul 27, 2018 at 01:44:29PM -0700, Qiuyu Xiao wrote: >> This patch adds transport ports information for route lookup so that IPsec >> can

Re: [ovs-dev] [PATCH v3 1/6] datapath: add transport ports in route lookup to enable IPsec policy match.

On Fri, Jul 27, 2018 at 01:44:29PM -0700, Qiuyu Xiao wrote: > This patch adds transport ports information for route lookup so that IPsec > can select tunnel traffic (geneve, stt, vxlan) to do encryption. > > The patch was tested for geneve, stt, and vxlan tunnel and the results > show that IPsec

Re: [ovs-dev] [PATCH v2] Introduce ovs-appctl command to monitor HVs sb connection status

Looks good to me. Ship it! Acked-by: Mark Michelson On 07/30/2018 11:10 AM, Lorenzo Bianconi wrote: Add 'connection-status' command to ovs-appctl utility in order to check if a given chassis is currently connected to SB db Co-authored-by: aginwala Signed-off-by: aginwala Signed-off-by:

[ovs-dev] [PATCH v2] Introduce ovs-appctl command to monitor HVs sb connection status

Add 'connection-status' command to ovs-appctl utility in order to check if a given chassis is currently connected to SB db Co-authored-by: aginwala Signed-off-by: aginwala Signed-off-by: Lorenzo Bianconi --- Changes since v1: - add unit tests for ovs-appctl -t ovn-controller connection-status

Re: [ovs-dev] [PATCH v2 0/3] Port Group fixes

Wow bad timing on my part for my review of v1. Acked-by: Mark Michelson On 07/30/2018 10:37 AM, Jakub Sitnicki wrote: This series addresses two issues noticed with Port Groups: (1) Port Group name cannot be used to refer to a row in NB DB. (2) LSP dynamic addresses don't get copied to port

Re: [ovs-dev] [PATCH 0/3] Port Group fixes

For the series (aside from Han's finding): Acked-by: Mark Michelson On 07/26/2018 06:51 AM, Jakub Sitnicki wrote: This series addresses two issues noticed with Port Groups: (1) Port Group name cannot be used to refer to a row in NB DB. (2) LSP dynamic addresses don't get copied to port group

Re: [ovs-dev] [PATCH 3/3] ovn-northd: Propagate dynamic addresses to port group address sets.

On Sat, 28 Jul 2018 23:54:32 -0700 Han Zhou wrote: > On Thu, Jul 26, 2018 at 3:51 AM, Jakub Sitnicki wrote: > > > > If a logical switch port belongs to a port group and has dynamic > > addresses assigned, propagate the addresses to the auto-generated > > address sets for the port group. > > > >

[ovs-dev] [PATCH v2 2/3] ovn-northd: Make use of svec for storing lists of addresses.

Get rid of what is, esentially, an open-coded version of svec. Signed-off-by: Jakub Sitnicki Acked-by: Han Zhou --- ovn/northd/ovn-northd.c | 47 +++--- tests/ovn.at| 50 + 2 files changed, 65

[ovs-dev] [PATCH v2 3/3] ovn-northd: Propagate dynamic addresses to port group address sets.

If a logical switch port belongs to a port group and has dynamic addresses assigned, propagate the addresses to the auto-generated address sets for the port group. Signed-off-by: Jakub Sitnicki Acked-by: Han Zhou --- ovn/northd/ovn-northd.c | 34 tests/ovn.at

[ovs-dev] [PATCH v2 1/3] ovn-nbctl: Allow referring to port groups by name.

Be user-friendly and allow using port group's name as its identifier in database commands. Signed-off-by: Jakub Sitnicki Acked-by: Han Zhou --- ovn/utilities/ovn-nbctl.c | 3 +++ tests/ovn-nbctl.at| 14 ++ 2 files changed, 17 insertions(+) diff --git

[ovs-dev] [PATCH v2 0/3] Port Group fixes

This series addresses two issues noticed with Port Groups: (1) Port Group name cannot be used to refer to a row in NB DB. (2) LSP dynamic addresses don't get copied to port group address sets. The series depends on recent fixes for IPAM from Mark Michelson [1]. Thanks, Jakub [1]

[ovs-dev] [PATCH v2 1/2] ovn: Add '--restart' flag to ovn-controller exit.

When "--restart" is passed to ovn-controller's exit command, then database entries are not removed for this hypervisor. This means that * Encaps * Chassis * OVS ports are not removed. The reasoning is that if the intent is to restart ovn-controller, this will allow for tunnels to remain up and

[ovs-dev] [PATCH v2 0/2] Allow for smoother restarting of ovn-controller

When ovn-controller is restarted, the ovn-controller process is stopped and then started again. When the process is stopped, the process cleans itself up by removing all traces of itself from the central southbound database and the OVS database on the hypervisor. The issue with this is that this

[ovs-dev] [PATCH v2 2/2] ovn: Modify restart_controller in ovn-ctl to use --restart

The --restart flag allows for uninterrupted packet flowage when exiting ovn-controller. This patch modifies the restart_controller argument to ovn-ctl to use --restart. Signed-off-by: Mark Michelson --- ovn/utilities/ovn-ctl | 4 ++-- utilities/ovs-lib.in | 2 +- 2 files changed, 3

Re: [ovs-dev] [ovs-dev, v3, 2 of 6] ipsec: reintroduce IPsec support for tunneling

0-day Robot writes: > Bleep bloop. Greetings Qiuyu Xiao, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Too many signoffs; are you missing Co-authored-by

Re: [ovs-dev] [PATCH v6 2/3] Send gateway port ARP through router internal ports

Thanks Mark for the review. Please see my reply inline. On Thu, Jul 19, 2018 at 7:04 PM, Mark Michelson wrote: > This patch had some compilation errors. It may be due to changes in master > since this patchset was posted: > > ovn/controller/pinctrl.c: In function ‘send_garp_run’: >

Re: [ovs-dev] [PATCH 0/2] Allow for smoother restarting of ovn-controller

On Tue, 24 Jul 2018 16:30:04 -0400 Mark Michelson wrote: > When ovn-controller is restarted, the ovn-controller process is stopped > and then started again. When the process is stopped, the process cleans > itself up by removing all traces of itself from the central southbound > database and the

Re: [ovs-dev] [PATCH 2/2] ovn: Modify restart_controller in ovn-ctl to use --restart

On Tue, 24 Jul 2018 16:30:06 -0400 Mark Michelson wrote: > The --restart flag allows for uninterrupted packet flowage when exiting > ovn-controller. This patch modifies the restart_controller argument to > ovn-ctl to use --restart. > > Signed-off-by: Mark Michelson > --- >

Re: [ovs-dev] [PATCH] oss-fuzz: Move oss-fuzz test harnesses and fuzzer configs to ovs source repo

Any updates on the proposed patch? :-) On 07/16/2018 02:07 PM, Bhargava Shastry wrote: > Update: I fixed these errors in the attached patch that supersedes the > patch here (https://patchwork.ozlabs.org/patch/942118/) > > The major change is that I add the following line for each fuzz target >

Re: [ovs-dev] [PATCH 2/2] Revert "dpctl: Expand the flow dump type filter"

On 27/07/2018 14:00, Simon Horman wrote: > Hi Gavi, > > On 26 July 2018 at 17:36, Justin Pettit > wrote: > > > > On Jul 26, 2018, at 7:29 AM, Gavi Teitz > wrote: > > > > From: Justin Pettit, sent: Thursday, July 26, 2018 12:02

Re: [ovs-dev] [ovs-dev, ACL, Meters, 7 of 7] ovn: Add rate-limiting for ACL logs.

Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 372 characters long (recommended limit is 79) #239 FILE:

Re: [ovs-dev] [ovs-dev, ACL, Meters, 4 of 7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #217 FILE:

[ovs-dev] [ACL Meters 7/7] ovn: Add rate-limiting for ACL logs.

Signed-off-by: Justin Pettit --- include/ovn/actions.h | 1 + ovn/lib/actions.c | 56 +-- ovn/northd/ovn-northd.c | 4 ++ ovn/ovn-nb.ovsschema | 5 ++- ovn/ovn-nb.xml| 9 + ovn/utilities/ovn-nbctl.8.xml | 6 ++-

[ovs-dev] [ACL Meters 6/7] ofproto: Add support for specifying a meter in controller actions.

Signed-off-by: Justin Pettit --- include/openvswitch/ofp-actions.h | 8 ++ lib/ofp-actions.c | 27 +-- ofproto/ofproto-dpif-xlate.c | 24 + ofproto/ofproto-dpif.c| 1 + ofproto/ofproto.c | 44

[ovs-dev] [ACL Meters 5/7] ovn: Support configuring meters through SB Meter table.

Add the ability to configure meters through the newly introduced Meter table in the Southbound database. Previously, meters were configured by providing strings to describe the meter in the extended meter table. This patch changes the behavior so that the extended meter table's strings are

[ovs-dev] [ACL Meters 4/7] ovn: Add Meter and Meter_Band tables to the NB and SB databases.

Add support for configuring meters through the Meter and Meter_Band tables in the Northbound database. This commit also has ovn-northd sync those tables between the Northbound and Southbound databases. Add support for configuring meters with ovn-nbctl. Signed-off-by: Justin Pettit ---

[ovs-dev] [ACL Meters 3/7] ovn-controller: Add "group-table-list" ovs-appctl command.

Signed-off-by: Justin Pettit --- ovn/controller/ovn-controller.8.xml | 5 + ovn/controller/ovn-controller.c | 30 + 2 files changed, 35 insertions(+) diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-controller.8.xml index

[ovs-dev] [ACL Meters 2/7] ovn-controller: Add "meter-table-list" ovs-appctl command.

Signed-off-by: Justin Pettit --- ovn/controller/ovn-controller.8.xml | 5 + ovn/controller/ovn-controller.c | 30 + 2 files changed, 35 insertions(+) diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-controller.8.xml index

[ovs-dev] [ACL Meters 1/7] ovn: Use C strings instead of ds for extended tables.

Dynamic strings are not needed for the most part and are introduing additional conversions back and forth with C strings. Signed-off-by: Justin Pettit --- ovn/controller/ofctrl.c | 4 ++-- ovn/lib/actions.c | 20 ovn/lib/extend-table.c | 22 --