[ovs-dev] INFO

See Attached___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] compat: Substitute more dependable define

On Mon, Aug 13, 2018 at 04:00:16PM -0700, Greg Rose wrote: > The compat layer ip_tunnel_get_stats64 function was checking for the > Linux kernel version to determine if the return was void or a pointer. > This is not very reliable and caused compile warnings on SLES 12 SP3. > In acinclude.m4

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

On Mon, Aug 13, 2018 at 05:39:07PM -0700, Ben Pfaff wrote: > On Mon, Aug 13, 2018 at 02:07:45PM +0200, Daniel Alvarez wrote: > > This patch in glibc [0] is fixing a bug where we may be getting > > inconsistent dumps from the kernel when listing interfaces due to > > a race condition. > > > > This

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

On Mon, Aug 13, 2018 at 02:07:45PM +0200, Daniel Alvarez wrote: > This patch in glibc [0] is fixing a bug where we may be getting > inconsistent dumps from the kernel when listing interfaces due to > a race condition. > > This could happen if we try to retrieve them while interfaces are > being

Re: [ovs-dev] [PATCH 2/2] ovsdb-idl.c: Fix IDL index problem when rows are updated.

Thanks for pointing that out. I fixed up the rejects and applied to those branches too. On Mon, Aug 13, 2018 at 04:41:02PM -0700, Han Zhou wrote: > Thanks Ben for merging. This problem do exist in 2.9 and 2.8 also, so I > think they'd better get applied, too. > > On Mon, Aug 13, 2018 at 3:44

Re: [ovs-dev] compat: Substitute more dependable define

Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Committer 0-day Robot needs to sign off. Lines checked: 70, Warnings: 0, Errors: 1

Re: [ovs-dev] [PATCH 2/2] ovsdb-idl.c: Fix IDL index problem when rows are updated.

Thanks Ben for merging. This problem do exist in 2.9 and 2.8 also, so I think they'd better get applied, too. On Mon, Aug 13, 2018 at 3:44 PM, Ben Pfaff wrote: > On Fri, Aug 10, 2018 at 08:29:46PM -0700, Han Zhou wrote: > > In current IDL index code it doesn't updated index when handling > >

Re: [ovs-dev] [PATCH 2/2] ovsdb-idl.c: Fix IDL index problem when rows are updated.

On Fri, Aug 10, 2018 at 08:29:46PM -0700, Han Zhou wrote: > In current IDL index code it doesn't updated index when handling > "update2" messages, which is the default case. The consequence > is that when a row is updated, the index is not updated accordingly, > and even worse, it causes crash

Re: [ovs-dev] [PATCH v5 2/6] ipsec: reintroduce IPsec support for tunneling

We'll look forward to it even if it takes a while. Thank you. (If it does turn out that you don't want to work on this anymore, please let me know. I will get someone else to finish it up.) On Mon, Aug 13, 2018 at 06:41:42AM -0400, Qiuyu Xiao wrote: > Thanks for the review! I will address your

Re: [ovs-dev] [PATCH] ovn-controller: Fix warning message when unable to assign meter ID.

On Mon, Aug 13, 2018 at 12:36:17PM -0700, Han Zhou wrote: > Signed-off-by: Han Zhou Thanks! Applied to master and branch-2.10. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] checkpatch: Improve accuracy and specificity of sign-off checking.

On Mon, Aug 13, 2018 at 01:16:25PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Sun, Aug 12, 2018 at 07:43:14AM -0700, Ben Pfaff wrote: > >> On Sat, Aug 11, 2018 at 09:54:01AM -0400, Aaron Conole wrote: > >> > Ben Pfaff writes: > >> > > >> > > This also makes a start at a testsuite

Re: [ovs-dev] [patch v8 9/9] ipf: Add fragmentation status reporting.

Thanks. Darrell On Fri, Aug 10, 2018 at 8:00 PM, Justin Pettit wrote: > > > On Jul 16, 2018, at 4:39 PM, Darrell Ball wrote: > > > > void > > ct_dpif_entry_uninit(struct ct_dpif_entry *entry) > > { > > diff --git a/lib/ct-dpif.h b/lib/ct-dpif.h > > index f886ab9..2ff7e26 100644 > > ---

Re: [ovs-dev] [ovs-dev, v5, 08 of 20] ovn-controller: Incremental logical flow processing

Aaron Conole writes: > 0-day Robot writes: > >> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your >> patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >> >> git-am: >> fatal: sha1 information is

[ovs-dev] [PATCH] ovn-controller: Fix warning message when unable to assign meter ID.

Signed-off-by: Han Zhou --- ovn/lib/actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/lib/actions.c b/ovn/lib/actions.c index bc1a200..ea72046 100644 --- a/ovn/lib/actions.c +++ b/ovn/lib/actions.c @@ -2179,7 +2179,7 @@ encode_LOG(const struct ovnact_log *log,

Re: [ovs-dev] [ovs-dev, v5, 08 of 20] ovn-controller: Incremental logical flow processing

0-day Robot writes: > Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > git-am: > fatal: sha1 information is lacking or useless

Re: [ovs-dev] [ovs-dev, v5, 08 of 20] ovn-controller: Incremental logical flow processing

Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (ovn/controller/lflow.c). Repository lacks necessary

Re: [ovs-dev] [ovs-dev, v5, 05 of 20] ovn-controller: Incremental processing engine

Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #439 FILE: ovn/lib/inc-proc-eng.h:194: if

Re: [ovs-dev] [RFC 00/14] ovn-controller incremental processing.

On Mon, Aug 6, 2018 at 10:30 PM, Han Zhou wrote: > > > > On Mon, Aug 6, 2018 at 3:13 AM, Mark Michelson wrote: > > > > Hi Han, > > > > I thought about this more over the weekend, and I was hoping I'd get to respond to my own e-mail before you saw it, because I realized I had a fundamental

Re: [ovs-dev] [ovs-dev, v4, 05 of 20] ovn-controller: Incremental processing engine

Han Zhou writes: > On Mon, Aug 13, 2018 at 1:04 AM, 0-day Robot wrote: >> >> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your > patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >> >> checkpatch: >>

Re: [ovs-dev] [ovs-dev, v4, 20 of 20] ovn-performance.at: Test port group incremental processing.

Han Zhou writes: > On Mon, Aug 13, 2018 at 1:06 AM, 0-day Robot wrote: >> >> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your > patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >> >> git-am: >>

[ovs-dev] [PATCH v5 19/20] ovn: Test for full logical flow processing in ovn-controller.

From: Jakub Sitnicki From: Jakub Sitnicki Add a test that performs typical operations of creating & destroying logical routers, switches, ports, address sets and ACLs while checking if they trigger full logical flow processing in the ovn-controller. This way confirm that incremental processing

[ovs-dev] [PATCH v5 20/20] ovn-performance.at: Test port group incremental processing.

Add tests to make sure port group change doesn't trigger recomputing. Signed-off-by: Han Zhou --- tests/ovn-performance.at | 43 +-- 1 file changed, 37 insertions(+), 6 deletions(-) diff --git a/tests/ovn-performance.at b/tests/ovn-performance.at index

[ovs-dev] [PATCH v5 18/20] coverage: Add command for reading counter value.

From: Jakub Sitnicki From: Jakub Sitnicki Facilitate checking coverage counters from scripts and tests with a new coverage/read-counter command that gets the total count for a counter. Same could be achieved by scraping the output of coverage/show command but the difficulties there are that

[ovs-dev] [PATCH v5 16/20] ovn-controller: Split port_groups from runtime_data.

Signed-off-by: Han Zhou --- ovn/controller/ovn-controller.c | 91 + 1 file changed, 73 insertions(+), 18 deletions(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 0e445df..8509145 100644 ---

[ovs-dev] [PATCH v5 17/20] ovn-controller: Incremental processing for port-group changes.

Signed-off-by: Han Zhou --- ovn/controller/lflow.h | 3 +- ovn/controller/ovn-controller.c | 110 ++-- 2 files changed, 97 insertions(+), 16 deletions(-) diff --git a/ovn/controller/lflow.h b/ovn/controller/lflow.h index 01dda1d..b90f971 100644 ---

[ovs-dev] [PATCH v5 15/20] ovn-controller: Incremental processing for address-set changes.

When the content of an address set changes, ovn-controller will not recompute all flows but only the ones related to the changed address-set. The performance test result is discussed at [1]. [1] https://mail.openvswitch.org/pipermail/ovs-discuss/2018-June/046880.html Tested-by: Mark Michelson

[ovs-dev] [PATCH v5 14/20] ovn-controller: Maintain resource references for logical flows.

This patch maintains the cross reference between logical flows and the resources such as address sets and port groups that are used by logical flows. This data will be needed in address set and port group incremental processing. Signed-off-by: Han Zhou --- include/ovn/expr.h | 5

[ovs-dev] [PATCH v5 07/20] ovn-controller: Initial use of incremental engine.

Incremental proccessing engine is used to compute flows. In this patch we create below engine nodes: - Engine nodes for each OVSDB table in local OVS DB and SB DB. - runtime_data: compute and maintain intermediate result such as local_datapath, etc. -

[ovs-dev] [PATCH v5 13/20] ovn-controller: Split addr_sets from runtime_data.

Signed-off-by: Han Zhou --- ovn/controller/ovn-controller.c | 75 - 1 file changed, 60 insertions(+), 15 deletions(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 4399d6e..a50d134 100644 ---

[ovs-dev] [PATCH v5 12/20] ovsdb-idl: Tracking - preserve data for deleted rows.

OVSDB IDL can track changes, but for deleted rows, the data is destroyed and only uuid is tracked. In some cases we need to check the data of the deleted rows. This patch preserves data for deleted rows until track clear is called. Signed-off-by: Han Zhou --- lib/ovsdb-idl-provider.h | 2 ++

[ovs-dev] [PATCH v5 11/20] ovn-controller: incremental processing for multicast group changes

This patch handles SB Multicast_Group table changes incrementally. The Multicast_Group table changes can be triggered by creating/deleting a lport of a lswitch. It can be also triggered indirectly by an updating of a port-binding which is referenced by the multicast group. This patch together

[ovs-dev] [PATCH v5 10/20] ovn-controller: port-binding incremental processing for physical flows

This patch implements change handler for port-binding in flow_output for physical flows computing, so that physical flow computing will be incremental. Signed-off-by: Han Zhou --- ovn/controller/ovn-controller.c | 95 ++- ovn/controller/physical.c | 106

[ovs-dev] [PATCH v5 09/20] ovn-controller: runtime_data change handler for SB port-binding

Evaluates change for SB port-binding in runtime_data node. If the port-binding change has no impact for the runtime_data it will not trigger runtime_data change. Signed-off-by: Han Zhou --- ovn/controller/binding.c| 91 + ovn/controller/binding.h

[ovs-dev] [PATCH v5 08/20] ovn-controller: Incremental logical flow processing

Implements change handler of flow_output for SB lflow changes. Signed-off-by: Han Zhou --- ovn/controller/lflow.c | 84 + ovn/controller/lflow.h | 18 + ovn/controller/ovn-controller.c | 76 -

[ovs-dev] [PATCH v5 06/20] ovn-controller: Track OVSDB changes

Track OVSDB changes for future patches of incremental processing Signed-off-by: Han Zhou --- ovn/controller/bfd.c| 4 ++-- ovn/controller/binding.c| 16 ovn/controller/encaps.c | 12 ++-- ovn/controller/ovn-controller.c | 22

[ovs-dev] [PATCH v5 05/20] ovn-controller: Incremental processing engine

This patch implements the engine which will be used in future patches for ovn-controller incremental processing. Signed-off-by: Han Zhou --- ovn/lib/automake.mk| 4 +- ovn/lib/inc-proc-eng.c | 201 + ovn/lib/inc-proc-eng.h | 240

[ovs-dev] [PATCH v5 04/20] ovsdb-idl.c: Track changes for table references.

If a change of a row is tracked, make sure the rows that reference this row are also added in tracked changes, unless change tracking is not required for those rows. Signed-off-by: Han Zhou --- lib/ovsdb-idl.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff

[ovs-dev] [PATCH v5 03/20] ovsdb-idlc.in: Support more interfaces for passing pointers of individual tables.

This is a follow-up patch for commit 0eb1e37c, to add more interfaces that supports passing around pointers of individual tables, which will be used in incremental processing. Signed-off-by: Han Zhou --- ovsdb/ovsdb-idlc.in | 25 + 1 file changed, 25 insertions(+) diff

[ovs-dev] [PATCH v5 02/20] ovsdb-idl.c: Update conditions when handling change tracking list.

There are places with the pattern: if (!ovs_list_is_empty(>track_node)) { ovs_list_remove(>track_node); } ovs_list_push_back(>table->track_list, >track_node); It seems to be trying to prevent double removing the node from a list, but actually it doesn't,

[ovs-dev] [PATCH v5 01/20] ovsdb-idl.c: Remove a misleading comment for change tracking.

The comment was added when the feature was introduced but what it described is not what is implemented, probably because of revisions after code reviews. Signed-off-by: Han Zhou --- lib/ovsdb-idl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/ovsdb-idl.c

[ovs-dev] [PATCH v5 00/20] ovn-controller incremental processing

ovn-controller currently recomputes everything when there are any changes of input, which leads to high CPU usages and slow in end-to-end flow enforcement in response to changes. It even wastes CPU to recompute flows for unrelated inputs such as pinctrl events. This patch series implements

Re: [ovs-dev] [PATCH v3] checkpatch: Improve accuracy and specificity of sign-off checking.

Ben Pfaff writes: > On Sun, Aug 12, 2018 at 07:43:14AM -0700, Ben Pfaff wrote: >> On Sat, Aug 11, 2018 at 09:54:01AM -0400, Aaron Conole wrote: >> > Ben Pfaff writes: >> > >> > > This also makes a start at a testsuite for checkpatch. >> > > >> > > CC: Aaron Conole >> > > Signed-off-by: Ben

Re: [ovs-dev] [PATCH 4/8] system-traffic.at: Add gre tunnel test that doesn't depend on upstream gre module

clarification: the running time is per test. On Mon, Aug 13, 2018 at 9:47 AM, Darrell Ball wrote: > With a few minor tweaks, below, the running time was brought down from > 1.5-2 minutes to 15-25 seconds per test. > > I just changed the tcpdump filter (many variations are possible though) >

Re: [ovs-dev] [PATCH 4/8] system-traffic.at: Add gre tunnel test that doesn't depend on upstream gre module

With a few minor tweaks, below, the running time was brought down from 1.5-2 minutes to 15-25 seconds. I just changed the tcpdump filter (many variations are possible though) and eliminated some redundant tcpdump checks since they are implied. Thanks Darrell dball@ubuntu:~/ovs$ git diff

Re: [ovs-dev] [PATCH v5 6/6] Documentation: OVN RBAC and IPsec tutorial

On Tue, 7 Aug 2018 at 09:46, Qiuyu Xiao wrote: > > This patch adds step-by-step guide for configuring OVN Role-Based Access > Control and IPsec. > > Signed-off-by: Qiuyu Xiao > --- > Documentation/automake.mk | 2 + > Documentation/index.rst | 4 +- >

Re: [ovs-dev] [ovs-dev, v4, 20 of 20] ovn-performance.at: Test port group incremental processing.

On Mon, Aug 13, 2018 at 1:06 AM, 0-day Robot wrote: > > Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > git-am: > fatal: sha1 information is lacking

Re: [ovs-dev] [ovs-dev, v4, 05 of 20] ovn-controller: Incremental processing engine

On Mon, Aug 13, 2018 at 1:04 AM, 0-day Robot wrote: > > Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Inappropriate bracing

Re: [ovs-dev] [ovs-dev, v4, 06 of 20] ovn-controller: Track OVSDB changes

On Mon, Aug 13, 2018 at 1:06 AM, 0-day Robot wrote: > > Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > build: > depbase=`echo

[ovs-dev] пшрю

хкз хфсг рвтт ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 1/2] Fix packet drops on LACP bond after link up

No. There were two comments but neither one received a response: https://mail.openvswitch.org/pipermail/ovs-dev/2018-July/348943.html https://mail.openvswitch.org/pipermail/ovs-dev/2018-July/348944.html On Mon, Aug 13, 2018 at 11:22:54AM +, Nitin Katiyar wrote: > Ben, > I am following up on

Re: [ovs-dev] s/rhel/rpm/?

On Mon, Aug 13, 2018 at 12:01 PM Ben Pfaff wrote: > On Mon, Aug 13, 2018 at 10:33:59AM -0400, Russell Bryant wrote: > > On Wed, Aug 8, 2018 at 6:16 PM Ben Pfaff wrote: > > > > > On Thu, Aug 09, 2018 at 12:29:20AM +0300, Markos Chandras wrote: > > > > On 08/08/2018 09:01 PM, Ben Pfaff wrote: > >

Re: [ovs-dev] s/rhel/rpm/?

On Wed, Aug 8, 2018 at 6:16 PM Ben Pfaff wrote: > On Thu, Aug 09, 2018 at 12:29:20AM +0300, Markos Chandras wrote: > > On 08/08/2018 09:01 PM, Ben Pfaff wrote: > > > [asking some random SuSE and Red Hat people] > > > > > > It had somehow slipped past my notice before that the spec files we >

Re: [ovs-dev] [ovs-dev, v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

Bleep bloop. Greetings Daniel Alvarez, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Too many signoffs; are you missing Co-authored-by lines? ERROR:

Re: [ovs-dev] OVN/OVS split: OVN mailing list?

+1 on my side too :) Thank you for bringing up the topic On Mon, Aug 13, 2018 at 2:03 PM Daniel Alvarez Sanchez wrote: > +1 for the split of the ML > > On Mon, Aug 13, 2018 at 11:17 AM Lucas Alvares Gomes < > lucasago...@gmail.com> > wrote: > > > Hi, > > > > > Before starting in-depth technical

[ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

This patch in glibc [0] is fixing a bug where we may be getting inconsistent dumps from the kernel when listing interfaces due to a race condition. This could happen if we try to retrieve them while interfaces are being added/removed from the system at the same time. For systems running against

Re: [ovs-dev] OVN/OVS split: OVN mailing list?

+1 for the split of the ML On Mon, Aug 13, 2018 at 11:17 AM Lucas Alvares Gomes wrote: > Hi, > > > Before starting in-depth technical discussions on this list or the > > ovs-dev list, I'm curious if people would be interested in splitting off > > a separate OVN list for this and future

Re: [ovs-dev] [PATCH v2 1/2] Fix packet drops on LACP bond after link up

Ben, I am following up on the patch which Manohar had sent earlier. Can it be merged? Regards, Nitin -Original Message- From: Manohar Krishnappa Chidambaraswamy [mailto:manohar.krishnappa.chidambarasw...@ericsson.com] Sent: Monday, June 25, 2018 2:49 PM To: Ben Pfaff Cc:

Re: [ovs-dev] [PATCH v5 2/6] ipsec: reintroduce IPsec support for tunneling

Thanks for the review! I will address your comments and post the next revision. But it might take a while because I need to deal with school stuff. Thanks, Qiuyu > On Aug 13, 2018, at 2:33 AM, Ansis Atteka wrote: > > On Tue, 7 Aug 2018 at 09:43, Qiuyu Xiao >

Re: [ovs-dev] OVN/OVS split: OVN mailing list?

Hi, > Before starting in-depth technical discussions on this list or the > ovs-dev list, I'm curious if people would be interested in splitting off > a separate OVN list for this and future OVN-related discussions? I can > see merits of keeping discussions on this list and of starting a new >

Re: [ovs-dev] [ovs-dev, v4, 20 of 20] ovn-performance.at: Test port group incremental processing.

Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (tests/ovn-performance.at). Repository lacks necessary

Re: [ovs-dev] [ovs-dev, v4, 06 of 20] ovn-controller: Track OVSDB changes

Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: depbase=`echo ovn/controller/ofctrl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\ gcc -std=gnu99

Re: [ovs-dev] [ovs-dev, v4, 05 of 20] ovn-controller: Incremental processing engine

Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #439 FILE: ovn/lib/inc-proc-eng.h:194: if

Re: [ovs-dev] [PATCH 0/2] Reflecting a flow's offloaded state - continuation

Hi Simon, On Friday, August 10, 2018 at 4:14 PM, Simon Horman wrote: >Hi Gavi, > >On 10 August 2018 at 10:30, Gavi Teitz wrote: >>Continuing work done on improving visibility of a flow's offloaded >>state via dpctl, which was begun in commit d63ca5329ff9 ("dpctl: >>Properly reflect a rule's

[ovs-dev] hallo

My Dear, With Due Respect And Humanity, I was compelled to write to you under a humanitarian ground ,i am Mrs.Balboa Escalante 58 yrs old widow from London,my husband He was a CEO/a textile company owner,business man, a miner at Kruger mining company in Cambodia. He was a geologist and

[ovs-dev] [PATCH v4 19/20] ovn: Test for full logical flow processing in ovn-controller.

From: Jakub Sitnicki From: Jakub Sitnicki Add a test that performs typical operations of creating & destroying logical routers, switches, ports, address sets and ACLs while checking if they trigger full logical flow processing in the ovn-controller. This way confirm that incremental processing

[ovs-dev] [PATCH v4 20/20] ovn-performance.at: Test port group incremental processing.

Add tests to make sure port group change doesn't trigger recomputing. Signed-off-by: Han Zhou --- tests/ovn-performance.at | 43 +-- 1 file changed, 37 insertions(+), 6 deletions(-) diff --git a/tests/ovn-performance.at b/tests/ovn-performance.at index

[ovs-dev] [PATCH v4 16/20] ovn-controller: Split port_groups from runtime_data.

Signed-off-by: Han Zhou --- ovn/controller/ovn-controller.c | 91 + 1 file changed, 73 insertions(+), 18 deletions(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 0e445df..8509145 100644 ---

[ovs-dev] [PATCH v4 18/20] coverage: Add command for reading counter value.

From: Jakub Sitnicki From: Jakub Sitnicki Facilitate checking coverage counters from scripts and tests with a new coverage/read-counter command that gets the total count for a counter. Same could be achieved by scraping the output of coverage/show command but the difficulties there are that

[ovs-dev] [PATCH v4 17/20] ovn-controller: Incremental processing for port-group changes.

Signed-off-by: Han Zhou --- ovn/controller/lflow.h | 3 +- ovn/controller/ovn-controller.c | 110 ++-- 2 files changed, 97 insertions(+), 16 deletions(-) diff --git a/ovn/controller/lflow.h b/ovn/controller/lflow.h index 01dda1d..b90f971 100644 ---

[ovs-dev] [PATCH v4 14/20] ovn-controller: Maintain resource references for logical flows.

This patch maintains the cross reference between logical flows and the resources such as address sets and port groups that are used by logical flows. This data will be needed in address set and port group incremental processing. Signed-off-by: Han Zhou --- include/ovn/expr.h | 5

[ovs-dev] [PATCH v4 15/20] ovn-controller: Incremental processing for address-set changes.

When the content of an address set changes, ovn-controller will not recompute all flows but only the ones related to the changed address-set. The performance test result is discussed at [1]. [1] https://mail.openvswitch.org/pipermail/ovs-discuss/2018-June/046880.html Tested-by: Mark Michelson

[ovs-dev] [PATCH v4 13/20] ovn-controller: Split addr_sets from runtime_data.

Signed-off-by: Han Zhou --- ovn/controller/ovn-controller.c | 75 - 1 file changed, 60 insertions(+), 15 deletions(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 4399d6e..a50d134 100644 ---

[ovs-dev] [PATCH v4 07/20] ovn-controller: Initial use of incremental engine.

Incremental proccessing engine is used to compute flows. In this patch we create below engine nodes: - Engine nodes for each OVSDB table in local OVS DB and SB DB. - runtime_data: compute and maintain intermediate result such as local_datapath, etc. -

[ovs-dev] [PATCH v4 11/20] ovn-controller: incremental processing for multicast group changes

This patch handles SB Multicast_Group table changes incrementally. The Multicast_Group table changes can be triggered by creating/deleting a lport of a lswitch. It can be also triggered indirectly by an updating of a port-binding which is referenced by the multicast group. This patch together

[ovs-dev] [PATCH v4 12/20] ovsdb-idl: Tracking - preserve data for deleted rows.

OVSDB IDL can track changes, but for deleted rows, the data is destroyed and only uuid is tracked. In some cases we need to check the data of the deleted rows. This patch preserves data for deleted rows until track clear is called. Signed-off-by: Han Zhou --- lib/ovsdb-idl-provider.h | 2 ++

[ovs-dev] [PATCH v4 10/20] ovn-controller: port-binding incremental processing for physical flows

This patch implements change handler for port-binding in flow_output for physical flows computing, so that physical flow computing will be incremental. Signed-off-by: Han Zhou --- ovn/controller/ovn-controller.c | 95 ++- ovn/controller/physical.c | 106

[ovs-dev] [PATCH v4 09/20] ovn-controller: runtime_data change handler for SB port-binding

Evaluates change for SB port-binding in runtime_data node. If the port-binding change has no impact for the runtime_data it will not trigger runtime_data change. Signed-off-by: Han Zhou --- ovn/controller/binding.c| 91 + ovn/controller/binding.h

[ovs-dev] [PATCH v4 08/20] ovn-controller: Incremental logical flow processing

Implements change handler of flow_output for SB lflow changes. Signed-off-by: Han Zhou --- ovn/controller/lflow.c | 84 + ovn/controller/lflow.h | 18 + ovn/controller/ovn-controller.c | 76 -

[ovs-dev] [PATCH v4 06/20] ovn-controller: Track OVSDB changes

Track OVSDB changes for future patches of incremental processing Signed-off-by: Han Zhou --- ovn/controller/bfd.c| 4 ++-- ovn/controller/binding.c| 16 ovn/controller/encaps.c | 12 ++-- ovn/controller/ovn-controller.c | 22

[ovs-dev] [PATCH v4 05/20] ovn-controller: Incremental processing engine

This patch implements the engine which will be used in future patches for ovn-controller incremental processing. Signed-off-by: Han Zhou --- ovn/lib/automake.mk| 4 +- ovn/lib/inc-proc-eng.c | 201 + ovn/lib/inc-proc-eng.h | 240

[ovs-dev] [PATCH v4 04/20] ovsdb-idl.c: Track changes for table references.

If a change of a row is tracked, make sure the rows that reference this row are also added in tracked changes, unless change tracking is not required for those rows. Signed-off-by: Han Zhou --- lib/ovsdb-idl.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff

[ovs-dev] [PATCH v4 03/20] ovsdb-idlc.in: Support more interfaces for passing pointers of individual tables.

This is a follow-up patch for commit 0eb1e37c, to add more interfaces that supports passing around pointers of individual tables, which will be used in incremental processing. Signed-off-by: Han Zhou --- ovsdb/ovsdb-idlc.in | 25 + 1 file changed, 25 insertions(+) diff

[ovs-dev] [PATCH v4 02/20] ovsdb-idl.c: Update conditions when handling change tracking list.

There are places with the pattern: if (!ovs_list_is_empty(>track_node)) { ovs_list_remove(>track_node); } ovs_list_push_back(>table->track_list, >track_node); It seems to be trying to prevent double removing the node from a list, but actually it doesn't,

[ovs-dev] [PATCH v4 01/20] ovsdb-idl.c: Remove a misleading comment for change tracking.

The comment was added when the feature was introduced but what it described is not what is implemented, probably because of revisions after code reviews. Signed-off-by: Han Zhou --- lib/ovsdb-idl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/ovsdb-idl.c

[ovs-dev] [PATCH v4 00/20] ovn-controller incremental processing

ovn-controller currently recomputes everything when there are any changes of input, which leads to high CPU usages and slow in end-to-end flow enforcement in response to changes. It even wastes CPU to recompute flows for unrelated inputs such as pinctrl events. This patch series implements

Re: [ovs-dev] [PATCH v5 2/6] ipsec: reintroduce IPsec support for tunneling

On Tue, 7 Aug 2018 at 09:43, Qiuyu Xiao wrote: > > This patch reintroduces ovs-monitor-ipsec daemon that > was previously removed by commit 2b02d770 ("openvswitch: > Allow external IPsec tunnel management.") > > After this patch, there are no IPsec flavored tunnels anymore. > IPsec is enabled by