[ovs-dev] Several conntrack problems, including some critical bugs.

While developing application using ovs userspace conntrack, we found some bugs worth mention here. 1. conntrack_clean may causes ovs crash. conntrack_clean function iterators through all buckets, and free entries in the bucket with bucket lock, but when releasing a NAT connection, inside

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for master

Thanks Ian and Ben. Warm Regards, Vishal Ajmera > -Original Message- > From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Ben Pfaff > Sent: Tuesday, August 28, 2018 2:00 AM > To: Ian Stokes > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] OVS DPDK:

Re: [ovs-dev] [RFC patch v1] datapath: Fix builds on older kernels.

Good catch. Just like Greg said, it is so complex when doing back porting. Do you mind putting 3.19 in the travis.yaml? So that later on we can catch this kind of bug, thanks. Yifeng On Mon, Aug 27, 2018 at 7:34 PM Gregory Rose wrote: > > On 8/27/2018 7:19 PM, Darrell Ball wrote: > > On older

Re: [ovs-dev] [PATCH v2] debian: Move libovn out from package libopenvswitch.

Tested-by: aginwala wrote: > On Fri, Aug 24, 2018 at 06:07:24PM -0700, Han Zhou wrote: > > From: Han Zhou > > > > Since we are packaging OVN and OVS components separately, libovn > > shouldn't belong to OVS, so move it to ovn-common. Also, remove > > it from libopenvswitch-dev. > > > >

Re: [ovs-dev] [RFC patch v1] datapath: Fix builds on older kernels.

On 8/27/2018 7:19 PM, Darrell Ball wrote: On older kernels, for example 3.19, the function rt6_get_cookie() is not available and used with ipv6 config enabled; it was introduced in 4.2. Put back the replacement function if it does not exist. Interesting that builds on 3.16.57 but not 3.19. 

[ovs-dev] Sistemas de gestión ambiental

--- Este correo electrónico ha sido comprobado en busca de virus por AVG. http://www.avg.com

[ovs-dev] [RFC patch v1] datapath: Fix builds on older kernels.

On older kernels, for example 3.19, the function rt6_get_cookie() is not available and used with ipv6 config enabled; it was introduced in 4.2. Put back the replacement function if it does not exist. CC: Yifeng Sun Fixes: bf61b8b1c1db ("datapath: Add support for kernel 4.16.x & 4.17.x.")

Re: [ovs-dev] [PATCH 3/4] ofp-port: Fix leak on error path in parse_intel_port_custom_property().

It seems (struct ofputil_port_stats).custom_stats.counters is still leaked by the below code path even after this fix. parse_intel_port_custom_property <- ofputil_pull_ofp14_port_stats <- ofputil_decode_port_stats <- ofputil_count_port_stats I created a diff, how do you like it? Thanks. diff

Re: [ovs-dev] [PATCH 2/4] nx-match: Avoid double-free on some error paths.

Looks good to me, thanks for the fix. Reviewed-by: Yifeng Sun On Fri, Aug 24, 2018 at 2:50 PM Ben Pfaff wrote: > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9966 > Reported-at > : >

Re: [ovs-dev] [PATCH] dpctl: Fix memory leak in dp_exists().

oops; good catch. On 8/27/18, 9:08 AM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: On Mon, Aug 27, 2018 at 07:52:55PM +0800, wangyunjian wrote: > From: Yunjian Wang > > Fixes: ffdcd110fa62 ("dpctl: Make opt_dpif_open() more general.") > Signed-off-by:

Re: [ovs-dev] OVN/OVS split: OVN mailing list?

> On Aug 10, 2018, at 10:52 AM, Mark Michelson wrote: > > A topic that's come up from time to time for a while now is splitting OVN out > of the OVS source and into a separate project. Based on discussions in recent > OVN IRC meetings, it seems like this will start actually happening

Re: [ovs-dev] [PATCH] datapath-windows: Add support to configure ct zone limits

Hi Sairam, Thanks for the review, please find my response inline. I send out a v2 addressing review comments. Regards, Anand Kumar On 8/24/18, 2:58 PM, "Sairam Venugopal" wrote: Hi Anand, Thanks for the patch. See comments inline. Thanks, Sairam On 8/21/18,

Re: [ovs-dev] [PATCH] datapath-windows: Add support to configure ct zone limits

Hi Shashank, Thanks for reviewing the patch. Please find response inline. Regards, Anand Kumar On 8/27/18, 9:00 AM, "Shashank Ram" wrote: On 08/21/2018 02:57 PM, Anand Kumar wrote: > This patch implements limiting conntrack entries > per zone using dpctl commands. >

Re: [ovs-dev] [branch 2.9] ovn: Fix the issue in IPv6 Neigh Solicitation responder for router IPs

On Tue, Aug 28, 2018 at 02:01:07AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > Commit [1] added a new action 'nd_na_router' to set the router bit > in the 'flags' field of the Neighbour Adv packet for router IPs. > This action was used in the router pipeline. But the logical

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.10

On Mon, Aug 27, 2018 at 08:17:37PM +0100, Ian Stokes wrote: > Hi Ben, > > The following changes since commit 052602d269480c69007bea771ebb8beffc2e377c: > > ovn-northd: Support learning neighbor from ARP request. (2018-08-27 > 09:50:28 -0700) > > are available in the git repository at: > >

Re: [ovs-dev] [PATCH v2] ovn: Fix the issue in IPv6 Neigh Solicitation responder for router IPs

On Tue, Aug 28, 2018 at 12:12 AM Ben Pfaff wrote: > On Mon, Aug 27, 2018 at 11:01:50PM +0530, Numan Siddique wrote: > > On Mon, Aug 27, 2018, 9:53 PM Ben Pfaff wrote: > > > Thanks, applied to master and branch-2.10. > > > > Thanks Ben and Han. Can this be applied to branch 2.9 as well ? > >

[ovs-dev] [branch 2.9] ovn: Fix the issue in IPv6 Neigh Solicitation responder for router IPs

From: Numan Siddique Commit [1] added a new action 'nd_na_router' to set the router bit in the 'flags' field of the Neighbour Adv packet for router IPs. This action was used in the router pipeline. But the logical switch pipeline also adds the Neighbour Adv flows for router IPs but with 'nd_na'

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for master

On Mon, Aug 27, 2018 at 08:17:25PM +0100, Ian Stokes wrote: > Hi Ben, > > The following changes since commit 418a7a84245f5fbe589dd1267463fc9ba27a1dd6: > > ofproto-dpif-trace: Make -generate send packets to controller again. > (2018-08-27 09:35:21 -0700) > > are available in the git repository

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.10

Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Too many signoffs; are you missing Co-authored-by lines? Lines checked: 401, Warnings: 0,

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.7

Hi Ben, The following changes since commit 576a2011a2872bf0f05ae19cf20425f88c837999: netdev-linux: Avoid division by 0 if kernel reports bad scheduler data. (2018-08-20 09:31:06 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_7 for you to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.8

Hi Ben, The following changes since commit f860e9ec5b009d836de6211510b17ebe2b894ef1: netdev-linux: Avoid division by 0 if kernel reports bad scheduler data. (2018-08-20 09:31:00 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_8 for you to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.9

Hi Ben, The following changes since commit 9b2b68660e9a939a82e9142f25ba0f7942188925: ovn-northd: Support learning neighbor from ARP request. (2018-08-27 09:51:21 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_9 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.10

Hi Ben, The following changes since commit 052602d269480c69007bea771ebb8beffc2e377c: ovn-northd: Support learning neighbor from ARP request. (2018-08-27 09:50:28 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_10 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for master

Hi Ben, The following changes since commit 418a7a84245f5fbe589dd1267463fc9ba27a1dd6: ofproto-dpif-trace: Make -generate send packets to controller again. (2018-08-27 09:35:21 -0700) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge for you to fetch

Re: [ovs-dev] [PATCH v2] ovn: Fix the issue in IPv6 Neigh Solicitation responder for router IPs

On Mon, Aug 27, 2018 at 11:01:50PM +0530, Numan Siddique wrote: > On Mon, Aug 27, 2018, 9:53 PM Ben Pfaff wrote: > > Thanks, applied to master and branch-2.10. > > Thanks Ben and Han. Can this be applied to branch 2.9 as well ? There's a merge conflict in tests/ovn.at. Would you mind sending a

Re: [ovs-dev] [PATCH v2] ovn: Fix the issue in IPv6 Neigh Solicitation responder for router IPs

On Mon, Aug 27, 2018, 9:53 PM Ben Pfaff wrote: > On Fri, Aug 24, 2018 at 02:11:05PM -0700, Han Zhou wrote: > > On Fri, Aug 24, 2018 at 12:27 PM wrote: > > > > > > From: Numan Siddique > > > > > > Commit [1] added a new action 'nd_na_router' to set the router bit > > > in the 'flags' field of

Re: [ovs-dev] [PATCH 1/2] ovn-northd: LR respond ARP from valid subnet only.

On Tue, Aug 21, 2018 at 04:24:27PM -0700, Han Zhou wrote: > On Tue, Aug 21, 2018 at 3:38 PM Ben Pfaff wrote: > > > > On Tue, Aug 21, 2018 at 03:03:16PM -0700, Han Zhou wrote: > > > On Tue, Aug 21, 2018 at 11:36 AM Ben Pfaff wrote: > > > > > > > > On Sun, Aug 19, 2018 at 10:27:30PM -0700, Han

Re: [ovs-dev] [PATCH v2] debian: Move libovn out from package libopenvswitch.

On Fri, Aug 24, 2018 at 06:07:24PM -0700, Han Zhou wrote: > From: Han Zhou > > Since we are packaging OVN and OVS components separately, libovn > shouldn't belong to OVS, so move it to ovn-common. Also, remove > it from libopenvswitch-dev. > > Signed-off-by: Han Zhou This is one where I'd

Re: [ovs-dev] [PATCH] ofproto-dpif-trace: Make -generate send packets to controller again.

On Fri, Aug 24, 2018 at 01:30:24PM -0700, Justin Pettit wrote: > > > On Aug 24, 2018, at 12:25 PM, Ben Pfaff wrote: > > > > +/* Copies ODP actions from 'in' (with length 'size') to 'out', dropping > > + * OVS_ACTION_ATTR_OUTPUT along the way. */ > > +static void > > +prune_output_actions(const

Re: [ovs-dev] [PATCH v2] ovn: Fix the issue in IPv6 Neigh Solicitation responder for router IPs

On Fri, Aug 24, 2018 at 02:11:05PM -0700, Han Zhou wrote: > On Fri, Aug 24, 2018 at 12:27 PM wrote: > > > > From: Numan Siddique > > > > Commit [1] added a new action 'nd_na_router' to set the router bit > > in the 'flags' field of the Neighbour Adv packet for router IPs. > > This action was

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

I can help with some of these. On Mon, Aug 27, 2018 at 04:05:39PM +, Ophir Munk wrote: > Ian, can you please specify the practical steps regarding the new branches? > Specifically, what is the procedure for adding a new patch for either of the > branches (OVS DPDK latest or HWOK)? > 1. What

Re: [ovs-dev] [PATCH] dpctl: Fix memory leak in dp_exists().

On Mon, Aug 27, 2018 at 07:52:55PM +0800, wangyunjian wrote: > From: Yunjian Wang > > Fixes: ffdcd110fa62 ("dpctl: Make opt_dpif_open() more general.") > Signed-off-by: Yunjian Wang Thanks, applied to master and branch-2.10. ___ dev mailing list

Re: [ovs-dev] OVS DPDK Latest & HWOL Branches

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Stokes, Ian > Sent: Tuesday, August 21, 2018 11:26 AM > To: Ben Pfaff ; Justin Pettit > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] OVS DPDK Latest & HWOL

Re: [ovs-dev] [PATCH] datapath-windows: Add support to configure ct zone limits

On 08/21/2018 02:57 PM, Anand Kumar wrote: This patch implements limiting conntrack entries per zone using dpctl commands. Example: ovs-appctl dpctl/ct-set-limits default=5 zone=1,limit=2 zone=1,limit=3 ovs-appctl dpct/ct-del-limits zone=4 ovs-appctl dpct/ct-get-limits zone=1,2,3 - Also

Re: [ovs-dev] [PATCH V2] ofproto-dpif: Check for EBUSY as well

On Fri, Aug 24, 2018 at 01:36:29PM -0700, Greg Rose wrote: > Guru reported that we can't create more than one geneve tunnel. > Sometimes a driver will return EBUSY as well as EEXIST for some > duplicate configurations. Check for EBUSY too. > > Fixes: 7521e0cf9e ("ofproto-dpif: Let the dpif

Re: [ovs-dev] [PATCH] oss-fuzz: Move oss-fuzz test harnesses and fuzzer configs to ovs source repo

I am just pointing out that there was a change. No action is required on your part. Sorry for the confusion. Regards, Bhargava On 08/27/2018 05:43 PM, Ben Pfaff wrote: > Do you mean that we should change the name in OVS? Or are you just > pointing out that it changed? > > Thanks, > > Ben. >

Re: [ovs-dev] [PATCH] oss-fuzz: Move oss-fuzz test harnesses and fuzzer configs to ovs source repo

Do you mean that we should change the name in OVS? Or are you just pointing out that it changed? Thanks, Ben. On Mon, Aug 27, 2018 at 04:50:35PM +0200, Bhargava Shastry wrote: > Minor change in naming: Now, the fuzzer binaries are called $name_target > instead of $name_fuzzer > > On

Re: [ovs-dev] [PATCH v3 1/1] netdev-vport: reject concomitant incompatible tunnels

On 11 Jul 2018, at 10:01, Eelco Chaudron wrote: On 10 Jul 2018, at 23:45, Ben Pfaff wrote: Does this support the case where, in a single database transaction, a GBP VXLAN tunnel is removed and a non-GBP VXLAN tunnel is created that would otherwise interfere with one another (and the

Re: [ovs-dev] Regarding OVS Datapath Flow !

On 8/27/2018 5:09 AM, rakesh kumar wrote: Hi Team, I am was trying to put log in the datapath module in Linux environment to trace the flow if we ping one host to another host using ovs switch(using mininet emulator).. Inside *vport.c* file *ovs_vport_send *function is being called and then

Re: [ovs-dev] [PATCH v3 1/2] dpif-netdev: Add round-robin based rxq to pmd assignment.

On 27.08.2018 17:19, Kevin Traynor wrote: > On 08/27/2018 02:30 PM, Ilya Maximets wrote: >> On 25.08.2018 13:00, Kevin Traynor wrote: >>> Prior to OVS 2.9 automatic assignment of Rxqs to PMDs >>> (i.e. CPUs) was done by round-robin. >>> >>> That was changed in OVS 2.9 to ordering the Rxqs based on

Re: [ovs-dev] [PATCH] oss-fuzz: Move oss-fuzz test harnesses and fuzzer configs to ovs source repo

Minor change in naming: Now, the fuzzer binaries are called $name_target instead of $name_fuzzer On 08/27/2018 04:49 PM, Bhargava Shastry wrote: > Thanks. The new oss-fuzz scripts for fetching, building and fuzzing OvS > is upstream > >

Re: [ovs-dev] [PATCH] oss-fuzz: Move oss-fuzz test harnesses and fuzzer configs to ovs source repo

Thanks. The new oss-fuzz scripts for fetching, building and fuzzing OvS is upstream https://github.com/google/oss-fuzz/tree/master/projects/openvswitch On 08/24/2018 10:05 PM, Ben Pfaff wrote: > Thanks. Applied to master. > > On Wed, Aug 22, 2018 at 03:09:26PM +0200, Bhargava Shastry wrote: >>

Re: [ovs-dev] [PATCH v3 1/2] dpif-netdev: Add round-robin based rxq to pmd assignment.

On 08/27/2018 02:30 PM, Ilya Maximets wrote: > On 25.08.2018 13:00, Kevin Traynor wrote: >> Prior to OVS 2.9 automatic assignment of Rxqs to PMDs >> (i.e. CPUs) was done by round-robin. >> >> That was changed in OVS 2.9 to ordering the Rxqs based on >> their measured processing cycles. This was to

Re: [ovs-dev] [PATCH 2/2] vswitch.xml: Fix type of dpdk-init key.

> On 08/24/2018 04:18 PM, Ilya Maximets wrote: > > This adds available modes to the man page. > > > > CC: Kevin Traynor > > Fixes: 6d947d508a51 ("vswitch.xml: Update dpdk-init documentation.") > > Signed-off-by: Ilya Maximets > > Thanks for catching here and in roundrobin patch. > > Acked-by:

Re: [ovs-dev] [PATCH 1/2] vswitch.xml: Fix key type and description style of tc-policy.

On Fri, Aug 24, 2018 at 06:13:19PM +0300, Ilya Maximets wrote: > The set of supported values specified. > Style fixed to look good in man page. Fixed indents. > > CC: Paul Blakey > Fixes: 691d20cbdcf3 ("other-config: Add tc-policy switch to > control tc flower flag") >

[ovs-dev] Regarding OVS Datapath Flow !

Hi Team, I am was trying to put log in the datapath module in Linux environment to trace the flow if we ping one host to another host using ovs switch(using mininet emulator).. Inside *vport.c* file *ovs_vport_send *function is being called and then internally it calls *vport->ops->send*()

[ovs-dev] [PATCH] dpctl: Fix memory leak in dp_exists().

From: Yunjian Wang Fixes: ffdcd110fa62 ("dpctl: Make opt_dpif_open() more general.") Signed-off-by: Yunjian Wang --- lib/dpctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/dpctl.c b/lib/dpctl.c index 743944d..2f8498f 100644 --- a/lib/dpctl.c +++ b/lib/dpctl.c @@ -202,6 +202,8 @@

Re: [ovs-dev] [PATCH v2 6/6] system-dpdk: Execute testpmd on the background

On 8/22/2018 2:37 PM, Aaron Conole wrote: From: Bala Sankaran This adds a new test to the 'check-dpdk' subsystem that will exercise allocations, PMDs, and the vhost-user code path. Signed-off-by: Bala Sankaran Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole ---

Re: [ovs-dev] [PATCH v2 5/6] system-dpdk: Convert /tmp to use OVS_RUNDIR

On 8/22/2018 2:37 PM, Aaron Conole wrote: From: Bala Sankaran When multiple users run the DPDK testsuite ther dependence on /tmp Minor typo above 'ther' -> 'their' Ian will cause conflicts. Use the RUNDIR as a dynamic path to overcome this. NOTE: This still doesn't solve the dependency on

Re: [ovs-dev] [PATCH v2 3/6] system-dpdk: Allow running the dpdk tests from a VM

On 8/22/2018 2:37 PM, Aaron Conole wrote: Some VM configurations result in CPU flags that cause warnings to be issued by the DPDK libraries. When these warnings are issued, the tests will fail. This commit adds the unreliable tsc warning to the list of ignored warnings. LGTM, tested and no

Re: [ovs-dev] [PATCH v2 4/6] system-dpdk: Use a different character marker for sed commands

On 8/22/2018 2:37 PM, Aaron Conole wrote: The default marker for sed commands according to the manual is /, but this is inconvenient when working with paths. The solution is either to escape all instances of / or use sed's \cREGEXc feature. LGTM, Ian Signed-off-by: Aaron Conole ---

Re: [ovs-dev] [PATCH v2 2/6] system-dpdk: skip all tests if there are no hugepages

On 8/22/2018 2:37 PM, Aaron Conole wrote: From: Bala Sankaran A failure is quite harsh in this scenario. It's better to simply skip all the tests and let the user look at the logs to understand the missing hugepages. This is ok, again however I'd like to see the expected behavior called

Re: [ovs-dev] [PATCH v2 1/6] system-dpdk: update test suite for non-phy testing

On 8/22/2018 2:37 PM, Aaron Conole wrote: This allows a system that doesn't have a dedicated DPDK nic to execute some DPDK tests. In this fashion, tests that operate on virtual ports (such as dpdkvhostuserclient) can be executed in a wider set of environments. Overall I think this approach is

Re: [ovs-dev] OVN/OVS split: OVN mailing list?

Hi, Is there any progress on this ? Cheers, Lucas On Mon, Aug 13, 2018 at 1:43 PM Miguel Angel Ajo Pelayo wrote: > > +1 on my side too :) Thank you for bringing up the topic > > On Mon, Aug 13, 2018 at 2:03 PM Daniel Alvarez Sanchez > wrote: >> >> +1 for the split of the ML >> >> On Mon, Aug

Re: [ovs-dev] [PATCH v3 2/2] NEWS: Add entry for pmd-rxq-assign.

Acked-by: Eelco Chaudron On 25 Aug 2018, at 12:00, Kevin Traynor wrote: > Signed-off-by: Kevin Traynor > --- > NEWS | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index 33b4d8a..33b3638 100644 > --- a/NEWS > +++ b/NEWS > @@ -9,5 +9,7 @@ Post-v2.10.0

Re: [ovs-dev] [PATCH v3 1/2] dpif-netdev: Add round-robin based rxq to pmd assignment.

On 25 Aug 2018, at 12:00, Kevin Traynor wrote: Prior to OVS 2.9 automatic assignment of Rxqs to PMDs (i.e. CPUs) was done by round-robin. That was changed in OVS 2.9 to ordering the Rxqs based on their measured processing cycles. This was to assign the busiest Rxqs to different PMDs,