Re: [ovs-dev] [PATCH 1/2] ovn-ctl: Allow passing ssl certs when starting OVN DBs in ssl mode.

Thanks for the review Han. Please find the comments inline below: On Thu, Oct 4, 2018 at 9:58 AM Han Zhou wrote: > Thanks Ali, please see my comments below > > On Fri, Sep 21, 2018 at 5:34 PM wrote: > > > > For OVN DBs to work with SSL in HA, we need to have capability to > > pass ssl certs

Re: [ovs-dev] [PATCH 2/2] ovndb-servers.ocf: Add ssl support for managing OVN DB resources with pacemaker using LB VIP.

Thanks for the review Han. Please find the comments inline below: On Thu, Oct 4, 2018 at 10:16 AM Han Zhou wrote: > Thanks Ali, please see my comm > > On Fri, Sep 21, 2018 at 5:38 PM wrote: > > > > When starting OVN DBs in HA using pacemaker with ssl, we need to pass > ssl > > certs for

Re: [ovs-dev] [PATCH] Python: Make Row's __getattr__ less error prone

On Fri, Oct 05, 2018 at 04:31:07PM +0100, lucasago...@gmail.com wrote: > From: Lucas Alvares Gomes > > Calling getattr() on a Row object after invoking delkey() with a value > that does not exist in the object will cause getattr() to fail with a > KeyError error. For example: > > Oct 05

Re: [ovs-dev] [PATCH v2 0/2] Add nanosecond resolution PCAP support

On Fri, Oct 05, 2018 at 12:52:38PM -0400, Mark Michelson wrote: > PCAP files can support nanosecond resolution instead of microsecond > resolution in timestamps. It indicates this is in effect in the header > of the file in the magic number. Without these patches we'll think that > the pcap file

Re: [ovs-dev] [PATCH v2] dpif-netlink: don't allocate per thread netlink sockets

On Fri, Oct 5, 2018 at 11:27 PM Guru Shetty wrote: > I get a segfault with this patch with the following backtrace. I have not > investigated. > > Program received signal SIGSEGV, Segmentation fault. > nl_sock_pid (sock=0x0) at lib/netlink-socket.c:1424 > 1424 return sock->pid; > (gdb) where

Re: [ovs-dev] [PATCH v2 2/2] windows, ovn-nbctl: Add service_start call inside the server loop

On Fri, Oct 05, 2018 at 05:59:41PM +0300, Alin Gabriel Serdean wrote: > > > > On 3 Oct 2018, at 01:37, Ben Pfaff wrote: > > > > On Tue, Oct 02, 2018 at 06:01:26PM +0300, Alin Gabriel Serdean wrote: > >> Currently all ovn-nbctl (daemon) tests are failing due to the missing > >> call to

Re: [ovs-dev] [PATCH v2] dpif-netlink: don't allocate per thread netlink sockets

Reproduction looks to be easy. I just need to use the kernel module from OVS repo and run 'ovs-vswitchd --pidfile'. If I do a 'ovs-vsctl add-br br0', ovs-vswitchd will segfault. I do see the the following message in ovs-vswitchd log: 2018-10-05T12:39:19Z|4|netlink_socket|INFO|netlink: could

Re: [ovs-dev] [PATCH v2] dpif-netlink: don't allocate per thread netlink sockets

On Tue, 25 Sep 2018 at 01:51, Matteo Croce wrote: > When using the kernel datapath, OVS allocates a pool of sockets to handle > netlink events. The number of sockets is: ports * n-handler-threads, where > n-handler-threads is user configurable and defaults to 3/4*number of cores. > > This

Re: [ovs-dev] [PATCH] odp-util: Fix a use-afer-free bug

This patch should also fix the bug reported at https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10802 On Fri, Oct 5, 2018 at 2:50 PM Yifeng Sun wrote: > After ofpbug_put, actions may have been reallocated and > key will point to invalid memory address. > > Reported-at:

[ovs-dev] [PATCH 2/2] ovn-nbctl: Don't parse table-formatting options in nbctl_client

When ovn-nbctl is running in daemon mode, nbctl_client attempts to parse table formatting options. The problem is that this then removes the table formatting options from the array of options passed to the server loop. The server loop resets the table formatting options to the defaults and then

[ovs-dev] [PATCH 1/2] table: Create method for resetting table formatting.

Table formatting has a local static integer that is intended to insert line breaks between tables. This works exactly as intended, as long as each call to table_format() is done as a single unit within the run of a process. When ovn-nbctl is run in daemon mode, it is a long-running process that

[ovs-dev] [PATCH 0/2] Fix ovn-nbctl daemon table printing issues.

ovn-nbctl when run in daemon mode has two issues: 1) An extra newline is prepended to table output 2) Table formatting issues are ignored. This patch series fixes both issues. Mark Michelson (2): table: Create method for resetting table formatting. ovn-nbctl: Don't parse table-formatting

[ovs-dev] [PATCH v3] extend-table: Fix a bug that iterates wrong table

This seems to be a copy and paste bug that iterates and frees the wrong table. This commit fixes that. Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10730 Co-authored-by: Ben Pfaff Signed-off-by: Yifeng Sun Signed-off-by: Ben Pfaff --- v1->v2: Fix email subject by adding

[ovs-dev] [PATCH] odp-util: Fix a use-afer-free bug

After ofpbug_put, actions may have been reallocated and key will point to invalid memory address. Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10796 Signed-off-by: Yifeng Sun --- lib/odp-util.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

Re: [ovs-dev] ossfuzz: Speed up flow extract fuzzing by refactoring

Bhargava Shastry writes: > Hello, > > I can take a look at these on Monday. In any case, they look easily fixable. > > P.S. I wonder why the build bot did not complain on the exact same > code that has now been refactored out of flow_extract_target.c. As far > as I can remember, that code also

Re: [ovs-dev] [PATCH] Add basic PG commands.

On 10/04/2018 06:08 PM, Han Zhou wrote: On Wed, Oct 3, 2018 at 2:14 PM Mark Michelson > wrote: > > Signed-off-by: Mark Michelson > > --- >  ovn/utilities/ovn-nbctl.8.xml | 22 + >  ovn/utilities/ovn-nbctl.c     | 72

Re: [ovs-dev] [PATCH v2] ovn: Fix IPv6 DAD failure for container ports

On Fri, 5 Oct 2018 at 07:35, wrote: > From: Numan Siddique > > When a container port is created inside a VM, the below kernel message > is seen and IPv6 doesn't work on that interface. > > [ 138.000753] IPv6: vlan4: IPv6 duplicate address detected! > > When a container port sends a ethernet

Re: [ovs-dev] [PATCH v5 11/20] ovn-controller: incremental processing for multicast group changes

On Mon, Aug 13, 2018 at 10:48 AM Han Zhou wrote: > > This patch handles SB Multicast_Group table changes incrementally. > The Multicast_Group table changes can be triggered by creating/deleting > a lport of a lswitch. It can be also triggered indirectly by an > updating of a port-binding which is

[ovs-dev] Zyxel Users list

Hello there, I would like to know if you are interested in acquiring Zyxel Users list. Information fields: Names, Title, Email, Phone, Company Name, Company URL, Company physical address, SIC Code, Industry, Company Size (Revenue and Employee), LinkedIn profile link and kind of technology

[ovs-dev] [PATCH] ovsdb-idl.c: Increase seqno for change-tracking of table references.

From: Han Zhou This is an enhancement for commit: 102781c ovsdb-idl: Track changes for table references. The seqno change is needed so that the change-tracking helper function ..._is_new() can work properly. Signed-off-by: Han Zhou --- lib/ovsdb-idl.c | 3 +++ 1 file changed, 3 insertions(+)

[ovs-dev] [PATCH 2/2] ovn: Support a new Logical_Switch_Port.type - 'external'

From: Numan Siddique In the case of OpenStack + OVN, when the VMs are booted on hypervisors supporting SR-IOV nics, there are no OVS ports for these VMs. When these VMs sends DHCPv4, DHPCv6 or IPv6 Router Solicitation requests, the local ovn-controller cannot reply to these packets. OpenStack

[ovs-dev] [PATCH 1/2] ovn: Avoid tunneling for VLAN packets redirected to a gateway chassis

From: Numan Siddique An OVN deployment can have multiple logical switches each with a localnet port connected to a distributed logical router with one logical router port providing external connectivity (provider network) and others used as tenant networks with VLAN tagging. As reported in [1],

[ovs-dev] [PATCH 0/2] Addressing VLAN tenant network issues and add

From: Numan Siddique Patch 1 addresses the VLAN tenant network issue. An OVN deployment can have multiple logical switches each with a localnet port connected to a distributed logical router with one logical router port providing external connectivity (provider network) and others used as

[ovs-dev] [PATCH v3] OVN: add buffering support for ip packets

Add buffering support for IPv4/IPv6 packets that will be processed by arp{}/nd_ns{} action when L2 address is not discovered yet since otherwise the packet will be substituted with an ARP/Neighbor Solicitation frame and this will result in the lost of the first packet of the connection. Moreover

[ovs-dev] [PATCH v2 2/2] pcap-file: Add nanosecond resolution pcap support.

PCAP header magic numbers are different for microsecond and nanosecond resolution timestamps. This patch adds support for understanding the difference and reporting the time correctly with ovs_pcap_read(). When writing pcap files, OVS will always use microsecond resolution, so no new calculations

[ovs-dev] [PATCH v2 1/2] ovs-pcap: Support nanosecond resolution pcap files.

pcap files with nanosecond resolution use a different magic number in the pcap header than those with microsecond resolution. Signed-off-by: Mark Michelson --- utilities/ovs-pcap.in | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/utilities/ovs-pcap.in

[ovs-dev] [PATCH v2 0/2] Add nanosecond resolution PCAP support

PCAP files can support nanosecond resolution instead of microsecond resolution in timestamps. It indicates this is in effect in the header of the file in the magic number. Without these patches we'll think that the pcap file is invalid if it is using nanosecond resolution. Mark Michelson (2):

Re: [ovs-dev] ossfuzz: Speed up flow extract fuzzing by refactoring

Hello, I can take a look at these on Monday. In any case, they look easily fixable. P.S. I wonder why the build bot did not complain on the exact same code that has now been refactored out of flow_extract_target.c. As far as I can remember, that code also used asserts. On October 5, 2018

Re: [ovs-dev] [PATCH v10 05/14] dp-packet: Fix data_len handling multi-seg mbufs.

On Fri, Oct 05, 2018 at 03:50:46PM +0100, Lam, Tiago wrote: > On 03/10/2018 19:26, Flavio Leitner wrote: > > On Fri, Sep 28, 2018 at 05:15:06PM +0100, Tiago Lam wrote: > >> When a dp_packet is from a DPDK source, and it contains multi-segment > >> mbufs, the data_len is not equal to the packet

Re: [ovs-dev] [PATCH v2 0/3] add buffering support for IP packets

> On Tue, Oct 02, 2018 at 03:59:11PM +0200, Lorenzo Bianconi wrote: > > Add buffering support for IP traffic that will be processed > > by neighboring subsystem (arp{} or nd_ns{} actions) since this > > will result in the lost of the first packet of the connection > > Thanks for the revision. >

[ovs-dev] [PATCH] ofp-packet: Fix NXT_RESUME with geneve tunnel metadata

The patch address vswitchd crash when it receives NXT_RESUME with geneve tunnel metadata. The crash is due to segmentation fault with the following stack trace, and it is observed only in kernel datapath. A test is added to prevent regression. Thread 1 "ovs-vswitchd" received signal SIGSEGV,

[ovs-dev] [PATCH] Python: Make Row's __getattr__ less error prone

From: Lucas Alvares Gomes Calling getattr() on a Row object after invoking delkey() with a value that does not exist in the object will cause getattr() to fail with a KeyError error. For example: Oct 05 14:59:28 neutron-server[28435]: File

Re: [ovs-dev] [PATCH v2 2/2] windows, ovn-nbctl: Add service_start call inside the server loop

> On 3 Oct 2018, at 01:37, Ben Pfaff wrote: > > On Tue, Oct 02, 2018 at 06:01:26PM +0300, Alin Gabriel Serdean wrote: >> Currently all ovn-nbctl (daemon) tests are failing due to the missing >> call to `service_start` which is required on Windows. >> >> Windows lacks fork so we need to pass

[ovs-dev] [PATCH v3 2/2] windows: Add set_detach function to daemon-windows.c

The daemon-windows file is missing a `set_detach` routine, so add it. This will be useful in the long run. Signed-off-by: Alin Gabriel Serdean Acked-by: Ben Pfaff --- v3: no change. v2: Fix typo in title, add Ack --- lib/daemon-windows.c | 10 +- lib/daemon.h | 3 +++ 2 files

[ovs-dev] [PATCH v3 1/2] windows, ovn-nbctl: Add service_start call inside the server loop

Currently all ovn-nbctl (daemon) tests are failing due to the missing call to `service_start` which is required on Windows. Windows lacks fork so we need to pass all arguments, so we can spawn a new process and interpret it properly when calling `service_start`. Signed-off-by: Alin Gabriel

Re: [ovs-dev] [PATCH v10 11/14] netdev-dpdk: support multi-segment jumbo frames

On 03/10/2018 19:27, Flavio Leitner wrote: > On Fri, Sep 28, 2018 at 05:15:12PM +0100, Tiago Lam wrote: >> From: Mark Kavanagh >> >> Currently, jumbo frame support for OvS-DPDK is implemented by >> increasing the size of mbufs within a mempool, such that each mbuf >> within the pool is large

Re: [ovs-dev] [PATCH v10 09/14] dp-packet: Add support for data "linearization".

On 03/10/2018 19:26, Flavio Leitner wrote: > > Hi Tiago, > > There is a lot to digest in this patch, so I only have a general > comment about it for now. > > See below. > > On Fri, Sep 28, 2018 at 05:15:10PM +0100, Tiago Lam wrote: >> Previous commits have added support to the dp_packet API to

Re: [ovs-dev] [PATCH v10 10/14] netdev-dpdk: copy large packet to multi-seg. mbufs

On 03/10/2018 19:27, Flavio Leitner wrote: > On Fri, Sep 28, 2018 at 05:15:11PM +0100, Tiago Lam wrote: >> From: Mark Kavanagh >> >> Currently, packets are only copied to a single segment in the function >> dpdk_do_tx_copy(). This could be an issue in the case of jumbo frames, >> particularly

Re: [ovs-dev] [PATCH v10 08/14] dp-packet: copy data from multi-seg. DPDK mbuf

On 03/10/2018 19:26, Flavio Leitner wrote: > On Fri, Sep 28, 2018 at 05:15:09PM +0100, Tiago Lam wrote: >> From: Michael Qiu >> >> When doing packet clone, if packet source is from DPDK driver, >> multi-segment must be considered, and copy the segment's data one by >> one. >> >> Also, lots of

Re: [ovs-dev] [PATCH v10 05/14] dp-packet: Fix data_len handling multi-seg mbufs.

On 03/10/2018 19:26, Flavio Leitner wrote: > On Fri, Sep 28, 2018 at 05:15:06PM +0100, Tiago Lam wrote: >> When a dp_packet is from a DPDK source, and it contains multi-segment >> mbufs, the data_len is not equal to the packet size, pkt_len. Instead, >> the data_len of each mbuf in the chain

Re: [ovs-dev] [PATCH v10 01/14] netdev-dpdk: fix mbuf sizing

On 03/10/2018 19:25, Flavio Leitner wrote: > > Hi Tiago, > > Thanks for working on this. This is my first pass trying to wrap my head > around the whole thing, so I may have missed something. > > See below. > > On Fri, Sep 28, 2018 at 05:15:02PM +0100, Tiago Lam wrote: >> From: Mark Kavanagh

[ovs-dev] [PATCH v2] ovn: Fix IPv6 DAD failure for container ports

From: Numan Siddique When a container port is created inside a VM, the below kernel message is seen and IPv6 doesn't work on that interface. [ 138.000753] IPv6: vlan4: IPv6 duplicate address detected! When a container port sends a ethernet broadcast packet, OVN delivers the same packet back

Re: [ovs-dev] ossfuzz: Speed up flow extract fuzzing by refactoring

Bleep bloop. Greetings Bhargava Shastry, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #585 FILE:

[ovs-dev] [PATCH] ossfuzz: Speed up flow extract fuzzing by refactoring

From: Bhargava Shastry Refactor miniflow tests out of flow_extract_target.c into a new target called miniflow_target.c The biggest motivation for this massive (7-10x) increase in fuzzing speed. Prior to the refactoring, we were doing roughly 900 executions per second on flow_extract_target.

Re: [ovs-dev] [PATCH] ovn: Fix IPv6 DAD failure for child ports

On Fri, Oct 5, 2018 at 2:32 AM Guru Shetty wrote: > > > On Thu, 4 Oct 2018 at 13:29, Numan Siddique wrote: > >> >> Thanks for the review Guru. >> >> Please see below for the comments. >> >> >> >> On Fri, Oct 5, 2018 at 12:09 AM Guru Shetty wrote: >> >>> >>> >>> On Mon, 17 Sep 2018 at 02:24,

Re: [ovs-dev] [PATCH v2] dpif-netlink: don't allocate per thread netlink sockets

On 05/10/2018 09:55, Matteo Croce wrote: > On Fri, Oct 5, 2018 at 8:32 AM Markos Chandras wrote: >> >> On 25/09/2018 22:14, Ben Pfaff wrote: >>> >>> Applied to master thanks! >>> >>> I sent a patch to remove support for multiple queues in the >>> infrastructure layer: >>>

Re: [ovs-dev] [PATCH v2] dpif-netlink: don't allocate per thread netlink sockets

On Fri, Oct 5, 2018 at 8:32 AM Markos Chandras wrote: > > On 25/09/2018 22:14, Ben Pfaff wrote: > > > > Applied to master thanks! > > > > I sent a patch to remove support for multiple queues in the > > infrastructure layer: > > https://patchwork.ozlabs.org/patch/974755/ > >

Re: [ovs-dev] [PATCH v2] dpif-netlink: don't allocate per thread netlink sockets

On 25/09/2018 22:14, Ben Pfaff wrote: > > Applied to master thanks! > > I sent a patch to remove support for multiple queues in the > infrastructure layer: > https://patchwork.ozlabs.org/patch/974755/ > ___ > dev mailing list >