[ovs-dev] [patch v1 2/2] odp-util: Keep address santizer happy.

2018-12-17 Thread Darrell Ball
An address santizer false positive. Signed-off-by: Darrell Ball --- lib/odp-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/odp-util.c b/lib/odp-util.c index 1e8c5f1..2326a59 100644 --- a/lib/odp-util.c +++ b/lib/odp-util.c @@ -5173,7 +5173,7 @@

Re: [ovs-dev] [PATCH] datapath: compat: Fix static key backport

2018-12-17 Thread Gregory Rose
On 12/14/2018 3:28 PM, Yi-Hung Wei wrote: The original static key backport is based on the upstream net-next commit 11276d5306b8 ("locking/static_keys: Add a new static_key interface"). However, in Canonical's Trusty kernel, it introduced partial static support which have different definition

[ovs-dev] [patch v1 1/2] conntrack: Keep address santizer happy.

2018-12-17 Thread Darrell Ball
An address santizer false positive. Signed-off-by: Darrell Ball --- lib/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 7b5a3f0..6f6021a 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -3177,7 +3177,7 @@

Re: [ovs-dev] [PATCH v2] openvswitch: kernel datapath clone action

2018-12-17 Thread Ben Pfaff
On Mon, Dec 17, 2018 at 01:38:05PM -0800, Gregory Rose wrote: > > On 12/14/2018 2:32 PM, Yifeng Sun wrote: > >Upstream commit: > > commit b233504033dbd65740e59681820ccfd0a2a8ec53 > > Author: Yifeng Sun > > Date: Mon Jul 2 08:18:03 2018 -0700 > > > > openvswitch: kernel datapath

[ovs-dev] [patch v4 4/4] conntrack: Enforce conn_type for conn_clean().

2018-12-17 Thread Darrell Ball
Add check to validate that 'conn_clean()' is only called for conntrack entries of default 'conn_type'. Signed-off-by: Darrell Ball --- lib/conntrack.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/conntrack.c b/lib/conntrack.c index 41232f4..7b5a3f0 100644 --- a/lib/conntrack.c +++

[ovs-dev] [patch v4 3/4] conntrack: Enforce conn_type for flush tuple.

2018-12-17 Thread Darrell Ball
The user should only reference a conntrack entry by the forward direction context, as per 'conntrack_flush()', enforce this by checking for 'default' conn_type. The likelihood of a user not using the original tuple is low, but it should be guarded against, logged and documented. Signed-off-by:

[ovs-dev] [patch v4 2/4] conntrack: Check all addresses for ephemeral ports.

2018-12-17 Thread Darrell Ball
When fallback to ephemeral ports triggers to find a NAT translation, it may happen that the full address range is not explored; i.e. if all ephemeral ports are being used for the address range >= the first address checked and there are other addresses in the available range, then they would not be

Re: [ovs-dev] [PATCH v2] openvswitch: kernel datapath clone action

2018-12-17 Thread Gregory Rose
On 12/14/2018 2:32 PM, Yifeng Sun wrote: Upstream commit: commit b233504033dbd65740e59681820ccfd0a2a8ec53 Author: Yifeng Sun Date: Mon Jul 2 08:18:03 2018 -0700 openvswitch: kernel datapath clone action Add 'clone' action to kernel datapath by using existing

[ovs-dev] [patch v4 1/4] conntrack: Skip ephemeral ports fallback for DNAT.

2018-12-17 Thread Darrell Ball
Ephemeral port fallback is being done for DNAT and the code could be hit in some special cases and testing configurations. Also good packets are expected to be persistently dropped in this case, which is not a common user goal. Regardless, this is incorrect, so filter this out. Also, rename the

Re: [ovs-dev] [patch v3 1/4] conntrack: Stop exporting internal datastructures.

2018-12-17 Thread Darrell Ball
On Tue, Dec 11, 2018 at 6:55 PM Ben Pfaff wrote: > On Tue, Dec 11, 2018 at 06:05:11PM -0800, Darrell Ball wrote: > > On Tue, Dec 11, 2018 at 8:51 AM Ben Pfaff wrote: > > > > > On Mon, Dec 10, 2018 at 07:18:43PM -0800, Darrell Ball wrote: > > > > On Mon, Dec 10, 2018 at 5:22 PM Ben Pfaff wrote:

Re: [ovs-dev] [PATCH 0/6] fixes for ftp alg in userspace dp

2018-12-17 Thread Darrell Ball
I took an initial look; I'll respond with the comments by tomorrow. On 12/17/18, 12:28 PM, "ovs-dev-boun...@openvswitch.org on behalf of Ben Pfaff" wrote: On Sat, Dec 15, 2018 at 06:37:22PM +0100, David Marchand wrote: > A lot of small fixes to make the ftp alg behave a little better.

Re: [ovs-dev] [PATCH v11 06/14] dp-packet: Handle multi-seg mbufs in helper funcs.

2018-12-17 Thread Ian Stokes
On 10/22/2018 3:30 PM, Stokes, Ian wrote: Most helper functions in dp-packet assume that the data held by a dp_packet is contiguous, and perform operations such as pointer arithmetic under that assumption. However, with the introduction of multi-segment mbufs, where data is non-contiguous, such

Re: [ovs-dev] [PATCH 0/6] fixes for ftp alg in userspace dp

2018-12-17 Thread Ben Pfaff
On Sat, Dec 15, 2018 at 06:37:22PM +0100, David Marchand wrote: > A lot of small fixes to make the ftp alg behave a little better. > I tried to come up with better tests but I am not too sure if we want to > have a dependency on yet another external tool for it. Thanks a lot! Darrell, will you

[ovs-dev] Indicadores de compras

2018-12-17 Thread Cuantificar el ahorro monetario
¡ Cursos Top - Webinar interactivo - Innova learn! Medir los indicadores es una tarea fundamental en la administración de un departamento y más si desea hacerse de manera óptima. Además, puede resultar la diferencia para conseguir costos bajos, ofrecer precios más accesibles y

[ovs-dev] [PATCH] ovn: Fix the invalid eth.dst and ip6.dst set by nd_ns action for certain cases.

2018-12-17 Thread nusiddiq
From: Numan Siddique When an IPv6 packet enters a router pipeline and it needs to be routed via the nexthop IP address set in the static route, OVN generates an IPv6 Neigh Solicitation request if the nexthop IP is not resolved yet. But right now, the generated IPv6 Neigh Solicitation packet

Re: [ovs-dev] [PATCH v11 07/14] dp-packet: Handle multi-seg mubfs in shift() func.

2018-12-17 Thread Ian Stokes
On 10/10/2018 5:22 PM, Tiago Lam wrote: In its current implementation dp_packet_shift() is also unaware of multi-seg mbufs (that holds data in memory non-contiguously) and assumes that data exists contiguously in memory, memmove'ing data to perform the shift. To add support for multi-seg mbufs

[ovs-dev] request: CL10B153KO SAMSUNG 2018+ 0.006usd

2018-12-17 Thread Doris(Hardfindelectronics)
DearValued Customer, Good day! How are you? This is Doris from

Re: [ovs-dev] [PATCH] datapath-windows: Use layers info to extract IP header in IpFragment

2018-12-17 Thread aserdean
> -Mesaj original- > De la: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> În numele Anand Kumar > Trimis: Friday, November 9, 2018 9:09 PM > Către: d...@openvswitch.org > Subiect: [ovs-dev] [PATCH] datapath-windows: Use layers info to extract IP > header in IpFragment > > -

[ovs-dev] To Whom It May Concern

2018-12-17 Thread Mabel Ovis via dev
Charitable Donation From Mrs. Mabel Ovis Greetings in the name of the Almighty God/Allah the giver of every good thing. I know this proposal will definitely come to you as a huge surprise, but I implore you to take your time to go through it carefully as the decision you make will go a long

[ovs-dev] [PATCH 1/7] openvswitch: convert to kvmalloc

2018-12-17 Thread Kent Overstreet
There was no real need for this code to be using flexarrays, it's just implementing a hash table - ideally it would be using rhashtables, but that conversion would be significantly more complicated. Signed-off-by: Kent Overstreet Cc: Pravin B Shelar Cc: d...@openvswitch.org Reviewed-by: Matthew

Re: [ovs-dev] [PATCH] acinclude: Include libmnl when needed

2018-12-17 Thread Ian Stokes
On 12/14/2018 10:45 AM, Timothy Redaelli wrote: DPDK 18.11 uses libmnl when MLX5 PMD is enabled. This commit makes OVS to link to libmnl when MLX5 PMD is enabled on DPDK. Signed-off-by: Timothy Redaelli Thanks for this Timothy, seems straight forward and it seems to be a reported issue

Re: [ovs-dev] [ovs-dev, dpdk-hwol, v1] netdev-dpdk: support port representors

2018-12-17 Thread Thomas Monjalon
16/12/2018 13:02, Ophir Munk: > Hi Ilya, > Please find comments inline. > > From: Ilya Maximets > > > > Not a full review. Just one comment inline. > > > > Best regards, Ilya Maximets. > > > > On 12.12.2018 2:34, Ophir Munk wrote: > > > Dpdk port representors were introduced in dpdk 18.xx. >

Re: [ovs-dev] [PATCH v3] ovs:group: support to insert bucket with weight value for select type

2018-12-17 Thread solomon
Aaron Conole wrote: > solomon writes: > >> After creating a group with hash select type,then we need to insert a new >> bucket with weight, >> But,it fails. Commands are as following: >> >> # ovs-ofctl -O OpenFlow15 add-group br0 "group_id=10, type=select, >>