Re: [ovs-dev] hash: Enable hash_bytes128 optimization for aarch64.

2019-02-17 Thread 0-day Robot
Bleep bloop. Greetings Yanqin Wei (Arm Technology China), I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: corrupt patch at line 15 Repository lacks necessary blobs to fall back

[ovs-dev] [PATCH v1 1/1] hash: Enable hash_bytes128 optimization for aarch64.

2019-02-17 Thread Yanqin Wei (Arm Technology China)
"hash_bytes128" has two versions for 64 bits and 32 bits system. This should be common optimization for their respective platforms. But 64 bits version was only enabled in x86-64. This patch enable it for aarch64 platform. Micro benchmarking test was run in two kinds of arm platform. It was

[ovs-dev] [PATCH] ovn-controller: Provide the option to set the datapath-type of br-int

2019-02-17 Thread nusiddiq
From: Numan Siddique If the integration bridge is deleted, ovn-controller recreates it but the previous datapath-type value is lost if it was set. This patch adds the code in ovn-controller to set the datapath-type if it is configured by the user in the 'external_ids:ovn-bridge-datapath-type'

[ovs-dev] [PATCH] ofctl: break the loop if ovs_pcap_read returns error

2019-02-17 Thread Li RongQing
otherwise packet is NULL, and dereference it to cause segfault Signed-off-by: Li RongQing --- utilities/ovs-ofctl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index d8a31e394..63620e4fb 100644 --- a/utilities/ovs-ofctl.c +++

[ovs-dev] possible issue with connection tracing with action Normal

2019-02-17 Thread Moshe Levi
Hi , I have openstack setup with ovs mechanism driver and ovs firewall driver (using connection tracing for security groups). The ovs firewall driver is implement as describe [1]. I have 2 compute (hypervisors) nodes and I am running ICMP from VM1 with mac fa:16:3e:b9:f4:4c which locate on

Re: [ovs-dev] doc: Add "Representors" topic document

2019-02-17 Thread 0-day Robot
Bleep bloop. Greetings Ophir Munk, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #104 FILE:

Re: [ovs-dev] doc: Add "Representors" topic document

2019-02-17 Thread 0-day Robot
Bleep bloop. Greetings Ophir Munk, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #104 FILE:

[ovs-dev] [PATCH v3] doc: Add "Representors" topic document

2019-02-17 Thread Ophir Munk
This details how to configure representors ports. Signed-off-by: Ophir Munk --- v1: First version v2: Following patch reviews. https://patchwork.ozlabs.org/patch/1039515/ Mainly add how to create representors with Intel and Mellanox NICs. v3: Fix Checkpatch complains regarding too long lines but

[ovs-dev] [PATCH v3] doc: Add "Representors" topic document

2019-02-17 Thread Ophir Munk
This details how to configure representors ports. Signed-off-by: Ophir Munk --- v1: First version v2: Following patch reviews. https://patchwork.ozlabs.org/patch/1039515/ Mainly add how to create representors with Intel and Mellanox NICs. v3: Fix Checkpatch complains on line lengths but still

Re: [ovs-dev] [PATCH v4 3/9] dp-packet: Refactor offloading API.

2019-02-17 Thread Ophir Munk
> -Original Message- > From: Ilya Maximets > Sent: Friday, February 15, 2019 3:07 PM > To: ovs-dev@openvswitch.org; Ian Stokes > Cc: Flavio Leitner ; Ophir Munk > ; Kevin Traynor ; Roni Bar > Yanai ; Finn Christensen ; Ilya > Maximets > Subject: [PATCH v4 3/9] dp-packet: Refactor

Re: [ovs-dev] doc: Add "Representors" topic document

2019-02-17 Thread 0-day Robot
Bleep bloop. Greetings Ophir Munk, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 160 characters long (recommended limit is 79) #85 FILE:

[ovs-dev] [PATCH v2] doc: Add "Representors" topic document

2019-02-17 Thread Ophir Munk
This details how to configure representors ports. Signed-off-by: Ophir Munk --- v1: First version v2: Following patch reviews. https://patchwork.ozlabs.org/patch/1039515/ Mainly add how to create representors with Intel and Mellanox NICs. Documentation/topics/dpdk/phy.rst | 130

Re: [ovs-dev] [PATCH v4 4/9] dp-packet: Add flow_mark support for non-DPDK case.

2019-02-17 Thread Asaf Penso
Regards, Asaf Penso > -Original Message- > From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Flavio Leitner > Sent: Friday, February 15, 2019 8:59 PM > To: Ilya Maximets > Cc: ovs-dev@openvswitch.org; Roni Bar Yanai > Subject: Re: [ovs-dev] [PATCH v4 4/9]

Re: [ovs-dev] [PATCH v4 3/9] dp-packet: Refactor offloading API.

2019-02-17 Thread Asaf Penso
Regards, Asaf Penso > -Original Message- > From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Ilya Maximets > Sent: Friday, February 15, 2019 3:07 PM > To: ovs-dev@openvswitch.org; Ian Stokes > Cc: Roni Bar Yanai ; Flavio Leitner > ; Ilya Maximets > Subject:

Re: [ovs-dev] [PATCH V4 0/3] Include libverbs and libmlx4/5 when needed

2019-02-17 Thread Eli Britstein
ping On 2/11/2019 1:31 PM, Eli Britstein wrote: > This patch set automatically links with the necessary libraries for > MLX4/5 DPDK PMDs. > > Patch 1 automatically links with the necessary libraries for MLX5 PMD > > Patch 2 automatically links with the necessary libraries for MLX4 PMD > > Patch 3

Re: [ovs-dev] odp-util: Do not rewrite fields with the same values as matched

2019-02-17 Thread 0-day Robot
Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 90 characters long (recommended limit is 79) #87 FILE: lib/odp-util.c:7252:

Re: [ovs-dev] Makefiles: Generate datapath ovs key fields macros

2019-02-17 Thread 0-day Robot
Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 83 characters long (recommended limit is 79) #69 FILE:

[ovs-dev] [PATCH V5 2/2] odp-util: Do not rewrite fields with the same values as matched

2019-02-17 Thread Eli Britstein
To improve performance and avoid wasting resources for HW offloaded flows, do not rewrite fields that are matched with the same value. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- lib/odp-util.c| 122 +- tests/mpls-xlate.at | 2 +-

[ovs-dev] [PATCH V5 1/2] Makefiles: Generate datapath ovs key fields macros

2019-02-17 Thread Eli Britstein
Generate datapath ovs key fields macros as a pre-step of retrieving field information, with no functional change. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- .gitignore | 1 + build-aux/extract-odp-netlink-xmacros-h | 53 +

[ovs-dev] [PATCH V5 0/2] Do not rewrite fields with the same values as matched

2019-02-17 Thread Eli Britstein
This patch set avoids unnecessary rewrite actions to fields with the same values as matched on. Patch 1 is a pre-step of generating ovs key fields macros Patch 2 avoids the unnecessary rewrites and adapts the tests accordingly Differences from V4: - Remove __ prefix - Remove unused