Re: [ovs-dev] ovsdb-monitor: Refactor ovsdb monitor implementation.

On Fri, Feb 22, 2019 at 8:36 PM Ben Pfaff wrote: > > On Fri, Feb 22, 2019 at 07:31:59PM -0800, Han Zhou wrote: > > On Fri, Feb 22, 2019 at 5:27 PM Ben Pfaff wrote: > > > > > > On Fri, Feb 22, 2019 at 05:21:51PM -0800, Han Zhou wrote: > > > > On Fri, Feb 22, 2019 at 3:04 PM Ben Pfaff wrote: > >

Re: [ovs-dev] ovsdb-monitor: Refactor ovsdb monitor implementation.

On Fri, Feb 22, 2019 at 07:31:59PM -0800, Han Zhou wrote: > On Fri, Feb 22, 2019 at 5:27 PM Ben Pfaff wrote: > > > > On Fri, Feb 22, 2019 at 05:21:51PM -0800, Han Zhou wrote: > > > On Fri, Feb 22, 2019 at 3:04 PM Ben Pfaff wrote: > > > > > > > > Using HMAP_FOR_EACH_SAFE_WITH_HASH tends to imply

Re: [ovs-dev] ovsdb-monitor: Refactor ovsdb monitor implementation.

On Fri, Feb 22, 2019 at 5:27 PM Ben Pfaff wrote: > > On Fri, Feb 22, 2019 at 05:21:51PM -0800, Han Zhou wrote: > > On Fri, Feb 22, 2019 at 3:04 PM Ben Pfaff wrote: > > > > > > Using HMAP_FOR_EACH_SAFE_WITH_HASH tends to imply that an hmap can have > > > more than one item with a given key.

Re: [ovs-dev] [patch v1] ipf: More cleanup.

ignore; sent V2 with more cleanup. On Fri, Feb 22, 2019 at 6:37 PM Darrell Ball wrote: > No functional changes here. > > Signed-off-by: Darrell Ball > --- > lib/ipf.c | 18 -- > 1 file changed, 4 insertions(+), 14 deletions(-) > > diff --git a/lib/ipf.c b/lib/ipf.c > index

[ovs-dev] [patch v2] ipf: More cleanup.

No functional changes here. Signed-off-by: Darrell Ball --- v2: Added another cleanup. lib/ipf.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/lib/ipf.c b/lib/ipf.c index 97d5b58..4cc0f2d 100644 --- a/lib/ipf.c +++ b/lib/ipf.c @@ -522,9 +522,7 @@

[ovs-dev] [patch v1] ipf: More cleanup.

No functional changes here. Signed-off-by: Darrell Ball --- lib/ipf.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/lib/ipf.c b/lib/ipf.c index 97d5b58..50678a6 100644 --- a/lib/ipf.c +++ b/lib/ipf.c @@ -522,9 +522,7 @@ ipf_list_state_transition(struct

Re: [ovs-dev] [patch v2 2/2] conntrack: Fix L4 csum for V6 extension hdr pkts.

On Fri, Feb 22, 2019 at 05:17:42PM -0800, Darrell Ball wrote: > It is a day one issue that got copied to subsequent code. > > Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.") > Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") > CC: Daniele Di Proietto >

Re: [ovs-dev] ovsdb-monitor: Refactor ovsdb monitor implementation.

On Fri, Feb 22, 2019 at 05:21:51PM -0800, Han Zhou wrote: > On Fri, Feb 22, 2019 at 3:04 PM Ben Pfaff wrote: > > > > Using HMAP_FOR_EACH_SAFE_WITH_HASH tends to imply that an hmap can have > > more than one item with a given key. Nothing prevents that, and it will > > otherwise work, but it is

Re: [ovs-dev] ovsdb-monitor: Refactor ovsdb monitor implementation.

On Fri, Feb 22, 2019 at 3:04 PM Ben Pfaff wrote: > > Using HMAP_FOR_EACH_SAFE_WITH_HASH tends to imply that an hmap can have > more than one item with a given key. Nothing prevents that, and it will > otherwise work, but it is unusual and it normally makes sense to use an > hindex instead of an

[ovs-dev] [patch v2 2/2] conntrack: Fix L4 csum for V6 extension hdr pkts.

It is a day one issue that got copied to subsequent code. Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.") Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") CC: Daniele Di Proietto Signed-off-by: Darrell Ball --- Fix will need to be backported as far back

[ovs-dev] [patch v2 1/2] packets: Change return type for 'packet_csum_upperlayer6()'.

Signed-off-by: Darrell Ball --- New patch for series with another patch at v2. Series will need to be backported to 2.6. lib/packets.c | 2 +- lib/packets.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/packets.c b/lib/packets.c index f5a2005..a8fd61f 100644 ---

Re: [ovs-dev] [PATCH] Prevent kernel warning length of ovs attribute.

On Wed, Dec 12, 2018 at 03:06:43PM +, Nathanael Davison wrote: > Linux kernel commit 6e237d099fac introduced warnings when validating the > length of some types. This exposed a bug in dpif-netlink.c > dpif_netlink_vport_to_ofpbuf where ovs was passing the upcall pids as > variable length array

Re: [ovs-dev] [PATCHv8] Improved Packet Drop Statistics in OVS

On Tue, Feb 19, 2019 at 11:38:04AM +, Anju Thomas wrote: > Currently OVS maintains explicit packet drop/error counters only on port > level. Packets that are dropped as part of normal OpenFlow processing are > counted in flow stats of “drop” flows or as table misses in table stats. > These can

Re: [ovs-dev] [PATCH] ovn-controller: Provide the option to set the datapath-type of br-int

On Tue, Feb 19, 2019 at 06:05:30PM +0530, Numan Siddique wrote: > On Tue, Feb 19, 2019 at 2:32 AM Mark Michelson wrote: > > > Looks good to me. > > > > Acked-by: Mark Michelson > > > > Out of curiosity, can you think of any other bridge configuration items > > that might need the same

Re: [ovs-dev] [PATCH] rstp: add ability to receive VLAN-tagged BPDUs

On Mon, Feb 18, 2019 at 12:07:54PM +0100, Matthias May wrote: > On 15/02/2019 01:28, Ben Pfaff wrote: > > On Fri, Feb 15, 2019 at 12:27:11AM +0100, Matthias May wrote: > >> On 14/02/2019 20:17, Ben Pfaff wrote: > >>> On Thu, Feb 14, 2019 at 10:58:48AM +0100, Matthias May via dev wrote: >

Re: [ovs-dev] [PATCH v2] rstp: add ability to receive VLAN-tagged BPDUs

On Fri, Feb 15, 2019 at 12:16:14AM +0100, Matthias May via dev wrote: > There are switches which allow to transmit their BPDUs VLAN-tagged. > With this change OVS is able to receive VLAN-tagged BPDUs, but still > transmits its own BPDUs untagged. > This was tested against Westermo RFI-207-F4G-T3G.

Re: [ovs-dev] ovsdb-monitor: Refactor ovsdb monitor implementation.

Using HMAP_FOR_EACH_SAFE_WITH_HASH tends to imply that an hmap can have more than one item with a given key. Nothing prevents that, and it will otherwise work, but it is unusual and it normally makes sense to use an hindex instead of an hmap for efficiency's sake if it is going to happen very

Re: [ovs-dev] [ovs-discuss] Geneve remote_ip as flow for OVN hosts

Thanks, Ben! I'll keep a watch, but if I do miss anything please let me know and I'll try to get to it quickly. thanks, -venu From: Ben Pfaff Sent: Friday, February 22, 2019 2:42 PM To: Venugopal Iyer Cc: Guru Shetty; Leonid Grossman;

Re: [ovs-dev] [PATCH v2 2/7] ovsdb_monitor: Fix style of prototypes.

On Fri, Feb 15, 2019 at 12:25:58PM -0800, Han Zhou wrote: > From: Han Zhou > > Ommiting the parameter names in prototypes, as suggested by coding > style: Omit parameter names from function prototypes when the names > do not give useful information. > > Adjust orders of parameters as suggested

Re: [ovs-dev] [PATCH v2 1/7] ovsdb-client.c: fix typo

On Fri, Feb 15, 2019 at 12:25:57PM -0800, Han Zhou wrote: > From: Han Zhou > > Signed-off-by: Han Zhou Thanks, applied to master and backported as far as it would go. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [ovs-discuss] Geneve remote_ip as flow for OVN hosts

This was definitely a bit quicker than I usually prefer for changes that might have nonobvious side effects, but we are also very close to the beginning of a release cycle, so I decided to be an optimist for once. You can watch the OVS CI/CD here: https://travis-ci.org/openvswitch/ovs On

Re: [ovs-dev] [ovs-discuss] Geneve remote_ip as flow for OVN hosts

Thanks, Ben! I was thinking there'll be additional test cycles to check for regression before making it to the code. From my side, I have tested it for the new feature, compatibility and run the OVN community tests (plus testing in our setup for OVN functionality). How do I monitor for

Re: [ovs-dev] [patch v3 6/6] conntrack: Fix L4 csum for V6 extension hdr pkts.

oops, thanks for pointing that out I'll fix and resend Darrell On Fri, Feb 22, 2019 at 2:18 PM Ben Pfaff wrote: > On Wed, Feb 20, 2019 at 08:17:19AM -0800, Darrell Ball wrote: > > It is a day one issue that got copied to the FTP handling code. > > > > Fixes: a489b16854b5 ("conntrack: New

Re: [ovs-dev] [PATCH v2] netdev-vport: Use the dst_port in tunnel netdev name

On Fri, Feb 22, 2019 at 10:10:16AM +0800, Chris Mi wrote: > If tunnel device dst_port is not the default one, "ovs-dpctl dump-flows" > will fail. The error message for vxlan is: > > netdev_linux|INFO|ioctl(SIOCGIFINDEX) on vxlan_sys_4789 device failed: No > such device > > That's because when

Re: [ovs-dev] [patch v3 6/6] conntrack: Fix L4 csum for V6 extension hdr pkts.

On Wed, Feb 20, 2019 at 08:17:19AM -0800, Darrell Ball wrote: > It is a day one issue that got copied to the FTP handling code. > > Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.") > Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") > CC: Daniele Di Proietto

Re: [ovs-dev] [patch v3 5/6] ipf: Handle non-zero L2 padding for first fragments.

On Wed, Feb 20, 2019 at 08:17:18AM -0800, Darrell Ball wrote: > Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.") > Signed-off-by: Darrell Ball Thanks for the fixes! I applied patches 1 through 5 to master. I'll send some comments for patch 6.

Re: [ovs-dev] [RFC] OVN: add the possibility to configure a static IPv4 addr/IPv6 prefix and dynamic MAC

On Wed, Feb 20, 2019 at 06:28:42PM +0100, Lorenzo Bianconi wrote: > Add the possibility to configure a static IPv4 address and IPv6 prefix > and get MAC address dynamically allocated. This can be done using the > following commands: > > $ovn-nbctl ls-add sw0 > $ovn-nbctl set Logical-Switch sw0

Re: [ovs-dev] [PATCH] faq: Return GRE-IPv6 tunneling support.

On Fri, Feb 15, 2019 at 01:37:20PM +0300, Ilya Maximets wrote: > Accidentially changed while updating conntrack support. > > CC: Darrell Ball > Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.") > Signed-off-by: Ilya Maximets Thanks, Ilya (and Darrell). Applied to master.

Re: [ovs-dev] [PATCH] ovn-nbctl: Daemon mode should retry when IDL connection lost.

On Fri, Feb 15, 2019 at 06:49:52PM -0800, Han Zhou wrote: > From: Han Zhou > > When creating IDL, "retry" was set to false. However, in daemon > mode, reconnecting upon DB server failure should be transparent > to user. This even impacts HA mode. E.g. in clustered mode, although > IDL tries to

Re: [ovs-dev] [ovs-discuss] Geneve remote_ip as flow for OVN hosts

I applied this series to master. Thank you! On Tue, Feb 12, 2019 at 03:52:48PM +, Venugopal Iyer wrote: > HI, Ben: > > > From: Ben Pfaff > Sent: Monday, February 11, 2019 5:55 PM > To: Venugopal Iyer > Cc: Guru Shetty; Leonid Grossman;

Re: [ovs-dev] OVN/OVS code split: POC

On Fri, Feb 22, 2019 at 04:15:27PM -0500, Mark Michelson wrote: > On 2/22/19 4:01 PM, Ben Pfaff wrote: > > On Mon, Feb 18, 2019 at 09:50:56AM -0500, Mark Michelson wrote: > > > Hi everyone, > > > > > > I have completed a *rough* POC of an OVN/OVS code split. You can find it > > > at > > >

Re: [ovs-dev] OVN/OVS code split: POC

On 2/22/19 4:01 PM, Ben Pfaff wrote: On Mon, Feb 18, 2019 at 09:50:56AM -0500, Mark Michelson wrote: Hi everyone, I have completed a *rough* POC of an OVN/OVS code split. You can find it at https://github.com/putnopvut/ovn.git Please take a look at the README file since that highlights how

Re: [ovs-dev] [PATCH] ofctl: break the loop if ovs_pcap_read returns error

On Mon, Feb 18, 2019 at 10:56:38AM +0800, Li RongQing wrote: > otherwise packet is NULL, and dereference it to cause segfault > > Signed-off-by: Li RongQing Thanks! I applied this to master and backported it as far as branch-2.6. ___ dev mailing list

Re: [ovs-dev] [RFC v4 1/1] datapath: Add a new action check_pkt_len

Numan, I intend to test and review this on my local net-next branch but I'm not feeling well so it will probably be early next week before I can do that.  Sorry for the delay... - Greg On 2/21/2019 10:42 AM, nusid...@redhat.com wrote: From: Numan Siddique [Please note, this patch is

Re: [ovs-dev] [PATCH v1 1/1] hash: Enable hash_bytes128 optimization for aarch64.

On Mon, Feb 18, 2019 at 05:46:01AM +, Yanqin Wei (Arm Technology China) wrote: > "hash_bytes128" has two versions for 64 bits and 32 bits system. This > should be common optimization for their respective platforms. > But 64 bits version was only enabled in x86-64. This patch enable it for >

Re: [ovs-dev] OVN/OVS code split: POC

On Mon, Feb 18, 2019 at 09:50:56AM -0500, Mark Michelson wrote: > Hi everyone, > > I have completed a *rough* POC of an OVN/OVS code split. You can find it at > https://github.com/putnopvut/ovn.git > > Please take a look at the README file since that highlights how the split > was done, as well

Re: [ovs-dev] [PATCH] checkpatch: Escape range operators inside regex.

On Mon, Feb 18, 2019 at 12:03:42PM -0500, Aaron Conole wrote: > Ilya Maximets writes: > > > ' -(' matches a single character in the range between ' ' (index 32) > > and '(' (index 40). This leads to the false positive: > > > > WARNING: Line lacks whitespace around operator > > #445 FILE:

Re: [ovs-dev] [PATCH] ovs-tcpdump: Fix an undefined variable

On Tue, Feb 19, 2019 at 05:34:53PM +0300, Ilya Maximets wrote: > > On Mon, Feb 04, 2019 at 11:50:22AM -0500, Aaron Conole wrote: > >> Hyong Youb Kim via dev writes: > >> > >> > From: Hyong Youb Kim > >> > > >> > Run ovs-tcpdump without --span, and it throws the following > >> > exception.

Re: [ovs-dev] [PATCHv3] netlink: added check to prevent netlink attribute overflow

On Tue, Feb 19, 2019 at 10:55:02AM -0800, Toms Atteka wrote: > If enough large input is passed to odp_actions_from_string it can > cause netlink attribute to overflow. > Check for buffer size was added to prevent entering this function > and returning appropriate error code. > > Basic manual

Re: [ovs-dev] [branch-2.10 1/2] Set release date for 2.10.2.

On Wed, Feb 20, 2019 at 04:47:14PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- Your patches are okay, but unfortunately while testing I found an issue which is resolved by the commit below in branch-2.11 and master: commit 024d93f62ca7a7fef9c8fc5f69a38b60ebf7e0ab Author:

[ovs-dev] STPS - Trámites de capacitación

Cursos esenciales - Webinar Interactivo – Martes 05 de Marzo Capacitación a tu Medida Guía paso a paso: Trámites de capacitación ante la S.T.P.S. En este webinar te presentamos una guía práctica paso a paso del proceso que debemos seguir ante este organismo para registrar la capacitación de

Re: [ovs-dev] [PATCH] OVN: select a random mac_prefix if not provided

On Wed, Feb 20, 2019 at 04:53:45PM +0100, Lorenzo Bianconi wrote: > Select a random IPAM mac_prefix if it has not been provided by the user. > With this patch the admin can avoid to configure mac_prefix in order to > avoid L2 address collisions if multiple OVN deployments share the same >

[ovs-dev] Creating your own VPORT type

Hello Team I am using ovs-2.8 and I want to create an ipinip6 tunnel. I am using native tunneling. Do I need to create a VPORT_TYPE for this? and what need to be done in order to create that? Otherwise its failing because of UNSPEC_OVS_VPORT_TYPE. Thanks and regards Prathamesh

Re: [ovs-dev] [PATCH V5 0/2] Do not rewrite fields with the same values as matched

On Sun, Feb 17, 2019 at 09:18:46AM +, Eli Britstein wrote: > This patch set avoids unnecessary rewrite actions to fields with the > same values as matched on. > > Patch 1 is a pre-step of generating ovs key fields macros > Patch 2 avoids the unnecessary rewrites and adapts the tests

Re: [ovs-dev] [PATCH 0/5] ovn: Add HA chassis group and 'external' port support

On 2/20/19 11:12 PM, Numan Siddique wrote: Thanks for the review and comments. Please see below for few comments. Thanks Numan On Thu, Feb 21, 2019 at 3:29 AM Mark Michelson > wrote: Hi Numan, This is quite a large patchset, but I believe I understand

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Expose flow creation/destruction calls

> -Original Message- > From: Ilya Maximets > Sent: Friday, February 22, 2019 1:26 PM > To: Roni Bar Yanai ; Ophir Munk > ; ovs-dev@openvswitch.org > Cc: Ian Stokes ; Olga Shern ; > Kevin Traynor ; Asaf Penso ; > Flavio Leitner > Subject: Re: [PATCH v2 1/3] netdev-dpdk: Expose flow

Re: [ovs-dev] [PATCH v2 1/3] netdev-dpdk: Expose flow creation/destruction calls

On 21.02.2019 19:37, Roni Bar Yanai wrote: > > >> -Original Message- >> From: Ilya Maximets >> Sent: Thursday, February 21, 2019 5:27 PM >> To: Ophir Munk ; ovs-dev@openvswitch.org >> Cc: Ian Stokes ; Olga Shern ; >> Kevin Traynor ; Asaf Penso ; >> Roni Bar Yanai ; Flavio Leitner >>

Re: [ovs-dev] [PATCH V5 0/2] Do not rewrite fields with the same values as matched

ping On 2/17/2019 11:18 AM, Eli Britstein wrote: > This patch set avoids unnecessary rewrite actions to fields with the > same values as matched on. > > Patch 1 is a pre-step of generating ovs key fields macros > Patch 2 avoids the unnecessary rewrites and adapts the tests accordingly > >