Re: [ovs-dev] [PATCH 1/2] ovsdb-idl: Fix memory leak of ovsdb_idl_delete_row.

2019-03-07 Thread Han Zhou
On Thu, Mar 7, 2019 at 7:45 PM Han Zhou wrote: > > On Tue, Mar 5, 2019 at 6:17 PM Han Zhou wrote: > > > > From: Han Zhou > > > > When a row is deleted, if it is referenced by another row, the > > function ovsdb_idl_row_reparse_backrefs() is called but in that > > function it doesn't destroy the

[ovs-dev] [PATCH v3] ovs-tcpdump: add dump_cmd checker before _doexec()

2019-03-07 Thread txfh2007 via dev
Hi Aaron: Thanks for your kinkdly suggession. I have tried your proposol and test in my repository. This is the new version. Add dump_cmd executable checker in ovs-tcpdump Signed-off-by: Liu Chang diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index

Re: [ovs-dev] [PATCH 1/2] ovsdb-idl: Fix memory leak of ovsdb_idl_delete_row.

2019-03-07 Thread Han Zhou
On Tue, Mar 5, 2019 at 6:17 PM Han Zhou wrote: > > From: Han Zhou > > When a row is deleted, if it is referenced by another row, the > function ovsdb_idl_row_reparse_backrefs() is called but in that > function it doesn't destroy the row, because parameter destroy_dsts > is false when

[ovs-dev] [PATCH] faq: Explain why select groups don't sort out packets evenly.

2019-03-07 Thread Ben Pfaff
This keeps coming up. Signed-off-by: Ben Pfaff --- Documentation/faq/openflow.rst | 16 1 file changed, 16 insertions(+) diff --git a/Documentation/faq/openflow.rst b/Documentation/faq/openflow.rst index 4a20255daf21..561d793a6692 100644 --- a/Documentation/faq/openflow.rst

Re: [ovs-dev] [crash] trigger a panic when flush-conntrack

2019-03-07 Thread Li Wei
hi darrell: I set nat action with actions=ct(nat(src=172.16.1.1-172.255.255.255),commit,table=40) With your patch, new double free panic happens in conntrack_flush() and sweep_bucket(): ==1st panic== [Thread debugging using libthread_db enabled] Using host libthread_db library

Re: [ovs-dev] [PATCH 2/2] ovsdb-idl: Fix memory leak of ovsdb_idl_db_clear.

2019-03-07 Thread Ben Pfaff
On Tue, Mar 05, 2019 at 06:16:50PM -0800, Han Zhou wrote: > From: Han Zhou > > ovsdb_idl_row_destroy() doesn't free the memory of row structure itself. > This is because of the ovsdb change tracking feature: the deleted row > may be accessed in the current iteration of main loop. The function >

Re: [ovs-dev] [PATCH 2/2] ovsdb-idl: Fix memory leak of ovsdb_idl_db_clear.

2019-03-07 Thread Ben Pfaff
On Thu, Mar 07, 2019 at 04:15:20PM -0800, Han Zhou wrote: > On Thu, Mar 7, 2019 at 2:22 PM Ben Pfaff wrote: > My apologies. It is caused by the first patch in this series. I can > reproduce easily by running idl tests such as: 2439: set, simple3 > idl-compound-index-with-ref, initially populated

Re: [ovs-dev] [PATCH 2/2] ovsdb-idl: Fix memory leak of ovsdb_idl_db_clear.

2019-03-07 Thread Han Zhou
On Thu, Mar 7, 2019 at 2:22 PM Ben Pfaff wrote: > > When I apply this series I get lots of segfaults in the testsuite, e.g.: > > = > ==27505==ERROR: AddressSanitizer: SEGV on unknown address 0x0008 (pc > 0x5557321b0f98 bp

Re: [ovs-dev] [PATCH 2/2] ovsdb raft: Precheck prereq before proposing commit.

2019-03-07 Thread Ben Pfaff
On Mon, Mar 04, 2019 at 01:53:38PM -0800, Han Zhou wrote: > On Mon, Mar 4, 2019 at 1:31 PM Ben Pfaff wrote: > > > > On Fri, Mar 01, 2019 at 10:56:37AM -0800, Han Zhou wrote: > > > From: Han Zhou > > > > > > In current OVSDB Raft design, when there are multiple transactions > > > pending, either

Re: [ovs-dev] [PATCH 2/2] ovsdb-idl: Fix memory leak of ovsdb_idl_db_clear.

2019-03-07 Thread Ben Pfaff
When I apply this series I get lots of segfaults in the testsuite, e.g.: = ==27505==ERROR: AddressSanitizer: SEGV on unknown address 0x0008 (pc 0x5557321b0f98 bp 0x7fffa7a2d230 sp 0x7fffa7a2d220 T0) ==27505==The signal is

Re: [ovs-dev] [PATCH V5 0/2] Do not rewrite fields with the same values as matched

2019-03-07 Thread Ben Pfaff
It's really hard for me to figure out what to do with a patch series where the author rejects my feedback. On Thu, Mar 07, 2019 at 02:53:31PM +, Eli Britstein wrote: > I would really want it to get merged. > > how do you suggest to progress? > > > On 3/1/2019 7:40 AM, Eli Britstein wrote:

Re: [ovs-dev] [PATCH 2/2] OVN: Add support for DHCP option 150 - TFTP server address

2019-03-07 Thread Ben Pfaff
On Thu, Mar 07, 2019 at 04:28:35PM +, lmart...@redhat.com wrote: > From: Lucas Alvares Gomes > > OpenStack Ironic relies on a few DHCP options [0] that were not > supported in OVN yet. This patch is adding the last one which is the > option 150 (TFTP server address, RFC5859 [1]). > > Note

[ovs-dev] Contact:

2019-03-07 Thread LIU SHIYU
I'm Liu Shiyu,I have a beneficial proposal for you. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [crash] trigger a panic when flush-conntrack

2019-03-07 Thread Darrell Ball
Thanks for your help Solomon Can you give the following debug patch a spin ? I will continue to try to repo locally. diff --git a/lib/conntrack.c b/lib/conntrack.c index 5410ab4..6968c03 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -250,6 +250,22 @@ conn_key_cmp(const struct conn_key

Re: [ovs-dev] [PATCH v2] ovsdb-idl: Fix memory leak of idl->remote.

2019-03-07 Thread Ben Pfaff
On Wed, Mar 06, 2019 at 09:01:21AM -0800, Han Zhou wrote: > From: Han Zhou > > Reported by Address Sanitizer. > > Fixes: 5e07b8f93f03 ("ovsdb-idl: New function > ovsdb_idl_create_unconnected().") > Signed-off-by: Han Zhou > --- > > Notes: > v1->v2: address comments from David Marchand.

Re: [ovs-dev] [PATCH v3 2/5] ovn: Add generic HA chassis group

2019-03-07 Thread Numan Siddique
On Thu, Mar 7, 2019, 10:46 PM Han Zhou wrote: > On Thu, Mar 7, 2019 at 8:37 AM Numan Siddique wrote: > > > > > > > > On Tue, Mar 5, 2019 at 11:34 PM Han Zhou wrote: > >> > >> > > + > >> > > +static void > >> > > +add_to_ha_ref_chassis_info(struct ha_ref_chassis_info *ref_ch_info, > >> > > +

Re: [ovs-dev] [PATCH v3 2/5] ovn: Add generic HA chassis group

2019-03-07 Thread Han Zhou
On Thu, Mar 7, 2019 at 8:37 AM Numan Siddique wrote: > > > > On Tue, Mar 5, 2019 at 11:34 PM Han Zhou wrote: >> >> > > + >> > > +static void >> > > +add_to_ha_ref_chassis_info(struct ha_ref_chassis_info *ref_ch_info, >> > > + const struct sbrec_chassis *chassis) >> > >

Re: [ovs-dev] [PATCH v3 2/5] ovn: Add generic HA chassis group

2019-03-07 Thread Numan Siddique
On Tue, Mar 5, 2019 at 11:34 PM Han Zhou wrote: > > > + > > > +static void > > > +add_to_ha_ref_chassis_info(struct ha_ref_chassis_info *ref_ch_info, > > > + const struct sbrec_chassis *chassis) > > > +{ > > > +for (size_t j = 0; j < ref_ch_info->n_ref_chassis; j++)

[ovs-dev] [PATCH 2/2] OVN: Add support for DHCP option 150 - TFTP server address

2019-03-07 Thread lmartins
From: Lucas Alvares Gomes OpenStack Ironic relies on a few DHCP options [0] that were not supported in OVN yet. This patch is adding the last one which is the option 150 (TFTP server address, RFC5859 [1]). Note that this option is Cisco proprietary, the IEEE standard that matches with this

[ovs-dev] [PATCH 1/2] OVN: Add support for DHCP option 210 - path prefix

2019-03-07 Thread lmartins
From: Lucas Alvares Gomes OpenStack Ironic relies on few DHCP options [0] that are not yet supported in OVN, one of them is the 210 (PATH PREFIX, RFC5071 [1]). [0] https://github.com/openstack/ironic/blob/3f6d4c6a789b12512d6cc67cdbc93ba5fbf29848/ironic/common/pxe_utils.py#L44-L54 [1]

Re: [ovs-dev] [PATCH v2] ovsdb-idl: Fix memory leak of idl->remote.

2019-03-07 Thread David Marchand
On Wed, Mar 6, 2019 at 7:23 PM Han Zhou wrote: > From: Han Zhou > > Reported by Address Sanitizer. > > Fixes: 5e07b8f93f03 ("ovsdb-idl: New function > ovsdb_idl_create_unconnected().") > Signed-off-by: Han Zhou > --- > > Notes: > v1->v2: address comments from David Marchand. > >

Re: [ovs-dev] :....

2019-03-07 Thread Liu Shiyu
Can I have a word with you? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] meta-flow.xml: Fix typos of flow-based tunnel command examples.

2019-03-07 Thread Ben Pfaff
On Wed, Mar 06, 2019 at 10:04:50PM -0800, Han Zhou wrote: > From: Han Zhou > > Signed-off-by: Han Zhou Thanks! I applied this to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] ovs-tcpdump: add dump_cmd checker before _doexec()

2019-03-07 Thread Aaron Conole
Hi Liu, Thanks for working on this issue. txfh2007 via dev writes: > Sorry , I forgot to add signed-off messages. > > v1->v2: add signed-off messages. > > diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in > index 269c252f8..f28ecf5b2 100755 > --- a/utilities/ovs-tcpdump.in > +++

Re: [ovs-dev] [ovs-dev, v2] ovs-tcpdump: add dump_cmd checker before _doexec()

2019-03-07 Thread 0-day Robot
Bleep bloop. Greetings txfh2007 via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author should not be mailing list. Lines checked: 33, Warnings: 0, Errors: 1

Re: [ovs-dev] [PATCH V5 0/2] Do not rewrite fields with the same values as matched

2019-03-07 Thread Eli Britstein
I would really want it to get merged. how do you suggest to progress? On 3/1/2019 7:40 AM, Eli Britstein wrote: > ping > > On 2/25/2019 9:42 PM, Eli Britstein wrote: >> >> On 2/25/2019 7:31 PM, Ben Pfaff wrote: >>> On Sun, Feb 24, 2019 at 09:45:21AM +, Eli Britstein wrote: On 2/22/2019

[ovs-dev] [PATCH v2] ovs-tcpdump: add dump_cmd checker before _doexec()

2019-03-07 Thread txfh2007 via dev
Sorry , I forgot to add signed-off messages. v1->v2: add signed-off messages. diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in index 269c252f8..f28ecf5b2 100755 --- a/utilities/ovs-tcpdump.in +++ b/utilities/ovs-tcpdump.in @@ -416,6 +416,10 @@ def main(): print("Error:

Re: [ovs-dev] Phy-VM connectivity issue

2019-03-07 Thread Ilya Maximets
On 07.03.2019 13:29, ppnaik wrote: > Hi Ilya, > > Thanks for your suggestion. > We tried pinning the PMD threads to core. But still the issue exists that > only single queue is working instead of multiqueue. > We tried using 'dpdkvhostuserclient' instead of 'dpdkvhostuser' but we are > getting

Re: [ovs-dev] Phy-VM connectivity issue

2019-03-07 Thread ppnaik
Hi Ilya, Thanks for your suggestion. We tried pinning the PMD threads to core. But still the issue exists that only single queue is working instead of multiqueue. We tried using 'dpdkvhostuserclient' instead of 'dpdkvhostuser' but we are getting the following error and the VM is not able to

Re: [ovs-dev] [crash] trigger a panic when flush-conntrack

2019-03-07 Thread Darrell Ball
On Wed, Mar 6, 2019 at 11:33 PM solomon wrote: > Darrell Ball wrote: > > +LIST_FOR_EACH_SAFE (conn, next, exp_node, > >exp_lists[j]) { > > +if (!zone || *zone == conn->key.zone) { > > +ovs_assert(conn->conn_type == CT_CONN_TYPE_DEFAULT); > > why do

Re: [ovs-dev] MUSL netpacket/packet.h

2019-03-07 Thread Fernando Casas Schössow
Thanks Stuart for confirming this. On mié, mar 6, 2019 at 10:30 AM, develo...@it-offshore.co.uk wrote: Hello, The musl-if_packet.patch will always be needed by Alpine due to musl libc / glibc incompatibilities. See: https://wiki.musl-libc.org/faq.html#Q:-Why-am-I-getting- Kind Regards, Stuart