Re: [ovs-dev] [ovs-dev, v4, 1/3] OVN ACL: Replace the usage of ct_label with ct_mark

2019-04-17 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 141 characters long (recommended limit is 79) #33 FILE:

Re: [ovs-dev] OVN/OVS Split POC: version 2

2019-04-17 Thread Ben Pfaff
On Wed, Apr 17, 2019 at 05:07:34PM -0300, Flavio Leitner via dev wrote: > On Tue, Mar 26, 2019 at 04:15:07PM -0400, Mark Michelson wrote: > > I've once again rolled another OVN/OVS split version. It can be found at > > https://github.com/putnopvut/ovn_mk2.git > > > > The main changes between this

Re: [ovs-dev] OVN/OVS Split POC: version 2

2019-04-17 Thread Ben Pfaff
On Wed, Apr 17, 2019 at 04:31:33PM -0400, Mark Michelson wrote: > On 4/12/19 6:02 PM, Ben Pfaff wrote: > > On Tue, Mar 26, 2019 at 04:15:07PM -0400, Mark Michelson wrote: > > > I've once again rolled another OVN/OVS split version. It can be found at > > > https://github.com/putnopvut/ovn_mk2.git >

Re: [ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-04-17 Thread Ankur Sharma
Hi Ben, Sorry, somehow messed up the 3rd patch. Submitted a v4 of this series. Thanks Regards, Ankur -Original Message- From: Ben Pfaff Sent: Wednesday, April 17, 2019 10:46 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user

[ovs-dev] [PATCH v4 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-04-17 Thread Ankur Sharma
This patch allows user to associate a value with acl, which will be assigned to ct.label of the corresponding connection tracking entry. This value can be used to map a ct entry with corresponding OVN ACL or higher level constructs like security group. Signed-off-by: Ankur Sharma ---

[ovs-dev] [PATCH v4 2/3] OVN ACL: Allow ct_mark and ct_label values to be set from register as well

2019-04-17 Thread Ankur Sharma
OVN allows only an integer (or masked integer) to be assigned to ct_mark and ct_label. This patch, enhances the parser code to allow ct_mark and ct_label to be assigned from 32 bit registers (MFF_REG0 - MFF_REG15) and 128 bit registers (MFF_XXREG0 - MFF_XXREG3) respectively. Signed-off-by:

[ovs-dev] [PATCH v4 1/3] OVN ACL: Replace the usage of ct_label with ct_mark

2019-04-17 Thread Ankur Sharma
OVN ACL implementation used ct_label to indicate if a previosuly allowed connection shoudl not be allowed anymore and vice versa. However, ct_label is a 128 bit value and we should rather leverage on ct_mark which is a 32 bit value. Using ct_mark for this purpose, allows us to use ct_label for

[ovs-dev] [PATCH v4 0/3] Associate identifier with OVN ACL connection tracking entry

2019-04-17 Thread Ankur Sharma
What: a. Goal is to be able to associate some identifier with a connection tracking entry. b. This identifier can be used to map OVN ACL which added this entry or higher level constructs like openstack security group etc. c. There are 2 connection tracking fields which can be used for it.

Re: [ovs-dev] OVN/OVS Split POC: version 2

2019-04-17 Thread Mark Michelson
On 4/12/19 6:02 PM, Ben Pfaff wrote: On Tue, Mar 26, 2019 at 04:15:07PM -0400, Mark Michelson wrote: I've once again rolled another OVN/OVS split version. It can be found at https://github.com/putnopvut/ovn_mk2.git The main changes between this and the old split POC are as follows: * This is

Re: [ovs-dev] OVN/OVS Split POC: version 2

2019-04-17 Thread Flavio Leitner via dev
On Tue, Mar 26, 2019 at 04:15:07PM -0400, Mark Michelson wrote: > I've once again rolled another OVN/OVS split version. It can be found at > https://github.com/putnopvut/ovn_mk2.git > > The main changes between this and the old split POC are as follows: > > * This is based on a much newer build

[ovs-dev] [PATCH] selinux: update for netlink socket types

2019-04-17 Thread Aaron Conole
These are used for interfacing with conntrack, as well as by some DPDK PMDs Signed-off-by: Aaron Conole --- selinux/openvswitch-custom.te.in | 8 1 file changed, 8 insertions(+) diff --git a/selinux/openvswitch-custom.te.in b/selinux/openvswitch-custom.te.in index 26495828a..2adaf231f

Re: [ovs-dev] OVN/OVS Split POC: version 2

2019-04-17 Thread Mark Michelson
On 4/12/19 3:38 PM, Aaron Conole wrote: Hi Mark, Mark Michelson writes: I've once again rolled another OVN/OVS split version. It can be found at https://github.com/putnopvut/ovn_mk2.git The main changes between this and the old split POC are as follows: * This is based on a much newer

Re: [ovs-dev] [PATCH] rhel: Include all header files in the Fedora's devel package

2019-04-17 Thread Ansis Atteka
On Wed, 17 Apr 2019 at 08:49, Aaron Conole wrote: > > Ben Pfaff writes: > > > On Mon, Apr 01, 2019 at 09:26:31AM -0700, Ansis Atteka wrote: > >> From: Ansis Atteka > >> > >> While the header files added by this patch into Fedora's devel > >> rpm package can be considered private, the other

Re: [ovs-dev] [PATCH v3 0/4] OVN: Distributed Virtual Router for Vlan Backed Networks

2019-04-17 Thread Ben Pfaff
On Tue, Apr 16, 2019 at 11:37:14PM +, Ankur Sharma wrote: > This series is about enhancing the logical router functionality in OVN to work > with vlan backed logical switches. This series has a lot of style and cosmetic issues reported by the robot. Please take a look at them. I also

Re: [ovs-dev] [PATCH] ovn-nbctl: Fix 32-bit build with gcc.

2019-04-17 Thread Ben Pfaff
On Wed, Apr 17, 2019 at 08:22:06PM +0300, Ilya Maximets wrote: > ovn/utilities/ovn-nbctl.c: In function 'print_routing_policy': > ovn/utilities/ovn-nbctl.c:3620:23: error: format '%ld' expects argument > of type 'long int', but argument 3 has type 'int64_t' >

Re: [ovs-dev] [PATCH v3 3/3] OVN ACL: Allow a user to input ct.label value for an acl

2019-04-17 Thread Ben Pfaff
On Tue, Apr 16, 2019 at 11:58:10PM +, Ankur Sharma wrote: > This patch allows user to associate a value with acl, > which will be assigned to ct.label of the corresponding > connection tracking entry. > > This value can be used to map a ct entry with corresponding > OVN ACL or higher level

Re: [ovs-dev] [PATCH v3 2/3] OVN ACL: Allow ct_mark and ct_label values to be set from register as well

2019-04-17 Thread Ben Pfaff
On Tue, Apr 16, 2019 at 11:58:08PM +, Ankur Sharma wrote: > OVN allows only an integer (or masked integer) to be assigned to > ct_mark and ct_label. > > This patch, enhances the parser code to allow ct_mark and ct_label > to be assigned from 32 bit registers (MFF_REG0 - MFF_REG15) and 128 >

Re: [ovs-dev] [PATCH RFCv4 0/4] AF_XDP netdev support for OVS

2019-04-17 Thread William Tu
On Wed, Apr 17, 2019 at 9:48 AM Ben Pfaff wrote: > > On Wed, Apr 17, 2019 at 12:16:59PM +0200, Eelco Chaudron wrote: > > One other thing that popped up in my head is how (will) it work together > > with DPDK enabled on the same system? > > Why not? It works OK with OVS-DPDK. For example, I can

Re: [ovs-dev] [PATCH RFCv4 0/4] AF_XDP netdev support for OVS

2019-04-17 Thread William Tu
On Wed, Apr 17, 2019 at 9:47 AM Ben Pfaff wrote: > > On Wed, Apr 17, 2019 at 10:09:53AM +0200, Eelco Chaudron wrote: > > On 16 Apr 2019, at 21:55, Ben Pfaff wrote: > > > AF_XDP is a faster way to access the existing kernel devices. If we > > > take that point of view, then it would be ideal if

Re: [ovs-dev] OVS-DPDK public meeting

2019-04-17 Thread Kevin Traynor
On 17/04/2019 18:24, Kevin Traynor wrote: > Next meeting April 15th 1600 UTC > oops, should be May 15th, time travel is still an experimental feature. > Attendees: Aaron, Alejandro, David, Fouad, Flavio, Ariel, Pieter, Mark, > Ian, Scott, Kevin. > > === > GENERAL > === > > - UNH lab

Re: [ovs-dev] OVS-DPDK public meeting

2019-04-17 Thread Kevin Traynor
Next meeting April 15th 1600 UTC Attendees: Aaron, Alejandro, David, Fouad, Flavio, Ariel, Pieter, Mark, Ian, Scott, Kevin. === GENERAL === - UNH lab testing (Aaron) -- Integrating ovs_perf test scripts -- Testing dpdk-latest OVS branch and dpdk master + patches from dpdk-dev -- Would

Re: [ovs-dev] [PATCH RFCv4 0/4] AF_XDP netdev support for OVS

2019-04-17 Thread William Tu
Hi Eelco, Thanks for trying this patchset! On Wed, Apr 17, 2019 at 7:26 AM Eelco Chaudron wrote: > > > > On 17 Apr 2019, at 14:01, Eelco Chaudron wrote: > > > Hi William, > > > > I think you applied the following patch to get it to compile? Or did > > you copy in the kernel headers? > > > >

Re: [ovs-dev] [PATCH RFCv4 0/4] AF_XDP netdev support for OVS

2019-04-17 Thread William Tu
On Wed, Apr 17, 2019 at 1:09 AM Eelco Chaudron wrote: > > > > On 16 Apr 2019, at 21:55, Ben Pfaff wrote: > > > On Mon, Apr 01, 2019 at 03:46:48PM -0700, William Tu wrote: > >> The patch series introduces AF_XDP support for OVS netdev. > >> AF_XDP is a new address family working together with

Re: [ovs-dev] [PATCH v5] OVN: Add support for Transport Zones

2019-04-17 Thread Ben Pfaff
On Wed, Apr 17, 2019 at 04:55:24PM +0100, lmart...@redhat.com wrote: > From: Lucas Alvares Gomes > > This patch is adding support for Transport Zones. Transport zones (a.k.a > TZs) is way to enable users of OVN to separate Chassis into different > logical groups that will only form tunnels

Re: [ovs-dev] [ovs-dev, v1] netdev-rte-offloads: Reassign vport netdev functions.

2019-04-17 Thread Ben Pfaff
On Wed, Apr 17, 2019 at 09:39:45AM -0700, Gregory Rose wrote: > > > On 4/17/2019 9:34 AM, Ben Pfaff wrote: > > On Wed, Apr 17, 2019 at 11:45:33AM -0400, Aaron Conole wrote: > > > rte comes from dpdk as an acronym for Run Time Environment. Maybe even > > > just dropping the 'rte_' portion? > >

Re: [ovs-dev] [PATCH RFCv4 0/4] AF_XDP netdev support for OVS

2019-04-17 Thread William Tu
Thanks for the feedbacks. On Tue, Apr 16, 2019 at 12:55 PM Ben Pfaff wrote: > > On Mon, Apr 01, 2019 at 03:46:48PM -0700, William Tu wrote: > > The patch series introduces AF_XDP support for OVS netdev. > > AF_XDP is a new address family working together with eBPF. > > In short, a socket with

Re: [ovs-dev] [PATCH RFCv4 0/4] AF_XDP netdev support for OVS

2019-04-17 Thread Ben Pfaff
On Wed, Apr 17, 2019 at 12:16:59PM +0200, Eelco Chaudron wrote: > One other thing that popped up in my head is how (will) it work together > with DPDK enabled on the same system? Why not? ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH RFCv4 0/4] AF_XDP netdev support for OVS

2019-04-17 Thread Ben Pfaff
On Wed, Apr 17, 2019 at 10:09:53AM +0200, Eelco Chaudron wrote: > On 16 Apr 2019, at 21:55, Ben Pfaff wrote: > > AF_XDP is a faster way to access the existing kernel devices. If we > > take that point of view, then it would be ideal if AF_XDP were > > automatically used when it was available,

Re: [ovs-dev] [ovs-dev, v1] netdev-rte-offloads: Reassign vport netdev functions.

2019-04-17 Thread Gregory Rose
On 4/17/2019 9:34 AM, Ben Pfaff wrote: On Wed, Apr 17, 2019 at 11:45:33AM -0400, Aaron Conole wrote: rte comes from dpdk as an acronym for Run Time Environment. Maybe even just dropping the 'rte_' portion? *That* is what rte stands for? What a ridiculously generic name. It's like naming

Re: [ovs-dev] [ovs-dev, v1] netdev-rte-offloads: Reassign vport netdev functions.

2019-04-17 Thread Ben Pfaff
On Wed, Apr 17, 2019 at 11:45:33AM -0400, Aaron Conole wrote: > rte comes from dpdk as an acronym for Run Time Environment. Maybe even > just dropping the 'rte_' portion? *That* is what rte stands for? What a ridiculously generic name. It's like naming a library Operating System.

Re: [ovs-dev] [PATCH v4] OVN: Add support for Transport Zones

2019-04-17 Thread Ben Pfaff
On Wed, Apr 17, 2019 at 09:15:33PM +0530, Numan Siddique wrote: > On Wed, Apr 17, 2019 at 8:21 PM wrote: > > diff --git a/ovn/ovn-sb.ovsschema b/ovn/ovn-sb.ovsschema > > index d87a02e7b..98007cb6e 100644 > > --- a/ovn/ovn-sb.ovsschema > > +++ b/ovn/ovn-sb.ovsschema > > @@ -1,7 +1,7 @@ > > { > >

[ovs-dev] Cómo vender por whatsapp

2019-04-17 Thread WhatsApp cómo poderosa herramienta
Cursos TOP - Webinar Interactivo – Viernes 03 de Mayo ¿Cómo vender por whatsapp ? Las ventas se logran el 90% con una estrategia comunicacional y el 10% con tecnología. En nuestro webinar podrás conocer todo lo que debes saber sobre WhatsApp, esta poderosa herramienta que todos utilizamos de

Re: [ovs-dev] [PATCH] dpif-netdev: Update comment about flow installation race.

2019-04-17 Thread Gregory Rose
On 4/17/2019 1:43 AM, Ilya Maximets wrote: Userspace datapath uses per-PMD flow tables/classifiers for a long time. However, it was decided to keep this race window to not block revalidators. Comment should be updated to reflect the current state. Fixes: 1c1e46ed8457 ("dpif-netdev: Add

Re: [ovs-dev] [PATCH v1] netdev-rte-offloads: Reserve mark space.

2019-04-17 Thread Gregory Rose
On 4/17/2019 1:42 AM, Ophir Munk wrote: From: Roni Bar Yanai Reserve the first 64 intergers (0-63) for special processing. For example, if a packet can't complete its procssesing in hardware, we will make sure that the packet is marked with a special mark to continue its processing in

[ovs-dev] [PATCH v5] OVN: Add support for Transport Zones

2019-04-17 Thread lmartins
From: Lucas Alvares Gomes This patch is adding support for Transport Zones. Transport zones (a.k.a TZs) is way to enable users of OVN to separate Chassis into different logical groups that will only form tunnels between members of the same groups. Each Chassis can belong to one or more Transport

Re: [ovs-dev] [PATCH 1/5 V2] datapath: meter: Use struct_size() in kzalloc()

2019-04-17 Thread Gregory Rose
On 4/16/2019 9:17 PM, Ben Pfaff wrote: On Tue, Apr 16, 2019 at 04:58:55PM -0700, Gregory Rose wrote: On 4/16/2019 4:56 PM, Gregory Rose wrote: On 4/16/2019 2:04 PM, Ben Pfaff wrote: On Wed, Mar 27, 2019 at 10:14:00AM -0700, Greg Rose wrote: From: "Gustavo A. R. Silva" Upstream commit:  

Re: [ovs-dev] [PATCH v4] OVN: Add support for Transport Zones

2019-04-17 Thread Lucas Alvares Gomes
On Wed, Apr 17, 2019 at 4:46 PM Numan Siddique wrote: > > On Wed, Apr 17, 2019 at 8:21 PM wrote: > > > From: Lucas Alvares Gomes > > > > This patch is adding support for Transport Zones. Transport zones (a.k.a > > TZs) is way to enable users of OVN to separate Chassis into different > > logical

Re: [ovs-dev] [PATCH] rhel: Include all header files in the Fedora's devel package

2019-04-17 Thread Aaron Conole
Ben Pfaff writes: > On Mon, Apr 01, 2019 at 09:26:31AM -0700, Ansis Atteka wrote: >> From: Ansis Atteka >> >> While the header files added by this patch into Fedora's devel >> rpm package can be considered private, the other devel packages >> for RHEL/CentOS and Debian/Ubuntu distros include

Re: [ovs-dev] [PATCH v4] OVN: Add support for Transport Zones

2019-04-17 Thread Numan Siddique
On Wed, Apr 17, 2019 at 8:21 PM wrote: > From: Lucas Alvares Gomes > > This patch is adding support for Transport Zones. Transport zones (a.k.a > TZs) is way to enable users of OVN to separate Chassis into different > logical groups that will only form tunnels between members of the same >

Re: [ovs-dev] [ovs-dev, v1] netdev-rte-offloads: Reassign vport netdev functions.

2019-04-17 Thread Aaron Conole
0-day Robot writes: > Bleep bloop. Greetings Ophir Munk, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > build: ... > libtool: link: gcc -std=gnu99 -Wstrict-prototypes -Wall

Re: [ovs-dev] [PATCH] rhel: if rpms were built without libcapng then let processrs to run as root

2019-04-17 Thread Aaron Conole
Ansis Atteka writes: > On Tue, 16 Apr 2019 at 12:36, Ansis Atteka wrote: >> >> On Tue, 16 Apr 2019 at 10:46, Aaron Conole wrote: >> > >> > Ansis Atteka writes: >> > >> > > Otherwise, Open vSwitch will fail to start with the following >> > > error "libcap-ng is not configured at compile time"

[ovs-dev] [PATCH v4] OVN: Add support for Transport Zones

2019-04-17 Thread lmartins
From: Lucas Alvares Gomes This patch is adding support for Transport Zones. Transport zones (a.k.a TZs) is way to enable users of OVN to separate Chassis into different logical groups that will only form tunnels between members of the same groups. Each Chassis can belong to one or more Transport

[ovs-dev] [PATCH net-next v3 4/4] openvswitch: load and reference the NAT helper.

2019-04-17 Thread Flavio Leitner
This improves the original commit 17c357efe5ec ("openvswitch: load NAT helper") where it unconditionally tries to load the module for every flow using NAT, so not efficient when loading multiple flows. It also doesn't hold any references to the NAT module while the flow is active. This change

[ovs-dev] [PATCH net-next v3 3/4] netfilter: nf_nat: register NAT helpers.

2019-04-17 Thread Flavio Leitner
Register amanda, ftp, irc, sip and tftp NAT helpers. Signed-off-by: Flavio Leitner --- net/netfilter/nf_nat_amanda.c | 9 - net/netfilter/nf_nat_ftp.c| 9 - net/netfilter/nf_nat_irc.c| 9 - net/netfilter/nf_nat_sip.c| 9 +++-- net/netfilter/nf_nat_tftp.c

[ovs-dev] [PATCH net-next v3 2/4] netfilter: add API to manage NAT helpers.

2019-04-17 Thread Flavio Leitner
The API allows a conntrack helper to indicate its corresponding NAT helper which then can be loaded and reference counted. Signed-off-by: Flavio Leitner --- include/net/netfilter/nf_conntrack_helper.h | 22 +- net/netfilter/nf_conntrack_amanda.c | 8 +-

[ovs-dev] [PATCH net-next v3 1/4] netfilter: use macros to create module aliases.

2019-04-17 Thread Flavio Leitner
Each NAT helper creates a module alias which follows a pattern. Use macros for consistency. Signed-off-by: Flavio Leitner --- include/net/netfilter/nf_conntrack_helper.h | 4 net/ipv4/netfilter/nf_nat_h323.c| 2 +- net/ipv4/netfilter/nf_nat_pptp.c| 2 +-

[ovs-dev] [PATCH net-next v3 0/4] openvswitch: load and reference the NAT helper

2019-04-17 Thread Flavio Leitner
The request_module() is quite expensive and triggers the usermode helper in userspace. Instead, load only if the module is not present and keep module references to avoid problems. The first patch standardize the module alias which is already there, but not in a formal way. The second patch adds

Re: [ovs-dev] [ovs-discuss] Does OVS support Infiniband?

2019-04-17 Thread Ben Pfaff
OVS does not support Infiniband. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

2019-04-17 Thread Kevin Traynor
On 16/04/2019 10:45, David Marchand wrote: > Rather than poll all disabled queues and waste some memory for vms that > have been shutdown, we can reconfigure when receiving a destroy > connection notification from the vhost library. > > $ while true; do > ovs-appctl dpif-netdev/pmd-rxq-show

Re: [ovs-dev] [PATCH RFCv4 0/4] AF_XDP netdev support for OVS

2019-04-17 Thread Eelco Chaudron
On 17 Apr 2019, at 14:01, Eelco Chaudron wrote: Hi William, I think you applied the following patch to get it to compile? Or did you copy in the kernel headers? https://www.spinics.net/lists/netdev/msg563507.html I noticed you duplicated the macros, which resulted in all kind of

Re: [ovs-dev] [PATCH v2 2/3] netdev-dpdk: avoid reconfiguration on VIRTIO_NET_F_MQ changes

2019-04-17 Thread Kevin Traynor
On 16/04/2019 10:45, David Marchand wrote: > At the moment, a malicious guest might negotiate VIRTIO_NET_F_MQ and > !VIRTIO_NET_F_MQ in a loop which would be seen as qp_num going from 1 to > n and n to 1 continuously, triggering datapath reconfigurations at each > transition. > > Limit this by

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

2019-04-17 Thread Kevin Traynor
On 16/04/2019 10:45, David Marchand wrote: > We currently poll all available queues based on the max queue count > exchanged with the vhost peer and rely on the vhost library in DPDK to > check the vring status beneath. > This can lead to some overhead when we have a lot of unused queues. > > To

Re: [ovs-dev] [PATCH RFCv4 0/4] AF_XDP netdev support for OVS

2019-04-17 Thread Eelco Chaudron
Hi William, I think you applied the following patch to get it to compile? Or did you copy in the kernel headers? https://www.spinics.net/lists/netdev/msg563507.html //Eelco On 2 Apr 2019, at 0:46, William Tu wrote: The patch series introduces AF_XDP support for OVS netdev. AF_XDP is a new

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

2019-04-17 Thread Ilya Maximets
On 17.04.2019 11:37, David Marchand wrote: > > > > On Tue, Apr 16, 2019 at 4:01 PM Ilya Maximets > wrote: > > On 16.04.2019 12:45, David Marchand wrote: > > Rather than poll all disabled queues and waste some memory for vms that > > have been

Re: [ovs-dev] [PATCH RFCv4 0/4] AF_XDP netdev support for OVS

2019-04-17 Thread Eelco Chaudron
On 17 Apr 2019, at 10:09, Eelco Chaudron wrote: On 16 Apr 2019, at 21:55, Ben Pfaff wrote: On Mon, Apr 01, 2019 at 03:46:48PM -0700, William Tu wrote: The patch series introduces AF_XDP support for OVS netdev. AF_XDP is a new address family working together with eBPF. In short, a socket

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

2019-04-17 Thread Ilya Maximets
On 17.04.2019 11:35, David Marchand wrote: > Hello Ilya, > > > On Tue, Apr 16, 2019 at 3:41 PM Ilya Maximets > wrote: > > Hi. > > One comment for the patch names. It's not a rule, but it's better > to make the part of the subject a complete

Re: [ovs-dev] [ovs-dev, v1] netdev-rte-offloads: Reassign vport netdev functions.

2019-04-17 Thread 0-day Robot
Bleep bloop. Greetings Ophir Munk, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: /bin/sh ./libtool --tag=CXX --mode=compile g++ -std=gnu++11 -DHAVE_CONFIG_H -I.-I ./include

[ovs-dev] [PATCH] dpif-netdev: Update comment about flow installation race.

2019-04-17 Thread Ilya Maximets
Userspace datapath uses per-PMD flow tables/classifiers for a long time. However, it was decided to keep this race window to not block revalidators. Comment should be updated to reflect the current state. Fixes: 1c1e46ed8457 ("dpif-netdev: Add per-pmd flow-table/classifier.") Signed-off-by: Ilya

[ovs-dev] [PATCH v1] netdev-rte-offloads: Reserve mark space.

2019-04-17 Thread Ophir Munk
From: Roni Bar Yanai Reserve the first 64 intergers (0-63) for special processing. For example, if a packet can't complete its procssesing in hardware, we will make sure that the packet is marked with a special mark to continue its processing in software. Co-authored-by: Asaf Penso

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

2019-04-17 Thread David Marchand
On Tue, Apr 16, 2019 at 4:01 PM Ilya Maximets wrote: > On 16.04.2019 12:45, David Marchand wrote: > > Rather than poll all disabled queues and waste some memory for vms that > > have been shutdown, we can reconfigure when receiving a destroy > > connection notification from the vhost library. >

Re: [ovs-dev] [PATCH v2 2/3] netdev-dpdk: avoid reconfiguration on VIRTIO_NET_F_MQ changes

2019-04-17 Thread David Marchand
On Tue, Apr 16, 2019 at 3:51 PM Ilya Maximets wrote: > On 16.04.2019 12:45, David Marchand wrote: > > At the moment, a malicious guest might negotiate VIRTIO_NET_F_MQ and > > !VIRTIO_NET_F_MQ in a loop which would be seen as qp_num going from 1 to > > n and n to 1 continuously, triggering

Re: [ovs-dev] [PATCH v2 1/3] dpif-netdev: only poll enabled vhost queues

2019-04-17 Thread David Marchand
Hello Ilya, On Tue, Apr 16, 2019 at 3:41 PM Ilya Maximets wrote: > Hi. > > One comment for the patch names. It's not a rule, but it's better > to make the part of the subject a complete sentence. > i.e. start with a capital letter and end with a period. > > Same rule is applicable to the

[ovs-dev] [PATCH v1] netdev-rte-offloads: Reassign vport netdev functions.

2019-04-17 Thread Ophir Munk
From: Roni Bar Yanai vport offloaded functions should have a different implementation for kernel based OVS versus dpdk based OVS. Currently there is an unconditional execution of a kernel based calls even if the vport was added by dpif-netdev rather than by dpif-netlink. Before this commit and

Re: [ovs-dev] [PATCH RFCv4 0/4] AF_XDP netdev support for OVS

2019-04-17 Thread Eelco Chaudron
On 16 Apr 2019, at 21:55, Ben Pfaff wrote: On Mon, Apr 01, 2019 at 03:46:48PM -0700, William Tu wrote: The patch series introduces AF_XDP support for OVS netdev. AF_XDP is a new address family working together with eBPF. In short, a socket with AF_XDP family can receive and send packets from

[ovs-dev] recherche médicale

2019-04-17 Thread Association 1901
Vous