[ovs-dev] Is there kernel datapath support for OVS_HASH_ALG_SYM_L4

Hello, Below commits have been added for supporting OVS_HASH_ALG_SYM_L4 in userspace datapath. Is there plan to add support in kernel datapath? Currently, while probing for max_dp_hash_alg, I get the error as -22(Invalid argument) in netlink message reply, and it falls back to OVS_HASH_ALG_L4.

Re: [ovs-dev] OVS/OVN Split initial commits are complete

> On Apr 26, 2019, at 2:50 PM, Mark Michelson wrote: > > On 4/26/19 3:42 PM, Ben Pfaff wrote: > >> We need to pick a date (or a trigger) for freezing the OVN parts of OVS. >> I don't know what that date should be. Thoughts? > > I'm of the opinion that it should be ASAP. With the new repo

Re: [ovs-dev] [PATCHv3] datapath: Fix compiling error for 4.14.111+ kernel

On Fri, Apr 26, 2019 at 2:57 PM Gregory Rose wrote: > > > On 4/26/2019 2:42 PM, Yifeng Sun wrote: > > CC: Greg Rose > > CC: Yi-Hung Wei > > Fixes: f72469405eec9 ("datapath: meter: Use struct_size() in kzalloc()") > > Signed-off-by: Yifeng Sun > > --- > > v1->v2: Update 4.14.111 in travis by

Re: [ovs-dev] [PATCHv3] datapath: Fix compiling error for 4.14.111+ kernel

On 4/26/2019 2:42 PM, Yifeng Sun wrote: CC: Greg Rose CC: Yi-Hung Wei Fixes: f72469405eec9 ("datapath: meter: Use struct_size() in kzalloc()") Signed-off-by: Yifeng Sun --- v1->v2: Update 4.14.111 in travis by Greg's suggestion, thanks! v2->v3: Fix patch title and comment of endif, thanks

Re: [ovs-dev] OVS/OVN Split initial commits are complete

On 4/26/19 3:42 PM, Ben Pfaff wrote: On Fri, Apr 26, 2019 at 11:14:23AM +0530, Numan Siddique wrote: On Fri, Apr 26, 2019 at 1:56 AM Ben Pfaff wrote: On Thu, Apr 25, 2019 at 12:51:29PM -0700, Ben Pfaff wrote: On Thu, Apr 25, 2019 at 08:38:06AM -0400, Mark Michelson wrote: Yesterday, I once

Re: [ovs-dev] [PATCH] OVN: Fix failures after OVS/OVN split

Thanks for the correction. I've pushed it to master. On 4/25/19 4:08 PM, Brian Haley wrote: Added TODO_SPLIT.rst to Makefile.am to avoid an error during build. Removed a section from config-h-check section of Makefile.am that was no longer relevant. Signed-off-by: Brian Haley ---

Re: [ovs-dev] [PATCH] OVN: Fix build when using a separate build directory.

On 4/26/19 2:14 PM, Ben Pfaff wrote: On Fri, Apr 26, 2019 at 12:14:06PM -0400, Mark Michelson wrote: The linker was searching for built libraries in the source directory rather than in the build directory. This fixes the problem. Reported-by: Numan Siddique Signed-off-by: Mark Michelson I

[ovs-dev] [PATCHv3] datapath: Fix compiling error for 4.14.111+ kernel

CC: Greg Rose CC: Yi-Hung Wei Fixes: f72469405eec9 ("datapath: meter: Use struct_size() in kzalloc()") Signed-off-by: Yifeng Sun --- v1->v2: Update 4.14.111 in travis by Greg's suggestion, thanks! v2->v3: Fix patch title and comment of endif, thanks Yi-Hung! .travis.yml

Re: [ovs-dev] [PATCHv2] datapath: Fix compiling error for latest Linux 4.14 kernel

Thanks for the patch. It fixes an issue where overflow.h is there but the struct_size marco is not available. Some minor comment. For the patch title, instead of having "Fix compiling error for latest Linux 4.14 kernel", maybe we can specify the minor version number say "4.14.111+ kernel) so

[ovs-dev] [PATCHv2] datapath: Fix compiling error for latest Linux 4.14 kernel

CC: Greg Rose Fixes: f72469405eec9 ("datapath: meter: Use struct_size() in kzalloc()") Signed-off-by: Yifeng Sun --- v1->v2: update 4.14.111 in travis by Greg's suggestion, thanks! .travis.yml| 2 +- acinclude.m4 | 2 ++

Re: [ovs-dev] [PATCH] datapath: Fix compiling error for latest Linux 4.14 kernel

Sure, I will do that. Thanks! Yifeng On Fri, Apr 26, 2019 at 1:31 PM Gregory Rose wrote: > > > > On 4/26/2019 1:18 PM, Yifeng Sun wrote: > > Hi Greg, > > > > I saw the compilation error for kernel 4.14.111 because `struct_size` > > isn't defined in kernel source tree. I didn't dig into it

Re: [ovs-dev] [PATCH] datapath: Fix compiling error for latest Linux 4.14 kernel

On 4/26/2019 1:18 PM, Yifeng Sun wrote: Hi Greg, I saw the compilation error for kernel 4.14.111 because `struct_size` isn't defined in kernel source tree. I didn't dig into it though. I see the problem then.  The .travis.yml file tests 4.14.63.  Please update the patch to include an

Re: [ovs-dev] [PATCH] datapath: Fix compiling error for latest Linux 4.14 kernel

Hi Greg, I saw the compilation error for kernel 4.14.111 because `struct_size` isn't defined in kernel source tree. I didn't dig into it though. Thanks, Yifeng On Fri, Apr 26, 2019 at 1:13 PM Gregory Rose wrote: > > > On 4/26/2019 11:07 AM, Yifeng Sun wrote: > > CC: Greg Rose > > Fixes:

Re: [ovs-dev] [PATCH] datapath: Fix compiling error for latest Linux 4.14 kernel

On 4/26/2019 11:07 AM, Yifeng Sun wrote: CC: Greg Rose Fixes: f72469405eec9 ("datapath: meter: Use struct_size() in kzalloc()") Signed-off-by: Yifeng Sun --- acinclude.m4 | 2 ++ datapath/linux/compat/include/linux/overflow.h | 2 +- datapath/meter.c

Re: [ovs-dev] [PATCH] MAINTAINERS: Add Ilya Maximets.

Thanks! Applied to master. On Fri, Apr 26, 2019 at 12:49:11PM -0700, Justin Pettit wrote: > Acked-by: Justin Pettit > > --Justin > > > > On Apr 26, 2019, at 10:52 AM, Ben Pfaff wrote: > > > > Ilya was elected by the Open vSwitch committers on Thursday. Welcome to > > the team, Ilya! > >

Re: [ovs-dev] [PATCH] MAINTAINERS: Add Ilya Maximets.

Acked-by: Justin Pettit --Justin > On Apr 26, 2019, at 10:52 AM, Ben Pfaff wrote: > > Ilya was elected by the Open vSwitch committers on Thursday. Welcome to > the team, Ilya! > > CC: Ilya Maximets > Signed-off-by: Ben Pfaff > --- > MAINTAINERS.rst | 2 ++ > 1 file changed, 2

Re: [ovs-dev] OVS/OVN Split initial commits are complete

On Fri, Apr 26, 2019 at 11:14:23AM +0530, Numan Siddique wrote: > On Fri, Apr 26, 2019 at 1:56 AM Ben Pfaff wrote: > > > On Thu, Apr 25, 2019 at 12:51:29PM -0700, Ben Pfaff wrote: > > > On Thu, Apr 25, 2019 at 08:38:06AM -0400, Mark Michelson wrote: > > > > Yesterday, I once again performed the

Re: [ovs-dev] [PATCH] OVN: Fix build when using a separate build directory.

On Fri, Apr 26, 2019 at 12:14:06PM -0400, Mark Michelson wrote: > The linker was searching for built libraries in the source directory > rather than in the build directory. This fixes the problem. > > Reported-by: Numan Siddique > Signed-off-by: Mark Michelson I did not test this but it looks

[ovs-dev] [PATCH] datapath: Fix compiling error for latest Linux 4.14 kernel

CC: Greg Rose Fixes: f72469405eec9 ("datapath: meter: Use struct_size() in kzalloc()") Signed-off-by: Yifeng Sun --- acinclude.m4 | 2 ++ datapath/linux/compat/include/linux/overflow.h | 2 +- datapath/meter.c | 1 + 3 files

[ovs-dev] [PATCH] MAINTAINERS: Add Ilya Maximets.

Ilya was elected by the Open vSwitch committers on Thursday. Welcome to the team, Ilya! CC: Ilya Maximets Signed-off-by: Ben Pfaff --- MAINTAINERS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index e5028400f72d..760f5c9736f0 100644 ---

Re: [ovs-dev] OVN: Fix build when using a separate build directory.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (configure.ac). Repository lacks necessary blobs

Re: [ovs-dev] [PATCH] OVN: Fix build when using a separate build directory.

On Fri, Apr 26, 2019, 9:55 PM Mark Michelson wrote: > The linker was searching for built libraries in the source directory > rather than in the build directory. This fixes the problem. > > Reported-by: Numan Siddique > Hi Mark Can you plz correct the email id - nusid...@redhat.com :) Thanks

[ovs-dev] [PATCH] OVN: Fix build when using a separate build directory.

The linker was searching for built libraries in the source directory rather than in the build directory. This fixes the problem. Reported-by: Numan Siddique Signed-off-by: Mark Michelson --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac

Re: [ovs-dev] OVS/OVN Split initial commits are complete

On 4/26/19 1:47 AM, Numan Siddique wrote: On Fri, Apr 26, 2019 at 11:14 AM Numan Siddique > wrote: On Fri, Apr 26, 2019 at 1:56 AM Ben Pfaff mailto:b...@ovn.org>> wrote: On Thu, Apr 25, 2019 at 12:51:29PM -0700, Ben Pfaff wrote: > On Thu,

Re: [ovs-dev] [ovs-dev, PATCHv6] netdev-afxdp: add new netdev type for AF_XDP.

On Fri, Apr 26, 2019 at 2:46 AM Ilya Maximets wrote: > On 25.04.2019 2:47, William Tu wrote: > > diff --git a/lib/netdev.c b/lib/netdev.c > > index 7d7ecf6f0946..c30016b34033 100644 > > --- a/lib/netdev.c > > +++ b/lib/netdev.c > > @@ -145,6 +145,7 @@ netdev_initialize(void) > >

Re: [ovs-dev] [PATCH] OVN: Fix failures after OVS/OVN split

On 4/25/19 4:45 PM, Ben Pfaff wrote: On Thu, Apr 25, 2019 at 04:33:03PM -0400, Brian Haley wrote: On 4/25/19 4:26 PM, Ben Pfaff wrote: On Thu, Apr 25, 2019 at 04:08:15PM -0400, Brian Haley wrote: Added TODO_SPLIT.rst to Makefile.am to avoid an error during build. Removed a section from

Re: [ovs-dev] OVS/OVN Split initial commits are complete

On 4/26/19 1:44 AM, Numan Siddique wrote: On Fri, Apr 26, 2019 at 1:56 AM Ben Pfaff > wrote: On Thu, Apr 25, 2019 at 12:51:29PM -0700, Ben Pfaff wrote: > On Thu, Apr 25, 2019 at 08:38:06AM -0400, Mark Michelson wrote: > > Yesterday, I once again performed

Re: [ovs-dev] OVS/OVN Split initial commits are complete

On 4/25/19 3:51 PM, Ben Pfaff wrote: On Thu, Apr 25, 2019 at 08:38:06AM -0400, Mark Michelson wrote: Yesterday, I once again performed the task of splitting OVN from OVS (I've gotten pretty good at it now). This time, rather than living in a personal repo, you can find the ovn repo at

[ovs-dev] [PATCH v2] system-offloads-traffic.at: Fix requesting HW offloaded flows from veth.

veth pair doesn't offload anything to HW. i.e. we should use 'tc' type while requesting flows. 'offloaded' kept just in case to not update the test if veths will be HW offloaded someday. Additionally fixed missed for unknown reason 'ipv4' fields. Also dropped stripping of the errors from log.

Re: [ovs-dev] [PATCH] system-offloads-traffic.at: Fix requesting HW oofloaded flows from veth.

s/oofloaded/offloaded/ ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] system-offloads-traffic.at: Fix requesting HW oofloaded flows from veth.

veth pair doesn't offload anything to HW. i.e. we should use 'tc' type while requesting flows. 'offloaded' kept just in case to not update the test if veths will be HW offloaded someday. Additionally fixed missed for unknown reason 'ipv4' fields. Also dropped stripping of the errors from log.

Re: [ovs-dev] [PATCH 1/1] dpdk: Use DPDK 18.11.1 release.

On 25.04.2019 13:42, Ian Stokes wrote: > On 4/25/2019 11:09 AM, Ilya Maximets wrote: >> "On 24.04.2019 20:03, Ian Stokes wrote: >>> Modify travis linux build script to use the latest >>> DPDK stable release 18.11.1. Update docs for latest >>> DPDK stable releases. >>> >>> Signed-off-by: Ian Stokes

Re: [ovs-dev] [ovs-dev, PATCHv6] netdev-afxdp: add new netdev type for AF_XDP.

On 25.04.2019 2:47, William Tu wrote: > diff --git a/lib/netdev.c b/lib/netdev.c > index 7d7ecf6f0946..c30016b34033 100644 > --- a/lib/netdev.c > +++ b/lib/netdev.c > @@ -145,6 +145,7 @@ netdev_initialize(void) > netdev_register_provider(_linux_class); >