Re: [ovs-dev] [PATCHv8] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-15 Thread William Tu
Hi Ilya, Thanks for your feedback. On Mon, May 13, 2019 at 10:48 AM Ilya Maximets wrote: > > On 10.05.2019 2:54, William Tu wrote: > > The patch introduces experimental AF_XDP support for OVS netdev. > > AF_XDP, Address Family of the eXpress Data Path, is a new Linux socket type > > built upon

Re: [ovs-dev] [PATCHv8] netdev-afxdp: add new netdev type for AF_XDP.

2019-05-15 Thread William Tu
> > + OVS AF_XDP netdev is using the userspace datapath, the same datapath > > + as used by OVS-DPDK. So it requires --disable-system for ovs-vswitchd > > + and datapath_type=netdev when adding a new bridge. > > I don't think that '--disable-system' is needed. It doesn't affect anything. >

Re: [ovs-dev] [PATCH v4 4/4] netdev-offload: Rename offload providers.

2019-05-15 Thread Aaron Conole
Aaron Conole writes: > Ilya Maximets writes: > >> On 15.05.2019 19:13, Ilya Maximets wrote: >>> Hi Aaron. >>> >>> Robot complains about lines not touched by this patch. >>> This is strange. >> >> I suspect that it's because of file renaming. > > Yes, I think you're correct. > >> What git

Re: [ovs-dev] [PATCH v2] ovn: Add a new logical switch port type - 'virtual'

2019-05-15 Thread Han Zhou
On Wed, May 15, 2019 at 11:55 AM Numan Siddique wrote: > > > On Thu, May 16, 2019 at 12:10 AM Han Zhou wrote: > >> >> >> On Wed, May 15, 2019 at 11:36 AM wrote: >> > >> > From: Numan Siddique >> > >> > This new type is added for the following reasons: >> > >> > - When a load balancer is

Re: [ovs-dev] [PATCH v2] ovn: Add a new logical switch port type - 'virtual'

2019-05-15 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 190 characters long (recommended limit is 79) #496 FILE:

Re: [ovs-dev] [PATCH] OVN: grab pinctrl_mutex before running pinctrl_handle_buffered_packets

2019-05-15 Thread Han Zhou
On Wed, May 15, 2019 at 6:34 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > pinctrl_handle_buffered_packets can insert new elements in > buffered_packets_map hasmap and it runs concurrently with pinctrl_run > starting from commit 3594ffab6b4b. Fix possible races grabbing >

Re: [ovs-dev] [PATCH] ovn-ctl: Set max open files limit for SB DB.

2019-05-15 Thread aginwala
Acked-by: aginwala On Wed, May 15, 2019 at 8:58 AM Han Zhou wrote: > > > On Wed, May 15, 2019 at 12:53 AM aginwala wrote: > >> >> >> On Tue, May 14, 2019 at 3:15 PM Han Zhou wrote: >> >>> From: Han Zhou >>> >>> Increase the limit on the number of open file descriptors, because >>> SB DB

Re: [ovs-dev] [PATCH] ovn: Add a new logical switch port type - 'virtual'

2019-05-15 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 190 characters long (recommended limit is 79) #491 FILE:

Re: [ovs-dev] [PATCH v2] ovn: Add a new logical switch port type - 'virtual'

2019-05-15 Thread Numan Siddique
On Thu, May 16, 2019 at 12:10 AM Han Zhou wrote: > > > On Wed, May 15, 2019 at 11:36 AM wrote: > > > > From: Numan Siddique > > > > This new type is added for the following reasons: > > > > - When a load balancer is created in an OpenStack deployment with > Octavia > > service, it

Re: [ovs-dev] [PATCH v1] OVN: Fix the ovn-controller 100% usage issue with put_mac_bindings

2019-05-15 Thread Ankur Sharma
Hi Numan, Just confirming, anything else pending from my side? or given that patch has been Acked, hence someone will apply it to master? Thanks Regards, Ankur From: Numan Siddique Sent: Wednesday, May 15, 2019 11:43 AM To: Ankur Sharma Cc: Han Zhou ; ovs-dev@openvswitch.org Subject: Re:

Re: [ovs-dev] [PATCH v9 2/5] dpif-netdev: move dpcls lookup structures to .h

2019-05-15 Thread Ian Stokes
On 5/8/2019 4:13 PM, Harry van Haaren wrote: This commit moves some data-structures to be available in the dpif-netdev.h header. This allows specific implementations of the subtable lookup function to include just that header file, and not require that the code exists in dpif-netdev.c

Re: [ovs-dev] [PATCH v1] OVN: Fix the ovn-controller 100% usage issue with put_mac_bindings

2019-05-15 Thread Numan Siddique
Gentle ping on this patch. This fix is a bit critical to fix the ovn-controller CPU usage. Thanks Numan On Sat, May 11, 2019 at 2:34 PM Numan Siddique wrote: > > > On Sat, May 11, 2019 at 2:09 PM Numan Siddique > wrote: > >> >> >> On Sat, May 11, 2019 at 5:38 AM Ankur Sharma >> wrote: >> >>>

Re: [ovs-dev] [PATCH v2] ovn: Add a new logical switch port type - 'virtual'

2019-05-15 Thread Han Zhou
On Wed, May 15, 2019 at 11:36 AM wrote: > > From: Numan Siddique > > This new type is added for the following reasons: > > - When a load balancer is created in an OpenStack deployment with Octavia > service, it creates a logical port 'VIP' for the virtual ip. > > - This logical port is

[ovs-dev] [PATCH v2] ovn: Add a new logical switch port type - 'virtual'

2019-05-15 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a

Re: [ovs-dev] [PATCH] cirrus: Disable coredumps on FreeBSD.

2019-05-15 Thread Ben Pfaff
On Wed, May 15, 2019 at 11:14:15AM +0300, Ilya Maximets wrote: > On 15.05.2019 8:51, Ben Pfaff wrote: > > On Tue, May 14, 2019 at 07:23:59PM +0300, Ilya Maximets wrote: > >> Some tests uses 'kill -SEGV' to simulate segfault of a child process. > >> This causes test failures on CirrusCI because

[ovs-dev] [PATCH] ovn: Add a new logical switch port type - 'virtual'

2019-05-15 Thread nusiddiq
From: Numan Siddique This new type is added for the following reasons: - When a load balancer is created in an OpenStack deployment with Octavia service, it creates a logical port 'VIP' for the virtual ip. - This logical port is not bound to any VIF. - Octavia service creates a

Re: [ovs-dev] OVS-DPDK public meeting

2019-05-15 Thread Kevin Traynor
Next meeting June 12th 1700 UTC May 15th minutes Attendees: Asaf, David, Flavio, Frikkie, Ian, Simon, Thomas, Aaron, Johann, Ophir, Roni, Kevin. === GENERAL === - Timing of meeting (Kevin) -- Should we move it to an earlier time? -- Some people from US west coast are attending - DPDK

Re: [ovs-dev] [PATCH v9 1/5] dpif-netdev: implement function pointers/subtable

2019-05-15 Thread Ian Stokes
On 5/8/2019 4:13 PM, Harry van Haaren wrote: This allows plugging-in of different subtable hash-lookup-verify routines, and allows special casing of those functions based on known context (eg: # of bits set) of the specific subtable. Signed-off-by: Harry van Haaren --- v9: - Use count_1bits

Re: [ovs-dev] [PATCH v4 4/4] netdev-offload: Rename offload providers.

2019-05-15 Thread Aaron Conole
Ilya Maximets writes: > On 15.05.2019 19:13, Ilya Maximets wrote: >> Hi Aaron. >> >> Robot complains about lines not touched by this patch. >> This is strange. > > I suspect that it's because of file renaming. Yes, I think you're correct. > What git version you're using? Or maybe some special

Re: [ovs-dev] [PATCH v4 4/4] netdev-offload: Rename offload providers.

2019-05-15 Thread Ilya Maximets
On 15.05.2019 19:13, Ilya Maximets wrote: > Hi Aaron. > > Robot complains about lines not touched by this patch. > This is strange. I suspect that it's because of file renaming. What git version you're using? Or maybe some special options? > > Best regards, Ilya Maximets. > > On 15.05.2019

Re: [ovs-dev] [PATCH v4 4/4] netdev-offload: Rename offload providers.

2019-05-15 Thread Ilya Maximets
Hi Aaron. Robot complains about lines not touched by this patch. This is strange. Best regards, Ilya Maximets. On 15.05.2019 19:05, 0-day Robot wrote: > Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered

Re: [ovs-dev] [PATCH] ovn-ctl: Set max open files limit for SB DB.

2019-05-15 Thread Han Zhou
On Wed, May 15, 2019 at 12:53 AM aginwala wrote: > > > On Tue, May 14, 2019 at 3:15 PM Han Zhou wrote: > >> From: Han Zhou >> >> Increase the limit on the number of open file descriptors, because >> SB DB may connect to large number of chassises. >> >> Signed-off-by: Han Zhou >> --- >>

[ovs-dev] [PATCH v4 4/4] netdev-offload: Rename offload providers.

2019-05-15 Thread Ilya Maximets
Flow API providers renamed to be consistent with parent module 'netdev-offload' and look more like each other. '_rte_' replaced with more convenient '_dpdk_'. We'll have following structure: Common code: lib/netdev-offload-provider.h lib/netdev-offload.c lib/netdev-offload.h

[ovs-dev] [PATCH v4 1/4] netdev: Dynamic per-port Flow API.

2019-05-15 Thread Ilya Maximets
Current issues with Flow API: * OVS calls offloading functions regardless of successful flow API initialization. (ex. on init_flow_api failure) * Static initilaization of Flow API for a netdev_class forbids having different offloading types for different instances of netdev with the same

[ovs-dev] [PATCH v4 2/4] dpctl: Update docs about dump-flows and HW offloading.

2019-05-15 Thread Ilya Maximets
Since introduction of dynamic flow API for netdevs, tricky accesses to uninitialized flow API are no longer possible. So, ovs-dpctl doesn't support dumping HW offloaded flows now. Claim this in docs and man pages. Additionally forbidden 'type' argument for 'ovs-dpctl dump-flows'. Signed-off-by:

[ovs-dev] [PATCH v4 0/4] netdev: Dynamic per-port Flow API + Offload Split Up.

2019-05-15 Thread Ilya Maximets
This is the combined patch-set for dynamic flow API along with the further work about splitting up netdev offloading from the generic netdev related code and making different netdev flow offloading implementations more or less consistent. Version 4: * Added dpctl related patch. * No other

Re: [ovs-dev] [RFC V2] netdev-rte-offloads: HW offload virtio-forwarder

2019-05-15 Thread Ilya Maximets
On 15.05.2019 16:01, Roni Bar Yanai wrote: > Hi Ilya, > > Thanks for the comment. > I think the suggested arch is very good and has many advantages, and in fact > I had something very similar as my internally first approach. > However, I had one problem: it doesn't solves the kernel case. It

[ovs-dev] [PATCH] OVN: grab pinctrl_mutex before running pinctrl_handle_buffered_packets

2019-05-15 Thread Lorenzo Bianconi
pinctrl_handle_buffered_packets can insert new elements in buffered_packets_map hasmap and it runs concurrently with pinctrl_run starting from commit 3594ffab6b4b. Fix possible races grabbing pinctrl_mutex before running pinctrl_handle_buffered_packets Fixes: 3594ffab6b4b ("ovn-controller: Add a

Re: [ovs-dev] [RFC V2] netdev-rte-offloads: HW offload virtio-forwarder

2019-05-15 Thread Roni Bar Yanai
Hi Ilya, Thanks for the comment. I think the suggested arch is very good and has many advantages, and in fact I had something very similar as my internally first approach. However, I had one problem: it doesn't solves the kernel case. It make sense doing forwarding using dpdk also when OVS is

Re: [ovs-dev] [PATCH v3 1/3] netdev: Dynamic per-port Flow API.

2019-05-15 Thread Ilya Maximets
On 15.05.2019 8:33, Roi Dayan wrote: > > > On 14/05/2019 19:20, Ilya Maximets wrote: >> On 14.05.2019 18:24, Roi Dayan wrote: >>> >>> >>> On 14/05/2019 18:16, Roi Dayan wrote: >> >> >> Hi, I did a quick ping test between two ports and after this commit the command

Re: [ovs-dev] [RFC V2] netdev-rte-offloads: HW offload virtio-forwarder

2019-05-15 Thread Ilya Maximets
On 06.05.2019 13:43, Roni Bar Yanai wrote: > Background > == > OVS HW offload solution is consisted of forwarding and control. HW implements > embedded switch that connects SRIOV VF's and forwards packets according to the > dynamically configured HW rules (packets can be altered by HW

Re: [ovs-dev] [PATCH v3 1/3] dpif-netdev: Only poll enabled vhost queues.

2019-05-15 Thread Ilya Maximets
On 25.04.2019 18:22, David Marchand wrote: > We currently poll all available queues based on the max queue count > exchanged with the vhost peer and rely on the vhost library in DPDK to > check the vring status beneath. > This can lead to some overhead when we have a lot of unused queues. > > To

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Post-copy Live Migration support for vhost-user-client.

2019-05-15 Thread Maxime Coquelin
On 5/14/19 3:08 PM, Ilya Maximets wrote: From: Liliia Butorina Post-copy Live Migration for vHost supported since DPDK 18.11 and QEMU 2.12. New global config option 'vhost-postcopy-support' added to control this feature. Ex.: ovs-vsctl set Open_vSwitch .

Re: [ovs-dev] [PATCH v2 1/2] vswitchd: Track status of memory locking.

2019-05-15 Thread Maxime Coquelin
On 5/14/19 3:08 PM, Ilya Maximets wrote: Needed for the future post-copy live migration support for vhost-user ports. Signed-off-by: Ilya Maximets --- lib/util.c | 15 +++ lib/util.h | 3 +++ vswitchd/ovs-vswitchd.c | 2 ++ 3 files changed, 20

Re: [ovs-dev] € 2,000,000.00 Euro

2019-05-15 Thread Richard Wahl
Hallo, Sie haben eine Spende von € 2.000.000,00 EUR, bitte kontaktieren Sie mich umgehend für weitere Informationen. Antworten Sie mit dem auf diese E-Mail: richardpoverty...@gmail.com ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] cirrus: Disable coredumps on FreeBSD.

2019-05-15 Thread Ilya Maximets
On 15.05.2019 8:51, Ben Pfaff wrote: > On Tue, May 14, 2019 at 07:23:59PM +0300, Ilya Maximets wrote: >> Some tests uses 'kill -SEGV' to simulate segfault of a child process. >> This causes test failures on CirrusCI because process hangs in DL state >> for more than 10 seconds: > > That seems

Re: [ovs-dev] [PATCH] ovn-ctl: Set max open files limit for SB DB.

2019-05-15 Thread aginwala
On Tue, May 14, 2019 at 3:15 PM Han Zhou wrote: > From: Han Zhou > > Increase the limit on the number of open file descriptors, because > SB DB may connect to large number of chassises. > > Signed-off-by: Han Zhou > --- > ovn/utilities/ovn-ctl | 8 > 1 file changed, 8 insertions(+) >

Re: [ovs-dev] [PATCH ovn-org/ovn 1/1] tests: Remove non OVN test files

2019-05-15 Thread Numan Siddique
On Thu, May 9, 2019 at 10:08 PM Numan Siddique wrote: > > > On Thu, May 9, 2019 at 9:45 PM Lorenzo Bianconi < > lorenzo.bianc...@redhat.com> wrote: > >> > > >> > > From: Numan Siddique >> > > >> > > This patch cleans up the tests folder and removes the non OVN >> > > test files. >> > > >> > >