Thanks for the patch
Few comments inline
On Thu, Jul 25, 2019 at 4:30 PM Yi-Hung Wei wrote:
> This patch derives the timeout policy based on ct zone from the
> internal data structure that reads the configuration from ovsdb.
>
> Signed-off-by: Yi-Hung Wei
> ---
> lib/ct-dpif.c
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Dan Carpenter needs to sign off.
WARNING: Unexpected sign-offs from developers
From: Han Zhou
The commit ca545a78 made sure that xxx_is_new() for the rows
referencing other rows returned false instead of true. However,
it caused xxx_is_new() for the row being referenced returned false,
even if the row was newly added. This patch fixes it.
Fixes: ca545a787ac0 (ovsdb-idl.c:
This patch derives the timeout policy based on ct zone from the
internal data structure that reads the configuration from ovsdb.
Signed-off-by: Yi-Hung Wei
---
lib/ct-dpif.c| 10 ++
lib/ct-dpif.h| 3 +++
lib/datapath-config.c| 30
This patch adds a system traffic test to verify the zone-based conntrack
timeout feature. The test uses ovs-vsctl commands to configure
the customized ICMP and UDP timeout on zone 5 to a shorter period.
It then injects ICMP and UDP traffic to conntrack, and checks if the
corresponding conntrack
This patch adds support for specifying a timeout policy for a
connection in connection tracking system in kernel datapath.
The timeout policy will be attached to a connection when the
connection is committed to conntrack.
This patch introduces a new odp field OVS_CT_ATTR_TIMEOUT in the
ct action
This patch brings in nf_ct_timeout_put() and nf_ct_set_timeout()
when it is not available in the kernel.
Three symbols are created in acinclude.m4.
* HAVE_NF_CT_SET_TIMEOUT is used to determine if upstream net-next commit
717700d183d65 ("netfilter: Export nf_ct_{set,destroy}_timeout()") is
This patch implements all the conntrack timeout policy related functions
defined in dpif_class for dpif-netlink class in Linux kernel datapath.
In Linux kernel, the timeout policy is maintained per L3/L4 protocol,
and it is identified by 32 bytes null terminated string. However,
in vswitchd, the
This patch reads the datapath, CT_Zone, and CT_Timeout_Policy tables
from ovsdb, stores the information in a per datapath internal datapath
structure, and pushes down the conntrack timeout policy into the
datapath via dpif interface.
The per datapath internal data structure will be used in
These functions will be useful in the following patches.
Signed-off-by: Yi-Hung Wei
---
lib/ct-dpif.c | 53 +
lib/ct-dpif.h | 3 +++
2 files changed, 56 insertions(+)
diff --git a/lib/ct-dpif.c b/lib/ct-dpif.c
index
This function will be useful for following patchs.
Signed-off-by: Yi-Hung Wei
---
lib/ct-dpif.c | 3 +--
lib/ct-dpif.h | 1 +
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ct-dpif.c b/lib/ct-dpif.c
index 5d8a75d3a63f..6ea7feb0ee35 100644
--- a/lib/ct-dpif.c
+++
This patch defines the dpif interface for a datapath to support
adding, deleting, getting and dumping conntrack timeout policy.
The timeout policy is identified by a 4 bytes unsigned integer in
datapath, and it currently support timeout for TCP, UDP, and ICMP
protocols.
Signed-off-by: Yi-Hung Wei
From: William Tu
The patch adds the following commands
$ ovs-vsctl {add,del,list}-dp
for creating/deleting/listing the datapath, and
$ ovs-vsctl {add,del,list}-zone-tp
for conntrack zones and timeout policies.
Signed-off-by: William Tu
---
tests/ovs-vsctl.at | 20 +++-
From: Justin Pettit
Signed-off-by: Justin Pettit
---
vswitchd/vswitch.ovsschema | 44 +++-
vswitchd/vswitch.xml | 254 -
2 files changed, 249 insertions(+), 49 deletions(-)
diff --git a/vswitchd/vswitch.ovsschema
From: Ben Pfaff
Signed-off-by: Ben Pfaff
---
lib/simap.c | 15 ++-
lib/simap.h | 1 +
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/lib/simap.c b/lib/simap.c
index d634f8ed9eea..f404ece67703 100644
--- a/lib/simap.c
+++ b/lib/simap.c
@@ -1,5 +1,5 @@
/*
- *
This patch series enables zone-based conntrack timeout policy support in OVS.
Timeout policy is a set of timeout attributes that can be associated with a
connection when it is committed. Then, the connection tracking system will
expire a connection based on its connection state. For example, one
From: Han Zhou
>From ovn-controller debug log it is seen that when creating a lsp
in NB, a lflow for ARP respond is added and then deleted in SB
by northd (the flow will be added again when the port is bound
to a chassis). This causes unnecessary handling from ovn-controller.
The root cause is
On Thu, Jul 25, 2019 at 08:39:21AM -0700, Ben Pfaff wrote:
> On Thu, Jul 25, 2019 at 11:21:25AM +0300, Ilya Maximets wrote:
> > On 25.07.2019 6:09, Ben Pfaff wrote:
> > > On Wed, Jul 24, 2019 at 08:25:54PM +0300, Ilya Maximets wrote:
> > >> On 24.07.2019 20:05, Ben Pfaff wrote:
> > >>>
Forgot the e-mail address after my name :)
Acked-by: Mark Michelson
On 7/25/19 4:16 PM, Mark Michelson wrote:
Acked-by: Mark Michelson
Thanks for the informative commit message!
On 7/23/19 10:52 PM, Han Zhou wrote:
From: Han Zhou
When there are in-flight flow-installations pending to
LGTM
Acked-by: Mark Michelson
On 7/25/19 11:38 AM, Daniel Alvarez wrote:
Prior to this patch, when a LRP has only IPv6 addresses, ovn-northd
will crash (SIGSEV) because the current code injects a flow to
emit the ICMP need-to-frag from its IPv4 address which does not
exist.
This patch is
Acked-by: Mark Michelson
Thanks for the informative commit message!
On 7/23/19 10:52 PM, Han Zhou wrote:
From: Han Zhou
When there are in-flight flow-installations pending to ovs-vswitchd,
current incremental processing logic prioritizes new change handling.
However, in scenarios where
On Wed, Jul 24, 2019 at 08:09:25PM -0700, Ben Pfaff wrote:
> On Wed, Jul 24, 2019 at 08:25:54PM +0300, Ilya Maximets wrote:
> > On 24.07.2019 20:05, Ben Pfaff wrote:
> > > Signed-off-by: Ben Pfaff
> > > ---
> > > Based on an off-lst discussion with Ilya. This is just my first, off-hand
> > >
On 7/25/19 12:37 PM, Ilya Maximets wrote:
Hi.
I have a question regarding the split.
Sorry if it's obvious from the RFC splitting code which I didn't look at.
The question is:
How the patches for the common data structures (lists, hash maps) will be
applied to OVN? Will we need to post same
That is good news! I am pleased to hear that the split is coming soon.
On Wed, Jul 24, 2019 at 02:46:17PM -0400, Mark Michelson wrote:
> Numan and I have discussed this, and we're planning to perform the split
> tomorrow July 25. Numan will be applying the commits he referenced below to
> the
On 25.07.2019 19:27, Ben Pfaff wrote:
> On Thu, Jul 25, 2019 at 07:09:22PM +0300, Ilya Maximets wrote:
>> No need to use quotes for strings like "br0".
>>
>> Keeping UUIDs always in quotes to avoid different treatment of those
>> that starts with digits and those that starts with letters.
>>
>>
Thanks! Could I get a backport to whatever branches backports are still
available for? I tested that it applied cleanly on 2.9 and passed tests
there. That code hasn't changed in a while.
On Tue, Jul 16, 2019 at 12:20 PM Ben Pfaff wrote:
> On Thu, Jul 11, 2019 at 08:00:20AM -0500, Terry Wilson
Hi.
I have a question regarding the split.
Sorry if it's obvious from the RFC splitting code which I didn't look at.
The question is:
How the patches for the common data structures (lists, hash maps) will be
applied to OVN? Will we need to post same patch for both repositories in the
future if
Designated initializers are not suitable for initializing non-packed
structures and unions which are subjects for comparison by memcmp().
Whole memory for 'struct user_action_cookie' must be explicitly cleared
before using because it will be copied with memcpy and later compared
by memcmp in
On Thu, Jul 25, 2019 at 07:09:22PM +0300, Ilya Maximets wrote:
> No need to use quotes for strings like "br0".
>
> Keeping UUIDs always in quotes to avoid different treatment of those
> that starts with digits and those that starts with letters.
>
> Signed-off-by: Ilya Maximets
> ---
>
>
No need to use quotes for strings like "br0".
Keeping UUIDs always in quotes to avoid different treatment of those
that starts with digits and those that starts with letters.
Signed-off-by: Ilya Maximets
---
Version 2:
* Added special treatment for UUIDs.
lib/ovsdb-data.c |
Hi,
Thanks for the quick patch Daniel. Without this patch I was getting a
segmentation fault in ovn-northd:
http://paste.openstack.org/show/754850/. Daniel debugged it and found
the problem, I applied this patch and now it works :D
On Thu, Jul 25, 2019 at 4:38 PM Daniel Alvarez wrote:
>
> Prior
On Thu, Jul 25, 2019 at 11:21:25AM +0300, Ilya Maximets wrote:
> On 25.07.2019 6:09, Ben Pfaff wrote:
> > On Wed, Jul 24, 2019 at 08:25:54PM +0300, Ilya Maximets wrote:
> >> On 24.07.2019 20:05, Ben Pfaff wrote:
> >>> Signed-off-by: Ben Pfaff
> >>> ---
> >>> Based on an off-lst discussion with
Prior to this patch, when a LRP has only IPv6 addresses, ovn-northd
will crash (SIGSEV) because the current code injects a flow to
emit the ICMP need-to-frag from its IPv4 address which does not
exist.
This patch is adding a check to skip the flow installation in case
the port does not have any
First City Monument Bank.
In conjunction with the Debt management office of the Federal republic
of Nigeria.
Sir,
This message today Thursday dated 25th day of July 2019 is to know if you are
still interested receiving your compensation payment value at two
million, five hundred thousand
alt_text
Le Guide du CPF
(Compte Personnel de Formation)
Tout savoir depuis la reforme du 1er janvier 2019
Notre guide, mis a jour dernierement par nos experts conseillers, vous donne
les cles pour comprendre tous les changements operes cette annee et savoir
comment lutiliser pour financer votre
On 25.07.2019 6:09, Ben Pfaff wrote:
> On Wed, Jul 24, 2019 at 08:25:54PM +0300, Ilya Maximets wrote:
>> On 24.07.2019 20:05, Ben Pfaff wrote:
>>> Signed-off-by: Ben Pfaff
>>> ---
>>> Based on an off-lst discussion with Ilya. This is just my first, off-hand
>>> thought on the topic. Feedback
On Thu, Jul 25, 2019 at 12:51 AM Han Zhou wrote:
>
>
>
> On Mon, Jul 8, 2019 at 2:11 PM Ben Pfaff wrote:
> >
> > On Mon, Jul 08, 2019 at 12:06:45PM +0200, Dumitru Ceara wrote:
> > > The chassis_run code didn't take into account the scenario when the
> > > system-id was changed in the
РУССКИЙ ШАНСОН
Только самые лучшие песни и известные шансонье
Здравствуйте, предлагаем Вашему внимаю, пожалуй, самую уникальную коллекцию
отечественного шансона. Основные отличия нашей коллекции от других, это большое
количество вошедших песен, высокое качество записей и широкий круг
38 matches
Mail list logo
