Hi,
Please consider this as gentle remainder and kindly review the patch set.
Thanks & Regards,
Sriram.
-Original Message-
From: Sriram Vatala
Sent: 11 October 2019 16:58
To: 'ovs-dev@openvswitch.org' ;
'i.maxim...@ovn.org'
Subject: RE: [PATCH v9 2/2] netdev-dpdk:Detailed packet drop
On 10/15/2019 5:14 AM, Gregory Rose wrote:
>
>
> On 10/8/2019 4:51 PM, Greg Rose wrote:
>> From: wenxu
>>
>> Upstream commit:
>> commit 18b6f717483a835fb98de9f0df6c724df9324e78
>> Author: wenxu
>> Date: Thu Mar 28 12:43:23 2019 +0800
>>
>> openvswitch: Make metadata_dst
Hi Ben:
Can you also push this to OVS master? Got it merged in ovn repo already.
On Fri, Oct 11, 2019 at 2:06 PM wrote:
> From: Aliasgar Ginwala
>
> building ovn/ovs container breaks while configure:
> checking for Python 3 (version 3.4 or later)... no
> configure: error: Python 3.4 or later
On Mon, Oct 14, 2019 at 4:38 PM Ben Pfaff wrote:
> On Mon, Oct 14, 2019 at 03:33:25PM -0700, Ben Pfaff wrote:
> > On Wed, Oct 09, 2019 at 04:56:40PM -0700, amgin...@gmail.com wrote:
> > > From: Aliasgar Ginwala
> > >
> > > Add new env variables OVN_NBCTL_OPTIONS and OVN_SBCTL_OPTIONS for
> > >
Nice to meet you,
There is a vital issue I need to discuss with you urgently. Confirm your
email valid for conscious security reason.
Best regards,
My contact E-mail: info...@zoho.com
___
dev mailing list
d...@openvswitch.org
On Mon, 14 Oct 2019 10:37:43 -0700
Yi-Hung Wei wrote:
> From: Flavio Leitner
>
> upstream patch:
>
> commit fa7e428c6b7ed3281610511a2b2ec716d9894be8
> Author: Flavio Leitner
> Date: Mon Mar 25 15:58:31 2019 -0300
>
> openvswitch: add seqadj extension when NAT is used.
>
> When
On Mon, Oct 14, 2019 at 03:33:25PM -0700, Ben Pfaff wrote:
> On Wed, Oct 09, 2019 at 04:56:40PM -0700, amgin...@gmail.com wrote:
> > From: Aliasgar Ginwala
> >
> > Add new env variables OVN_NBCTL_OPTIONS and OVN_SBCTL_OPTIONS for
> > ovn-nbctl and ovn-sbctl respectively where user can set any
On Mon, Oct 14, 2019 at 03:18:01PM -0700, Gregory Rose wrote:
> On 10/10/2019 12:07 PM, Ben Pfaff wrote:
> > This workaround only applied to kernels earlier than 2.6.37, but OVS
> > only supports 3.10 and later.
> >
> > As the original author of this code, I won't miss it.
> >
> > Signed-off-by:
LGTM, thanks.
Reviewed-by: Yifeng Sun
On Mon, Oct 14, 2019 at 10:56 AM Yi-Hung Wei wrote:
>
> Upstream commit:
> commit 248d45f1e1934f7849fbdc35ef1e57151cf063eb
> Author: Yi-Hung Wei
> Date: Fri Oct 4 09:26:44 2019 -0700
>
> openvswitch: Allow attaching helper in later commit
>
>
LGTM, thanks.
Reviewed-by: Yifeng Sun
On Mon, Oct 14, 2019 at 10:55 AM Yi-Hung Wei wrote:
>
> Upstream commit:
> commit 12c6bc38f99bb168b7f16bdb5e855a51a23ee9ec
> Author: Yi-Hung Wei
> Date: Wed Aug 21 17:16:10 2019 -0700
>
> openvswitch: Fix log message in ovs conntrack
>
> Fixes:
LGTM, thanks.
Reviewed-by: Yifeng Sun
On Mon, Oct 14, 2019 at 10:55 AM Yi-Hung Wei wrote:
>
> Backports the following upstream commit with some backward compatibility
> change.
>
> commit f319ca6557c10a711facc4dd60197470796d3ec1
> Author: Geert Uytterhoeven
> Date: Wed May 8 08:52:32 2019
LGTM, thanks.
Reviewed-by: Yifeng Sun
On Mon, Oct 14, 2019 at 10:54 AM Yi-Hung Wei wrote:
>
> From: Colin Ian King
>
> upstream commit:
>
> commit ca96534630e2edfd73121c487c957b17eca3b7d7
> Author: Colin Ian King
> Date: Wed May 1 14:41:58 2019 +0100
>
> openvswitch: check for null
LGTM, thanks.
Reviewed-by: Yifeng Sun
On Mon, Oct 14, 2019 at 10:54 AM Yi-Hung Wei wrote:
>
> This commit backports the following upstream commit, and two functions
> in nf_conntrack_helper.h.
>
> Upstream commit:
> commit fec9c271b8f1bde1086be5aa415cdb586e0dc800
> Author: Flavio Leitner
>
LGTM, thanks.
Reviewed-by: Yifeng Sun
On Mon, Oct 14, 2019 at 10:53 AM Yi-Hung Wei wrote:
>
> This patch backports the following upstream commit within the
> openvswitch kernel module with some checks so that it also works
> in the older kernel.
>
> Upstream commit:
> commit
LGTM, thanks.
Reviewed-by: Yifeng Sun
On Mon, Oct 14, 2019 at 10:53 AM Yi-Hung Wei wrote:
>
> This patch backports the openvswitch changes and update the compat layer
> for the following upstream patch.
>
> commit ae0be8de9a53cda3505865c11826d8ff0640237c
> Author: Michal Kubecek
> Date: Fri
LGTM, thanks.
Reviewed-by: Yifeng Sun
On Mon, Oct 14, 2019 at 10:52 AM Yi-Hung Wei wrote:
>
> Starting from the following upstream commit, NF_NAT_NEEDED is replaced
> by IS_ENABLED(CONFIG_NF_NAT) in the upstream kernel. This patch makes
> some changes so that our in tree ovs kernel module is
LGTM, thanks.
Reviewed-by: Yifeng Sun
On Mon, Oct 14, 2019 at 10:51 AM Yi-Hung Wei wrote:
>
> The following two upstream commits merge nf_nat_ipv4 and nf_nat_ipv6
> into nf_nat core, and move some header files around. To handle
> these modifications, this patch detects the upstream changes,
LGTM, thanks.
Reviewed-by: Yifeng Sun
On Mon, Oct 14, 2019 at 10:51 AM Yi-Hung Wei wrote:
>
> From: Flavio Leitner
>
> upstream patch:
>
> commit fa7e428c6b7ed3281610511a2b2ec716d9894be8
> Author: Flavio Leitner
> Date: Mon Mar 25 15:58:31 2019 -0300
>
> openvswitch: add seqadj
A minor issue in commit message: pl_nf_ct_invert_tuple => rpl_nf_ct_invert_tuple
Other than that, LGTM, thanks.
Reviewed-by: Yifeng Sun
On Mon, Oct 14, 2019 at 10:50 AM Yi-Hung Wei wrote:
>
> After upstream net-next commit 303e0c558959 ("netfilter: conntrack:
> avoid unneeded
Found by inspection.
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif-xlate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index f92cb62c80ce..0fa5d8a7c61b 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++
On Wed, Oct 09, 2019 at 04:56:40PM -0700, amgin...@gmail.com wrote:
> From: Aliasgar Ginwala
>
> Add new env variables OVN_NBCTL_OPTIONS and OVN_SBCTL_OPTIONS for
> ovn-nbctl and ovn-sbctl respectively where user can set any single
> supported option. e.g export
On Thu, Oct 10, 2019 at 07:58:02PM -0400, 0-day Robot wrote:
> WARNING: New doc ovs-appctl.8.rst not listed in Documentation/automake.mk
> WARNING: New doc ovs-ctl.8.rst not listed in Documentation/automake.mk
> WARNING: New doc ovs-l3ping.8.rst not listed in Documentation/automake.mk
> WARNING:
On 10/10/2019 12:07 PM, Ben Pfaff wrote:
This workaround only applied to kernels earlier than 2.6.37, but OVS
only supports 3.10 and later.
As the original author of this code, I won't miss it.
Signed-off-by: Ben Pfaff
Nice.
I applied the patch and compile tested it. I then ran 'make
On 10/8/2019 4:51 PM, Greg Rose wrote:
From: wenxu
Upstream commit:
commit 18b6f717483a835fb98de9f0df6c724df9324e78
Author: wenxu
Date: Thu Mar 28 12:43:23 2019 +0800
openvswitch: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode
There is currently no
Thank you for the review. I applied this to master.
On Mon, Oct 14, 2019 at 12:16:59PM -0700, Yifeng Sun wrote:
> LGTM, thanks.
>
> Reviewed-by: Yifeng Sun
>
> On Mon, Oct 14, 2019 at 11:28 AM Ben Pfaff wrote:
> >
> > Usually a plural name refers to an array, but 'socks' and 'socksp' were
>
On Tue, Oct 15, 2019 at 12:42:04AM +0530, Numan Siddique wrote:
> On Mon, Oct 14, 2019 at 11:45 PM Numan Siddique wrote:
>
> >
> >
> > On Mon, Oct 14, 2019 at 11:37 PM Ben Pfaff wrote:
> >
> >> On Mon, Oct 14, 2019 at 08:50:02PM +0530, nusid...@redhat.com wrote:
> >> > From: Numan Siddique
>
On Fri, Oct 11, 2019 at 11:46:29AM +0800, zhaozhanxu wrote:
> Add argument '-m' for command ovs-appctl bridge/dump-flows
> to display the offloaded packets statistics.
This seems like a reasonable addition, and the code looks OK too.
Before, with 2 pointers as function parameters, it was OK to
LGTM, thanks.
Reviewed-by: Yifeng Sun
On Mon, Oct 14, 2019 at 11:28 AM Ben Pfaff wrote:
>
> Usually a plural name refers to an array, but 'socks' and 'socksp' were
> only single objects, so this changes their names to 'sock' and 'sockp'.
>
> Usually a 'p' suffix means that a variable is an
On Mon, Oct 14, 2019 at 11:45 PM Numan Siddique wrote:
>
>
> On Mon, Oct 14, 2019 at 11:37 PM Ben Pfaff wrote:
>
>> On Mon, Oct 14, 2019 at 08:50:02PM +0530, nusid...@redhat.com wrote:
>> > From: Numan Siddique
>> >
>> > The commit [1] force drops all connections when the db read/write
>>
Usually a plural name refers to an array, but 'socks' and 'socksp' were
only single objects, so this changes their names to 'sock' and 'sockp'.
Usually a 'p' suffix means that a variable is an output argument, but
that was only true in one place here, so this changes the names of the
other
On Fri, Oct 11, 2019 at 03:50:47PM -0700, Yifeng Sun wrote:
> Valgrind reports:
> 20 bytes in 1 blocks are definitely lost in loss record 94 of 353
> by 0x532594: xmalloc (util.c:138)
> by 0x553EAD: nl_sock_create (netlink-socket.c:146)
> by 0x54331D: create_nl_sock
On Mon, Oct 14, 2019 at 11:37 PM Ben Pfaff wrote:
> On Mon, Oct 14, 2019 at 08:50:02PM +0530, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > The commit [1] force drops all connections when the db read/write status
> changes.
> > Prior to the commit [1], when there was read/write
On Mon, Oct 14, 2019, 11:42 PM Han Zhou wrote:
>
>
> On Mon, Oct 14, 2019 at 8:20 AM wrote:
>
>> From: Numan Siddique
>>
>> The commit [1] force drops all connections when the db read/write status
>> changes.
>> Prior to the commit [1], when there was read/write status change, the
>> existing
On Mon, Oct 14, 2019 at 8:20 AM wrote:
> From: Numan Siddique
>
> The commit [1] force drops all connections when the db read/write status
> changes.
> Prior to the commit [1], when there was read/write status change, the
> existing
> jsonrpc sessions with 'db_change_aware' set to true, were
On Mon, Oct 14, 2019 at 08:50:02PM +0530, nusid...@redhat.com wrote:
> From: Numan Siddique
>
> The commit [1] force drops all connections when the db read/write status
> changes.
> Prior to the commit [1], when there was read/write status change, the existing
> jsonrpc sessions with
0-day Robot writes:
> Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> git-am:
> fatal: sha1 information is lacking or useless
David Marchand writes:
> Add a coverage counter to help diagnose contention on the vhost txqs.
> This is seen as dropped packets on the physical ports for rates that
> are usually handled fine by OVS.
> Document how to further debug this contention with perf.
>
> Signed-off-by: David Marchand
>
Upstream commit:
commit 248d45f1e1934f7849fbdc35ef1e57151cf063eb
Author: Yi-Hung Wei
Date: Fri Oct 4 09:26:44 2019 -0700
openvswitch: Allow attaching helper in later commit
This patch allows to attach conntrack helper to a confirmed conntrack
entry. Currently, we can only attach
Upstream commit:
commit 12c6bc38f99bb168b7f16bdb5e855a51a23ee9ec
Author: Yi-Hung Wei
Date: Wed Aug 21 17:16:10 2019 -0700
openvswitch: Fix log message in ovs conntrack
Fixes: 06bd2bdf19d2 ("openvswitch: Add timeout support to ct action")
Signed-off-by: Yi-Hung Wei
Backports the following upstream commit with some backward compatibility
change.
commit f319ca6557c10a711facc4dd60197470796d3ec1
Author: Geert Uytterhoeven
Date: Wed May 8 08:52:32 2019 +0200
openvswitch: Replace removed NF_NAT_NEEDED with IS_ENABLED(CONFIG_NF_NAT)
Commit
From: Colin Ian King
upstream commit:
commit ca96534630e2edfd73121c487c957b17eca3b7d7
Author: Colin Ian King
Date: Wed May 1 14:41:58 2019 +0100
openvswitch: check for null pointer return from nla_nest_start_noflag
The call to nla_nest_start_noflag can return null in the unlikely
This commit backports the following upstream commit, and two functions
in nf_conntrack_helper.h.
Upstream commit:
commit fec9c271b8f1bde1086be5aa415cdb586e0dc800
Author: Flavio Leitner
Date: Wed Apr 17 11:46:17 2019 -0300
openvswitch: load and reference the NAT helper.
This improves
This patch backports the following upstream commit within the
openvswitch kernel module with some checks so that it also works
in the older kernel.
Upstream commit:
commit ef6243acb4782df587a4d7d6c310fa5b5d82684b
Author: Johannes Berg
Date: Fri Apr 26 14:07:31 2019 +0200
genetlink:
This patch backports the openvswitch changes and update the compat layer
for the following upstream patch.
commit ae0be8de9a53cda3505865c11826d8ff0640237c
Author: Michal Kubecek
Date: Fri Apr 26 11:13:06 2019 +0200
netlink: make nla_nest_start() add NLA_F_NESTED flag
Even if the
Starting from the following upstream commit, NF_NAT_NEEDED is replaced
by IS_ENABLED(CONFIG_NF_NAT) in the upstream kernel. This patch makes
some changes so that our in tree ovs kernel module is compatible to
both old and new kernels.
Upstream commit:
commit
From: Flavio Leitner
upstream patch:
commit fa7e428c6b7ed3281610511a2b2ec716d9894be8
Author: Flavio Leitner
Date: Mon Mar 25 15:58:31 2019 -0300
openvswitch: add seqadj extension when NAT is used.
When the conntrack is initialized, there is no helper attached
yet so the nat
The following two upstream commits merge nf_nat_ipv4 and nf_nat_ipv6
into nf_nat core, and move some header files around. To handle
these modifications, this patch detects the upstream changes, uses
the header files and config symbols properly.
Ideally, we should replace CONFIG_NF_NAT_IPV4 and
After upstream net-next commit 303e0c558959 ("netfilter: conntrack:
avoid unneeded nf_conntrack_l4proto lookups") nf_ct_invert_tuplepr()
is no longer available in the kernel.
Ideally, we should be in sync with upstream kernel by calling
nf_ct_invert_tuple() directly in conntrack.c. However,
This series backports conntrack related patches from upstream kernel.
It has been tested on
* Ubuntu 14.04, 16.04, and 18.04.
* RHEL 7.4-7.6.
* 5.0 kernel.
Travis test: https://travis-ci.org/YiHungWei/ovs/builds/596361660
Colin Ian King (1):
datapath: Check for null pointer return
From: Numan Siddique
The commit [1] force drops all connections when the db read/write status
changes.
Prior to the commit [1], when there was read/write status change, the existing
jsonrpc sessions with 'db_change_aware' set to true, were not updated with the
changed 'read_only' value. If the
On Mon, Oct 14, 2019 at 11:33 AM wrote:
>
> From: Numan Siddique
>
> The commit [1] force drops all connections when the db read/write status
> changes.
> Prior to the commit [1], when there was read/write status change, the existing
> jsonrpc sessions with 'db_change_aware' set to true, were
Hallo..
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Oct 14, 2019 at 2:23 PM Dumitru Ceara wrote:
> On Mon, Oct 14, 2019 at 8:21 AM wrote:
> >
> > From: Numan Siddique
> >
> > The commit [1] force drops all connections when the db read/write status
> changes.
> > Prior to the commit [1], when there was read/write status change, the
>
From: Numan Siddique
The commit [1] force drops all connections when the db read/write status
changes.
Prior to the commit [1], when there was read/write status change, the existing
jsonrpc sessions with 'db_change_aware' set to true, were not updated with the
changed 'read_only' value. If the
On Mon, Oct 14, 2019 at 8:21 AM wrote:
>
> From: Numan Siddique
>
> The commit [1] force drops all connections when the db read/write status
> changes.
> Prior to the commit [1], when there was read/write status change, the existing
> jsonrpc sessions with 'db_change_aware' set to true, were
From: Numan Siddique
The commit [1] force drops all connections when the db read/write status
changes.
Prior to the commit [1], when there was read/write status change, the existing
jsonrpc sessions with 'db_change_aware' set to true, were not updated with the
changed 'read_only' value. If the
56 matches
Mail list logo
