Re: [ovs-dev] [PATCH v2] Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

2019-11-21 Thread Varghese, Martin (Nokia - IN/Bangalore)
Hi I have posted again. Thanks, Martin -Original Message- From: Tonghao Zhang Sent: Friday, November 22, 2019 7:47 AM To: Gregory Rose ; Varghese, Martin (Nokia - IN/Bangalore) Cc: ovs dev Subject: Re: [ovs-dev] [PATCH v2] Change in openvswitch kernel module to support MPLS label

[ovs-dev] [PATCH] Datapath: Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

2019-11-21 Thread Martin Varghese
From: Martin Varghese Upstream commit: commit fbdcdd78da7c95f1b970d371e1b23cbd3aa990f3 Author: Martin Varghese Date: Mon Nov 4 07:27:44 2019 +0530 Change in Openvswitch to support MPLS label depth of 3 in ingress direction The openvswitch was supporting a MPLS label

Re: [ovs-dev] [PATCH v2] Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

2019-11-21 Thread Tonghao Zhang
On Fri, Nov 22, 2019 at 2:15 AM Gregory Rose wrote: > > > On 11/21/2019 7:49 AM, Martin Varghese wrote: > > From: Martin Varghese > > > > The openvswitch kernel module was supporting a MPLS label depth of 1 > > in the ingress direction though the userspace OVS supports a max depth > > of 3

Re: [ovs-dev] [PATCH] ofproto: Fix crash on PACKET_OUT due to recursive locking after upcall.

2019-11-21 Thread Anil Kumar Koli via dev
Hi Ben, I was not able to reproduce this issue in ovs sandbox, but able to test this patch on local testbed which had this issue and the patch works. Thanks & Regards, Anil Kumar. -Original Message- From: Ilya Maximets Sent: Friday, 22 November, 2019 12:02 AM To: Ilya Maximets ;

Re: [ovs-dev] [PATCH] flow: Fix IPv6 header parser with partial offloading.

2019-11-21 Thread Ben Pfaff
On Fri, Nov 08, 2019 at 05:02:44PM +0800, Zhike Wang wrote: > Set new_proto before it is used in parse_ipv6_ext_hdrs__(). > > Signed-off-by: Zhike Wang That's embarrassing. I applied this to master and branch-2.12. ___ dev mailing list

Re: [ovs-dev] [bug-report] Check Python IDL reconnects to leader unit case failed on arm64

2019-11-21 Thread Lance Yang (Arm Technology China)
Hi Ben, Thanks for your reply. I checked the original email I sent. I did attach the logs in my previous email. However, as you said, they might be stripped automatically. At this time, I compress everything into a zip file. I am not sure whether it would be stripped again. So I also attach a

Re: [ovs-dev] [PATCH] lacp: Add support to recognize LACP Marker RX PDUs.

2019-11-21 Thread Ben Pfaff
On Tue, Nov 12, 2019 at 09:08:59AM +0100, Nitin katiyar via dev wrote: > OVS does not support the LACP Marker protocol. Typically, ToR switches > send a LACP Marker PDU when restarting LACP negotiation following a link > flap or LACP timeout. > > When a LACP Marker PDU is received, OVS logs the

Re: [ovs-dev] [PATCH] ofproto-dpif: Allow IPv6 ND Extensions only if supported

2019-11-21 Thread Ben Pfaff
On Wed, Nov 20, 2019 at 11:28:03AM -0300, Flavio Leitner wrote: > On Wed, 20 Nov 2019 11:21:13 -0300 > Flavio Leitner wrote: > > > The IPv6 ND Extensions is only implemented in userspace datapath, > > but nothing prevents that to be used with other datapaths. > > > > This patch probes the

Re: [ovs-dev] [PATCH 1/2] bridge: Move sec_in_state to port statistics from port status.

2019-11-21 Thread Ben Pfaff
On Wed, Nov 20, 2019 at 05:54:28PM -0800, Krishna Kolakaluri wrote: > This commit moves the field sec_in_state field from port statistics to > port status structure.This helps in reducing the number of updates > sent to the controller, with the current mechanism everytime there is > a change in

Re: [ovs-dev] [bug-report] Check Python IDL reconnects to leader unit case failed on arm64

2019-11-21 Thread Ben Pfaff
On Thu, Nov 21, 2019 at 07:54:09AM +, Lance Yang (Arm Technology China) wrote: > Hi, > I encountered an issue when I was running testsuite on Arm. > The system I tested on was an arm server running Ubuntu 18.04.3 LTS > (GNU/Linux 4.15.0-65-generic aarch64). > After I downloaded the

Re: [ovs-dev] [PATCH] dp-packet: Fix clearing/copying of memory layout flags.

2019-11-21 Thread Ben Pfaff
On Thu, Nov 21, 2019 at 02:58:31PM +0100, Ilya Maximets wrote: > 'ol_flags' of DPDK mbuf could contain bits responsible for external > or indirect buffers which are not actually offload flags in a common > sense. Clearing/copying of these flags could lead to memory leaks of > external memory

Re: [ovs-dev] [PATCH v1] ovs container build: Make kernel module configurable

2019-11-21 Thread Ben Pfaff
On Tue, Nov 12, 2019 at 12:47:58AM -0800, amgin...@gmail.com wrote: > -./configure --localstatedir="/var" --sysconfdir="/etc" --prefix="/usr" \ > +if [ $KERNEL_VERSION == "host" ]; then Supporting == in [] or "test" is a GNUism. Use = for wider support (including BSD). > + ./configure

Re: [ovs-dev] [PATCH] ipf: bail out when ipf state is COMPLETED

2019-11-21 Thread Ben Pfaff
On Thu, Nov 14, 2019 at 07:38:55AM -0800, Darrell Ball wrote: > Hi RongQing/Wang > > On Thu, Nov 14, 2019 at 1:26 AM Li RongQing wrote: > > > it is easy to crash ovs when a packet with same id > > hits a list that already reassembled completedly > > but have not been sent out yet, and this

[ovs-dev] Venture Capital & Private Investors

2019-11-21 Thread Mr. Joon-Kyu Lin via dev
Attention: I am an investor that can provide funding for any viable business idea or venture. Please do let me know if you have fund management abilities, credible projects in need of funding or advanced stage projects requiring Bank Guarantees, Loans or Partnership, Joint Venture, Equity, we

Re: [ovs-dev] [PATCH v1 4/4] travis: Enable OVS Travis CI for arm

2019-11-21 Thread Ilya Maximets
On 20.11.2019 9:15, Lance Yang wrote: > Enable part of travis jobs with gcc compiler for arm64 architecture > > 1. Add arm jobs into the matrix in .travis.yml and define dpdk cache > directory for arm64 architecture. > 2. Temporarily disable sparse checker because of static code checking >

Re: [ovs-dev] [PATCH v1 3/4] travis: split cache and set target for

2019-11-21 Thread Ilya Maximets
On 20.11.2019 9:15, Lance Yang wrote: > To compile OvS with DPDK in some Travis jobs, it is necessary to set the > build target and split the dpdk cache directory according to different CPU > architectures. > > Reviewed-by: Yanqin Wei > Reviewed-by: Malvika Gupta > Signed-off-by: Lance Yang >

Re: [ovs-dev] [PATCH v1 2/4] travis: Move x86-only addon packages

2019-11-21 Thread Ilya Maximets
On 20.11.2019 9:14, Lance Yang wrote: > To enable multiple CPU architectures support, it is necessary to move the > x86-only addon packages from .travis.yml file. Otherwise, the x86-only > addon packages will break the builds on some other CPU architectures. > > Reviewed-by: Yangqin Wei >

Re: [ovs-dev] [PATCH v1 1/4] dpif-netdev: Fix the pmd_perf_stats

2019-11-21 Thread Ilya Maximets
On 20.11.2019 9:13, Lance Yang wrote: > When compiling Open vSwitch for aarch64, the compiler will warn about > an uninitailized variable in lib/dpif-netdev-perf.c. It is necessary to > initialize it to avoid build failure. Hi. Thanks for making OVS build on aarch64. Could you provide the error

[ovs-dev] [PATCH] ofproto-dpif: Refactor the get capability code.

2019-11-21 Thread William Tu
Make the code simpler by removing the use of xasprintf and free, and use smap_add_format. Cc: Ben Pfaff Signed-off-by: William Tu --- ofproto/ofproto-dpif.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c

Re: [ovs-dev] [PATCH] ovsdb raft: Fix election timer parsing in snapshot RPC.

2019-11-21 Thread Ben Pfaff
On Thu, Nov 21, 2019 at 10:57:41AM -0800, Han Zhou wrote: > On Thu, Nov 21, 2019 at 10:54 AM Ben Pfaff wrote: > > > > On Wed, Nov 13, 2019 at 09:33:59AM -0800, Han Zhou wrote: > > > Commit a76ba825 took care of saving and restoring election timer in > > > file header snapshot, but it didn't

Re: [ovs-dev] [PATCH] ovsdb raft: Fix election timer parsing in snapshot RPC.

2019-11-21 Thread Han Zhou
On Thu, Nov 21, 2019 at 10:54 AM Ben Pfaff wrote: > > On Wed, Nov 13, 2019 at 09:33:59AM -0800, Han Zhou wrote: > > Commit a76ba825 took care of saving and restoring election timer in > > file header snapshot, but it didn't handle the parsing of election > > timer in

Re: [ovs-dev] [PATCH] ovsdb raft: Fix election timer parsing in snapshot RPC.

2019-11-21 Thread Ben Pfaff
On Wed, Nov 13, 2019 at 09:33:59AM -0800, Han Zhou wrote: > Commit a76ba825 took care of saving and restoring election timer in > file header snapshot, but it didn't handle the parsing of election > timer in install_snapshot_request/reply RPC, which results in problems, > e.g. when election timer

Re: [ovs-dev] [PATCH] jsonrpc: increase input buffer size from 512 to 4096

2019-11-21 Thread Ben Pfaff
On Thu, Nov 21, 2019 at 10:46:59AM -0800, Ben Pfaff wrote: > On Wed, Nov 06, 2019 at 11:19:44AM +0200, Lorenzo Bianconi wrote: > > Increase jsonrpc input buffer size from 512 to 4096 bytes in order to > > reduce the syscall overhead when downloading huge db size > > > > Signed-off-by: Lorenzo

Re: [ovs-dev] [PATCH] jsonrpc: increase input buffer size from 512 to 4096

2019-11-21 Thread Ben Pfaff
On Wed, Nov 06, 2019 at 11:19:44AM +0200, Lorenzo Bianconi wrote: > Increase jsonrpc input buffer size from 512 to 4096 bytes in order to > reduce the syscall overhead when downloading huge db size > > Signed-off-by: Lorenzo Bianconi Applied to master, thanks!

Re: [ovs-dev] [PATCH ovn] ovn-detrace: Decode OVS Interfaces from ofproto/trace dumps.

2019-11-21 Thread Dumitru Ceara
On Thu, Nov 21, 2019 at 7:22 PM Mark Michelson wrote: > > I pushed this to master. Thanks! > > On 11/15/19 8:39 PM, Mark Michelson wrote: > > Acked-by: Mark Michelson > > > > On 11/15/19 2:24 PM, Dumitru Ceara wrote: > >> Two new command line arguments are added to ovn-detrace: > >> - "--ovs":

Re: [ovs-dev] [PATCH] ofproto: Fix crash on PACKET_OUT due to recursive locking after upcall.

2019-11-21 Thread Ilya Maximets
On 01.11.2019 22:24, Ilya Maximets wrote: > Handling of OpenFlow PACKET_OUT implies pushing the packet through > the datapath and packet processing inside the datapath could trigger > an upcall. In case of system datapath, 'dpif_execute()' sends packet > to the kernel module and returns. If any,

Re: [ovs-dev] [PATCH ovn] ovn-detrace: Decode OVS Interfaces from ofproto/trace dumps.

2019-11-21 Thread Mark Michelson
I pushed this to master. On 11/15/19 8:39 PM, Mark Michelson wrote: Acked-by: Mark Michelson On 11/15/19 2:24 PM, Dumitru Ceara wrote: Two new command line arguments are added to ovn-detrace: - "--ovs": which will instruct ovn-detrace to connect to the local OVS    db.sock and try to decode

Re: [ovs-dev] [PATCH v2] Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

2019-11-21 Thread Gregory Rose
On 11/21/2019 7:49 AM, Martin Varghese wrote: From: Martin Varghese The openvswitch kernel module was supporting a MPLS label depth of 1 in the ingress direction though the userspace OVS supports a max depth of 3 labels. This change enables openvswitch module to support a max depth of 3

Re: [ovs-dev] [PATCH v2] Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

2019-11-21 Thread Gregory Rose
On 11/21/2019 7:49 AM, Martin Varghese wrote: From: Martin Varghese The openvswitch kernel module was supporting a MPLS label depth of 1 in the ingress direction though the userspace OVS supports a max depth of 3 labels. This change enables openvswitch module to support a max depth of 3

Re: [ovs-dev] [PATCH v1 0/4] Fix issues and enable Travis CI on arm

2019-11-21 Thread Ben Pfaff
Hi Lance. Thanks for sending all the patches. In the future, please just send them to either d...@openvswitch.org or ovs-dev@openvswitch.org, not both. They are the same list. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCHv4] ofproto-dpif: Expose datapath capability to ovsdb.

2019-11-21 Thread William Tu
On Wed, Nov 20, 2019 at 05:20:35PM -0800, William Tu wrote: > On Wed, Nov 20, 2019 at 11:25:12AM -0800, Ben Pfaff wrote: > > On Wed, Nov 06, 2019 at 12:35:49PM -0800, William Tu wrote: > > > On Tue, Nov 05, 2019 at 04:49:10PM -0800, Ben Pfaff wrote: > > > > On Tue, Nov 05, 2019 at 02:57:46PM

Re: [ovs-dev] [bug-report] bfd decay unit case failure

2019-11-21 Thread Ben Pfaff
On Thu, Nov 21, 2019 at 09:25:49AM +, Lance Yang (Arm Technology China) wrote: > I encountered a unit test failure when I ran the Open vSwitch testsuite on > Travis CI aarch64 lxd container. > The environment can be found at line 7 : build system information section in > the report on

Re: [ovs-dev] [PATCH] ofproto-dpif: Allow IPv6 ND Extensions only if supported

2019-11-21 Thread Eelco Chaudron
On 20 Nov 2019, at 15:21, Flavio Leitner wrote: The IPv6 ND Extensions is only implemented in userspace datapath, but nothing prevents that to be used with other datapaths. This patch probes the datapath and only allows if the support is available. Fixes: 9b2b84973 ("Support for match & set

Re: [ovs-dev] [PATCH] netdev-afxdp: Enable libbpf logging to OVS.

2019-11-21 Thread William Tu
On Thu, Nov 21, 2019 at 11:37:48AM +0100, Eelco Chaudron wrote: > > On 20 Nov 2019, at 21:25, William Tu wrote: > > > libbpf has pr_warn, pr_info, and pr_debug. The patch registers > > these print functions, integrating the libbpf logs to OVS log. > > > > Signed-off-by: William Tu > > Looks

Re: [ovs-dev] [PATCHv4] ofproto-dpif: Expose datapath capability to ovsdb.

2019-11-21 Thread William Tu
On Wed, Nov 20, 2019 at 06:00:44PM -0800, Ben Pfaff wrote: > On Wed, Nov 20, 2019 at 05:20:35PM -0800, William Tu wrote: > > I think the above is not related. I will remove the manpages.mk diff. > > Rest below looks good to me. > > Yes, thanks! I fixed a couple minor issues (tab and lines > 79

Re: [ovs-dev] [PATCH] ofproto-dpif: Allow IPv6 ND Extensions only if supported

2019-11-21 Thread Aaron Conole
Flavio Leitner writes: > The IPv6 ND Extensions is only implemented in userspace datapath, > but nothing prevents that to be used with other datapaths. > > This patch probes the datapath and only allows if the support > is available. > > Fixes: 9b2b84973 ("Support for match & set ICMPv6 reserved

[ovs-dev] [PATCH v2] Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

2019-11-21 Thread Martin Varghese
From: Martin Varghese The openvswitch kernel module was supporting a MPLS label depth of 1 in the ingress direction though the userspace OVS supports a max depth of 3 labels. This change enables openvswitch module to support a max depth of 3 labels in the ingress. Signed-off-by: Martin Varghese

Re: [ovs-dev] [PATCH] dp-packet: Fix clearing/copying of memory layout flags.

2019-11-21 Thread Ilya Maximets
On 21.11.2019 14:58, Ilya Maximets wrote: > 'ol_flags' of DPDK mbuf could contain bits responsible for external > or indirect buffers which are not actually offload flags in a common > sense. Clearing/copying of these flags could lead to memory leaks of > external memory chunks and crashes due to

Re: [ovs-dev] [PATCH v2] netdev-afxdp: Best-effort configuration of XDP mode.

2019-11-21 Thread Eelco Chaudron
On 20 Nov 2019, at 17:43, Ilya Maximets wrote: On 20.11.2019 8:35, Eelco Chaudron wrote: On 19 Nov 2019, at 17:52, Ilya Maximets wrote: On 19.11.2019 17:16, Eelco Chaudron wrote: On 7 Nov 2019, at 12:36, Ilya Maximets wrote: Until now there was only two options for XDP mode in OVS:

Re: [ovs-dev] include/sparse/rte_flow.h

2019-11-21 Thread Ilya Maximets
On 20.11.2019 19:14, Stokes, Ian wrote: > > > On 11/20/2019 6:02 PM, Kevin Traynor wrote: >> On 19/11/2019 18:48, Ilya Maximets wrote: >>> On 19.11.2019 19:01, Eli Britstein wrote: On 11/19/2019 7:46 PM, Ilya Maximets wrote: > On 19.11.2019 18:29, Eli Britstein wrote: >> On

[ovs-dev] [PATCH] dp-packet: Fix clearing/copying of memory layout flags.

2019-11-21 Thread Ilya Maximets
'ol_flags' of DPDK mbuf could contain bits responsible for external or indirect buffers which are not actually offload flags in a common sense. Clearing/copying of these flags could lead to memory leaks of external memory chunks and crashes due to access to wrong memory. OVS should not clear

[ovs-dev] B2B COLLABORATION ( BUYING)

2019-11-21 Thread info
Hi, Located in the United Kingdom, famous supermarket chain Sainsbury's Supermarkets Limited, is UK's one of the largest multi-channel retailer with over 1423 shops furnished by European products. We are looking for new products to attract new customers and also retained our existing ones ,

Re: [ovs-dev] [PATCH v4 0/3] Associate identifier with OVN ACL connection tracking entry

2019-11-21 Thread Numan Siddique
On Sat, Nov 9, 2019 at 8:20 AM Ankur Sharma wrote: > > I submitted this patch long time back and somehow lost track it. > Resubmitting the series, calling it as V4, as it addresses the > review comments given till v3. > https://mail.openvswitch.org/pipermail/ovs-dev/2019-April/358280.html > >

Re: [ovs-dev] [PATCHv4] netdev-afxdp: Enable loading XDP program.

2019-11-21 Thread Eelco Chaudron
On 20 Nov 2019, at 21:17, William Tu wrote: On Tue, Nov 19, 2019 at 10:51:01AM -0800, William Tu wrote: Hi Eelco, Thanks for your testing. On Tue, Nov 12, 2019 at 11:25:55AM +0100, Eelco Chaudron wrote: See one remark below, however when I did a quick test with a program that would not

Re: [ovs-dev] [PATCH] netdev-afxdp: Enable libbpf logging to OVS.

2019-11-21 Thread Eelco Chaudron
On 20 Nov 2019, at 21:25, William Tu wrote: > libbpf has pr_warn, pr_info, and pr_debug. The patch registers > these print functions, integrating the libbpf logs to OVS log. > > Signed-off-by: William Tu Looks good to me… Acked-by: Eelco Chaudron

[ovs-dev] [bug-report] bfd decay unit case failure

2019-11-21 Thread Lance Yang (Arm Technology China)
Hi, I encountered a unit test failure when I ran the Open vSwitch testsuite on Travis CI aarch64 lxd container. The environment can be found at line 7 : build system information section in the report on https://travis-ci.org/yzyuestc/ovs/jobs/614941322 . The unit test case name is "bfd decay" ,

Re: [ovs-dev] [PATCH ovn 0/2] Add IPv6 Prefix delegation (RFC3633)

2019-11-21 Thread Lorenzo Bianconi
> On Thu, Nov 7, 2019 at 2:18 PM Lorenzo Bianconi > wrote: > > > > Introduce IPv6 Prefix delegation state machine according to RFC 3633 > > https://tools.ietf.org/html/rfc3633. > > Add dhcp6_server_pkt controller action to parse advertise/reply from > > IPv6 delegation server. > > Introduce

[ovs-dev] [bug-report] Check Python IDL reconnects to leader unit case failed on arm64

2019-11-21 Thread Lance Yang (Arm Technology China)
Hi, I encountered an issue when I was running testsuite on Arm. The system I tested on was an arm server running Ubuntu 18.04.3 LTS (GNU/Linux 4.15.0-65-generic aarch64). After I downloaded the up-to-date source code on master branch and built ovs, I run the testsuite with TESTSUITEFLAGS="2105"