On Wed, Nov 4, 2020 at 3:44 AM Mark Michelson wrote:
>
> Aside from spelling "update" properly in the title of patch 1, this
> looks good to me.
>
> Acked-by: Mark Michelson
Thanks Dumitru for fixing this issue and thanks Mark for the reviews.
I applied this patch series to master by updating
From: Justin Pettit
The upcoming ddlog implementation of northd needs these functions too,
so they should be in a common library.
Signed-off-by: Justin Pettit
ovn: Break out functions needed for ddlog.
---
lib/ovn-util.c | 79 +++--
lib/ovn-util.h
This makes it more debuggable.
Signed-off-by: Ben Pfaff
---
tests/ovn-northd.at | 67 +
1 file changed, 44 insertions(+), 23 deletions(-)
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index 9e7d8750f8fd..0bf20c1a7053 100644
---
The idea is to run each test twice, once with ovn-northd, once
with ovn-northd-ddlog. To do that, we add a macro OVN_FOR_EACH_NORTHD
and bracket each test that uses ovn-northd in it.
Signed-off-by: Ben Pfaff
---
tests/ovn-ic.at | 11 +-
tests/ovn-macros.at | 96 ++--
From: Leonid Ryzhyk
Export `ddlog_warn` and `ddlog_err` functions that are just wrappers
around `VLOG_WARN` and `VLOG_ERR`. This is not ideal because the
functions are exported by `ovn_util.c` and the resulting log messages use
`ovn_util` as module name. More importantly, these functions do
At the time this was written, there weren't any OVN releases independent
of OVS, but now there are so we should mention them.
Also, I don't think it's worth talking about compilers other than the
three listed. We haven't tested with them.
Signed-off-by: Ben Pfaff
---
This makes it possible for the upcoming ovn-northd-ddlog program to call
into it from Rust.
Signed-off-by: Ben Pfaff
---
lib/automake.mk | 1 +
lib/ovn-l7.c| 39 +++
lib/ovn-l7.h| 19 +--
3 files changed, 41 insertions(+), 18
This test assumed that datapaths and ports were assigned particular
tunnel keys, but this isn't guaranteed. Fix the problem by requesting
the required keys, with options:requested-tnl-key and
other_config:requested-tnl-key.
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 130
This makes it more debuggable.
Signed-off-by: Ben Pfaff
---
tests/ovn-northd.at | 116 +++-
1 file changed, 62 insertions(+), 54 deletions(-)
diff --git a/tests/ovn-northd.at b/tests/ovn-northd.at
index ae845e4eafd4..9e7d8750f8fd 100644
---
This is also available at:
https://github.com/blp/ovs-reviews/tree/ddlog7
Ben Pfaff (9):
tests: Improve "dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS".
tests: Improve "ipam" test.
tests: Fix port numbering in "1 LR with distributed gateway port".
tests: More careful checking.
tests: Improve "check
This change makes the test much more debuggable:
- Make it easier to find the particular failing test.
- Use correct checksums so that the packets can be compared for
equality instead of omitting the checksum field.
- Factor out packet comparison and produce better error messages on
This commit adds further use of "check" and other ways to make sure that
commands run during a test succeed.
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 125 +--
1 file changed, 52 insertions(+), 73 deletions(-)
diff --git a/tests/ovn.at
It's easier to follow this way.
Signed-off-by: Ben Pfaff
---
tests/ovn.at | 271 ++-
1 file changed, 72 insertions(+), 199 deletions(-)
diff --git a/tests/ovn.at b/tests/ovn.at
index 5666058d99ca..6282d0a6bb8a 100644
--- a/tests/ovn.at
+++
View Attachment!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Nov 3, 2020 at 4:06 PM Gregory Rose wrote:
> On 11/3/2020 2:17 PM, Yi-Hung Wei wrote:
> > On Tue, Oct 20, 2020 at 10:07 AM Greg Rose wrote:
> >>
> >> RHEL 7.7 has a KABI fixup in struct sk_buff to backport the member
> >> name change of l4_rxhash to l4_hash. This exposed a couple of
>
On Tue, 3 Nov 2020 09:25:49 +0100 Eelco Chaudron wrote:
> Silence suspicious RCU usage warning in ovs_flow_tbl_masks_cache_resize()
> by replacing rcu_dereference() with rcu_dereference_ovsl().
>
> In addition, when creating a new datapath, make sure it's configured under
> the ovs_lock.
>
>
On 11/3/2020 2:17 PM, Yi-Hung Wei wrote:
On Tue, Oct 20, 2020 at 10:07 AM Greg Rose wrote:
RHEL 7.7 has a KABI fixup in struct sk_buff to backport the member
name change of l4_rxhash to l4_hash. This exposed a couple of
issues in patch 8063e0958780 which was intended to remove support
for
Using meters is a great way to keep the ovn-controllers from getting
overwhelmed with ACL log events. Since multiple ACL rows with logging
enabled can refer to the same meter name, I ran a little experiment
to better understand how that behaves [1].
>From that experiment, we see that a 'noisy'
On Tue, Oct 20, 2020 at 10:07 AM Greg Rose wrote:
>
> In ../compat/nf_conntrack_reasm.c nf_frags_cache_name is declared
> if OVS_NF_DEFRAG6_BACKPORT is defined. However, later in the patch
> it is only used if HAVE_INET_FRAGS_WITH_FRAGS_WORK is defined and
> HAVE_INET_FRAGS_RND is not defined.
On Tue, Oct 20, 2020 at 10:07 AM Greg Rose wrote:
>
> RHEL 7.7 has a KABI fixup in struct sk_buff to backport the member
> name change of l4_rxhash to l4_hash. This exposed a couple of
> issues in patch 8063e0958780 which was intended to remove support
> for kernels older than 3.10.
>
> Remove
Aside from spelling "update" properly in the title of patch 1, this
looks good to me.
Acked-by: Mark Michelson
On 11/3/20 10:50 AM, Dumitru Ceara wrote:
This series aims at further restricting ARP/ND broadcast domain for self
originated packets. Until now those packets were always flooded on
When multiple ACL rows use the same meter for log rate-limiting, the
'noisiest' ACL matches may completely consume the meter and shadow other
ACL logs. This patch introduces an option in NB_Global that allows for a
meter to rate-limit each ACL log separately.
The change is backward compatible.
Using meters is a great way to keep the ovn-controllers from getting
overwhelmed with ACL log events. Since multiple ACL rows with logging
enabled can refer to the same meter name, I ran a little experiment
to better understand how that behaves [1].
>From that experiment, we see that a 'noisy'
Webinar en Vivo:
T-MEC implicaciones aduanales, arancelarias y logísticas en importaciones y
exportaciones.
18 y 19 de Noviembre - Horario de 10:00 a 17:00 Hrs.
Aportaremos a los interesados en el comercio exterior mexicano con Estados
Unidos y Canadá, los aspectos más relevantes del nuevo
On Tue, Nov 3, 2020 at 3:14 PM Numan Siddique wrote:
>
> On Fri, Oct 30, 2020 at 1:52 AM Dumitru Ceara wrote:
> >
> > On 10/27/20 6:16 PM, num...@ovn.org wrote:
> > > From: Numan Siddique
> > >
> > > Parsing of the load balancer VIPs is moved to a separate file - lib/lb.c.
> > > ovn-northd
On Mon, Oct 26, 2020 at 10:56:02AM +0100, Matthias May via dev wrote:
> I'm looking for a way to replicate the behaviour of a standard bridge.
> In a standard bridge when all members of the bridge report their
> operstate as down, the bridge itself reports its operstate down as well.
>
> Is there
Oh, it's about wireless. OVS doesn't have special 802.11 support.
On Tue, Oct 27, 2020 at 06:51:08AM +, Soliman Awad Alshra´a Abdullah TU
Ilmenau wrote:
>
> Dear sir,
>
>
> Attached you find the requested article
>
> Thanks
> M.Sc Abdullah Soliman
> Technische Universität Ilmenau
>
On Tue, Nov 03, 2020 at 03:53:51AM +0100, Ilya Maximets wrote:
> On 11/3/20 12:28 AM, Ben Pfaff wrote:
> > match_format() prints out "igmp" for IGMP flows, but
> > ofp_parse_protocol() didn't accept it, which meant that OVS would print
> > out a flow that it wouldn't re-parse. This fixes the
Fix the following warning reported by ovn-controller when there are no
active backends for lb health_check and selection_fields have been
configured for hash computation
flow|WARN|error parsing actions "drop;
hash_fields="ip_dst,ip_src,tcp_dst,tcp_src");":
Syntax error at `hash_fields' expecting
On 11/3/2020 2:12 AM, Timothy Redaelli wrote:
In commit a82083ee3091 ("Documentation: Add extra repo info for RHEL 8")
a newline was missing to correctly generate the code block to add
codeready-builder repository.
This commit adds the missing newline to correctly generate the code block
On 10/28/20 12:03 PM, Dumitru Ceara wrote:
> On 10/26/20 2:42 AM, Ilya Maximets wrote:
>> Under a heavy load or in a long run memory consumption if ovsdb-server
>> process that is part of a RAFT cluster could reach very high values.
>> From my experience it could be up to 60-100 GB. In these
Version 2:
- Skipping 3 patches that already applied.
- Fixed use of uninitialized backlog limits in jsonrpc_session,
i.e. added initialization on each jsorpc_session_open*()
- Added Acked-by from Dumitru to the last patch.
Original cover letter:
Under a heavy load or in a long run memory
New appctl 'cluster/set-backlog-threshold' to configure thresholds
on backlog of raft jsonrpc connections. Could be used, for example,
in some extreme conditions where size of a database expected to be
very large, i.e. comparable with default 4GB threshold.
Acked-by: Dumitru Ceara
RAFT messages could be fairly big. If something abnormal happens to
one of the servers in a cluster it may not be able to process all the
incoming messages in a timely manner. This results in jsonrpc backlog
growth on the sender's side. For example if follower gets many new
clients at once that
On 10/28/20 11:49 AM, Dumitru Ceara wrote:
> On 10/26/20 2:42 AM, Ilya Maximets wrote:
>> RAFT messages could be fairly big. If something abnormal happens to
>> one of the servers in a cluster it may not be able to process all the
>> incoming messages in a timely manner. This results in jsonrpc
This series aims at further restricting ARP/ND broadcast domain for self
originated packets. Until now those packets were always flooded on all
ports of the switch.
The first patch of the series is needed in order to remove dependency on
self-originated GARPs to be sent through the network (OVS)
Considering the following large scale deployment:
external-network -- public-logical-switch -- router-1 -- sw1 -- VIF-1
-- router-2 -- sw2 -- VIF-2
...
-- router-n -- swn
OVN uses GARPs to announce changes to locally owned NAT addresses. This is
OK when updating upstream router caches but is unnecessary for updating OVN
logical router MAC_Bindings.
ovn-controller already has the information required for directly
updating/inserting the MAC_Bindings that would be
On 10/28/20 11:58 AM, Dumitru Ceara wrote:
> On 10/26/20 2:42 AM, Ilya Maximets wrote:
>> Previous commit 8c2c503bdb0d ("raft: Avoid sending equal snapshots.")
>> took a "safe" approach to not send only exactly same snapshot
>> installation requests. However, it doesn't make much sense to send
>>
On 10/28/20 11:57 AM, Dumitru Ceara wrote:
> On 10/26/20 2:42 AM, Ilya Maximets wrote:
>> Compaction happens at most once in 10 minutes. That is a big time
>> interval for a heavy loaded ovsdb-server in cluster mode.
>> In 10 minutes raft logs could grow up to tens of thousands of entries
>> with
On 10/28/20 11:56 AM, Dumitru Ceara wrote:
> On 10/26/20 2:42 AM, Ilya Maximets wrote:
>> In many cases a big part of a memory consumed by ovsdb-server process
>> is a raft log, so it's important to add its length to the memory
>> report.
>>
>> Signed-off-by: Ilya Maximets
>> ---
>> ovsdb/raft.c
On 30/10/2020 15:45, Gaetan Rivet wrote:
> In some cloud topologies, using DPDK VF representors in guest requires
> configuring a VF before it is assigned to the guest.
>
> A first basic option for such configuration is setting the VF MAC
> address. Add a key 'dpdk-vf-mac' to the 'options' column
On 27/10/2020 14:03, Ilya Maximets wrote:
> On 10/20/20 1:15 PM, Kevin Traynor wrote:
>> On 16/09/2020 16:17, Gaetan Rivet wrote:
>>> In some cloud topologies, using DPDK VF representors in guest requires
>>> configuring a VF before it is assigned to the guest.
>>>
>>> A first basic option for
On 11/2/20 1:07 PM, Roi Dayan wrote:
> There is no need for a thread start per probe.
This sounds like we're actually starting some pthreads here.
I think, it should be something like:
"There is no need for a 'once' variable per probe."
Same for the patch name. E.g.
"netdev-offload-tc: Use
In commit a82083ee3091 ("Documentation: Add extra repo info for RHEL 8")
a newline was missing to correctly generate the code block to add
codeready-builder repository.
This commit adds the missing newline to correctly generate the code block
with the RHEL 8 codeready-builder instructions.
On Fri, Oct 30, 2020 at 1:52 AM Dumitru Ceara wrote:
>
> On 10/27/20 6:16 PM, num...@ovn.org wrote:
> > From: Numan Siddique
> >
> > Parsing of the load balancer VIPs is moved to a separate file - lib/lb.c.
> > ovn-northd makes use of these functions. Upcoming patch will make use of
> > these
>
On 2 Nov 2020, at 20:51, Jakub Kicinski wrote:
> On Mon, 02 Nov 2020 09:52:19 +0100 Eelco Chaudron wrote:
>> On 30 Oct 2020, at 22:28, Jakub Kicinski wrote:
@@ -1695,6 +1695,9 @@ static int ovs_dp_cmd_new(struct sk_buff *skb,
struct genl_info *info)
if (err)
Silence suspicious RCU usage warning in ovs_flow_tbl_masks_cache_resize()
by replacing rcu_dereference() with rcu_dereference_ovsl().
In addition, when creating a new datapath, make sure it's configured under
the ovs_lock.
Fixes: 9bf24f594c6a ("net: openvswitch: make masks cache size
48 matches
Mail list logo
