[ovs-dev] updating ovn's submodule for ovs

2021-02-25 Thread Ben Pfaff
Leonid pointed out that OVN's submodule for OVS is wrong now because it doesn't include what ovn-northd-ddlog needs to build. Do we have a policy or a practice on which commit to update it to? It's tempting to just pick "current tip of OVS master". ___

[ovs-dev] [PATCH v2] dpctl/add-flow: Fix ovs-dpdk crash when add dp flow without in_port field.

2021-02-25 Thread Mao YingMing
Fix the following ovs-dpdk crash and add a unit test for this issue to tests/dpif-netdev.at $ ovs-appctl dpctl/add-flow netdev@ovs-netdev "eth(),eth_type(0x0800),ipv4()" "3" unixctl|WARN|error communicating with unix:/usr/local/var/run/openvswitch/ovs-vswitchd.1995.ctl: End of file ovs-appctl:

Re: [ovs-dev] [PATCH v4 0/5] XDP offload using flow API provider

2021-02-25 Thread William Tu
On Thu, Feb 25, 2021 at 7:26 AM Toshiaki Makita wrote: > > On 2021/02/24 3:37, William Tu wrote: > > I don't know if this is too much to ask for. > > I wonder if you, or we can work together, to add at least a tunnel > > support, ex: vxlan? > > The current version is a good

Re: [ovs-dev] [PATCH RESEND v2 3/3] tests/dpif-netdev: Update dpif-netdev meter testcase.

2021-02-25 Thread Ilya Maximets
On 2/24/21 1:21 PM, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > The buckets used was changed, and now dpif-netdev support > burst_size, change the testcase. > > Signed-off-by: Tonghao Zhang > --- > tests/dpif-netdev.at | 16 > 1 file changed, 8 insertions(+), 8

Re: [ovs-dev] [PATCH RESEND v2 2/3] dpif-netdev: Add the burst size to buckets.

2021-02-25 Thread Ilya Maximets
On 2/24/21 1:21 PM, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > For now, the meter of the userspace datapath, don't include > the bucket burst size to buckets. Well, it was used before the patch 1/3 of this series. :) The problem seems to be that 'rate' was not used for bucket

Re: [ovs-dev] [PATCH RESEND v2 1/3] dpif-netdev: Fix the meter buckets overflow.

2021-02-25 Thread Ilya Maximets
On 2/24/21 1:21 PM, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > When setting the meter rate to 4.3+Gbps, there is an overflow, the > meters don't work as expected. > > $ ovs-ofctl -O OpenFlow13 add-meter br-int "meter=1 kbps stats > bands=type=drop rate=4294968" > > Before the

Re: [ovs-dev] [PATCH ovn] northd: Remove the usage of 'ct.inv' in logical flows.

2021-02-25 Thread Han Zhou
On Thu, Feb 25, 2021 at 1:25 AM Numan Siddique wrote: > > On Thu, Feb 25, 2021 at 1:12 PM Han Zhou wrote: > > > > On Wed, Feb 24, 2021 at 5:27 AM wrote: > > > > > > From: Numan Siddique > > > > > > Presently we add 65535 priority lflows in the stages - > > > 'ls_in_acl' and 'ls_out_acl' to

Re: [ovs-dev] [ovs-dev v2] ofproto: add refcount to ofproto to fix crash at ofproto_destroy

2021-02-25 Thread William Tu
On Thu, Feb 25, 2021 at 4:54 AM Ilya Maximets wrote: > > On 2/25/21 4:32 AM, Guohongzhi (Russell Lab) wrote: > > Refcount and RCU are not mutually exclusive. > > IMO, the main reason for this problem is that the rule uses both refcount > > and rcu, while the ofproto uses only rcu, and the rule

Re: [ovs-dev] [PATCH branch-2.7] ofproto-dpif-xlate: Fix leak in learn action

2021-02-25 Thread Gregory Rose
On 2/25/2021 3:18 AM, Darragh O'Reilly via dev wrote: This is a backport of commit 1bddcb5dc (ofproto-dpif-xlate: Fix bug that may leak ofproto_flow_mod) from branch-2.8. That commit won't cherry-pick cleanly onto branch-2.7 as the addition of the learn limit in 2.8 changed

Re: [ovs-dev] [PATCH ovn] ovn-northd: Warn for >1 IPv4 in build_lrouter_force_snat_flows_op().

2021-02-25 Thread Ben Pfaff
On Thu, Feb 25, 2021 at 11:21:26PM +0530, Numan Siddique wrote: > On Thu, Feb 25, 2021 at 4:57 AM Ben Pfaff wrote: > > > > The comments here point out that more than one IPv4 address is a > > problem (versus more than 2 IPv6 addresses), but the code doesn't match. > > > > Oops. My mistake.

Re: [ovs-dev] [PATCH ovn] ovn-northd: Warn for >1 IPv4 in build_lrouter_force_snat_flows_op().

2021-02-25 Thread Mark Gray
On 25/02/2021 17:51, Numan Siddique wrote: > On Thu, Feb 25, 2021 at 4:57 AM Ben Pfaff wrote: >> >> The comments here point out that more than one IPv4 address is a >> problem (versus more than 2 IPv6 addresses), but the code doesn't match. >> > > Oops. My mistake. Thanks for catching this. And

Re: [ovs-dev] [PATCH ovn v10.1 0/6] Add DDlog implementation of ovn-northd

2021-02-25 Thread Numan Siddique
On Thu, Feb 25, 2021 at 12:35 PM Ben Pfaff wrote: > > On Wed, Feb 24, 2021 at 12:40:17AM +0530, Numan Siddique wrote: > > On Tue, Feb 23, 2021 at 11:16 PM Ben Pfaff wrote: > > > > > > On Tue, Feb 23, 2021 at 07:38:12PM +0530, Numan Siddique wrote: > > > > On Tue, Feb 23, 2021 at 4:10 PM Numan

Re: [ovs-dev] [PATCH ovn] northd: Remove the usage of 'ct.inv' in logical flows.

2021-02-25 Thread Numan Siddique
On Thu, Feb 25, 2021 at 10:19 PM Ben Pfaff wrote: > > On Wed, Feb 24, 2021 at 06:56:38PM +0530, num...@ovn.org wrote: > > From: Numan Siddique > > > > Presently we add 65535 priority lflows in the stages - > > 'ls_in_acl' and 'ls_out_acl' to drop packets which > > match on 'ct.inv'. > > > > As

Re: [ovs-dev] [PATCH ovn] ovn-northd: Warn for >1 IPv4 in build_lrouter_force_snat_flows_op().

2021-02-25 Thread Numan Siddique
On Thu, Feb 25, 2021 at 4:57 AM Ben Pfaff wrote: > > The comments here point out that more than one IPv4 address is a > problem (versus more than 2 IPv6 addresses), but the code doesn't match. > Oops. My mistake. Thanks for catching this. Looks like you have addressed fixing the logic in the

Re: [ovs-dev] [OVN Patch v14 1/3] ovn-libs: Add support for parallel processing

2021-02-25 Thread Numan Siddique
On Thu, Feb 25, 2021 at 9:33 PM Anton Ivanov wrote: > > Good one. > > I will add handling for that. > > I think we can just restart the call if it is it an EINTR. The patches need rebase. Can you please rebase to the latest master and post them after addressing the review comments from me and

Re: [ovs-dev] [PATCH ovn 0/8] northd: build_lrouter_nat_defrag_and_lb refactor

2021-02-25 Thread Lorenzo Bianconi
> > On Thu, Feb 25, 2021 at 05:59:01PM +0100, Lorenzo Bianconi wrote: > > > > > > On Thu, Feb 25, 2021 at 01:49:18PM +0100, Lorenzo Bianconi wrote: > > > > Lorenzo Bianconi (8): > > > > northd: reduce indentation in build_lrouter_nat_defrag_and_lb > > > > northd: introduce

Re: [ovs-dev] [PATCH V2 11/14] netdev-offload-dpdk: Refactor offload rule creation

2021-02-25 Thread Sriharsha Basavapatna via dev
On Thu, Feb 25, 2021 at 7:51 PM Eli Britstein wrote: > > > On 2/25/2021 9:35 AM, Sriharsha Basavapatna wrote: > > On Wed, Feb 24, 2021 at 3:47 PM Eli Britstein wrote: > >> > >> On 2/24/2021 11:55 AM, Sriharsha Basavapatna wrote: > >>> On Wed, Feb 10, 2021 at 8:57 PM Eli Britstein wrote: >

Re: [ovs-dev] [PATCH V2 05/14] netdev-offload-dpdk: Implement HW miss packet recover for vport

2021-02-25 Thread Sriharsha Basavapatna via dev
On Thu, Feb 25, 2021 at 7:50 PM Eli Britstein wrote: > > > On 2/25/2021 9:34 AM, Sriharsha Basavapatna wrote: > > On Tue, Feb 23, 2021 at 7:24 PM Eli Britstein wrote: > >> > >> On 2/23/2021 3:10 PM, Sriharsha Basavapatna wrote: > >>> On Wed, Feb 10, 2021 at 8:57 PM Eli Britstein wrote: > A

Re: [ovs-dev] [PATCH ovn 0/8] northd: build_lrouter_nat_defrag_and_lb refactor

2021-02-25 Thread Ben Pfaff
On Thu, Feb 25, 2021 at 05:59:01PM +0100, Lorenzo Bianconi wrote: > > > > On Thu, Feb 25, 2021 at 01:49:18PM +0100, Lorenzo Bianconi wrote: > > > Lorenzo Bianconi (8): > > > northd: reduce indentation in build_lrouter_nat_defrag_and_lb > > > northd: introduce build_lrouter_lb_flows routine > >

Re: [ovs-dev] [PATCH ovn 0/8] northd: build_lrouter_nat_defrag_and_lb refactor

2021-02-25 Thread Lorenzo Bianconi
> > On Thu, Feb 25, 2021 at 01:49:18PM +0100, Lorenzo Bianconi wrote: > > Lorenzo Bianconi (8): > > northd: reduce indentation in build_lrouter_nat_defrag_and_lb > > northd: introduce build_lrouter_lb_flows routine > > northd: introduce build_lrouter_in_unsnat_flow routine > > northd:

Re: [ovs-dev] [PATCH v3] datapath: Add a new action dec_ttl

2021-02-25 Thread bindiya Kurle
On Tue, Nov 24, 2020 at 4:13 PM Eelco Chaudron wrote: > >Add support for the dec_ttl action. Instead of programming the datapath > with > >a flow that matches the packet TTL and an IP set, use a single dec_ttl > action. > > > >The old behavior is kept if the new action is not supported by the >

Re: [ovs-dev] [PATCH ovn] northd: Remove the usage of 'ct.inv' in logical flows.

2021-02-25 Thread Ben Pfaff
On Wed, Feb 24, 2021 at 06:56:38PM +0530, num...@ovn.org wrote: > From: Numan Siddique > > Presently we add 65535 priority lflows in the stages - > 'ls_in_acl' and 'ls_out_acl' to drop packets which > match on 'ct.inv'. > > As per the 'ovs-fields' man page, this > ct state field can be used to

Re: [ovs-dev] [PATCH ovn 0/8] northd: build_lrouter_nat_defrag_and_lb refactor

2021-02-25 Thread Ben Pfaff
On Thu, Feb 25, 2021 at 01:49:18PM +0100, Lorenzo Bianconi wrote: > Lorenzo Bianconi (8): > northd: reduce indentation in build_lrouter_nat_defrag_and_lb > northd: introduce build_lrouter_lb_flows routine > northd: introduce build_lrouter_in_unsnat_flow routine > northd: introduce

Re: [ovs-dev] [OVN Patch v14 1/3] ovn-libs: Add support for parallel processing

2021-02-25 Thread Anton Ivanov
Good one. I will add handling for that. I think we can just restart the call if it is it an EINTR. A. On 25/02/2021 15:18, Ilya Maximets wrote: On 2/12/21 3:49 PM, Anton Ivanov wrote: This adds a set of functions and macros intended to process hashes in parallel. The principles of

Re: [ovs-dev] [PATCH v4 3/5] netdev-offload: Add xdp flow api provider

2021-02-25 Thread Toshiaki Makita
On 2021/02/24 4:03, William Tu wrote: + +return 0; +} +#endif + static int xsk_load_prog(struct netdev *netdev, const char *path, struct bpf_object **pobj, int *prog_fd) { +struct netdev_linux *dev OVS_UNUSED = netdev_linux_cast(netdev); struct

[ovs-dev] [PATCH v2] ovs-ctl: Allow recording hostname separately

2021-02-25 Thread Frode Nordahl
ovs-ctl determines the system FQDN or hostname and records it in the `external-ids:hostname` field of the `Open-vSwitch` table on system startup if it is not already set. This value may be consumed by downstream software and having it unset or set to a incorrect value could lead to erratic

Re: [ovs-dev] [PATCH v4 0/5] XDP offload using flow API provider

2021-02-25 Thread Toshiaki Makita
On 2021/02/24 3:37, William Tu wrote: I don't know if this is too much to ask for. I wonder if you, or we can work together, to add at least a tunnel support, ex: vxlan? The current version is a good prototype for people to test an L2/L3 XDP offload switch, but without a good use case, it's hard

Re: [ovs-dev] [OVN Patch v14 1/3] ovn-libs: Add support for parallel processing

2021-02-25 Thread Ilya Maximets
On 2/12/21 3:49 PM, Anton Ivanov wrote: > This adds a set of functions and macros intended to process > hashes in parallel. > > The principles of operation are documented in the fasthmap.h > > If these one day go into the OVS tree, the OVS tree versions > would be used in preference. > >

Re: [ovs-dev] [OVN Patch v14 1/3] ovn-libs: Add support for parallel processing

2021-02-25 Thread Anton Ivanov
On 25/02/2021 14:29, Numan Siddique wrote: On Thu, Feb 25, 2021 at 7:33 PM Anton Ivanov wrote: Found the most likely culprit. This is similar to this: https://bugzilla.redhat.com/show_bug.cgi?id=663584 this: https://bugzilla.redhat.com/show_bug.cgi?id=1554955 and god knows how many others.

Re: [ovs-dev] [OVN Patch v14 1/3] ovn-libs: Add support for parallel processing

2021-02-25 Thread Numan Siddique
On Thu, Feb 25, 2021 at 7:33 PM Anton Ivanov wrote: > > Found the most likely culprit. > > This is similar to this: https://bugzilla.redhat.com/show_bug.cgi?id=663584 > this: https://bugzilla.redhat.com/show_bug.cgi?id=1554955 > and god knows how many others. > > Selinux is "securing" your

Re: [ovs-dev] [PATCH V2 13/14] netdev-offload-dpdk: Support vports flows offload

2021-02-25 Thread Eli Britstein
On 2/25/2021 9:35 AM, Sriharsha Basavapatna wrote: On Wed, Feb 24, 2021 at 4:50 PM Eli Britstein wrote: On 2/24/2021 12:37 PM, Sriharsha Basavapatna wrote: On Wed, Feb 10, 2021 at 8:57 PM Eli Britstein wrote: Vports are virtual, OVS only logical devices, so rte_flows cannot be applied as

Re: [ovs-dev] [PATCH V2 11/14] netdev-offload-dpdk: Refactor offload rule creation

2021-02-25 Thread Eli Britstein
On 2/25/2021 9:35 AM, Sriharsha Basavapatna wrote: On Wed, Feb 24, 2021 at 3:47 PM Eli Britstein wrote: On 2/24/2021 11:55 AM, Sriharsha Basavapatna wrote: On Wed, Feb 10, 2021 at 8:57 PM Eli Britstein wrote: Refactor offload rule creation as a pre-step towards tunnel matching that

Re: [ovs-dev] [PATCH V2 10/14] netdev-offload-dpdk: Support tunnel pop action

2021-02-25 Thread Eli Britstein
On 2/25/2021 9:35 AM, Sriharsha Basavapatna wrote: On Wed, Feb 24, 2021 at 1:50 PM Eli Britstein wrote: On 2/24/2021 9:52 AM, Sriharsha Basavapatna wrote: On Wed, Feb 10, 2021 at 8:57 PM Eli Britstein wrote: Support tunnel pop action. Signed-off-by: Eli Britstein Reviewed-by: Gaetan

Re: [ovs-dev] [PATCH V2 05/14] netdev-offload-dpdk: Implement HW miss packet recover for vport

2021-02-25 Thread Eli Britstein
On 2/25/2021 9:34 AM, Sriharsha Basavapatna wrote: On Tue, Feb 23, 2021 at 7:24 PM Eli Britstein wrote: On 2/23/2021 3:10 PM, Sriharsha Basavapatna wrote: On Wed, Feb 10, 2021 at 8:57 PM Eli Britstein wrote: A miss in virtual port offloads means the flow with tnl_pop was offloaded, but

Re: [ovs-dev] [PATCH V2 01/14] netdev-offload: Add HW miss packet state recover API

2021-02-25 Thread Eli Britstein
On 2/25/2021 9:34 AM, Sriharsha Basavapatna wrote: On Tue, Feb 23, 2021 at 6:51 PM Eli Britstein wrote: On 2/23/2021 3:10 PM, Sriharsha Basavapatna wrote: On Wed, Feb 10, 2021 at 8:57 PM Eli Britstein wrote: When the HW offload involves multiple flows, like in tunnel decap path, it is

Re: [ovs-dev] [PATCH] ovs-ctl: Allow recording hostname separately

2021-02-25 Thread Ilya Maximets
On 2/25/21 2:34 PM, Frode Nordahl wrote: > On Thu, Feb 25, 2021 at 1:33 PM Ilya Maximets wrote: >> >> On 2/25/21 6:56 AM, Frode Nordahl wrote: >>> On Wed, Feb 24, 2021 at 5:36 PM Ilya Maximets wrote: On 2/19/21 9:10 AM, Christian Ehrhardt wrote: > On Tue, Feb 16, 2021 at 5:32 PM

Re: [ovs-dev] [OVN Patch v14 1/3] ovn-libs: Add support for parallel processing

2021-02-25 Thread Anton Ivanov
Found the most likely culprit. This is similar to this: https://bugzilla.redhat.com/show_bug.cgi?id=663584 this: https://bugzilla.redhat.com/show_bug.cgi?id=1554955 and god knows how many others. Selinux is "securing" your semaphores. A. On 25/02/2021 13:27, Anton Ivanov wrote: On

Re: [ovs-dev] [PATCH] ovs-ctl: Allow recording hostname separately

2021-02-25 Thread Frode Nordahl
On Thu, Feb 25, 2021 at 1:33 PM Ilya Maximets wrote: > > On 2/25/21 6:56 AM, Frode Nordahl wrote: > > On Wed, Feb 24, 2021 at 5:36 PM Ilya Maximets wrote: > >> > >> On 2/19/21 9:10 AM, Christian Ehrhardt wrote: > >>> On Tue, Feb 16, 2021 at 5:32 PM Frode Nordahl > >>> wrote: > >

Re: [ovs-dev] [OVN Patch v14 1/3] ovn-libs: Add support for parallel processing

2021-02-25 Thread Anton Ivanov
On 25/02/2021 12:41, Numan Siddique wrote: On Fri, Feb 12, 2021 at 8:20 PM Anton Ivanov wrote: This adds a set of functions and macros intended to process hashes in parallel. The principles of operation are documented in the fasthmap.h If these one day go into the OVS tree, the OVS tree

Re: [ovs-dev] [PATCH] raft: Report disconnected in cluster/status if candidate retries election.

2021-02-25 Thread Ilya Maximets
On 2/25/21 8:14 AM, Han Zhou wrote: > > > On Tue, Feb 23, 2021 at 5:16 AM Ilya Maximets > wrote: >> >> If election times out for a server in 'candidate' role it sets >> 'candidate_retrying' flag that notifies that storage is disconnected >> and client should

Re: [ovs-dev] [ovs-dev v2] ofproto: add refcount to ofproto to fix crash at ofproto_destroy

2021-02-25 Thread Ilya Maximets
On 2/25/21 4:32 AM, Guohongzhi (Russell Lab) wrote: > Refcount and RCU are not mutually exclusive. > IMO, the main reason for this problem is that the rule uses both refcount and > rcu, while the ofproto uses only rcu, and the rule retains the pointer of the > ofproto. More importantly, ofproto

[ovs-dev] [PATCH ovn 8/8] northd: introduce lrouter_check_nat_entry routine

2021-02-25 Thread Lorenzo Bianconi
Introduce lrouter_check_nat_entry routine to check logical router per nat configuration and allow nat entry processing. Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 180 1 file changed, 97 insertions(+), 83 deletions(-) diff --git

[ovs-dev] [PATCH ovn 1/8] northd: reduce indentation in build_lrouter_nat_defrag_and_lb

2021-02-25 Thread Lorenzo Bianconi
Since all the code in the build_lrouter_nat_defrag_and_lb routine is executed if the current datapath is a logical router, just return if the condition is false. Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 1101 ++- 1 file changed, 551

[ovs-dev] [PATCH ovn 6/8] northd: introduce build_lrouter_out_snat_flow routine

2021-02-25 Thread Lorenzo Bianconi
Introduce build_lrouter_out_snat_flow routine as a container for logical router per nat configuration in build_lrouter_nat_defrag_and_lb routine for S_ROUTER_OUT_SNAT table. Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 195 ++-- 1 file

[ovs-dev] [PATCH ovn 3/8] northd: introduce build_lrouter_in_unsnat_flow routine

2021-02-25 Thread Lorenzo Bianconi
Introduce build_lrouter_in_unsnat_flow routine as a container for logical router per nat configuration in build_lrouter_nat_defrag_and_lb routine for S_ROUTER_IN_UNSNAT table. Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 127 +++- 1 file

[ovs-dev] [PATCH ovn 7/8] northd: introduce build_lrouter_ingress_flow routine

2021-02-25 Thread Lorenzo Bianconi
Introduce build_lrouter_ingress_flow routine as a container for logical router per nat configuration in build_lrouter_nat_defrag_and_lb routine for ingress tables. Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 82 + 1 file changed, 46

[ovs-dev] [PATCH ovn 5/8] northd: introduce build_lrouter_out_undnat_flow routine

2021-02-25 Thread Lorenzo Bianconi
Introduce build_lrouter_out_undnat_flow routine as a container for logical router per nat configuration in build_lrouter_nat_defrag_and_lb routine for S_ROUTER_OUT_UNDNAT table. Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 90 + 1 file

[ovs-dev] [PATCH ovn 4/8] northd: introduce build_lrouter_in_dnat_flow routine

2021-02-25 Thread Lorenzo Bianconi
Introduce build_lrouter_in_dnat_flow routine as a container for logical router per nat configuration in build_lrouter_nat_defrag_and_lb routine for S_ROUTER_IN_DNAT table. Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 203 +++- 1 file changed,

[ovs-dev] [PATCH ovn 2/8] northd: introduce build_lrouter_lb_flows routine

2021-02-25 Thread Lorenzo Bianconi
Introduce build_lrouter_lb_flows routine as a container for logical router load balancer configuration in build_lrouter_nat_defrag_and_lb routine. Signed-off-by: Lorenzo Bianconi --- northd/ovn-northd.c | 163 1 file changed, 88 insertions(+), 75

[ovs-dev] [PATCH ovn 0/8] northd: build_lrouter_nat_defrag_and_lb refactor

2021-02-25 Thread Lorenzo Bianconi
Lorenzo Bianconi (8): northd: reduce indentation in build_lrouter_nat_defrag_and_lb northd: introduce build_lrouter_lb_flows routine northd: introduce build_lrouter_in_unsnat_flow routine northd: introduce build_lrouter_in_dnat_flow routine northd: introduce build_lrouter_out_undnat_flow

Re: [ovs-dev] [OVN Patch v14 1/3] ovn-libs: Add support for parallel processing

2021-02-25 Thread Numan Siddique
On Fri, Feb 12, 2021 at 8:20 PM Anton Ivanov wrote: > > This adds a set of functions and macros intended to process > hashes in parallel. > > The principles of operation are documented in the fasthmap.h > > If these one day go into the OVS tree, the OVS tree versions > would be used in

Re: [ovs-dev] [PATCH] ovs-ctl: Allow recording hostname separately

2021-02-25 Thread Ilya Maximets
On 2/25/21 6:56 AM, Frode Nordahl wrote: > On Wed, Feb 24, 2021 at 5:36 PM Ilya Maximets wrote: >> >> On 2/19/21 9:10 AM, Christian Ehrhardt wrote: >>> On Tue, Feb 16, 2021 at 5:32 PM Frode Nordahl >>> wrote: ovs-ctl determines the system FQDN or hostname and records it in the

Re: [ovs-dev] [PATCH] netdev-linux: correct unit of burst parameter

2021-02-25 Thread Tonghao Zhang
On Thu, Feb 25, 2021 at 4:14 PM Simon Horman wrote: > > On Thu, Feb 25, 2021 at 10:21:15AM +0800, Tonghao Zhang wrote: > > On Wed, Feb 24, 2021 at 10:38 PM Simon Horman > > wrote: > > > > > From: Yong Xu > > > > > > Correct calculation of burst parameter used when configuring TC policer > > >

Re: [ovs-dev] [PATCH branch-2.7] ofproto-dpif-xlate: Fix leak in learn action

2021-02-25 Thread 0-day Robot
Bleep bloop. Greetings Darragh O'Reilly, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I

[ovs-dev] [PATCH branch-2.7] ofproto-dpif-xlate: Fix leak in learn action

2021-02-25 Thread Darragh O'Reilly via dev
This is a backport of commit 1bddcb5dc (ofproto-dpif-xlate: Fix bug that may leak ofproto_flow_mod) from branch-2.8. That commit won't cherry-pick cleanly onto branch-2.7 as the addition of the learn limit in 2.8 changed xlate_learn_action() a lot. Neutron ml2/ovs uses a learn action to learn

Re: [ovs-dev] [PATCH v2 ovn 0/3] Handle LB VIPs that share backends and make flows offloadable.

2021-02-25 Thread Dumitru Ceara
On 2/24/21 7:19 PM, Numan Siddique wrote: On Wed, Feb 24, 2021 at 9:40 PM Dumitru Ceara wrote: Patch 1/3 fixes a bug when using learn() action to generate hairpin reply flows for different VIPs that share backends. It also addresses backwards compatibility in order to avoid having issues

Re: [ovs-dev] [PATCH ovn v3] ovn-controller: Split logical flow and phsyical flow processing.

2021-02-25 Thread Mark Gray
On 18/02/2021 15:54, num...@ovn.org wrote: > From: Numan Siddique Hi Numans, I can't comment on the design change but I have a few comments/questions. It needs to be rebased again. Just to help move it along, I found a commit that it applies to and reviewed at that point. > > Presently, the

Re: [ovs-dev] [PATCH ovn] northd: Remove the usage of 'ct.inv' in logical flows.

2021-02-25 Thread Numan Siddique
On Thu, Feb 25, 2021 at 1:12 PM Han Zhou wrote: > > On Wed, Feb 24, 2021 at 5:27 AM wrote: > > > > From: Numan Siddique > > > > Presently we add 65535 priority lflows in the stages - > > 'ls_in_acl' and 'ls_out_acl' to drop packets which > > match on 'ct.inv'. > > > > As per the 'ovs-fields'

Re: [ovs-dev] [PATCH] netdev-linux: correct unit of burst parameter

2021-02-25 Thread Simon Horman
On Thu, Feb 25, 2021 at 10:21:15AM +0800, Tonghao Zhang wrote: > On Wed, Feb 24, 2021 at 10:38 PM Simon Horman > wrote: > > > From: Yong Xu > > > > Correct calculation of burst parameter used when configuring TC policer > > action for ingress port-based policing in the case where TC offload is