Re: [ovs-dev] [PATCH v4 0/2] Encap & Decap actions for MPLS packet type

On Mon, Jun 14, 2021 at 03:09:39PM +0200, Eelco Chaudron wrote: > Hi Martin, > > What is the status of this patchset? Are you going to send out a v5, as I > noticed quite some discussion with Jan, but I lost track? > HI Eelco, I am waiting for the below patches to get merged.

Re: [ovs-dev] [PATCH v4] netlink: removed incorrect optimization

On Mon, Jun 7, 2021 at 1:31 PM Toms Atteka wrote: > > This optimization caused FLOW_TNL_F_UDPIF flag not to be used in > hash calculation for geneve tunnel when revalidating flows which > resulted in different cache hash values and incorrect behaviour. > > Added test to prevent regression. > >

Re: [ovs-dev] [ovs-discuss] Patch for PACKET_OUT getting deleted twice crash

I did the patch as suggested, and it looks something like this: --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4168,9 +4168,13 @@ dpif_netdev_execute(struct dpif *dpif, struct dpif_execute *execute) flow_hash_5tuple(execute->flow, 0)); } +/* We are not

Re: [ovs-dev] [PATCH v6] ofproto-dpif: APIs and CLI option to add/delete static fdb entry

Ok Ben, Will do that. Thanks -Vasu *Vasu Dasari* On Mon, Jun 14, 2021 at 11:48 AM Ben Pfaff wrote: > On Fri, Jun 11, 2021 at 10:09:58PM -0400, Vasu Dasari wrote: > > Currently there is an option to add/flush/show ARP/ND neighbor. This > covers L3 > > side. For L2 side, there is only fdb

Re: [ovs-dev] [ovs-discuss] Patch for PACKET_OUT getting deleted twice crash

Yes, I can create that patch. Tony On Sat, Jun 12, 2021 at 5:24 AM Ilya Maximets wrote: > On 6/9/21 3:12 PM, Aaron Conole wrote: > > Ilya Maximets writes: > > > >> On 6/7/21 3:59 PM, Ilya Maximets wrote: > >>> On 6/7/21 3:09 PM, Aaron Conole wrote: > Ilya Maximets writes: > >

[ovs-dev] [PATCH v3] Remove Python 2 leftovers.

Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949875 Signed-off-by: Rosemarie O'Riorden --- Version 2: - Fixed import errors in v1. - Removed lines that indicate compatibility with python 2. Version 3: -

Re: [ovs-dev] [PATCH ovn] ovn-northd-ddlog: Fix memleak when destroying context.

On 6/10/21 7:26 PM, Ben Pfaff wrote: On Fri, Jun 04, 2021 at 06:48:13PM +0200, Dumitru Ceara wrote: This is benign but AddressSanitizer was complaining about it: Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x7fa93cd6d667 in __interceptor_malloc

Re: [ovs-dev] [External] : [PATCH ovn v2] ovn-northd.c: Add proxy ARP support to OVN

On Mon, Jun 14, 2021 at 5:19 AM Brendan Doyle wrote: > > Hi, > > Just wondering how to move this along. It's been in the queue a while now. > The product I'm working on requires this feature and If I can't get it > upstream > I'll need to look at other options. Hi Brendan, Sorry for the late

Re: [ovs-dev] [PATCH v2] odp-util: Return an error on actions overflow while parsing from string.

On 6/14/21 8:20 PM, Ben Pfaff wrote: > On Mon, Jun 14, 2021 at 07:36:01PM +0200, Ilya Maximets wrote: >> We don't need to continue parsing if already oversized. This is not >> very important, but fuzzer times out while parsing very long list of >> actions. >> >> Reported-at:

Re: [ovs-dev] [PATCH 2/2] bridge: Only an inactivity_probe of 0 should turn off inactivity probes.

On 6/11/21 12:49 AM, Ben Pfaff wrote: > The documentation for inactivity_probe says this: > >inactivity_probe: optional integer > Maximum number of milliseconds of idle time on connec‐ > tion to controller before sending an inactivity probe >

Re: [ovs-dev] [PATCH 1/2] fail-open: Only fail open if we've been disconnected for at least 1 s.

On 6/11/21 12:49 AM, Ben Pfaff wrote: > The 'last_disconn_secs' member determines whether we're currently in > fail-open mode (see fail_open_is_active()), but before this > commit, fail_open_run() could decide to enter fail-open mode even if > that would set 'last_disconn_secs' to 0 (and thus not

Re: [ovs-dev] [PATCH ovn 1/4] ovn-northd.at: Fix test "northd ssl file change -- ovn-northd-ddlog".

On 6/11/21 6:30 PM, Han Zhou wrote: On Fri, Jun 11, 2021 at 11:24 AM Mark Michelson > wrote: > > Hi Han, > > I'm fine with fixing the test this way, since like you said it's not > meant to test RBAC. > > Acked-by: Mark Michelson >

Re: [ovs-dev] [PATCH ovn v2] ovn.at: Fix test "virtual ports -- ovn-northd-ddlog".

On Fri, Jun 11, 2021 at 03:48:52PM -0700, Han Zhou wrote: > The test case fails quite often for northd-ddlog because of the tunnel > keys mismatch when comparing OpenFlow rules. Keys can change in > different runs. This patch fixes it by extracting the expected keys from > SB DB before comparison

Re: [ovs-dev] [PATCH v2] ofp-monitor: Extend Flow Monitoring support for OF 1.0-1.3 with Nicira Extensions

Ok Ben. Is it ok if I take this up as a separate submit. So after this commit, I propose to add the following changes(listing the tasks): 1. Support for 1.3 ONF extension for flow monitoring 2. Support for 1.4+ flow monitoring. Thanks, -Vasu *Vasu Dasari* On Mon, Jun 14, 2021 at 2:31 PM Ben

Re: [ovs-dev] [PATCH v2] ofp-monitor: Extend Flow Monitoring support for OF 1.0-1.3 with Nicira Extensions

There are a number of ONF extensions already: [bpfaff@sigfpe _build]$ git grep -h -E 'ONFS?T' ../include/openvswitch/ofp-msgs.h * * ONFT: Open Networking Foundation extension message. * * ONFST: Open Networking Foundation multipart message. * For NXT or ONFT, the

Re: [ovs-dev] [PATCH ovn] northd: Add support for DHCP Option 12 (Hostname)

On Fri, May 28, 2021 at 7:32 AM Vladislav Odintsov wrote: > > DHCP Option Hostname is a per-Logical_Switch_Port property, configured in > Logical_Switch_Port's options:hostname field. It is used if DHCPv4 is > enabled for this LSP. > > Signed-off-by: Vladislav Odintsov Thanks for the patch.

Re: [ovs-dev] [PATCH] tests: Fix spelling error in test name.

On Mon, Jun 14, 2021 at 08:18:39PM +0200, Ilya Maximets wrote: > On 6/11/21 9:17 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > tests/drop-stats.at | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/drop-stats.at b/tests/drop-stats.at > > index

Re: [ovs-dev] [PATCH v2] odp-util: Return an error on actions overflow while parsing from string.

On Mon, Jun 14, 2021 at 07:36:01PM +0200, Ilya Maximets wrote: > We don't need to continue parsing if already oversized. This is not > very important, but fuzzer times out while parsing very long list of > actions. > > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=29190 >

Re: [ovs-dev] [PATCH] tests: Fix spelling error in test name.

On 6/11/21 9:17 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > tests/drop-stats.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/drop-stats.at b/tests/drop-stats.at > index 94528f55620c..f3e19cd83ba9 100644 > --- a/tests/drop-stats.at > +++

Re: [ovs-dev] [PATCH] ofproto-dpif: fix issue with non-reversible actions on a patch ports

On 6/14/21 4:28 PM, Eelco Chaudron wrote: > For patch ports, the is_last_action value is not propagated and is > always set to true. This causes non-reversible actions to modify the > packet, and the original content is not preserved when processing > the remaining actions. > > This patch

[ovs-dev] [PATCH v2] odp-util: Return an error on actions overflow while parsing from string.

We don't need to continue parsing if already oversized. This is not very important, but fuzzer times out while parsing very long list of actions. Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=29190 Signed-off-by: Ilya Maximets --- Version 2: - Fixed non-portable shell

Re: [ovs-dev] [PATCH] odp-util: Return an error on actions overflow while parsing from string.

On 6/14/21 5:53 PM, Ilya Maximets wrote: > On 6/14/21 5:40 PM, Ben Pfaff wrote: >> On Mon, Jun 14, 2021 at 05:17:01PM +0200, Ilya Maximets wrote: >>> We don't need to continue parsing if already oversized. This is not >>> very important, but fuzzer times out while parsing very long list of >>>

Re: [ovs-dev] [PATCH] odp-util: Return an error on actions overflow while parsing from string.

On 6/14/21 5:40 PM, Ben Pfaff wrote: > On Mon, Jun 14, 2021 at 05:17:01PM +0200, Ilya Maximets wrote: >> We don't need to continue parsing if already oversized. This is not >> very important, but fuzzer times out while parsing very long list of >> actions. >> >> Reported-at:

Re: [ovs-dev] [PATCH v3] [python] Don't mix system poll/monkeypatched select

On Fri, Jun 11, 2021 at 10:30 AM Terry Wilson wrote: > > This is a partial revert of c1aa16d19, but keeps its test. > > Applications that use eventlet cannot use poll() without blocking. > To fix an issue where the check_connection_completion() code would > not detect connection errors when using

Re: [ovs-dev] [PATCH v6] ofproto-dpif: APIs and CLI option to add/delete static fdb entry

On Fri, Jun 11, 2021 at 10:09:58PM -0400, Vasu Dasari wrote: > Currently there is an option to add/flush/show ARP/ND neighbor. This covers L3 > side. For L2 side, there is only fdb show command. This patch gives an option > to add/del an fdb entry via ovs-appctl. I didn't really review this

Re: [ovs-dev] [PATCH] odp-util: Return an error on actions overflow while parsing from string.

On Mon, Jun 14, 2021 at 05:17:01PM +0200, Ilya Maximets wrote: > We don't need to continue parsing if already oversized. This is not > very important, but fuzzer times out while parsing very long list of > actions. > > Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=29190 >

[ovs-dev] [PATCH] odp-util: Return an error on actions overflow while parsing from string.

We don't need to continue parsing if already oversized. This is not very important, but fuzzer times out while parsing very long list of actions. Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=29190 Signed-off-by: Ilya Maximets --- lib/odp-util.c | 4 tests/odp.at |

[ovs-dev] [PATCH] ofproto-dpif: fix issue with non-reversible actions on a patch ports

For patch ports, the is_last_action value is not propagated and is always set to true. This causes non-reversible actions to modify the packet, and the original content is not preserved when processing the remaining actions. This patch propagates the is_last_action flag for patch port related

Re: [ovs-dev] [RFC net-next] openvswitch: add trace points

Eelco Chaudron writes: > On 27 May 2021, at 21:15, Aaron Conole wrote: > > This makes openvswitch module use the event tracing framework > to log the upcall interface and action execution pipeline. When > using openvswitch as the packet forwarding engine, some types of > debugging are

Re: [ovs-dev] [PATCH ovn 2/2] tests: Fix consistency of 4 HV, 3LS, 2 LR test runs.

On 6/10/21 6:54 PM, Ben Pfaff wrote: On Mon, Jun 07, 2021 at 08:49:59AM -0400, Mark Michelson wrote: Much like the 4 HV, 1 LS, 1 LR test, this one was also having issues where the pcap file would not be reset before attempting to capture packets. Therefore, the pcap file would be reset after

Re: [ovs-dev] [PATCH v4 0/2] Encap & Decap actions for MPLS packet type

Hi Martin, What is the status of this patchset? Are you going to send out a v5, as I noticed quite some discussion with Jan, but I lost track? //Eelco On 30 Mar 2021, at 18:49, Martin Varghese wrote: > On Tue, Mar 30, 2021 at 05:26:19PM +0200, Eelco Chaudron wrote: >> >> >> On 26 Mar 2021,

Re: [ovs-dev] [PATCH v3] ofp-monitor: Extend Flow Monitoring support for OF 1.0-1.2 with Nicira Extensions

Hi Ben This patch makse all flow-monitoring tests to be tested against all versions. For this to happen I have added debug options to "ovs-ofctl {add,mod,del}-flows " to print out byte streams. I see that other ovs-ofctl commands like dump-ports, dump-table-features, etc have options to dump

Re: [ovs-dev] [PATCH ovn v9 0/5] ovn-controller: Split logical flow and physical flow processing

On Mon, Jun 14, 2021 at 3:32 AM Han Zhou wrote: > > Thanks Numan and Mark. > I have only a minor comment on patch 3. I understand it may not affect > correctness for now since new datapath always triggers recompute, but I > think it's better to be explicit that the ct_zones node cannot handle it

Re: [ovs-dev] [PATCH ovn 0/4] Fix ovn-controller I-P for multicast groups and lport changes

On 6/11/21 9:45 PM, Han Zhou wrote: > On Mon, Jun 7, 2021 at 12:16 AM Dumitru Ceara wrote: >> >> On 6/7/21 7:33 AM, Han Zhou wrote: >>> On Fri, Jun 4, 2021 at 6:56 AM Dumitru Ceara wrote: On 5/28/21 9:23 PM, Han Zhou wrote: > The series fixes incremental processing for missing

Re: [ovs-dev] [PATCH v2] ofp-monitor: Extend Flow Monitoring support for OF 1.0-1.3 with Nicira Extensions

Hi Ben, I see that the flow monitoring is added as an ONF extension. I am looking at ofp-msgs.h, I do not see any ONF_ related extensions added in that file. If we were to add ONF flow monitoring support to OVS this will be the first one. Let me know if this is a desired one. Or, we could

Re: [ovs-dev] [PATCH ovn v9 3/5] ovn-controller: Handle datapath changes incrementally for ct zone I-P engine node.

On Mon, Jun 14, 2021 at 7:20 AM Numan Siddique wrote: > > On Mon, Jun 14, 2021 at 7:14 AM Numan Siddique wrote: > > > > On Mon, Jun 14, 2021 at 3:28 AM Han Zhou wrote: > > > > > > On Thu, Jun 3, 2021 at 5:29 AM wrote: > > > > > > > > From: Numan Siddique > > > > > > > > After the commit [1],

Re: [ovs-dev] [PATCH ovn v9 3/5] ovn-controller: Handle datapath changes incrementally for ct zone I-P engine node.

On Mon, Jun 14, 2021 at 7:14 AM Numan Siddique wrote: > > On Mon, Jun 14, 2021 at 3:28 AM Han Zhou wrote: > > > > On Thu, Jun 3, 2021 at 5:29 AM wrote: > > > > > > From: Numan Siddique > > > > > > After the commit [1], we do a full recompute of ct zone I-P engine for > > > any datapath binding

Re: [ovs-dev] [PATCH ovn v9 3/5] ovn-controller: Handle datapath changes incrementally for ct zone I-P engine node.

On Mon, Jun 14, 2021 at 3:28 AM Han Zhou wrote: > > On Thu, Jun 3, 2021 at 5:29 AM wrote: > > > > From: Numan Siddique > > > > After the commit [1], we do a full recompute of ct zone I-P engine for > > any datapath binding change. This results in physical_flow() getting > > called. In a

Re: [ovs-dev] [External] : [PATCH ovn v2] ovn-northd.c: Add proxy ARP support to OVN

Hi, Just wondering how to move this along. It's been in the queue a while now. The product I'm working on requires this feature and If I can't get it upstream I'll need to look at other options. Thanks Brendan On 04/06/2021 15:51, Brendan Doyle wrote: From

Re: [ovs-dev] [PATCH ovn v9 0/5] ovn-controller: Split logical flow and physical flow processing

Thanks Numan and Mark. I have only a minor comment on patch 3. I understand it may not affect correctness for now since new datapath always triggers recompute, but I think it's better to be explicit that the ct_zones node cannot handle it incrementally. With that being said, for the series:

Re: [ovs-dev] [PATCH ovn v9 3/5] ovn-controller: Handle datapath changes incrementally for ct zone I-P engine node.

On Thu, Jun 3, 2021 at 5:29 AM wrote: > > From: Numan Siddique > > After the commit [1], we do a full recompute of ct zone I-P engine for > any datapath binding change. This results in physical_flow() getting > called. In a highly scaled environment this can result in costly CPU > cycles.