Re: [ovs-dev] [PATCH ovn 3/3] northd: Refactor Logical Flows for Gateway Router with DNAT/Load Balancers

On Sat, Jun 19, 2021 at 2:52 AM Mark Gray wrote: > > This patch addresses a number of interconnected issues with Gateway Routers > that have Load Balancing enabled: > > 1) In the router pipeline, we have the following stages to handle > dnat and unsnat. > > - Stage 4 : lr_in_defrag (dnat zone) >

[ovs-dev] [PATCH ovn v2 2/2] ovn-macros.at: Enable northd parallelization

- Add NORTHD_USE_PARALLELIZATION variable to enable it in ovn_start. - Add NORTHD_DUMMY_NUMA variable for passing --dummy-numa flag when tests are run in a low CPU system. Signed-off-by: Fabrizio D'Angelo Acked-by: Mark Michelson --- tests/ovn-macros.at | 40

[ovs-dev] [PATCH ovn v2 1/2] northd: Port dummy-numa cli option from OVS

Signed-off-by: Fabrizio D'Angelo Acked-by: Mark Michelson --- northd/ovn-northd-ddlog.c | 9 - northd/ovn-northd.c | 7 +++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/northd/ovn-northd-ddlog.c b/northd/ovn-northd-ddlog.c index 444e13e39..d81414ce7 100644

Re: [ovs-dev] [PATCH ovn] northd: avoid memory reallocation while building ACL and QoS rules

On 6/22/21 1:14 PM, Dan Williams wrote: On Fri, 2021-06-18 at 21:49 +0200, Dumitru Ceara wrote: On 6/4/21 10:00 PM, Dan Williams wrote: Inspried by: 3b6362d64e86b northd: Avoid memory reallocation while building lb rules. Signed-off-by: Dan Williams --- NOTE: this is driven by visual

Re: [ovs-dev] [PATCH v4] Remove Python 2 leftovers.

On 6/15/21 5:58 PM, Rosemarie O'Riorden wrote: > Fixes: 1ca0323e7c29 ("Require Python 3 and remove support for Python 2.") > Reported at: https://bugzilla.redhat.com/show_bug.cgi?id=1949875 > Signed-off-by: Rosemarie O'Riorden > --- > Version 2: > - Fixed import errors in v1. > - Removed

[ovs-dev] [PATCH ovn] controller: Fix the wrong 'struct' type for 'pflow_output_data'.

From: Numan Siddique 'pflow_output_data' should be of type 'struct ed_type_pflow_output' and not 'struct ed_type_lflow_output'. Fixes: e07e397b7ae("ovn-controller: Split logical flow and physical flow processing.") Signed-off-by: Numan Siddique --- controller/ovn-controller.c | 2 +- 1 file

Re: [ovs-dev] [PATCH 1/5] dpif-netdev: Rework rxq scheduling code.

Hey Kevin , Patch looks good to me: Builds fine , all test cases here http://patchwork.ozlabs.org/project/openvswitch/patch/20210316154532.127858-1-ktray...@redhat.com/ pass as well. Some minor nits inline : > diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 650e67ab3..57d23e112

[ovs-dev] [PATCH v7 1/1] ovs-numa: Support non-contiguous numa nodes and offline CPU cores

This change removes the assumption that numa nodes and cores are numbered contiguously in linux. This change is required to support some Power systems. A check has been added to verify that cores are online, offline cores result in non-contiguously numbered cores. Dpdk EAL option generation is

[ovs-dev] [PATCH v7 0/1] Support for non-contiguous numa nodes and core ids.

Ovs-numa currently makes the assumption that numa node ids and cpu core ids will be numbered contiguously. Current Power systems don't always follow this model. Furthermore, cpus on Power may be on/off lined based the setting of Simultaneous multithreading (SMT). The result can be gaps in the

Re: [ovs-dev] [PATCH net-next] openvswitch: add trace points

Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 22 Jun 2021 10:02:33 -0400 you wrote: > This makes openvswitch module use the event tracing framework > to log the upcall interface and action execution pipeline. When > using openvswitch as the packet forwarding

Re: [ovs-dev] [PATCH ovn] northd: avoid memory reallocation while building ACL and QoS rules

On Fri, 2021-06-18 at 21:49 +0200, Dumitru Ceara wrote: > On 6/4/21 10:00 PM, Dan Williams wrote: > > Inspried by: > > > > 3b6362d64e86b northd: Avoid memory reallocation while building lb > > rules. > > > > Signed-off-by: Dan Williams > > --- > > NOTE: this is driven by visual inspection not

Re: [ovs-dev] [PATCH v3] [python] Don't mix system poll/monkeypatched select

On 6/22/21 6:51 PM, Ben Pfaff wrote: > On Tue, Jun 15, 2021 at 10:06:53PM +0200, Ilya Maximets wrote: >> 3. Use select() + getsockopt(SO_ERRROR), effectively revert d6cedfd9d29d >>--> give up on systems that doesn't support SO_ERRROR. (ESX?) > > d6cedfd9d29d is the commit titled "socket-util:

Re: [ovs-dev] [v13 08/12] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs

> Hi all, > > Thanks for the feedback. My responses are inline. > > Cian > > > -Original Message- > > From: Flavio Leitner > > Sent: Tuesday 22 June 2021 17:39 > > To: Stokes, Ian > > Cc: Ferriter, Cian ; ovs-dev@openvswitch.org; > i.maxim...@ovn.org > > Subject: Re: [ovs-dev] [v13

Re: [ovs-dev] [PATCH] conntrack: increment coverage counter for all bad checksum cases

Paolo Valerio writes: > conntrack_l4csum_err gets incremented only when corrupted icmp > pass through conntrack. > Increase it for the remaining bad checksum cases including when > checksum is offloaded. > > Signed-off-by: Paolo Valerio > --- Missed the Fixes tag: Fixes: 38c69ccf8e29

Re: [ovs-dev] [PATCH v5] conntrack: document all-zero IP SNAT behavior and add a test case

Eelco Chaudron writes: > Currently, conntrack in the kernel has an undocumented feature referred > to as all-zero IP address SNAT. Basically, when a source port > collision is detected during the commit, the source port will be > translated to an ephemeral port. If there is no collision, no SNAT

Re: [ovs-dev] [PATCH v3] [python] Don't mix system poll/monkeypatched select

On Tue, Jun 15, 2021 at 10:06:53PM +0200, Ilya Maximets wrote: > 3. Use select() + getsockopt(SO_ERRROR), effectively revert d6cedfd9d29d >--> give up on systems that doesn't support SO_ERRROR. (ESX?) d6cedfd9d29d is the commit titled "socket-util: Avoid using SO_ERROR." from 2012. This was

Re: [ovs-dev] [PATCH v1] conntrack: Add state and sequence validation

Hi Aaron, Aaron Conole writes: > During testing, there was an edge condition that was found during > packet pickup where userspace can improperly advance the TCP state > machine during connection exstablishment and bypass the 3whs. This > can pollute the TCP sequence windows. > > Add a fix to

Re: [ovs-dev] [v13 08/12] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs

Hi all, Thanks for the feedback. My responses are inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Tuesday 22 June 2021 17:39 > To: Stokes, Ian > Cc: Ferriter, Cian ; ovs-dev@openvswitch.org; > i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 08/12]

Re: [ovs-dev] [v13 08/12] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs

On Tue, Jun 22, 2021 at 03:42:46PM +, Stokes, Ian wrote: > > Hi Flavio, > > > > Thanks for the review. My responses are inline. > > > > Cian > > > > > -Original Message- > > > From: Flavio Leitner > > > Sent: Monday 21 June 2021 19:22 > > > To: Ferriter, Cian > > > Cc:

Re: [ovs-dev] [v13 04/12] dpif-avx512: Add ISA implementation of dpif.

Hi Harry, All good points. I made a suggestion and left to the authors to decide the best course of action. It was a suggestion to accommodate everyone and to reduce the churn. That's all. Anyways, my plan is to continue reviewing the patches and, as always, I appreciate your support. Thanks,

Re: [ovs-dev] [PATCH V6 00/13] Netdev vxlan-decap offload

On 4/4/21 11:54 AM, Eli Britstein wrote: > VXLAN decap in OVS-DPDK configuration consists of two flows: > F1: in_port(ens1f0),eth(),ipv4(),udp(), actions:tnl_pop(vxlan_sys_4789) > F2: tunnel(),in_port(vxlan_sys_4789),eth(),ipv4(), actions:ens1f0_0 > > F1 is a classification flow. It has outer

Re: [ovs-dev] [v13 08/12] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs

> Hi Flavio, > > Thanks for the review. My responses are inline. > > Cian > > > -Original Message- > > From: Flavio Leitner > > Sent: Monday 21 June 2021 19:22 > > To: Ferriter, Cian > > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > > Subject: Re: [ovs-dev] [v13 08/12]

Re: [ovs-dev] [v13 08/12] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs

Hi Flavio, Thanks for the review. My responses are inline. Cian > -Original Message- > From: Flavio Leitner > Sent: Monday 21 June 2021 19:22 > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 08/12] dpif-netdev-unixctl.man: Document

[ovs-dev] [PATCH net-next] openvswitch: add trace points

This makes openvswitch module use the event tracing framework to log the upcall interface and action execution pipeline. When using openvswitch as the packet forwarding engine, some types of debugging are made possible simply by using the ovs-vswitchd's ofproto/trace command. However, such a

Re: [ovs-dev] [PATCH v3 2/3] northd: enable check_pkt_larger for gw router

> On Fri, Jun 11, 2021 at 10:32 AM Lorenzo Bianconi > wrote: > > > > As it is already done for distributed gw router scenario, introduce > > check_pkt_larger logical flows for gw router use case. > > > > Signed-off-by: Lorenzo Bianconi > > Hi Lorenzo, > > Thanks for the patches. You forgot to

Re: [ovs-dev] [PATCH ovn] Disable ARP/NA responders for vlan-passthru switches

On Tue, Jun 15, 2021 at 8:40 PM Ihar Hrachyshka wrote: > > When vlan-passthru is on, VIFs may attach different VLAN tags. In this > case, VIFs are not guaranteed to belong to the same L2 broadcast domain. > Because of that, we don't know if a peer port on the switch has the same > tag used and

Re: [ovs-dev] [PATCH ovn v3] northd: Add support for DHCP Option 12 (Hostname)

Thanks Numan for adding ddlog support here and additional tests as well. Okay, I’ll try to do it by myself next time, if any. Regards, Vladislav Odintsov > On 22 Jun 2021, at 13:47, Numan Siddique wrote: > > On Tue, Jun 15, 2021 at 11:34 AM Vladislav Odintsov >

[ovs-dev] [PATCH v2 ovn] northd: do not centralized traffic for unclaimed virtual ports

Add a rule to drop traffic from a distributed NAT if the virtual port has not claimed yet becaused otherwise the traffic will be centralized misconfiguring the TOR switch. https://bugzilla.redhat.com/show_bug.cgi?id=1952961 Co-authored-by: Numan Siddique Signed-off-by: Numan Siddique

Re: [ovs-dev] [v13 04/12] dpif-avx512: Add ISA implementation of dpif.

> -Original Message- > From: dev On Behalf Of Flavio Leitner > Sent: Monday, June 21, 2021 5:39 PM > To: Ferriter, Cian > Cc: ovs-dev@openvswitch.org; Amber, Kumar ; > i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v13 04/12] dpif-avx512: Add ISA implementation of > dpif. > > On Mon, Jun

Re: [ovs-dev] [PATCH ovn v3] northd: Add support for DHCP Option 12 (Hostname)

On Tue, Jun 15, 2021 at 11:34 AM Vladislav Odintsov wrote: > > DHCP option Hostname (opcode 12) can be configured in > Logical_Switch_Port as well as in DHCP_Options table's > options:hostname column. If both methods of configuration were > used, Logical_Switch_Port's setting takes precedence. >

Re: [ovs-dev] [PATCH v2] ovsdb: provide raft and command interfaces with priority

On 21/06/2021 20:29, Ilya Maximets wrote: On 6/11/21 5:42 PM, anton.iva...@cambridgegreys.com wrote: From: Anton Ivanov Set a soft time limit of "raft election timer"/2 on ovsdb processing. This improves behaviour in large heavily loaded clusters. While it cannot fully eliminate spurious