On 7/14/21 3:50 PM, Ilya Maximets wrote:
> It might be important for clients to know that relay lost connection
> with the relay remote, so they could re-connect to other relay.
>
> Signed-off-by: Ilya Maximets
> ---
Acked-by: Dumitru Ceara
Thanks!
On 7/14/21 3:50 PM, Ilya Maximets wrote:
> New database service model 'relay' that is needed to scale out
> read-mostly database access, e.g. ovn-controller connections to
> OVN_Southbound.
>
> In this service model ovsdb-server connects to existing OVSDB
> server and maintains in-memory copy of
Hi Mark,
I'm a bit curious about this change. Does the removal of the protocol
from the match mean that traffic that is not of the protocol specified
in the load balancer will be ct_dnat()'ed? Does that constitute
unexpected behavior?
On 7/15/21 8:14 AM, Mark Gray wrote:
When adding two SB
From: Harry van Haaren
This commit adds 3 new traffic profile implementations to the
existing avx512 miniflow extract infrastructure. The profiles added are:
- Ether()/IP()/TCP()
- Ether()/Dot1Q()/IP()/UDP()
- Ether()/Dot1Q()/IP()/TCP()
The design of the avx512 code here is for scalability to
From: Harry van Haaren
This commit adds AVX512 implementations of miniflow extract.
By using the 64 bytes available in an AVX512 register, it is
possible to convert a packet to a miniflow data-structure in
a small quantity instructions.
The implementation here probes for Ether()/IP()/UDP()
From: Harry van Haaren
This commit enables OVS to at runtime check for more detailed
AVX512 capabilities, specifically Byte and Word (BW) extensions,
and Vector Bit Manipulation Instructions (VBMI).
These instructions will be used in the CPU ISA optimized
implementations of traffic profile
From: Harry van Haaren
This commit adds a new counter to be displayed to the user when
requesting datapath packet statistics. It counts the number of
packets that are parsed and a miniflow built up from it by the
optimized miniflow extract parsers.
The ovs-appctl command
From: Kumar Amber
Tests:
6: OVS-DPDK - MFEX Autovalidator
7: OVS-DPDK - MFEX Autovalidator Fuzzy
8: OVS-DPDK - MFEX Configuration
Added a new directory to store the PCAP file used
in the tests and a script to generate the fuzzy traffic
type pcap to be used in fuzzy unit test.
From: Kumar Amber
This commit introduces additional command line paramter
for mfex study function. If user provides additional packet out
it is used in study to compare minimum packets which must be processed
else a default value is choosen.
Also introduces a third paramter for choosing a
From: Kumar Amber
This commit adds a new command to allow the user to enable
autovalidatior by default at build time thus allowing for
runnig unit test by default.
$ ./configure --enable-mfex-default-autovalidator
Signed-off-by: Kumar Amber
Co-authored-by: Harry van Haaren
Signed-off-by:
From: Kumar Amber
The study function runs all the available implementations
of miniflow_extract and makes a choice whose hitmask has
maximum hits and sets the mfex to that function.
Study can be run at runtime using the following command:
$ ovs-appctl dpif-netdev/miniflow-parser-set study
From: Kumar Amber
This commit adds a section to the dpdk/bridge.rst netdev documentation,
detailing the added miniflow functionality. The newly added commands are
documented, and sample output is provided.
The use of auto-validator and special study function is also described
in detail as well
From: Kumar Amber
This patch introduces the MFEX function pointers which allows
the user to switch between different miniflow extract implementations
which are provided by the OVS based on optimized ISA CPU.
The user can query for the available minflow extract variants available
for that CPU by
From: Kumar Amber
This patch introduced the auto-validation function which
allows users to compare the batch of packets obtained from
different miniflow implementations against the linear
miniflow extract and return a hitmask.
The autovaidator function can be triggered at runtime using the
v13:
- add Acks from Flavio
- fixed atomic set and static var in study
- shotened null check in first patch
- added improvements to set command as per discussion
- added test-case to test for set commands both negative and positive
v12:
- re-work the set command to sweep method
- changes skip for
The Open vSwitch kernel module uses the upcall mechanism to send
packets from kernel space to user space when it misses in the kernel
space flow table. The upcall sends packets via a Netlink socket.
Currently, a Netlink socket is created for every vport. In this way,
there is a 1:1 mapping between
When adding two SB flows with the same vip but different protocols, only
the most recent flow will be added due to the `if` statement:
if (!sset_contains(_ips, lb_vip->vip_str)) {
sset_add(_ips, lb_vip->vip_str);
This can cause unexpected behaviour when two load
On 13/07/2021 20:15, Rosemarie O'Riorden wrote:
> As the changes of patch 2 and 3 will be applied for the 2.17 release,
> warnings have been added to alert users in advance.
>
The references to patches 2 and 3 won't have context if this patch is
applied in OVS initially. How about something
On 15/07/2021 05:45, Pravin Shelar wrote:
> On Wed, Jun 30, 2021 at 2:53 AM Mark Gray wrote:
>>
>> The Open vSwitch kernel module uses the upcall mechanism to send
>> packets from kernel space to user space when it misses in the kernel
>> space flow table. The upcall sends packets via a Netlink
Hi All,
Eelco, thanks for the reviews. We've addressed your concerns as much as
possible, there is one bool (mfex_name_is_study) remaining as
it was required for simplification of logic, and avoiding 3x strcmp() calls on
mfex_name.
A v13 will be posted to mailing list shortly. Request to focus
On 15 Jul 2021, at 12:31, Eelco Chaudron wrote:
On 15 Jul 2021, at 12:10, Van Haaren, Harry wrote:
-Original Message-
From: Eelco Chaudron
Sent: Thursday, July 15, 2021 11:08 AM
To: Van Haaren, Harry
Cc: Amber, Kumar ; ovs-dev@openvswitch.org;
f...@sysclose.org;
On 15 Jul 2021, at 12:10, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Thursday, July 15, 2021 11:08 AM
>> To: Van Haaren, Harry
>> Cc: Amber, Kumar ; ovs-dev@openvswitch.org;
>> f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian
>> ;
>> Stokes,
> -Original Message-
> From: Eelco Chaudron
> Sent: Thursday, July 15, 2021 11:08 AM
> To: Van Haaren, Harry
> Cc: Amber, Kumar ; ovs-dev@openvswitch.org;
> f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian
> ;
> Stokes, Ian
> Subject: Re: [v12 06/11] dpif-netdev: Add packet count
On 15 Jul 2021, at 12:03, Van Haaren, Harry wrote:
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Thursday, July 15, 2021 10:47 AM
>> To: Van Haaren, Harry
>> Cc: Amber, Kumar ; ovs-dev@openvswitch.org;
>> f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian
>> ;
>> Stokes,
> -Original Message-
> From: Eelco Chaudron
> Sent: Thursday, July 15, 2021 10:47 AM
> To: Van Haaren, Harry
> Cc: Amber, Kumar ; ovs-dev@openvswitch.org;
> f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian
> ;
> Stokes, Ian
> Subject: Re: [v12 06/11] dpif-netdev: Add packet count
On 15 Jul 2021, at 11:24, Van Haaren, Harry wrote:
> Hi Eelco,
>
> Thanks for review. Updates with [hvh] prefix below. In general I've fixed-up
> the suggestions,
> with the exception of 1 that I didn't understand or think actually worked.
ACK, will comment on the one remaining item.
> I'll
Hi Eelco,
Thanks for review. Updates with [hvh] prefix below. In general I've fixed-up
the suggestions,
with the exception of 1 that I didn't understand or think actually worked.
I'll ask Amber to integrate the changes below into the patchset, next version
to ML soon.
Regards, -Harry
From:
On 15 Jul 2021, at 10:13, Amber, Kumar wrote:
> Hi Eelco,
>
>
>
>> -Original Message-
>> From: Eelco Chaudron
>> Sent: Thursday, July 15, 2021 1:38 PM
>> To: Amber, Kumar
>> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
>> Haaren, Harry ; Ferriter, Cian
>> ;
On 14 Jul 2021, at 16:14, kumar Amber wrote:
From: Kumar Amber
This commit introduces additional command line paramter
for mfex study function. If user provides additional packet out
it is used in study to compare minimum packets which must be processed
else a default value is choosen.
Also
Hi Eelco,
> -Original Message-
> From: Eelco Chaudron
> Sent: Thursday, July 15, 2021 1:38 PM
> To: Amber, Kumar
> Cc: ovs-dev@openvswitch.org; f...@sysclose.org; i.maxim...@ovn.org; Van
> Haaren, Harry ; Ferriter, Cian
> ; Stokes, Ian
> Subject: Re: [v12 01/11] dpif-netdev: Add
On 14 Jul 2021, at 16:14, kumar Amber wrote:
> From: Kumar Amber
>
> This patch introduces the MFEX function pointers which allows
> the user to switch between different miniflow extract implementations
> which are provided by the OVS based on optimized ISA CPU.
>
> The user can query for the
Create a unique group ID to map the sFlow info when offloading sFlow
action to TC. When showing the offloaded datapath flows, translate the
group ID from TC sample action to sFlow info using the mapping.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
NEWS| 1 +
Some offload actions require functionality that is not netdev
based, but dpif. For example, sFlow action requires to create
a psample netlink socket to receive the sampled packets from
TC or kernel driver.
Create dpif-offload-provider layer to support such actions.
Signed-off-by: Chris Mi
Process sFlow offload packet in handler thread if handler id is 0.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
ofproto/ofproto-dpif-upcall.c | 57 +++
1 file changed, 57 insertions(+)
diff --git a/ofproto/ofproto-dpif-upcall.c
Implement dpif-offload API for netlink datapath.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
---
lib/automake.mk | 1 +
lib/dpif-netlink.c | 2 +-
lib/dpif-offload-netlink.c | 210
lib/dpif-offload-provider.h | 12 +++
4
When offloading sample action to TC, userspace creates a unique ID
to map sFlow action and tunnel info and passes this ID to kernel instead
of the sFlow info. psample will send this ID and sampled packet to
userspace. Using the ID, userspace can recover the sFlow info and send
sampled packet to
Load kernel module psample to receive sampled packets from TC.
Before removing kernel module psample, remove act_sample first.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
utilities/ovs-kmod-ctl.in | 14 ++
1 file changed, 14 insertions(+)
diff
Update kernel UAPI to support psample and the tc sample action.
Signed-off-by: Chris Mi
Reviewed-by: Eli Britstein
Acked-by: Eelco Chaudron
---
include/linux/automake.mk| 4 ++-
include/linux/psample.h | 62
include/linux/tc_act/tc_sample.h |
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action act_sample
uses psample to send sampled packets to userspace.
When offloading sample action to TC, userspace creates a unique ID to
map sFlow action and tunnel info and passes this ID to
101 - 139 of 139 matches
Mail list logo
