On Mon, Jul 26, 2021 at 7:52 PM Numan Siddique wrote:
>
> We have a bug in the present branch-21.06. Unfortunately the commit
> e1e78b4b148("binding: Fix the crashes seen when port binding type
> changes.")
> introduced a regression for the localports. When an OVS interface for
> a localport is
On Mon, Jul 26, 2021 at 7:39 PM Numan Siddique wrote:
>
> On Mon, Jul 26, 2021 at 10:04 PM Han Zhou wrote:
> >
> > On Mon, Jul 26, 2021 at 6:47 PM Han Zhou wrote:
> > >
> > >
> > >
> > > On Fri, Jul 16, 2021 at 4:45 AM wrote:
> > > >
> > > > From: Numan Siddique
> > > >
> > > > This would
We have a bug in the present branch-21.06. Unfortunately the commit
e1e78b4b148("binding: Fix the crashes seen when port binding type
changes.")
introduced a regression for the localports. When an OVS interface for
a localport is created by CMS, ovn-controller
doesn't update or add the existing
On Mon, Jul 26, 2021 at 10:04 PM Han Zhou wrote:
>
> On Mon, Jul 26, 2021 at 6:47 PM Han Zhou wrote:
> >
> >
> >
> > On Fri, Jul 16, 2021 at 4:45 AM wrote:
> > >
> > > From: Numan Siddique
> > >
> > > This would uncomplicate the binding.c code a bit. The tracking
> > > data and the related
On Fri, Jul 16, 2021 at 4:46 AM wrote:
>
> From: Numan Siddique
>
> When a container logical port's parent changes and if the parent logical
> port resides in the same chassis as the old parent, ovn-controller doesn't
> track that change in the 'tracked_dp_bindings'. At present this is not
> an
On Fri, Jul 16, 2021 at 4:45 AM wrote:
>
> From: Numan Siddique
>
> If there is an OVS interface present with the external_ids:iface-id set
> to a localport port binding, we create a 'struct local_binding' for this
> OVS interface but we do not associate the binding_lport to this
>
On Mon, Jul 26, 2021 at 6:47 PM Han Zhou wrote:
>
>
>
> On Fri, Jul 16, 2021 at 4:45 AM wrote:
> >
> > From: Numan Siddique
> >
> > This would uncomplicate the binding.c code a bit. The tracking
> > data and the related functions are also moved to the file - ldata.h.
> > This would help in an
On Fri, Jul 16, 2021 at 4:45 AM wrote:
>
> From: Numan Siddique
>
> This would uncomplicate the binding.c code a bit. The tracking
> data and the related functions are also moved to the file - ldata.h.
> This would help in an upcoming patch.
>
> Signed-off-by: Numan Siddique
> ---
>
On Mon, Jul 26, 2021 at 10:01 AM Dumitru Ceara wrote:
>
> Commit 6aab704fb67d ("controller: Avoid unnecessary load balancer flow
> processing.") handled the case when load balancers are updated but
> addition/removal of load balancers will trigger almost all logical
> flows to be reprocessed by
On Fri, Jul 16, 2021 at 2:53 PM Han Zhou wrote:
>
> On Fri, Jul 16, 2021 at 7:15 AM Numan Siddique wrote:
> >
> > On Mon, Jul 12, 2021 at 11:09 AM Mark Michelson
> wrote:
> > >
> > > Full disclosure: I have not looked at all the details in this patch,
> > > since it is quite large. However, I
On 23/07/2021 21:18, Numan Siddique wrote:
> On Wed, Jul 14, 2021 at 9:08 AM Dumitru Ceara wrote:
>>
>> On 6/30/21 3:15 PM, Mark Gray wrote:
>>> Add a suite of micro-benchmarks to aid a developer in understanding the
>>> performance impact of any changes that they are making. They can be used to
If the Port_Binding.options map already has the correct values set for
the 'ipv6_prefix_delegation' and 'ipv6_prefix' keys, don't update the
map as it will trigger unnecessary jsonrpc messages to be sent on the
wire towards OVN_Southbound.
Signed-off-by: Dumitru Ceara
---
northd/ovn-northd.c |
Commit 6aab704fb67d ("controller: Avoid unnecessary load balancer flow
processing.") handled the case when load balancers are updated but
addition/removal of load balancers will trigger almost all logical
flows to be reprocessed by ovn-controller.
The references are just used for optimizing
On Fri, 23 Jul 2021 10:58:40 -0400
Salvatore Daniele wrote:
> match.c generates the keyword "igmp", which is not supported in ofp-parse.
> This means that flow dumps containing 'igmp' can not be restored.
>
> Removing the 'igmp' keyword entirely could break existing scripts in stable
>
Salvatore Daniele writes:
> From: Adrian Moreno
>
> The match keyword "igmp" is not supported in ofp-parse, which means
> that flow dumps cannot be restored. Previously a workaround was
> added to ovs-save to avoid changing output in stable branches.
>
> This patch changes the output to print
On 20 Jul 2021, at 9:55, bindiya Kurle wrote:
> Comments inline BK >>
>
> On Wed, Jun 23, 2021 at 3:50 PM Eelco Chaudron wrote:
>
>> On 26 May 2021, at 14:34, Eelco Chaudron wrote:
>>
>> On 18 May 2021, at 20:15, Ilya Maximets wrote:
>>
>> On 5/18/21 4:44 PM, Eelco Chaudron wrote:
>>
>> Add
On 7/24/21 12:37 AM, Numan Siddique wrote:
> On Fri, Jul 23, 2021 at 2:42 PM Mark Michelson wrote:
>>
>> Hi Dumitru,
>>
>> From a functionality standpoint,
>>
>> Acked-by: Mark Michelson
>>
>> I have a question and suggestion below.
>>
>
> Hi Dumitru,
Hi, Mark, Numan,
Thanks for the reviews!
On 7/23/21 9:02 PM, Numan Siddique wrote:
> On Fri, Jul 23, 2021 at 2:55 PM Mark Michelson wrote:
>>
>> I merged the change with your recommended edit to the commit message.
Thanks, Mark!
>
> Does this patch need a backport to branch-21.06 ?
I guess it can be useful to have in stable branches
Association of a mark to a flow is done as part of its offload handling,
in the offloading thread. However, the PMD thread specifies whether an
offload request is an "add" or "modify" by the association of a mark to
the flow.
This is exposed to a race condition. A flow might be created with
Log flow modifications to help debugging.
Signed-off-by: Eli Britstein
Reviewed-by: Gaetan Rivet
---
lib/dpif-netdev.c | 114 +++---
1 file changed, 68 insertions(+), 46 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index
dp_netdev_flow_offload_main thread is asynchronous, by the cited commit.
There might be a case where there are modification requests of the same
flow submitted before handled. Then, if the first handling fails, the
rule for the flow is deleted, and the mark is freed. Then, the following
one should
Before flushing offloads of a removed port was supported by [1], it was
necessary to flush the 'marks'. In doing so, all offloads of the PMD are
removed, include the ones that are not related to the removed port and
that are not modified following this removal. As a result such flows are
evicted
This patch-set improves/fixes offloads transitions behavior.
Patch #1 avoids flushing PMD offloads unnecessarily.
Patch #2 fixes a flow modifications bug.
Patch #3 fixes a race condition with flow modifications.
Patch #3 improves debuggability of flow modifications.
v2-v1:
- Rebase.
v3-v2:
-
Sure,
will send a v2. Thanks for the review.
Ilya Maximets 于2021年7月26日周一 上午7:22写道：
>
> Re-adding the list and people from CC.
>
> On 6/27/21 8:16 AM, 贺鹏 wrote:
> > Hi, Ilya,
> >
> > sorry for replying so late, being really busy this month.
>
> Busy time for everyone.
> BTW, I'm taking some
24 matches
Mail list logo
