Re: [ovs-dev] [PATCH] netdev-offload-dpdk: initialize s_tnl dynamic string

2021-08-13 Thread Sriharsha Basavapatna via dev
On Fri, Aug 13, 2021 at 6:27 PM Gaëtan Rivet wrote: > On Fri, Aug 13, 2021, at 08:14, Sriharsha Basavapatna via dev wrote: > > The 's_tnl' member in flow_patterns and flow_actions should be > > to set to DS_EMPTY_INITIALIZER, to be consistent with dynamic string > > initializations. > > > >

Re: [ovs-dev] [RFC PATCH ovn 0/4] Use Distributed Gateway Port for ovn-controller scalability.

2021-08-13 Thread Han Zhou
On Tue, Aug 10, 2021 at 9:43 AM Mark Gray wrote: > > On 03/08/2021 19:33, Han Zhou wrote: > > On Tue, Aug 3, 2021 at 11:09 AM Numan Siddique wrote: > >> > >> On Fri, Jul 30, 2021 at 3:22 AM Han Zhou wrote: > >>> > >>> Note: This patch series is on top of a pending patch that is still under >

[ovs-dev] [PATCH ovn 1/6] ovn-northd: Avoid ha_ref_chassis calculation when there is only one chassis in ha_chassis_group.

2021-08-13 Thread Han Zhou
When there is a big number of ha_chassis_groups (e.g. for distributed gateway ports), the calculation of ha_ref_chassis can take the major part of ovn-northd CPU as shown in perf. However, when there is only one chassis in ha_chassis_group, no BFD sessions are needed, so ha_ref_chassis

[ovs-dev] [PATCH ovn 6/6] ovn-controller: Don't flood fill local datapaths beyond DGP boundary.

2021-08-13 Thread Han Zhou
For a fully distributed virtual network dataplane, ovn-controller flood-fills datapaths that are connected through patch ports. This creates scale problems in ovn-controller when the connected datapaths are too many. In a particular situation, when distributed gateway ports are used to connect

[ovs-dev] [PATCH ovn 5/6] ovn-architecture: Add description of a limitation for distributed gateway ports.

2021-08-13 Thread Han Zhou
Signed-off-by: Han Zhou --- ovn-architecture.7.xml | 19 +++ 1 file changed, 19 insertions(+) diff --git a/ovn-architecture.7.xml b/ovn-architecture.7.xml index 3598b5073..091627ede 100644 --- a/ovn-architecture.7.xml +++ b/ovn-architecture.7.xml @@ -1837,6 +1837,25 @@ to

[ovs-dev] [PATCH ovn 4/6] ovn-sb.xml: Add the missing documentation for redirect-type.

2021-08-13 Thread Han Zhou
Signed-off-by: Han Zhou --- ovn-sb.xml | 8 1 file changed, 8 insertions(+) diff --git a/ovn-sb.xml b/ovn-sb.xml index f3b6307e3..4d1cd4eaf 100644 --- a/ovn-sb.xml +++ b/ovn-sb.xml @@ -3177,6 +3177,14 @@ tcp.flags = RST; The name of the distributed port for which this

[ovs-dev] [PATCH ovn 0/6] Use Distributed Gateway Port for ovn-controller scalability.

2021-08-13 Thread Han Zhou
For a fully distributed virtual network dataplane, ovn-controller flood-fills datapaths that are connected through patch ports. This creates scale problems in ovn-controller when the connected datapaths are too many. In a particular situation, when distributed gateway ports are used to connect

[ovs-dev] [PATCH ovn 3/6] binding.c: Create a new function consider_patch_port_for_local_datapaths.

2021-08-13 Thread Han Zhou
Move the logical of handling patch port changes for updating local_datapaths to a separate function, which will be reused later. Also split the switch-case for the 2 cases: LP_PATCH and LP_VTEP, because there are more differences than common, to avoid the extra if-blocks. Signed-off-by: Han Zhou

[ovs-dev] [PATCH ovn 2/6] binding.c: Refactor binding_handle_port_binding_changes.

2021-08-13 Thread Han Zhou
The extra get_local_datapath() call seems unnecessary. Remove it and combine the two if-blocks to an if-else block. Signed-off-by: Han Zhou --- controller/binding.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/controller/binding.c b/controller/binding.c

Re: [ovs-dev] [PATCH RFC 0/1] use meson and ninja as a build system for ovs

2021-08-13 Thread William Tu
> >>> Meson is a nice system in many aspects, but its support for tests is very > >>> limited. IIUC, it can only run a single binary and check the error codes. > >>> Most of our tests starts several daemons and performs several fairly > >>> complex > >>> operations and checks. I'm afraid that

Re: [ovs-dev] [PATCH] dpif-netdev: Fix crash when PACKET_OUT is metered

2021-08-13 Thread Ilya Maximets
On 8/13/21 6:25 AM, Tony van der Peet wrote: > Hi Ilya et al > > I can do that, but it may take a few days to get to it. Thanks for the > detailed analysis, I'll try to get my head around that too and contribute to > a fix. Thanks! I'm planning to make a series of stable releases in a couple

[ovs-dev] [PATCH v2 2/3] dpif-netdev-unixctl.man: Document miniflow-parser-* CMDs

2021-08-13 Thread Cian Ferriter
Document the "ovs-appctl dpif-netdev/miniflow-parser-get" and "ovs-appctl dpif-netdev/miniflow-parser-set" commands in the vswitchd manpage. Fixes: 3d8f47bc041a ("dpif-netdev: Add command line and function pointer for miniflow extract") Signed-off-by: Cian Ferriter --- v2: - Add one line

Re: [ovs-dev] [PATCH 3/3] docs/dpdk/bridge: Fix dpif-netdev/miniflow-parser-set formatting

2021-08-13 Thread Ferriter, Cian
> -Original Message- > From: Stokes, Ian > Sent: Thursday 12 August 2021 15:58 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Cc: f...@sysclose.org > Subject: RE: [ovs-dev] [PATCH 3/3] docs/dpdk/bridge: Fix > dpif-netdev/miniflow-parser-set formatting > > > The "name" parameter

Re: [ovs-dev] [PATCH 2/3] dpif-netdev-unixctl.man: Document miniflow-parser-* CMDs

2021-08-13 Thread Ferriter, Cian
> -Original Message- > From: Stokes, Ian > Sent: Thursday 12 August 2021 15:46 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Cc: f...@sysclose.org > Subject: RE: [ovs-dev] [PATCH 2/3] dpif-netdev-unixctl.man: Document > miniflow-parser-* CMDs > > > Fixes: 3d8f47bc041a

Re: [ovs-dev] [PATCH 1/3] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs

2021-08-13 Thread Ferriter, Cian
> -Original Message- > From: Stokes, Ian > Sent: Thursday 12 August 2021 15:43 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Cc: f...@sysclose.org > Subject: RE: [ovs-dev] [PATCH 1/3] dpif-netdev-unixctl.man: Document > subtable-lookup-* CMDs > > > Fixes: 9ff7cabfd78d ("dpif-netdev:

[ovs-dev] [PATCH v2 3/3] docs/dpdk/bridge: Fix dpif-netdev/miniflow-parser-set formatting

2021-08-13 Thread Cian Ferriter
The "name" parameter isn't optional so don't use brackets around it. Fixes: 5c5c98cec21b ("docs/dpdk/bridge: Add miniflow extract section.") Signed-off-by: Cian Ferriter --- v2: - Change indentation after wrapping shell command. --- Documentation/topics/dpdk/bridge.rst | 4 ++-- 1 file

[ovs-dev] [PATCH v2 1/3] dpif-netdev-unixctl.man: Document subtable-lookup-* CMDs

2021-08-13 Thread Cian Ferriter
Document the "ovs-appctl dpif-netdev/subtable-lookup-prio-get" and "ovs-appctl dpif-netdev/subtable-lookup-prio-set" commands in the vswitchd manpage. Fixes: 9ff7cabfd78d ("dpif-netdev: add subtable-lookup-prio-get command.") Fixes: 3d018c3ea79d ("dpif-netdev: add subtable lookup prio set

Re: [ovs-dev] [PATCH ovn] Suppress periodic RAs for switches attached to localnet

2021-08-13 Thread Frode Nordahl
On Sat, Aug 7, 2021 at 12:20 AM Ihar Hrachyshka wrote: > > When a router port is attached to a localnet switch, sending periodic > RAs through localnet port will confuse upstream router by leaking > conflicting router advertisements into datacenter network. Do I understand you correctly that you

Re: [ovs-dev] [PATCH] netdev-offload-dpdk: initialize s_tnl dynamic string

2021-08-13 Thread Gaëtan Rivet
On Fri, Aug 13, 2021, at 08:14, Sriharsha Basavapatna via dev wrote: > The 's_tnl' member in flow_patterns and flow_actions should be > to set to DS_EMPTY_INITIALIZER, to be consistent with dynamic string > initializations. > > Also, there's a potential memory leak of flow_patterns->s_tnl. > Fix

Re: [ovs-dev] ovs-ctl and other scripts are empty

2021-08-13 Thread mythosmonkeyking
Hi, I made a new discovery, but I don't know why the script went wrong. why??? [mythos@localhost build-gcc]$ pwd /home/mythos/github/ovs/build-gcc [mythos@localhost build-gcc]$ /usr/bin/python3 ../build-aux/soexpand.py -I.. < ../utilities/ovs-test.in Something wrong with TOP_DIR, can't

[ovs-dev] [PATCH] netdev-offload-dpdk: initialize s_tnl dynamic string

2021-08-13 Thread Sriharsha Basavapatna via dev
The 's_tnl' member in flow_patterns and flow_actions should be to set to DS_EMPTY_INITIALIZER, to be consistent with dynamic string initializations. Also, there's a potential memory leak of flow_patterns->s_tnl. Fix this by destroying s_tnl in free_flow_patterns(). Fixes: 507d20e77bfe