Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

I need to have a look. I use the ovn-heater end-to-end test, that was showing a substantial improvement. What are you running this on? A. On 30/09/2021 00:56, Han Zhou wrote: On Wed, Sep 15, 2021 at 5:45 AM > wrote: > > From: Anton Ivanov

Re: [ovs-dev] [PATCH] datapath-windows:adjust Offset when processing packet in POP_VLAN action

Alin, Thanks for your comments, I have sent out the updated patch, please help check. https://patchwork.ozlabs.org/project/openvswitch/patch/20210930045626.9250-1-pweis...@vmware.com/ Regards Wilson 在 2021/9/29 23:21，“Alin-Gabriel Serdean” 写入: Indeed. Thanks for pointing that out. To

[ovs-dev] [PATCH v2 1/1] datapath-windows:adjust Offset when processing packet in POP_VLAN action

From: wilsonpeng In one typical setup, on the Windows VM running OVS Windows Kernel, a Geneva packet with 8021.q VLAN tag is received. Then it may do POP_VLAN action processing in Actions.c, if the packet does not have Ieee8021QNetBufferListInfo in the oob of the packet, it will be processed by

Re: [ovs-dev] [PATCH 0/6] Add support for ovs metering with tc offload

On Wed, 2021-09-29 at 13:37 +0200, Simon Horman wrote: > On Thu, Sep 02, 2021 at 01:18:17PM +0300, Roi Dayan via dev wrote: > > Hi, > > > > This series is adding support for tc offloading of ovs metering. > > The first 3 patches add lib support. > > 4th patch adding tc police actions to reflect

Re: [ovs-dev] [PATCH v6] Encap & Decap actions for MPLS packet type.

Bleep bloop. Greetings Martin Varghese, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around

[ovs-dev] [PATCH v6] Encap & Decap actions for MPLS packet type.

From: Martin Varghese The encap & decap actions are extended to support MPLS packet type. Encap & decap actions adds and removes MPLS header at start of the packet. The existing PUSH MPLS & POP MPLS actions inserts & removes MPLS header between ethernet header and the IP header. Though this

Re: [ovs-dev] [OVN Patch v8 3/3] northd: Restore parallel build with dp_groups

On Wed, Sep 15, 2021 at 5:45 AM wrote: > > From: Anton Ivanov > > Restore parallel build with dp groups using rwlock instead > of per row locking as an underlying mechanism. > > This provides improvement ~ 10% end-to-end on ovn-heater > under virutalization despite awakening some qemu gremlin >

[ovs-dev] [PATCH] Documentation: Change the address in userspace-tunneling.rst

Fixes: b438493e1b03 ("doc: Add DPDK to userspace tunneling guide") Signed-off-by: Paolo Valerio --- Documentation/howto/userspace-tunneling.rst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/howto/userspace-tunneling.rst

Re: [ovs-dev] [PATCH ovn 2/7] northd: Introduce incremental processing for northd

Bleep bloop. Greetings Mark Gray, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: libtool: link: gcc -std=gnu99 -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith

Re: [ovs-dev] [PATCH ovn v4 7/7] northd: Add functionality to runtime node

On 16/09/2021 08:08, Han Zhou wrote: > On Fri, Sep 3, 2021 at 5:22 AM Mark Gray wrote: >> >> Update the runtime node to initialize and destroy some common data >> used by multiple functions in northd. > > Hi Mark, > > It looks good overall as an initiate step to employ the inc-proc engine for >

Re: [ovs-dev] [PATCH ovn v4 5/7] northd: Add n_nat_entries field to 'struct ovn_datapath'

On 15/09/2021 18:58, Mark Michelson wrote: > On 9/14/21 1:27 PM, Mark Gray wrote: >> On 13/09/2021 21:41, Mark Michelson wrote: >>> Hi Mark, >>> >>> Of all the patches in this series, this is the one I am least sure about. >> Thanks for looking over these. >> >>> >>> It seems simple enough, but

[ovs-dev] [PATCH ovn 5/7] northd: Introduce struct northd_data

'struct northd_data' is used to hold the output data from the incremental processing node 'en_northd'. This will be used, in a later commit, as the input data to 'en_lflow'. In order to achieve this, we refactor in the following way: * Introduce northd_init() which initializes this data. *

[ovs-dev] [PATCH ovn 7/7] en_lflow: Generate logical flows

Generate logical flows using 'en_flow' incremental processing node. This node uses output data from 'en_northd' in order to generate logical flows. Signed-off-by: Mark Gray --- northd/en-lflow.c | 12 northd/northd.c | 6 +- northd/northd.h | 1 + 3 files changed, 14

[ovs-dev] [PATCH ovn 6/7] northd: Add lflow node

Add an additional node that initially does nothing. This serves as a template for how to add a new node. This node is inserted after the northd_node. This node will be updated in a later commit to generate logical flows for the SBDB. Signed-off-by: Mark Gray --- northd/automake.mk | 2

[ovs-dev] [PATCH ovn 4/7] northd: Rename struct northd_context

In order to prepare for a subsequent commit, rename 'struct northd_context' to 'struct northd_idl_context'. In subsequent commits, 'struct northd_idl_context' will then be used, only, to hold the IDL context required by northd. Signed-off-by: Mark Gray --- northd/en-northd.c | 2 +-

[ovs-dev] [PATCH ovn 2/7] northd: Introduce incremental processing for northd

Initial implementation adds a single node (northd). This single node executes the northd processing pipeline but does not do so incrementally. In order to develop incremental processing for northd, the code will be organised with a .c/.h file for each I-P node following the naming convention

[ovs-dev] [PATCH ovn 3/7] northd: Add n_nat_entries field to 'struct ovn_datapath'

destroy_nat_entries() iterates over nat_entries using 'n_nat' as the number of NAT entries from the NB database. This behaviour can be incorrect as it assumes that there are 'n_nat' 'nat_entries'. 'struct ovn_datapath' should maintain a count of 'nat_entries' in 'struct ovn_datapath' rather than

[ovs-dev] [PATCH ovn 1/7] inc-proc-eng: Allow definition of engine_node with global scope

Refactor ENGINE_NODE() macro to not assign function pointers. This allows ENGINE_NODE() to be used outside functions, creating an engine_node with global scope (but can be statically defined within a file). This allows more flexibility in how the I-P engine can be used as engine nodes can be

[ovs-dev] [PATCH ovn 0/7] northd: Introduce incremental processing framework

Add the 'inc-proc-eng' framework to northd. This does *not* add any incremental processing at this stage but provides the framework to do so. Even in this base configuration, we see an advantage as northd no longer processes the databases if it has been woken only to handle, for example, a unixctl

Re: [ovs-dev] [PATCH] datapath-windows:adjust Offset when processing packet in POP_VLAN action

Indeed. Thanks for pointing that out. To be honest that looks like a bug. We should return an error if the it is not a valid VLAN frame. -Original Message- From: Wilson Peng Sent: Wednesday, September 29, 2021 5:52 PM To: Alin-Gabriel Serdean ; ovs-dev@openvswitch.org Subject: Re:

Re: [ovs-dev] [PATCH] datapath-windows:adjust Offset when processing packet in POP_VLAN action

Alin, Original code diff is to avoid the case below(it will return NDIS_STATUS_SUCCESS before RtlMoveMemory in function OvsPopFieldInPacketBuf). Regards Wilson In function OvsPopFieldInPacketBuf(..) if (!bufferData) { EthHdr *ethHdr = (EthHdr *)bufferStart; /* If the frame is

[ovs-dev] [PATCH] netdev-vport : Fix userspace tunnel ioctl(SIOCGIFINDEX) info logs.

From: linhuang Userspace tunnel doesn't have a valid device in the kernel. So get_ifindex() function (ioctl) always get error during adding a port, deleting a port or updating a port status. The info log is "2021-08-29T09:17:39.830Z|00059|netdev_linux|INFO|ioctl(SIOCGIFINDEX) on vxlan_sys_4789

[ovs-dev] [PATCH] conntrack: support default timeout policy get/set cmd for netdev datapath

From: wenxu Now, the default timeout policy for netdev datapath is hard codeing. In some case show or modify is needed. Add command for get/set default timeout policy. Using like this: ovs-appctl dpctl/ct-get-default-timeout-policy [dp] ovs-appctl dpctl/ct-set-default-timeout-policy [dp]

Re: [ovs-dev] [PATCH] datapath-windows:adjust Offset when processing packet in POP_VLAN action

From: aserd...@ovn.org Thank you for raising awareness about this issue. You are right the offsets are not being updated when a pop vlan action is hit, they are updated only on pop_mpls. https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Actions.c#L1173-L1174 Can you please

Re: [ovs-dev] [PATCH] python: replace pyOpenSSL with ssl

I'll take a look this morning and run it through the neutron ml2/ovn SSL-related tests. Terry On Fri, Sep 10, 2021 at 9:34 AM Timothy Redaelli wrote: > > Currently, pyOpenSSL is half-deprecated upstream and so it's removed on > some distributions (for example on CentOS Stream 9, >

Re: [ovs-dev] [PATCH net-next v6] net: openvswitch: IPv6: Add IPv6 extension header support

On Wed, 29 Sep 2021 08:19:05 +0200 Nicolas Dichtel wrote: > > /* Insert a kernel only KEY_ATTR */ > > #define OVS_KEY_ATTR_TUNNEL_INFO__OVS_KEY_ATTR_MAX > > #undef OVS_KEY_ATTR_MAX > > #define OVS_KEY_ATTR_MAX__OVS_KEY_ATTR_MAX > Following the other thread [1], this will break if

Re: [ovs-dev] [PATCH] system-offloads-traffic.at: Add sFlow offload test cases

On Tue, Sep 28, 2021 at 02:41:17PM +0800, Chris Mi wrote: > Hi Simon, > > On 9/24/2021 3:03 PM, Simon Horman wrote: > > On Thu, Sep 16, 2021 at 11:38:52AM +0300, Chris Mi wrote: > > > Add two sFlow offload test caes: > > > > > >3: sflow offloads with sampling=1 - ping between two ports -

Re: [ovs-dev] [PATCH 0/6] Add support for ovs metering with tc offload

On Thu, Sep 02, 2021 at 01:18:17PM +0300, Roi Dayan via dev wrote: > Hi, > > This series is adding support for tc offloading of ovs metering. > The first 3 patches add lib support. > 4th patch adding tc police actions to reflect ovs metering. > 5th patch cleaning existing tc police actions on

Re: [ovs-dev] [PATCH ovn] nbctl: allow multiple bfd sessions with same nexthop and different outports

Hi all, Tested this PR on an OCP OVN-K cluster and it works as expected. I created two pods on different nodes having the same nexthop and OVN created two BFD sessions one from each of the GW routers on those nodes towards the nexthop/dst_ip. === sh-4.4# ovn-nbctl lr-route-list

Re: [ovs-dev] [PATCH v2 0/6] Add support for ovs metering with tc offload

On Fri, 2021-09-24 at 15:51 +0200, Ilya Maximets wrote: > On 9/22/21 09:25, Roi Dayan wrote: > > > > > > On 2021-09-02 3:59 PM, Roi Dayan wrote: > > > Hi, > > > > > > This series is adding support for tc offloading of ovs metering. > > > The first 3 patches add lib support. > > > 4th patch

[ovs-dev] [PATCH ovn v6 13/12] ovn-controller: Remove unnecessary log call

A INFO level log call used during development was left behind in the en_plug_provider_lookup_run function. Remove it. --- controller/ovn-controller.c | 1 - 1 file changed, 1 deletion(-) diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c index f5516a879..7ec377f03 100644 ---

Re: [ovs-dev] [PATCH net-next v6] net: openvswitch: IPv6: Add IPv6 extension header support

Le 29/09/2021 à 02:48, Jakub Kicinski a écrit : > On Tue, 28 Sep 2021 12:47:27 -0700 Toms Atteka wrote: >> diff --git a/include/uapi/linux/openvswitch.h >> b/include/uapi/linux/openvswitch.h >> index a87b44cd5590..dc6eb5f6399f 100644 >> --- a/include/uapi/linux/openvswitch.h >> +++