Re: [ovs-dev] [PATCH v2 4/4] Tunnel: Snoop ingress packets and update neigh cache if needed.

2021-11-24 Thread Flavio Leitner
On Wed, Nov 10, 2021 at 11:46:55AM +0100, Paolo Valerio wrote: > In case of native tunnel with bfd enabled, if the MAC address of the > remote end's interface changes (e.g. because it got rebooted, and the > MAC address is allocated dynamically), the BFD session will never be > re-established. >

Re: [ovs-dev] [PATCH v2 3/4] Native tunnel: Do not refresh the entry while revalidating.

2021-11-24 Thread Flavio Leitner
On Wed, Nov 10, 2021 at 11:46:49AM +0100, Paolo Valerio wrote: > This is a minor issue but visible e.g. when you try to flush the neigh > cache while the ARP flow is still present in the datapath, triggering > the revalidation of the datapath flows which subsequently > refreshes/adds the entry in

Re: [ovs-dev] [PATCH v2 2/4] Native tunnel: Add tnl/neigh/aging command.

2021-11-24 Thread Flavio Leitner
On Wed, Nov 10, 2021 at 11:46:42AM +0100, Paolo Valerio wrote: > with the command is now possible to change the aging time of the > cache entries. > > For the existing entries the aging time is updated only if the > current expiration is greater than the new one. In any case, the next > refresh

Re: [ovs-dev] [PATCH v2 1/4] Native tunnel: Read/write expires atomically.

2021-11-24 Thread Flavio Leitner
On Wed, Nov 10, 2021 at 11:46:36AM +0100, Paolo Valerio wrote: > Expires is modified in different threads (revalidator, pmd-rx, bfd-tx). > It's better to use atomics for such potentially parallel write. > > Signed-off-by: Paolo Valerio > --- Acked-by: Flavio Leitner

[ovs-dev] [PATCH 4/4] system-dpdk: Add tests for HXPS

2021-11-24 Thread Maxime Coquelin
This patch adds two tests for Vhost-user client ports with multiqueue. First test is with HXPS disabled, where the expectation is that a single queue Vhost-user queue receives the 256 packets injected on the dummy port. Second test is with HXPS enabled, where the expectation is that the 256

[ovs-dev] [PATCH 3/4] dpif-netdev: Add HXPS Tx queue mode

2021-11-24 Thread Maxime Coquelin
This patch adds a new HXPS Tx mode that distributes the traffic on all the Tx queues, whatever the number of PMD threads. It would be useful for guests expecting traffic to be distributed on all the vCPUs. The idea here is to re-use the 5-tuple hash of the packets, already computed to build the

[ovs-dev] [PATCH 2/4] dpif-netdev: Introduce Tx queue mode

2021-11-24 Thread Maxime Coquelin
A boolean is currently used to differenciate between the static and XPS Tx queue modes. Since we are going to introduce a new RSS mode, replace this boolean with an enum. This patch does not introduce functionnal changes. Signed-off-by: Maxime Coquelin --- lib/dpif-netdev.c | 25

[ovs-dev] [PATCH 1/4] netdev-dpdk: Introduce per rxq/txq Vhost-user statistics

2021-11-24 Thread Maxime Coquelin
HXPS feature will enable steering Tx packets on transmist queues based on their hashes. In order to test the feature, it is needed to be able to get the per-queue statistics for Vhost-user ports. This patch introduces "bytes", "packets" and "error" per-queue custom statistics for Vhost-user

[ovs-dev] [PATCH 0/4] dpif-netdev: Hash-based Tx packet steering

2021-11-24 Thread Maxime Coquelin
This series introduces a new HXPS Tx mode alognside existing XPS and static modes. The goal is to provide a mode where all the transmit queues are used, whatever the number of PMD threads. This may be used with Vhost-user ports, where the guest application driving the Virtio device expects packets

Re: [ovs-dev] [PATCH 0/2] ovsdb-data: Consolidate ovsdb atom and json strings.

2021-11-24 Thread Mike Pattrick
On Mon, 2021-11-22 at 01:09 +0100, Ilya Maximets wrote: > This patch-set is a continuation of work for deduplication of > ovsdb strings. Previous patch (accepted): > > https://patchwork.ozlabs.org/project/openvswitch/patch/20210923001353.4072533-1-i.maxim...@ovn.org/ > > Ilya Maximets (2): >

Re: [ovs-dev] [PATCH v2 1/2] stream-ssl: Fix handling of default ciphers/protocols

2021-11-24 Thread Flavio Leitner
On Mon, Nov 15, 2021 at 10:40:47AM +0100, Frode Nordahl wrote: > On Mon, Sep 13, 2021 at 4:23 AM Frode Nordahl > wrote: > > > > On Sat, Sep 11, 2021 at 10:23 PM Flavio Leitner wrote: > > > > > > On Fri, Sep 10, 2021 at 06:20:45PM +0200, Frode Nordahl wrote: > > > > On Thu, Sep 9, 2021 at 9:53 PM

[ovs-dev] [PATCH net-next v8] net: openvswitch: IPv6: Add IPv6 extension header support

2021-11-24 Thread Toms Atteka
This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and packets can be filtered using ipv6_ext flag. Signed-off-by: Toms Atteka --- include/uapi/linux/openvswitch.h | 6 ++ net/openvswitch/flow.c | 140 +++ net/openvswitch/flow.h | 14

Re: [ovs-dev] [PATCH] tests/flowgen: Fix length field of 802.2 data link header.

2021-11-24 Thread Paolo Valerio
Hello Ilya, Ilya Maximets writes: > Length in Data Link Header for these packets should not include > source and destination MACs or the length field itself. > > Therefore, it should be 14 bytes less, otherwise other network > tools like wireshark complains: > > Expert Info (Error/Malformed):

Re: [ovs-dev] [PATCH ovn] northd: I-P: fix BFD dependency.

2021-11-24 Thread Dumitru Ceara
On 11/24/21 17:21, Numan Siddique wrote: > On Wed, Nov 24, 2021 at 11:19 AM Dumitru Ceara wrote: >> >> On 11/24/21 17:15, Numan Siddique wrote: >>> On Tue, Nov 23, 2021 at 7:52 PM Dumitru Ceara wrote: BFD entries are updated and their ->ref field is set to 'true' when static

Re: [ovs-dev] [PATCH ovn] northd: I-P: fix BFD dependency.

2021-11-24 Thread Numan Siddique
On Wed, Nov 24, 2021 at 11:19 AM Dumitru Ceara wrote: > > On 11/24/21 17:15, Numan Siddique wrote: > > On Tue, Nov 23, 2021 at 7:52 PM Dumitru Ceara wrote: > >> > >> BFD entries are updated and their ->ref field is set to 'true' when > >> static routes are parsed, within build_lflows(), in the

Re: [ovs-dev] [PATCH ovn] northd: I-P: fix BFD dependency.

2021-11-24 Thread Dumitru Ceara
On 11/24/21 17:15, Numan Siddique wrote: > On Tue, Nov 23, 2021 at 7:52 PM Dumitru Ceara wrote: >> >> BFD entries are updated and their ->ref field is set to 'true' when >> static routes are parsed, within build_lflows(), in the 'en_lflow' I-P >> node. Therefore we cannot clean up BFD entries in

Re: [ovs-dev] [PATCH v2 3/3] system-dpdk: Test with mlx5 devices.

2021-11-24 Thread Eelco Chaudron
On 24 Nov 2021, at 17:14, Eelco Chaudron wrote: > On 23 Nov 2021, at 15:15, David Marchand wrote: > >> The DPDK unit test only runs if vfio or igb_uio kernel module is loaded: >> on systems with only mlx5, this test is always skipped. >> >> Besides, the test tries to grab the first device

Re: [ovs-dev] [PATCH ovn] northd: I-P: fix BFD dependency.

2021-11-24 Thread Numan Siddique
On Tue, Nov 23, 2021 at 7:52 PM Dumitru Ceara wrote: > > BFD entries are updated and their ->ref field is set to 'true' when > static routes are parsed, within build_lflows(), in the 'en_lflow' I-P > node. Therefore we cannot clean up BFD entries in 'en_northd' which is > an input of 'en_lflow'.

Re: [ovs-dev] [PATCH v2 3/3] system-dpdk: Test with mlx5 devices.

2021-11-24 Thread Eelco Chaudron
On 23 Nov 2021, at 15:15, David Marchand wrote: > The DPDK unit test only runs if vfio or igb_uio kernel module is loaded: > on systems with only mlx5, this test is always skipped. > > Besides, the test tries to grab the first device listed by dpdk-devbind.py, > regardless of the PCI device

Re: [ovs-dev] [PATCH v2 2/3] system-dpdk: Use dummy-pmd port for packet injection.

2021-11-24 Thread Eelco Chaudron
On 23 Nov 2021, at 15:15, David Marchand wrote: > net_pcap is not always available in DPDK (like, in a dev > environment when you forgot to install the libpcap-devel). > On the other hand, OVS already has its own way to inject packets into a > bridge. Let's make use of it. > > This solution is

Re: [ovs-dev] [PATCH v2 1/3] system-dpdk: Refactor common logs matching.

2021-11-24 Thread Eelco Chaudron
On 23 Nov 2021, at 15:15, David Marchand wrote: > Move EAL logs and commonly ignored logs to a common macro. > Remove obsolete ones (like i40e [1] and timer [2] logs). > Extend regex on hugepage logs since a check on hugepages availability is > already present on OVS side, and as a

Re: [ovs-dev] [PATCH v3] netdev-vport : Fix userspace tunnel ioctl(SIOCGIFINDEX) info logs.

2021-11-24 Thread 0-day Robot
Bleep bloop. Greetings lin huang, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author linhuang needs to sign off. WARNING: Unexpected sign-offs from developers who are

[ovs-dev] [PATCH v3] netdev-vport : Fix userspace tunnel ioctl(SIOCGIFINDEX) info logs.

2021-11-24 Thread lin huang
From: linhuang Userspace tunnel doesn't have a valid device in the kernel. So get_ifindex() function (ioctl) always get error during adding a port, deleting a port or updating a port status. The info log is "2021-08-29T09:17:39.830Z|00059|netdev_linux|INFO|ioctl(SIOCGIFINDEX) on vxlan_sys_4789

Re: [ovs-dev] [PATCH] netlink-socket: Check for null sock in nl_sock_recv__()

2021-11-24 Thread Flavio Leitner
On Tue, Nov 23, 2021 at 07:58:52PM -0300, Murilo Opsfelder Araújo wrote: > Hi, Flavio. > > On 11/23/21 15:32, Flavio Leitner wrote: > > On Mon, Nov 22, 2021 at 03:46:28PM -0300, Murilo Opsfelder Araújo wrote: > > > Hi, Ilya Maximets. > > > > > > On 11/19/21 13:23, Ilya Maximets wrote: > > > > On

Re: [ovs-dev] [PATCH dpdk-latest v3 0/5] Fixes for DPDK v21.11

2021-11-24 Thread David Marchand
Hello Ian, On Wed, Nov 24, 2021 at 12:17 PM Stokes, Ian wrote: > > On Wed, Nov 10, 2021 at 3:19 PM Stokes, Ian wrote: > > > Thanks for the series. Looks good on the github actions to myself. I'd > > > like to > > get OVS up and running on validation with rc2 so I've pushed the series to > >

Re: [ovs-dev] [PATCH ovn] northd: I-P: fix BFD dependency.

2021-11-24 Thread Dumitru Ceara
On 11/24/21 01:51, Dumitru Ceara wrote: > BFD entries are updated and their ->ref field is set to 'true' when > static routes are parsed, within build_lflows(), in the 'en_lflow' I-P > node. Therefore we cannot clean up BFD entries in 'en_northd' which is > an input of 'en_lflow'. > > To fix

Re: [ovs-dev] [PATCH v4] utilities: Add another GDB macro for ovs-vswitchd

2021-11-24 Thread Eelco Chaudron
On 19 Nov 2021, at 15:35, Mike Pattrick wrote: > This commit adds a basic packet metadata macro to the already existing > macros in ovs_gdb.py, ovs_dump_packets will print out information about > one or more packets. It feeds packets into tcpdump, and the user can > pass in tcpdump options to

Re: [ovs-dev] [PATCH dpdk-latest v3 0/5] Fixes for DPDK v21.11

2021-11-24 Thread Stokes, Ian
> Hello Ian, > > On Wed, Nov 10, 2021 at 3:19 PM Stokes, Ian wrote: > > Thanks for the series. Looks good on the github actions to myself. I'd like > > to > get OVS up and running on validation with rc2 so I've pushed the series to > dpdk-latest and rebased. > > > > Folks on the Intel side will