Re: [ovs-dev] [PATCH ovn v3] Add a northbound interface to program MAC_Binding table

Hi Lorenzo, I’ll address the review comments and try to send out a patch next week. Thank You, Karthik C On 3/3/22, 3:14 PM, "Lorenzo Bianconi" wrote: > > From: Karthik Chandrashekar > > mailto:karthi...@nutanix.com>> > > > > Add a new NB and SB table for managing Static MAC_Binding entries.

Re: [ovs-dev] [PATCH v7 ovn] controller: reconfigure ovs meters for ovn meters

On Wed, Mar 2, 2022 at 11:21 AM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > At the moment ovs meters are reconfigured by ovn just when a > meter is allocated or removed while updates for an already > allocated meter are ignored. This issue can be easily verified > with the following

Re: [ovs-dev] [PATCH 4/4] ovsdb: row: Optimize row updates by applying diffs in-place.

On 1/7/22 21:46, Mike Pattrick wrote: > On Sun, 2021-12-19 at 15:09 +0100, Ilya Maximets wrote: >> ovsdb_datum_apply_diff_in_place() is much faster than the usual >> ovsdb_datum_apply_diff() in most cases, because it doesn't clone or >> compare unnecessary data. Since the original destination

Re: [ovs-dev] [PATCH 3/4] ovsdb: relay: Add transaction history support.

On 1/25/22 18:47, Han Zhou wrote: > > > On Sun, Dec 19, 2021 at 6:09 AM Ilya Maximets > wrote: >> >> Even though relays can be scaled to the big number of servers to >> handle a lot more clients, lack of transaction history may cause >> significant load if clients are

[ovs-dev] [PATCH v3 6/6] acinclude: Add seperate check for AVX512VPOPCNTDQ ISA.

Checking for AVX512VPOPCNTDQ separately will allow the compiler to generate other AVX512 ISA code where supported. This is relevant for GCC where AVX512VPOPCNTDQ support is added in GCC 7. In GCC 5 and 6, most AVX512 code can be generated, just without VPOPCNTDQ support. Signed-off-by: Cian

[ovs-dev] [PATCH v3 5/6] acinclude: Add seperate check for AVX512VBMI ISA.

Only use the "avx512vbmi" compiler target when it is actually supported by the compiler. Signed-off-by: Cian Ferriter --- v3: * Preserve the order of the mfex impl list. v2 changed this order. We want the order to be preserved because VBMI functions should be chosen by the mfex study impl

[ovs-dev] [PATCH v3 3/6] dpif-netdev-extract: Remove ISA compiler target for mfex.

There are no instructions from this ISA used. The target is not needed. Signed-off-by: Cian Ferriter --- lib/dpif-netdev-extract-avx512.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/dpif-netdev-extract-avx512.c b/lib/dpif-netdev-extract-avx512.c index c1c1fefb6..f36a6eab0 100644

[ovs-dev] [PATCH v3 4/6] acinclude: Add seperate check for AVX512BW and AVX512DQ ISA.

Checking for AVX512BW and AVX512DQ separately will allow the compiler to generate some AVX512 code where it is supported. For example, in GCC 4.9 where there is just support for AVX512F, this patch will allow the AVX512 DPIF to be built. This partial support change will be effective when the

[ovs-dev] [PATCH v3 2/6] dpif-netdev-lookup: Fix GCC 5 warning.

GCC 5 gave an incompatible pointer type warning for pkt_blocks when it's passed to _mm512_mask_i64gather_epi64(). Follow the same pattern used for tbl_blocks where the 'const uint64_t *' is cast to a 'const void *' when passed in to avx512_blocks_gather(). Signed-off-by: Cian Ferriter --- v3:

[ovs-dev] [PATCH v3 0/6] Build some AVX512 code on older compilers.

Support for more AVX512 ISA was added in various compiler releases. For example in GCC, increasing AVX512 ISA support was added in GCC 4.9, 5 and then 7. Depending on the GCC version, none, some or all of the AVX512 code in OVS can be built. This patchset adds support for the "some" case, where

[ovs-dev] [PATCH v3 1/6] dpif-netdev-private-extract: Fix typo VMBI -> VBMI.

Signed-off-by: Cian Ferriter --- lib/dpif-netdev-private-extract.c | 8 lib/dpif-netdev-private-extract.h | 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/dpif-netdev-private-extract.c b/lib/dpif-netdev-private-extract.c index a29bdcfa7..d8e2a55f2

Re: [ovs-dev] [PATCH v2 4/5] acinclude: Add seperate check for AVX512VBMI ISA.

> -Original Message- > From: Van Haaren, Harry > Sent: Wednesday 2 March 2022 14:36 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Subject: RE: [PATCH v2 4/5] acinclude: Add seperate check for AVX512VBMI ISA. > > > -Original Message- > > From: Ferriter, Cian > > Sent:

Re: [ovs-dev] [PATCH] json: Improve json parsing

Hi Rosemarie, On 2/28/22 16:39, Rosemarie O'Riorden wrote: > To parse a json string prior to this change, json_lex_input is called > with each character of the string. If the character needs to be copied > to the buffer, it is copied individually. This is an expensive > operation, as often there

Re: [ovs-dev] [PATCH branch-2.15] dpdk: Use DPDK 20.11.4 release

On 03/03/2022 08:00, Suneetha Kalahasthi wrote: Modify ci linux build script to use the latest DPDK stable release 20.11.4. Modify Documentation to use the latest DPDK stable release 20.11.4. Update NEWS file to reflect the latest DPDK stable release 20.11.4. FAQ is updated to reflect the latest

Re: [ovs-dev] [PATCH branch-2.16] dpdk: Use DPDK 20.11.4 release

On 03/03/2022 08:01, Suneetha Kalahasthi wrote: Modify ci linux build script to use the latest DPDK stable release 20.11.4. Modify Documentation to use the latest DPDK stable release 20.11.4. Update NEWS file to reflect the latest DPDK stable release 20.11.4. FAQ is updated to reflect the latest

Re: [ovs-dev] [PATCH v3 01/17] util: add multi-variable loop iterator macros

On 3/3/22 10:39, Dumitru Ceara wrote: On 3/3/22 07:43, Adrian Moreno wrote: Thanks for the review Dumitru, A comment below. On 2/25/22 13:06, Dumitru Ceara wrote: On 2/16/22 15:27, Adrian Moreno wrote: Multi-variable loop iterators avoid potential undefined behavior by using an internal

Re: [ovs-dev] [PATCH v2] system-dpdk: Fix mfex autovalidator tests.

> -Original Message- > From: Amber, Kumar > Sent: Tuesday 1 March 2022 15:08 > To: ovs-dev@openvswitch.org > Cc: Ferriter, Cian ; echau...@redhat.com; Stokes, > Ian ; > Van Haaren, Harry ; Amber, Kumar > > Subject: [PATCH v2] system-dpdk: Fix mfex autovalidator tests. > > AVX512

[ovs-dev] [PATCH ovn v2] ovn-ic: Support IGMP/MLD in multi-AZ deployments.

Commit 974618c61de8 ("ovn-ic: physical: Support multicast_group flooding on IC transit switches.") added support for statically forwarding IP multicast traffic between AZs. While this works, it's a waste of resources to flood all IP multicast traffic to all instances of the transit switch in all

Re: [ovs-dev] [PATCH ovn v3] Add a northbound interface to program MAC_Binding table

> > From: Karthik Chandrashekar > > > > Add a new NB and SB table for managing Static MAC_Binding entries. > > This table is currently supported for logical routers. OVN northd > > is responsible for propagating the values from NB to SB. OVN controller > > is responsible for installation MAC

Re: [ovs-dev] [PATCH v3 01/17] util: add multi-variable loop iterator macros

On 3/3/22 07:43, Adrian Moreno wrote: > Thanks for the review Dumitru, > > A comment below. > > On 2/25/22 13:06, Dumitru Ceara wrote: >> On 2/16/22 15:27, Adrian Moreno wrote: >>> Multi-variable loop iterators avoid potential undefined behavior by >>> using an internal iterator variable to

Re: [ovs-dev] [PATCH ovn] ovn-ic: Support IGMP/MLD in multi-AZ deployments.

On 3/2/22 20:31, Mark Michelson wrote: > Hi Dumitru, > Hi Mark, > This looks good to me. I only have a small nit below. > > Acked-by: Mark Michelson > Thanks! > On 2/28/22 16:06, Dumitru Ceara wrote: >> Commit 974618c61de8 ("ovn-ic: physical: Support multicast_group flooding >> on IC

[ovs-dev] [PATCH branch-2.16] dpdk: Use DPDK 20.11.4 release

Modify ci linux build script to use the latest DPDK stable release 20.11.4. Modify Documentation to use the latest DPDK stable release 20.11.4. Update NEWS file to reflect the latest DPDK stable release 20.11.4. FAQ is updated to reflect the latest DPDK for each OVS branch. Signed-off-by:

[ovs-dev] [PATCH branch-2.15] dpdk: Use DPDK 20.11.4 release

Modify ci linux build script to use the latest DPDK stable release 20.11.4. Modify Documentation to use the latest DPDK stable release 20.11.4. Update NEWS file to reflect the latest DPDK stable release 20.11.4. FAQ is updated to reflect the latest DPDK for each OVS branch. Signed-off-by: