> From: Karthik Chandrashekar
>
> From: Karthik Chandrashekar
Hi Karthik,
Thanks for the new version. You need rebase it since it does not apply cleanly.
Some comments inline.
Regards,
Lorenzo
>
[...]
> @@ -2346,7 +2368,7 @@ add_lb_hairpin_flows(const struct
> sbrec_load_balancer_table
IPv6 extension headers carry optional internet layer information
and are placed between the fixed header and the upper-layer
protocol header.
This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
packets can be filtered using ipv6_ext flag.
Some spacing style issues fixed.
Tested-at:
Bleep bloop. Greetings Toms Atteka, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Toms Atteka needs to sign off.
WARNING: Unexpected sign-offs from developers who
From: Toms Atteka
IPv6 extension headers carry optional internet layer information
and are placed between the fixed header and the upper-layer
protocol header.
This change adds a new OpenFlow field OFPXMT_OFB_IPV6_EXTHDR and
packets can be filtered using ipv6_ext flag.
Some spacing style
On Wed, Mar 9, 2022 at 2:38 PM Mark Michelson wrote:
>
> Commit 4deac4509abbedd6ffaecf27eed01ddefccea40a introduced functionality
> in ovn-northd to use a single zone for SNAT and DNAT when possible. It
> accounts for certain situations, such as hairpinned traffic, where we
> still need a
On 3/16/22 15:08, Eelco Chaudron wrote:
>
>
> On 14 Jul 2021, at 14:33, Eelco Chaudron wrote:
>
>> On 8 Jul 2021, at 21:21, Ilya Maximets wrote:
>>
>>> On 5/24/21 2:39 PM, Timothy Redaelli wrote:
On Tue, 18 May 2021 06:17:48 -0400
Eelco Chaudron wrote:
> Due to flow lookup
DPDK based dp-packets points to data buffers that can't be expanded
dynamically.
Their layout is as follows:
- a 128 bytes headroom chosen at DPDK build time (RTE_PKTMBUF_HEADROOM),
- a maximum size chosen at mempool creation,
In some usecases though (like encapsulating with multiple tunnels),
a
On Wed, Mar 2, 2022 at 8:40 AM Andreas Karis wrote:
>
> Tunnels in LibreSwan and OpenSwan allow for many options to be set on a
> per tunnel basis. Pass through any options starting with ipsec_ to the
> connection in the configuration file. Administrators are responsible for
> picking valid
On Thu, Mar 17, 2022 at 7:36 AM Mohammad Heib wrote:
>
> IPsec unit tests uses tcpdump to capture and validate the ESP
> traffic so the test must be skipped in environment that don't
> have the tcpdump tool installed.
>
> Signed-off-by: Mohammad Heib
Doesn't system-traffic.at also use tcpdump?
On 18 Mar 2022, at 13:43, Aaron Conole wrote:
> During NAT, a tuple collision may occur. When this happens, openvswitch
> will make a second pass through NAT which will perform additional packet
> modification. This will update the skb data, but not the flow key that
> OVS uses. This means
On 9 Mar 2022, at 17:10, Adrian Moreno wrote:
> Using the SHORT version of the *_SAFE loops makes the code cleaner
> and less error-prone. So, use the SHORT version and remove the extra
> variable when possible.
>
> In order to be able to use both long and short versions without changing
> the
On 9 Mar 2022, at 17:10, Adrian Moreno wrote:
> Use multi-variable iteration helpers to rewrite non-safe loops.
>
> There is an important behavior change compared with the previous
> implementation: When the loop ends normally (i.e: not via "break;"), the
> object pointer provided by the user
On 9 Mar 2022, at 17:10, Adrian Moreno wrote:
> Having both LONG and SHORT versions of the SAFE macros with different
> names is not very convenient. Add helpers that facilitate overloading
> such macros using a single name.
>
> In order to work around a known issue in MSVC [1], an indirection
On 9 Mar 2022, at 17:10, Adrian Moreno wrote:
> Safe version of multi-variable iterator helpers declare an internal
> variable to store the next value of the iterator temporarily.
>
> Two versions of the macro are provided, one that still uses the NEXT
> variable for backwards compatibility
On 9 Mar 2022, at 17:10, Adrian Moreno wrote:
> Multi-variable loop iterators avoid potential undefined behavior by
> using an internal iterator variable to perform the iteration and only
> referencing the containing object (via OBJECT_CONTAINING) if the
> iterator has been validated via the
During NAT, a tuple collision may occur. When this happens, openvswitch
will make a second pass through NAT which will perform additional packet
modification. This will update the skb data, but not the flow key that
OVS uses. This means that future flow lookups, and packet matches will
have
On 17 Mar 2022, at 2:01, Chris Mi wrote:
> On 2022-03-11 8:53 PM, Eelco Chaudron wrote:
>>
>
> @@ -449,6 +462,7 @@ dpif_close(struct dpif *dpif)
>if (dpif) {
>struct registered_dpif_class *rc;
>
> +dpif_offload_close(dpif);
** Not sure
On 11 Mar 2022, at 16:21, Adrian Moreno wrote:
> Add unit test for OFFilter class.
>
> Acked-by: Eelco Chaudron
> Signed-off-by: Adrian Moreno
> ---
This was the final patch in the series, and it all looks good.
One small question on patch 3 as I noticed the code change post-ack.
Thanks,
On 11 Mar 2022, at 16:21, Adrian Moreno wrote:
> Introduce OFPFlow class and all its decoders.
>
> Most of the decoders are generic (from decoders.py). Some have special
> syntax and need a specific implementation.
>
> Decoders for nat are moved to the common decoders.py because it's syntax
>
On 11 Mar 2022, at 16:21, Adrian Moreno wrote:
> Signed-off-by: Adrian Moreno
> ---
Changes look good to me!
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 11 Mar 2022, at 16:21, Adrian Moreno wrote:
> Add unit tests for OFPFlow class and ip-port range decoder
>
> Signed-off-by: Adrian Moreno
> ---
Changes look good to me!
Acked-by: Eelco Chaudron
___
dev mailing list
d...@openvswitch.org
On 11 Mar 2022, at 16:21, Adrian Moreno wrote:
> In order to minimize the risk of having the python flow parsing code and
> the C flow formatting code divert, add a target that checks if the
> formatting code has been changed since the last revision and warn the
> developer if it has.
>
> The
On 11 Mar 2022, at 16:21, Adrian Moreno wrote:
> Based on meta-field information extracted by extract_ofp_fields,
> autogenerate the right decoder to be used.
>
> Acked-by: Eelco Chaudron
> Signed-off-by: Adrian Moreno
Additional v3 changes look good to me.
Acked-by: Eelco Chaudron
On 11 Mar 2022, at 16:21, Adrian Moreno wrote:
> In order to be able to reuse the core extraction logic, split the command
> in two parts. The core extraction logic is moved to python/build while
> the command that writes the different files out of the extracted field
> info is kept in
On 11 Mar 2022, at 16:21, Adrian Moreno wrote:
> Some openflow or dpif flows encode their arguments in lists, eg:
> "some_action(arg1,arg2,arg3)". In order to decode this in a way that can
> be then stored and queried, add ListParser and ListDecoders classes
> that parse lists into KeyValue
On 11 Mar 2022, at 16:21, Adrian Moreno wrote:
> Add more decoders that can be used by KVParser.
>
> For IPv4 and IPv6 addresses, create a new class that wraps
> netaddr.IPAddress.
> For Ethernet addresses, create a new class that wraps netaddr.EUI.
> For Integers, create a new class that
On 11 Mar 2022, at 16:21, Adrian Moreno wrote:
> Most of ofproto and dpif flows are based on key-value pairs. These
> key-value pairs can be represented in several ways, eg: key:value,
> key=value, key(value).
>
> Add the following classes that allow parsing of key-value strings:
> * KeyValue:
27 matches
Mail list logo
