ipfix cfg creation/deleting triggers revalidation. But this does
not cover the case where ipfix options changes, which also suppose
to trigger revalidation.
Fixes: a9f5ee1199e1 ("ofproto-dpif: Trigger revalidation when ipfix config
set.")
Signed-off-by: lic121
---
ofproto/ofproto-dpif-ipfix.c
Hi, Eelco
Thanks for your comments.
Eelco Chaudron 于2022年4月29日周五 18:54写道：
>
>
> On 12 Apr 2022, at 11:09, Peng He wrote:
>
> > David Marchand 于2022年4月12日周二 16:40写道：
> >
> >> On Thu, Apr 7, 2022 at 4:13 AM Peng He wrote:
> >>>
> >>> I understand there is no need to introduce a rcu api,
> >>>
On 4/29/22 01:29, Alin-Gabriel Serdean wrote:
> This patch removes the newly added NEWS entry and adds it as a leaf
> under post 2.17.
>
> Add OVS version instead of specifying that the feature is supported
> for IPv6 connection tracking and Genenve IPv6 tunnels.
>
> Signed-off-by: Alin-Gabriel
Thank you Ilya and Aaron.
Best,
*Vasu Dasari*
On Thu, Apr 28, 2022 at 4:50 PM Ilya Maximets wrote:
> On 4/27/22 17:33, Aaron Conole wrote:
> > Vasu Dasari writes:
> >
> >> Extended OpenFlow monitoring support
> >> * OpenFlow 1.3 with ONF extensions
> >> * OpenFlow 1.4+ as defined in
Currently, ovs_dump_packets will break the formatting of the GDB
terminal UI, resulting in artifacts displayed on the screen that
may make packets difficult to read. This patch suppresses stderr
output from tcpdump and feeds tcpdumps stdout into the paginated
output stream.
Signed-off-by: Mike
On Tue, Apr 12, 2022 at 7:49 AM Christophe Fontaine wrote:
>
> This config param allows the delivery of broadcast and multicast packets
> to the secondary interface of non-lacp bonds, equivalent to the option
> "all_slaves_active" for kernel bonds.
>
> Reported-at:
nx_to_ofp_flow_update_event() aborts the execution if incorrect
event is passed, so checking has to be done before conversion
in order to avoid the crash while decoding malformed flow update
message:
==397030==ERROR: AddressSanitizer: ABRT on unknown address 0x... )
0 0x7fd26688418b in raise
On 4/29/22 20:01, Ilya Maximets wrote:
> On 4/29/22 05:28, Jianbo Liu wrote:
>> On Thu, 2022-04-28 at 14:00 +0200, Ilya Maximets wrote:
>>> On 4/28/22 13:49, Ilya Maximets wrote:
On 4/28/22 11:06, Jianbo Liu wrote:
> On Wed, 2022-04-27 at 13:37 +0200, Ilya Maximets wrote:
>> On
On 4/29/22 05:28, Jianbo Liu wrote:
> On Thu, 2022-04-28 at 14:00 +0200, Ilya Maximets wrote:
>> On 4/28/22 13:49, Ilya Maximets wrote:
>>> On 4/28/22 11:06, Jianbo Liu wrote:
On Wed, 2022-04-27 at 13:37 +0200, Ilya Maximets wrote:
> On 4/27/22 04:41, Jianbo Liu wrote:
>> On Wed,
nx_to_ofp_flow_update_event() aborts the execution if incorrect
event is passed, so checking has to be done before conversion
in order to avoid the crash while decoding malformed flow update
message:
==397030==ERROR: AddressSanitizer: ABRT on unknown address 0x... )
0 0x7fd26688418b in raise
This reverts commit c645550bb249 ("odp-util: Always report
ODP_FIT_TOO_LITTLE for IGMP.")
Always forcing a slow path action can result in some over-broad
flows which swallow all traffic and force them to userspace, as reported
in the thread at
Signed-off-by: Ihar Hrachyshka
---
ovn-nb.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ovn-nb.xml b/ovn-nb.xml
index 9010240a8..e9ad002a0 100644
--- a/ovn-nb.xml
+++ b/ovn-nb.xml
@@ -2365,9 +2365,9 @@
with the highest-
will have QoS applied to it.
Bleep bloop. Greetings Xavier Simonart, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around
This patch is intended to change the way to enable northd lflow build
parallelization, as well as enable runtime change of number of threads.
Before this patch, the following was needed to use parallelization:
- enable parallelization through use_parallel_build in NBDB
- use --dummy-numa to select
The hash of the port number is only needed when a DPCLS needs to be
created. Move the hash calculation inside the if to accomplish this.
Signed-off-by: Cian Ferriter
---
lib/dpif-netdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
Checking for each of the required AVX512 ISA separately will allow the
compiler to generate some AVX512 code where there is some support in the
compiler rather than only generating all AVX512 code when all of it is
supported or no AVX512 code at all.
For example, in GCC 4.9 where there is just
No instructions from the AVX512VL ISA are used.
Compilation for the AVX512F ISA is already enabled in lib/automake.mk
for the dpif-netdev-lookup-avx512-gather.c file because it's part of the
libopenvswitchavx512.la library. It doesn't need to be enabled at a
function level.
Remove both of these
No instructions from the AVX512DQ ISA are used anywhere in OVS. Remove
this unnecessary CFLAG.
Signed-off-by: Cian Ferriter
---
v4:
* Add this commit to the series.
---
lib/automake.mk | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/automake.mk b/lib/automake.mk
index
GCC 5 gave an incompatible pointer type warning for pkt_blocks when it's
passed to _mm512_mask_i64gather_epi64().
Follow the same pattern used for tbl_blocks where the 'const uint64_t *'
is cast to a 'const void *' when passed in to avx512_blocks_gather().
Fixes: 47a2a8f4138e
Support for more AVX512 ISA was added in various compiler releases. For
example in GCC, increasing AVX512 ISA support was added in GCC 4.9, 5
and then 7. Depending on the GCC version, none, some or all of the
AVX512 code in OVS can be built. This patchset adds support for the
"some" case, where
Fixes: 250ceddcc2d0 ("dpif-netdev/mfex: Add AVX512 based optimized miniflow
extract")
Fixes: aa85a25095ae ("dpif-netdev/mfex: Add more AVX512 traffic profiles")
Signed-off-by: Cian Ferriter
Acked-by: Sunil Pai G
---
v4:
* Added Sunil's Fixes and Acked-by tags.
---
On 28 Apr 2022, at 16:55, Ilya Maximets wrote:
> On 4/28/22 15:44, Eelco Chaudron wrote:
>> Hi All,
>>
>> I just got the following feedback from the robot, but it does not look like
>> any of the code this patchset is touching:
>>
>> ==17733==ERROR: AddressSanitizer: heap-use-after-free on
On 12 Apr 2022, at 11:09, Peng He wrote:
> David Marchand 于2022年4月12日周二 16:40写道：
>
>> On Thu, Apr 7, 2022 at 4:13 AM Peng He wrote:
>>>
>>> I understand there is no need to introduce a rcu api,
>>> but at least put these codes into a separate function ? :-)
>>
>> No strong opinion.
>>
>>
Hello Kumar,
On Tue, Apr 12, 2022 at 4:13 PM Kumar Amber wrote:
>
> For packets which don't already have a hash calculated,
> miniflow_hash_5tuple() calculates the hash of a packet
> using the previously built miniflow.
>
> This commit adds IPv4 profile specific hashing which
> uses fixed
Bleep bloop. Greetings Ales Musil, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 85 characters long (recommended limit is 79)
#20 FILE:
From: wenxu
A packet go through the encap openflow(set_field tun_id/src/dst)
The tunnel wc bits will be set. But it should be clear if the
original packet is non-tunnel. It is not necessary for datapath
wc the tunnel info for match(like the similar logic for vlan).
Signed-off-by: wenxu
---
Signed-off-by: Ales Musil
---
.ci/ovn-kubernetes/Dockerfile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci/ovn-kubernetes/Dockerfile b/.ci/ovn-kubernetes/Dockerfile
index bd220b1e2..19662889e 100644
--- a/.ci/ovn-kubernetes/Dockerfile
+++ b/.ci/ovn-kubernetes/Dockerfile
Bleep bloop. Greetings wenxu, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: corrupt patch at line 10
error: could not build fake ancestor
hint: Use 'git am
During the revalidation/upcall, mirror could be removed. Instead of crash
the process, we can simply skip the deleted mirror.
The issue had been triggered multiple times by ovs-tcpdump in my test.
Fixes: ec7ceaed4f3e ("ofproto-dpif: Modularize mirror code.")
Signed-off-by: lic121
Tested-by:
When Recving tcp stream form LOCAL port, and flows have a dp_hash group, linux call
skb_set_hash_from_sk to set skb->hash and skb->l4_hash, ovs use skb->hash to
select group bucket.
When tcp retransmission occurs，linux call sk_rethink_txhash to rehash skb->hash
of retransmission packet, so the
From: wenxu
A packet go through the encap openflow(set_field tun_id/src/dst)
The tunnel wc bits will be set. But it should be clear if the
original packet is non-tunnel. It is not necessary for datapath
wc the tunnel info for match(like the similar logic for vlan).
Signed-off-by: wenxu
---
31 matches
Mail list logo
