Re: [ovs-dev] [PATCH RFC ovn] nb: Remove possibility of disabling logical datapath groups.

2022-06-07 Thread Han Zhou
On Tue, Jun 7, 2022 at 8:20 AM Dumitru Ceara wrote: > > In large scale scenarios this option hugely reduces the size of the > Southbound database positively affecting end to end performance. In > such scenarios there's no real reason to ever disable datapath groups. > > In lower scale scenarios

[ovs-dev] [PATCH net-next] net: rename reference+tracking helpers

2022-06-07 Thread Jakub Kicinski
Netdev reference helpers have a dev_ prefix for historic reasons. Renaming the old helpers would be too much churn but we can rename the tracking ones which are relatively recent and should be the default for new code. Rename: dev_hold_track()-> netdev_hold() dev_put_track() ->

Re: [ovs-dev] [PATCH v4 2/2] Ensure pid belongs to ovsdb-server in ovn-ctl

2022-06-07 Thread 0-day Robot
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH v4 1/2] Handle re-used pids in pidfile_is_running

2022-06-07 Thread 0-day Robot
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (utilities/ovn-ctl). error: could not build fake

[ovs-dev] [PATCH v4 2/2] Ensure pid belongs to ovsdb-server in ovn-ctl

2022-06-07 Thread Terry Wilson
When checking if ovsdb-server is running, ensure that the binary we are going to run matches the one actually running with the the pid that was in our pidfile. Signed-off-by: Terry Wilson --- utilities/ovn-ctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovn-ctl

[ovs-dev] [PATCH v4 1/2] Handle re-used pids in pidfile_is_running

2022-06-07 Thread Terry Wilson
Since pids can be re-used, it is necessary to check that the process that is running with a pid matches the one that we expect. This adds the ability to optionally pass a 'binary' argument to pidfile_is_running, and if it is passed to match the binary against /proc/$pid/exe. Signed-off-by: Terry

Re: [ovs-dev] [PATCH v13 ovn] Implement RARP activation strategy for ports

2022-06-07 Thread Ihar Hrachyshka
On Mon, Jun 6, 2022 at 3:48 AM Han Zhou wrote: > > > > On Fri, Jun 3, 2022 at 1:20 PM Ihar Hrachyshka wrote: > > > > When options:activation-strategy is set to "rarp" for LSP, when used in > > combination with multiple chassis names listed in > > options:requested-chassis, additional chassis

[ovs-dev] [PATCH ovn v14] Implement RARP activation strategy for ports

2022-06-07 Thread Ihar Hrachyshka
When options:activation-strategy is set to "rarp" for LSP, when used in combination with multiple chassis names listed in options:requested-chassis, additional chassis will install special flows that would block all ingress and egress traffic for the port until a special activation event happens.

Re: [ovs-dev] [ovs-discuss] Commit 355fef6f2 seems to break connectivity in my setup

2022-06-07 Thread Frode Nordahl
On Tue, Jun 7, 2022 at 12:16 AM Ilya Maximets wrote: > > On 5/31/22 23:48, Ilya Maximets wrote: > > On 5/31/22 21:15, Frode Nordahl wrote: > >> On Mon, May 30, 2022 at 5:25 PM Frode Nordahl > > > > >> I've pushed the first part of the fix here: > >>

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix internal CT state for non-recirc traffic.

2022-06-07 Thread Frode Nordahl
On Tue, Jun 7, 2022 at 10:52 PM Ilya Maximets wrote: > > On 5/30/22 21:07, Frode Nordahl wrote: > > In some circumstances a flow may get its ct_state set without > > conscious intervention by the OVS user space code. > > > > Commit 355fef6f2ccbc optimizes out uneccessary ct_clear actions > >

Re: [ovs-dev] [PATCH v3 2/2] Ensure pid belongs to ovsdb-server in ovn-ctl

2022-06-07 Thread 0-day Robot
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. Patch skipped due to previous failure. Please check this out. If you feel there has been an error,

Re: [ovs-dev] [PATCH v3 1/2] Handle re-used pids in pidfile_is_running

2022-06-07 Thread 0-day Robot
Bleep bloop. Greetings Terry Wilson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (utilities/ovn-ctl). error: could not build fake

[ovs-dev] [PATCH v3 1/2] Handle re-used pids in pidfile_is_running

2022-06-07 Thread Terry Wilson
Since pids can be re-used, it is necessary to check that the process that is running with a pid matches the one that we expect. This adds the ability to optionally pass a 'binary' argument to pidfile_is_running, and if it is passed to match the binary against /proc/$pid/exe. Signed-off-by: Terry

[ovs-dev] [PATCH v3 2/2] Ensure pid belongs to ovsdb-server in ovn-ctl

2022-06-07 Thread Terry Wilson
When checking if ovsdb-server is running, ensure that the binary we are going to run matches the one actually running with the the pid that was in our pidfile. Signed-off-by: Terry Wilson --- utilities/ovn-ctl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovn-ctl

Re: [ovs-dev] [PATCH 3/3] netdev-offload-dpdk: use flow transfer proxy mechanism

2022-06-07 Thread Ivan Malov
Hi Eli, On Wed, 1 Jun 2022, Eli Britstein wrote: - Missing proper handling of the testpmd syntax logging. It changes the used port according to "transfer", but the log still uses netdev_dpdk_get_port_id(). Thanks for noticing. I will see to it in the next version. - The usage of the

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix internal CT state for non-recirc traffic.

2022-06-07 Thread Ilya Maximets
On 5/30/22 21:07, Frode Nordahl wrote: > In some circumstances a flow may get its ct_state set without > conscious intervention by the OVS user space code. > > Commit 355fef6f2ccbc optimizes out uneccessary ct_clear actions > based on an internal struct xlate_ctx->conntracked state flag. > >

Re: [ovs-dev] [PATCH v2] classifier: adjust segment boundary to execute prerequisite processing

2022-06-07 Thread Ilya Maximets
On 5/24/22 23:35, Aaron Conole wrote: > During flow processing, the flow wildcards are checked as a series of > stages, and these stages are intended to carry dependencies in a single > direction. But when the neighbor discovery processing, for example, was > executed there is an incorrect

Re: [ovs-dev] [PATCH] ovs-tcpdump: Fix error when stopping ovs-tcpdump.

2022-06-07 Thread Ilya Maximets
On 6/3/22 17:51, Mike Pattrick wrote: > On Fri, May 20, 2022 at 5:55 AM Han Ding wrote: >> >> >> Sometimes we need to dump packets on more than two interfaces in a bridge >> at the same time. Then when we stop dumping in order, ovs-tcpdump print >> traceback and fail to delete mirror interface

Re: [ovs-dev] [PATCH v3 1/2] conntrack: remove the IP iterations in nat_get_unique_l4

2022-06-07 Thread Ilya Maximets
On 5/5/22 16:00, we...@chinatelecom.cn wrote: > From: wenxu > > Removing the IP iterations, and just picking the IP address > with the hash base on the least-used src-ip/dst-ip/proto triple. > > Signed-off-by: wenxu > Acked-by: Paolo Valerio > --- Thanks, wenxu and Paolo! I applied both

Re: [ovs-dev] [PATCH 1/3] netdev-dpdk: negotiate delivery of per-packet Rx metadata

2022-06-07 Thread Ivan Malov
Hi Eli, Thanks for reviewing the series. On Wed, 1 Jun 2022, Eli Britstein wrote: "TUNNEL_ID" is a bad name, but that's how dpdk called it. There was a discussion about having this knowledge in OVS so we can avoid calling rte_flow_get_restore_info(). How else it is used? As far as I know,

[ovs-dev] [PATCH RFC ovn] nb: Remove possibility of disabling logical datapath groups.

2022-06-07 Thread Dumitru Ceara
In large scale scenarios this option hugely reduces the size of the Southbound database positively affecting end to end performance. In such scenarios there's no real reason to ever disable datapath groups. In lower scale scenarios any potential overhead due to logical datapath groups is, very

Re: [ovs-dev] [PATCH 1/1] packets: Re-calculate IPv6 checksum only for last frags upon modify.

2022-06-07 Thread Salem Sol via dev
> -Original Message- > From: Ilya Maximets > Sent: Tuesday, June 7, 2022 1:14 PM > To: Salem Sol ; d...@openvswitch.org > Cc: Eli Britstein ; Michael Pattrick ; > i.maxim...@ovn.org > Subject: Re: [ovs-dev] [PATCH 1/1] packets: Re-calculate IPv6 checksum only > for last frags upon modify.

[ovs-dev] [PATCH v3 1/1] packets: Re-calculate IPv6 checksum only for first frag upon modify.

2022-06-07 Thread Salem Sol via dev
In case of modifying an IPv6 packet src/dst address the L4 checksum should be recalculated only for the first frag. Currently it's done for all frags, leading to incorrect reassembled packet checksum. Fix it by adding a new flag to recalculate the checksum only for last frag. Fixes: bc7a5acdff08

Re: [ovs-dev] [PATCH v3 ovn] northd: add the capability to inherit logical routers lbs on logical switches

2022-06-07 Thread Numan Siddique
On Mon, Jun 6, 2022 at 6:44 PM Lorenzo Bianconi wrote: > > Add the capability to automatically deploy a load-balancer on each > logical-switch connected to a logical router where the load-balancer > has been installed by the CMS. This patch allow to overcome the > distributed gw router scenario

[ovs-dev] [PATCH v2] dpcls: add unlisted alias for subtable lookup command

2022-06-07 Thread Harry van Haaren
This patch adds the old name "subtable-lookup-prio-get" as an unlisted command, to restore a consistency between OVS releases for testing scripts. Fixes 738c76a503f4 ("dpcls: Change info-get function to fetch dpcls usage stats.") Suggested-by: Eelco Chaudron Suggested-by: Ilya Maximets

Re: [ovs-dev] [PATCH 1/1] packets: Re-calculate IPv6 checksum only for last frags upon modify.

2022-06-07 Thread Ilya Maximets
On 6/6/22 12:12, Salem Sol via dev wrote: > In case of modifying an IPv6 packet src/dst address the checksum should be > recalculated only for the last frag. Currently it's done for all frags, > leading to incorrect reassembled packet checksum. > Fix it by adding a new flag to recalculate the

Re: [ovs-dev] User space connection tracking benchmarks

2022-06-07 Thread Robin Jarry
Paolo Valerio, Jun 05, 2022 at 19:37: > Just a note that may be useful. > After some tests, I noticed that establishing e.g. two TCP connections, > and leaving the first one idle after 3whs, once the second connection > expires (after moving to TIME_WAIT as a result of termination), the > second

[ovs-dev] [PATCH v3] ovs-ofctl:'--bundle' option can be used with OpenFlow 1.3

2022-06-07 Thread yangchang
>From the commit 25070e045e, bundle option can be used with OpenFlow 1.3 Signed-off-by: yangchang Acked-by: Mike Pattrick --- Notes: v2: modify some compilation errors v3: modify message, change 'has' to 'can' utilities/ovs-ofctl.8.in | 10 +- 1 file