Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Ilya Maximets
On 6/22/22 21:27, Eric Dumazet wrote: > On Wed, Jun 22, 2022 at 9:04 PM Eric Dumazet wrote: >> >> On Wed, Jun 22, 2022 at 8:19 PM Ilya Maximets wrote: >>> >>> On 6/22/22 19:03, Eric Dumazet wrote: On Wed, Jun 22, 2022 at 6:47 PM Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 6:39

Re: [ovs-dev] [PATCH v2] netdev-linux: do not touch LAG slaves if master is not attached to ovs.

2022-06-22 Thread Marcelo Ricardo Leitner
On Wed, Jun 22, 2022 at 11:10:17AM +0800, Tao Liu wrote: > On Tue, Jun 21, 2022 at 06:49:42AM -0700, Marcelo Ricardo Leitner wrote: > > Hi, > > > > On Tue, Jun 21, 2022 at 02:10:39PM +0800, Tao Liu wrote: > > > Bond master netdev may be created without a classification type, due > > > to routing

Re: [ovs-dev] [PATCH ovn v4 1/1] IPsec: Add option to force NAT-T encapsulation

2022-06-22 Thread Numan Siddique
On Mon, Jun 6, 2022 at 12:54 PM Andreas Karis wrote: > > Provide options to enforce NAT-T UDP encapsulation. Options are > encapsulation=true for libreswan and forceencaps=true for strongswan. > This may be required in environments where firewalls drop ESP > traffic but where NAT-T detection

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 9:04 PM Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 8:19 PM Ilya Maximets wrote: > > > > On 6/22/22 19:03, Eric Dumazet wrote: > > > On Wed, Jun 22, 2022 at 6:47 PM Eric Dumazet wrote: > > >> > > >> On Wed, Jun 22, 2022 at 6:39 PM Eric Dumazet wrote: > > >>> > > >>>

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 8:19 PM Ilya Maximets wrote: > > On 6/22/22 19:03, Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 6:47 PM Eric Dumazet wrote: > >> > >> On Wed, Jun 22, 2022 at 6:39 PM Eric Dumazet wrote: > >>> > >>> On Wed, Jun 22, 2022 at 6:29 PM Eric Dumazet wrote: > > On

Re: [ovs-dev] [OVN v3] OVN - Add Support for Remote Port Mirroring

2022-06-22 Thread 0-day Robot
Bleep bloop. Greetings Abhiram R N, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #1522 FILE: utilities/ovn-nbctl.c:275:

[ovs-dev] [OVN v3] OVN - Add Support for Remote Port Mirroring

2022-06-22 Thread Abhiram R N
Added changes in ovn-nbctl, ovn-sbctl, northd and in ovn-controller. While Mirror creation just creates the mirror, the lsp-attach-mirror triggers the sequence to create Mirror in OVS DB on compute node. OVS already supports Port Mirroring. Note: This is targeted to mirror to destinations

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Ilya Maximets
On 6/22/22 19:03, Eric Dumazet wrote: > On Wed, Jun 22, 2022 at 6:47 PM Eric Dumazet wrote: >> >> On Wed, Jun 22, 2022 at 6:39 PM Eric Dumazet wrote: >>> >>> On Wed, Jun 22, 2022 at 6:29 PM Eric Dumazet wrote: On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: > > On

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Ilya Maximets
On 6/22/22 16:35, Eric Dumazet wrote: > On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: >> >> On 6/22/22 13:43, Eric Dumazet wrote: >>> On Wed, Jun 22, 2022 at 1:32 PM Ilya Maximets wrote: On 6/22/22 12:36, Eric Dumazet wrote: > On Wed, Jun 22, 2022 at 12:28 PM Florian

Re: [ovs-dev] [PATCH ovn v2 1/6] Add chassis column to MAC_Binding table

2022-06-22 Thread Dan Williams
On Fri, 2022-06-17 at 11:07 +0200, Ales Musil wrote: > The new chassis column in MAC_Binding should > act as an "owner" order of that particular row. > This can be utilized by MAC binding aging mechanism, > where only single is responsible for that particular > record. In order to keep it

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 6:47 PM Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 6:39 PM Eric Dumazet wrote: > > > > On Wed, Jun 22, 2022 at 6:29 PM Eric Dumazet wrote: > > > > > > On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: > > > > > > > > On 6/22/22 13:43, Eric Dumazet wrote: > > > >

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 6:39 PM Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 6:29 PM Eric Dumazet wrote: > > > > On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: > > > > > > On 6/22/22 13:43, Eric Dumazet wrote: > > > > > > > > I tested the patch below and it seems to fix the issue seen

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 6:29 PM Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: > > > > On 6/22/22 13:43, Eric Dumazet wrote: > > > > > I tested the patch below and it seems to fix the issue seen > > with OVS testsuite. Though it's not obvious for me why this > >

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: > > On 6/22/22 13:43, Eric Dumazet wrote: > > I tested the patch below and it seems to fix the issue seen > with OVS testsuite. Though it's not obvious for me why this > happens. Can you explain a bit more? Anyway, I am not sure we can call

Re: [ovs-dev] [PATCH v7 00/11] Actions Infrastructure + Optimizations

2022-06-22 Thread Finn, Emma
Hi Eelco, I've investigated the issue and resolved the failing unit tests. Diff's are provided below or if it's convenient I can send as patchset instead. Fix for 05/11: odp-execute: Add command to switch action implementation. diff --git a/tests/pmd.at b/tests/pmd.at index

[ovs-dev] [PATCH ovn] tests: fixed flaky test localnet connectivity with multiple requested-chassis

2022-06-22 Thread Xavier Simonart
The test was failing randomly (on highly loaded systems) mainly because the MAC address of the migrator port in the main switch was migrating at unexpected times. In addition, a few undefined variables were fixed, and sleep was removed / replaced by ovs_wait actions. Signed-off-by: Xavier

Re: [ovs-dev] [PATCH v5 5/5] acinclude: Add seperate checks for AVX512 ISA.

2022-06-22 Thread Ferriter, Cian
> -Original Message- > From: Ilya Maximets > Sent: Tuesday 31 May 2022 12:00 > To: Ferriter, Cian ; Pai G, Sunil > ; ovs- > d...@openvswitch.org > Cc: i.maxim...@ovn.org > Subject: Re: [ovs-dev] [PATCH v5 5/5] acinclude: Add seperate checks for > AVX512 ISA. > > On 5/18/22 10:51,

[ovs-dev] [RFC 1/1] configure: Run AVX512 binutils check only for GCC.

2022-06-22 Thread Cian Ferriter
The bug being checked for by OVS_CHECK_BINUTILS_AVX512 is only present when the compiler is GCC. Add a check for GCC before the other checks. Also only create the directory and variables for the assembler check if gcc and x86_64 are present. Signed-off-by: Cian Ferriter --- m4/openvswitch.m4 |

[ovs-dev] [RFC 0/1] Enable AVX512 build on Windows.

2022-06-22 Thread Cian Ferriter
I have been testing a fix for the OVS_CHECK_BINUTILS_AVX512 build time check that happens in m4/openvswitch.m4 to allow Windows to build AVX512 code. The binuntils check can be skipped when GCC isn't present. I have been testing this fix using the OVS Appveyor CI. The BINUTILS check no longer

Re: [ovs-dev] [PATCH ovn v2 0/6] MAC binding aging mechanism

2022-06-22 Thread Han Zhou
On Wed, Jun 22, 2022 at 12:51 AM Ales Musil wrote: > > > > On Wed, Jun 22, 2022 at 9:21 AM Han Zhou wrote: >> >> >> >> On Fri, Jun 17, 2022 at 2:08 AM Ales Musil wrote: >> > >> > Add MAC binding aging mechanism, that >> > should take care of stale MAC bindings. >> > >> > The mechanism works on

[ovs-dev] [PATCH ovn] tests: fixed multiple flaky tests (not waiting for patch flows)

2022-06-22 Thread Xavier Simonart
The following test cases were sometimes failing, (mainly) for the same reason i.e. packet lost as being sent before patch ports were installed. - 2 HVs, 2 LS, switching between multiple localnet ports with same tags - VLAN transparency, passthru=true, ARP responder disabled - send gratuitous arp

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 4:26 PM Ilya Maximets wrote: > > On 6/22/22 13:43, Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 1:32 PM Ilya Maximets wrote: > >> > >> On 6/22/22 12:36, Eric Dumazet wrote: > >>> On Wed, Jun 22, 2022 at 12:28 PM Florian Westphal wrote: > > Eric Dumazet

[ovs-dev] [PATCH v5] bond: Improve bond and lacp visibility

2022-06-22 Thread Mike Pattrick
Add additional logging for debug and info level with a focus on code related to bond members coming up, go down, and changing. Several existing log messages were modified to handle sub 1kB log messages with more grace. Instead of reporting 0kB of traffic load shifting from one member to another,

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Ilya Maximets
On 6/22/22 13:43, Eric Dumazet wrote: > On Wed, Jun 22, 2022 at 1:32 PM Ilya Maximets wrote: >> >> On 6/22/22 12:36, Eric Dumazet wrote: >>> On Wed, Jun 22, 2022 at 12:28 PM Florian Westphal wrote: Eric Dumazet wrote: > On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: >>

Re: [ovs-dev] [PATCH v4] bond: Improve bond and lacp visibility

2022-06-22 Thread Adrian Moreno
On 6/21/22 18:53, Mike Pattrick wrote: Add additional logging for debug and info level with a focus on code related to bond members coming up, go down, and changing. Several existing log messages were modified to handle sub 1kB log messages with more grace. Instead of reporting 0kB of traffic

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 1:32 PM Ilya Maximets wrote: > > On 6/22/22 12:36, Eric Dumazet wrote: > > On Wed, Jun 22, 2022 at 12:28 PM Florian Westphal wrote: > >> > >> Eric Dumazet wrote: > >>> On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: > > Open vSwitch system test suite is

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Ilya Maximets
On 6/22/22 12:36, Eric Dumazet wrote: > On Wed, Jun 22, 2022 at 12:28 PM Florian Westphal wrote: >> >> Eric Dumazet wrote: >>> On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: Open vSwitch system test suite is broken due to inability to load/unload netfilter modules. kworker

Re: [ovs-dev] [PATCH v4] dpif-netdev: Allow cross-NUMA polling on selected ports

2022-06-22 Thread lic121
On Wed, Jun 22, 2022 at 09:32:29AM +, Anurag Agarwal wrote: > Thanks for your feedback. Please find my comments inline. > > Regards, > Anurag > > > -Original Message- > > From: lic...@chinatelecom.cn > > Sent: Friday, June 17, 2022 2:29 PM > > To: Anurag Agarwal > > Cc:

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 12:28 PM Florian Westphal wrote: > > Eric Dumazet wrote: > > On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: > > > > > > Open vSwitch system test suite is broken due to inability to > > > load/unload netfilter modules. kworker thread is getting trapped > > > in the

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Florian Westphal
Eric Dumazet wrote: > On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: > > > > Open vSwitch system test suite is broken due to inability to > > load/unload netfilter modules. kworker thread is getting trapped > > in the infinite loop while running a net cleanup inside the > >

[ovs-dev] [PATCH ovn v3] controller: avoid recomputes triggered by SBDB Port_Binding updates.

2022-06-22 Thread Xavier Simonart
When VIF ports are claimed on a chassis, SBDB Port_Binding table is updated. If the SBDB IDL is still is read-only ("in transaction") when such a update is required, the update is not possible and recompute is triggered through I+P failure. This situation can happen: - after updating

Re: [ovs-dev] [PATCH ovn v2] controller: avoid recomputes triggered by SBDB Port_Binding updates.

2022-06-22 Thread Xavier Simonart
Hi Dumitru Thanks for the review and the comments. I'll send an update (v3) taking into account your comments. See comments/feedback embedded below Thanks Xavier On Thu, Jun 16, 2022 at 12:55 PM Dumitru Ceara wrote: > On 6/15/22 11:46, Xavier Simonart wrote: > > When VIF ports are claimed on

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Wed, Jun 22, 2022 at 12:02 PM Eric Dumazet wrote: > > On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: > > > > Open vSwitch system test suite is broken due to inability to > > load/unload netfilter modules. kworker thread is getting trapped > > in the infinite loop while running a net

Re: [ovs-dev] [PATCH net] net: ensure all external references are released in deferred skbuffs

2022-06-22 Thread Eric Dumazet via dev
On Sun, Jun 19, 2022 at 2:39 AM Ilya Maximets wrote: > > Open vSwitch system test suite is broken due to inability to > load/unload netfilter modules. kworker thread is getting trapped > in the infinite loop while running a net cleanup inside the > nf_conntrack_cleanup_net_list, because deferred

Re: [ovs-dev] [PATCH v4] dpif-netdev: Allow cross-NUMA polling on selected ports

2022-06-22 Thread Anurag Agarwal via dev
Thanks for your feedback. Please find my comments inline. Regards, Anurag > -Original Message- > From: lic...@chinatelecom.cn > Sent: Friday, June 17, 2022 2:29 PM > To: Anurag Agarwal > Cc: ovs-dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v4] dpif-netdev: Allow cross-NUMA

Re: [ovs-dev] [PATCH ovn v2 0/6] MAC binding aging mechanism

2022-06-22 Thread Ales Musil
On Wed, Jun 22, 2022 at 9:21 AM Han Zhou wrote: > > > On Fri, Jun 17, 2022 at 2:08 AM Ales Musil wrote: > > > > Add MAC binding aging mechanism, that > > should take care of stale MAC bindings. > > > > The mechanism works on "ownership" of the > > MAC binding row. The chassis that creates > >

Re: [ovs-dev] [PATCH ovn v2 0/6] MAC binding aging mechanism

2022-06-22 Thread Han Zhou
On Fri, Jun 17, 2022 at 2:08 AM Ales Musil wrote: > > Add MAC binding aging mechanism, that > should take care of stale MAC bindings. > > The mechanism works on "ownership" of the > MAC binding row. The chassis that creates > the row is then checking if the "idle_age" > of the flow is over the