On Mon, Jul 25, 2022 at 6:01 PM Ihar Hrachyshka wrote:
> On Mon, Jul 25, 2022 at 1:25 AM Ales Musil wrote:
> >
> > Hi Ihar,
> >
> >
> > On Fri, Jul 22, 2022 at 8:37 PM Ihar Hrachyshka
> wrote:
> >>
> >> On Wed, Jul 20, 2022 at 4:50 AM Ales Musil wrote:
> >> >
> >> > Reported-at:
On Mon, Jul 25, 2022 at 5:53 PM Ihar Hrachyshka wrote:
> On Mon, Jul 25, 2022 at 1:23 AM Ales Musil wrote:
>
>> Hi Ihar,
>>
>>
>> On Fri, Jul 22, 2022 at 8:38 PM Ihar Hrachyshka
>> wrote:
>>
>>> On Wed, Jul 20, 2022 at 4:50 AM Ales Musil wrote:
>>> >
>>> > Add MAC binding aging mechanism,
I forgot to add the v2 comment, so for clarification just the commit title
has changed between the versions.
Thanks,
Ales
On Mon, Jul 25, 2022 at 5:19 PM Ales Musil wrote:
> The ip6_hdr is aligned to 4 bytes, but the pointer
> from dp_packet_l3 is aligned to 2 bytes. Use
>
Hi Mark,
thank you for the review.
On Mon, Jul 25, 2022 at 6:09 PM Mark Michelson wrote:
> Hi Ales, I have one small finding below, but other than that, it looks
> good. I don't think you need to roll a new version to address this issue,
> so
>
> Acked-by: Mark Michelson
>
> On 7/25/22
Bleep bloop. Greetings david hanks (王传雷), I am a robot and I have tried out
your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author david hanks (王传雷) needs to sign off.
WARNING: Unexpected sign-offs from
Ok, I’ve already resubmit the commit message of patch , please check the
format, thanks a lot！
发件人: Numan Siddique [mailto:num...@ovn.org]
发送时间: 2022年7月22日 0:37
收件人: david hanks (王传雷)
抄送: ovs dev
主题: Re: [ovs-dev] [PATCH ovn] pinctrl: fix monitor state when using udp(icmp)
to check
Also remove the reset mechanism when DB is reconnected, because at DB
reconnection the data in IDL would not reset.
Signed-off-by: Han Zhou
---
controller/ovn-controller.c | 1 -
controller/vif-plug.c | 20 ++--
2 files changed, 6 insertions(+), 15 deletions(-)
diff
When ovn-controller is restarted, it may need multiple iterations of
main loop before completely download all related data from SB DB,
especially when ovn-monitor-all=false, so after restart, before it sees
the related localnet ports from SB DB, it treats the related patch
ports on the chassis as
In some cases we need to know if ovn-controller started long enough and
has enough iterations of input processing, primarily to ensure it has
downloaded and handled a complete initial view of the SB DB (and of
course the local OVS DB), so that it won't delete things too early by
mistake based on
When handling port_binding changes, it is possible that new
local_datapaths are added, and the fields of the local_datapath, such as
localnet_port, external_ports, etc. need to be updated for the newly
added local_datapaths.
This problem doesn't happen in most cases because the changes that
When ovn-controller is restarted, it may need multiple iterations of
main loop before completely download all related data from SB DB,
especially when ovn-monitor-all=false, so after restart, before it sees
the related localnet ports from SB DB, it treats the related patch
ports on the chassis as
For all patches in the series,
Acked-by: Mark Michelson
There are still references to internal concepts in the docs
(OFTABLE_ECMP_NH_MAC, OFTABLE_ECMP_NH, and REGBIT_KNOWN_ECMP_NH, for
example), but I think those can be fixed by whoever merges the series.
On 7/15/22 07:35, Lorenzo Bianconi
Acked-by: Mark Michelson
On 7/12/22 17:57, Ihar Hrachyshka wrote:
When multiple chassis are fighting for the same port (requested-chassis
is not set, e.g. for gateway ports), they may produce an unreasonable
number of chassis field updates in a very short time frame (hundreds of
updates in
Acked-by: Mark Michelson
On 7/12/22 17:57, Ihar Hrachyshka wrote:
This function will later be used to handle port binding updates for
postponed (throttled) bindings.
Signed-off-by: Ihar Hrachyshka
---
controller/binding.c | 250 ++-
1 file changed,
On 7/25/22 10:58, Eelco Chaudron wrote:
>
>
> On 25 Jul 2022, at 10:19, David Marchand wrote:
>
>> On my Fedora 36, the test with enabled offloads often fails with one of
>> those ping failing.
>> By chance (?), the previous tcpdumps are not stopped and I can see for
>> example:
>>
On 7/25/22 11:23, Paolo Valerio wrote:
> Hello Eli,
>
> Eli Britstein via dev writes:
>
>> A connection is established if we see packets from both directions.
>> The cited commit [1] fixed the issue of sending twice in one direction,
>> but still an issue if more than that.
>> Fix it.
>>
>
>
On 7/22/22 21:15, David Marchand wrote:
> On Fri, Jul 22, 2022 at 6:30 PM Ilya Maximets wrote:
>>
>> Ping process remains in the system after the test. Using a proper
>> macro that will correctly register it for stopping at cleanup stage.
>>
>> Fixes: 134e6831acca ("system-traffic: Check frozen
Considering I acked the first version,
Acked-by: Mark Michelson
On 7/25/22 06:49, Ales Musil wrote:
If one of the permutations failed, others running after
that would also fail because of leftover dhcpd running.
Make sure that dhcpd is killed if it's still running
since previous test.
Hi Ales, I have one small finding below, but other than that, it looks
good. I don't think you need to roll a new version to address this issue, so
Acked-by: Mark Michelson
On 7/25/22 06:49, Ales Musil wrote:
The local_datapaths are populated by iterating through
all available port bindings
On Mon, Jul 25, 2022 at 1:25 AM Ales Musil wrote:
>
> Hi Ihar,
>
>
> On Fri, Jul 22, 2022 at 8:37 PM Ihar Hrachyshka wrote:
>>
>> On Wed, Jul 20, 2022 at 4:50 AM Ales Musil wrote:
>> >
>> > Reported-at: https://bugzilla.redhat.com/2084668
>> > Signed-off-by: Ales Musil
>> > ---
>> > v3: Rebase
On Mon, Jul 25, 2022 at 1:23 AM Ales Musil wrote:
> Hi Ihar,
>
>
> On Fri, Jul 22, 2022 at 8:38 PM Ihar Hrachyshka
> wrote:
>
>> On Wed, Jul 20, 2022 at 4:50 AM Ales Musil wrote:
>> >
>> > Add MAC binding aging mechanism, that utilizes
>> > the timestamp column of MAC_Binding table.
>> > When
The ip6_hdr is aligned to 4 bytes, but the pointer
from dp_packet_l3 is aligned to 2 bytes. Use
ovs_16aligned_ip6_hdr instead to get 2 bytes alignment.
Signed-off-by: Ales Musil
---
controller/pinctrl.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git
The ip6_hdr is aligned to 4 bytes, but the pointer
from dp_packet_l3 is aligned to 2 bytes. Use
ovs_16aligned_ip6_hdr instead to get 2 bytes alignment.
Signed-off-by: Ales Musil
---
controller/pinctrl.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git
On Mon, Jul 25, 2022 at 04:01:07PM +0200, Ilya Maximets wrote:
> On 7/25/22 14:45, Vlad Buslov via dev wrote:
> > Dear maintainers,
> >
> > Could you please check out this patch?
> >
> > When kernel 5.19 is released with all the added validation code, it will
> > make OvS matchall police offload
The ip6_hdr is aligned to 4 bytes, but the pointer
from dp_packet_l3 is aligned to 2 bytes. Use
ovs_16aligned_ip6_hdr instead to get 2 bytes alignment.
Signed-off-by: Ales Musil
---
lib/packets.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/packets.c
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#64 FILE: python/ovs/_json.c:176:
On 7/25/22 14:45, Vlad Buslov via dev wrote:
> Dear maintainers,
>
> Could you please check out this patch?
>
> When kernel 5.19 is released with all the added validation code, it will
> make OvS matchall police offload completely broken on mlx5 without the
> fix.
Simon, Eelco, could you,
Bleep bloop. Greetings Andreas Karis, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed
Dear maintainers,
Could you please check out this patch?
When kernel 5.19 is released with all the added validation code, it will
make OvS matchall police offload completely broken on mlx5 without the
fix.
Thanks,
Vlad
On Wed 06 Jul 2022 at 08:53, Vlad Buslov wrote:
> Referenced commit
Current version of debian/rules simply passes the libopenvswitch.a
as a command line argument via LDFLAGS, but that doesn't actually
lead to this library being statically linked into python extension,
which is a shared library. Instead, the build "succeeds", but the
resulted extension is not
Bleep bloop. Greetings Andreas Karis, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Unexpected sign-offs from developers who are not authors or co-authors
or
In order to correctly link with static libopenvswitch.a library,
users should also provide required cflags and all the libraries
libopenvswitch.a was actually built with and depends on. Otherwise,
it's not possible to link correctly.
Fixes: 671f93fe42d3 ("python: Allow building json C extension
Currently, openvswitch-devel installs following header tree:
/usr/include
/openflow/*.h
/openvswitch
/*.h
/openflow/*.h
/openvswitch/*.h
/sparse/*.h
SSL, BPF, lcap-ng and other libraries are in use by a static library,
so they has to be linked while building applications with that static
library, i.e. 'pkg-config --libs --static libopenvswitch' must return
-lssl, -lcap-ng, etc. in the output for a successful build.
For dynamic library
Ilya Maximets (4):
rhel: Stop installing internal headers.
libopenvswitch.pc: Add missing libs for a static build.
python: Add ability to pass extra libs and cflags for C extension.
debian: Fix incorrect linkage of the python C extension.
.ci/linux-build.sh | 7 +++
Hi Mark,
thank you for the review, I have posted v2 after suggestion from Ilya
to use NETNS_DAEMONIZE instead of the pidof + kill check.
Thanks,
Ales
On Fri, Jul 22, 2022 at 8:29 PM Mark Michelson wrote:
> Hi Ales, thanks for the change. It looks good to me.
>
> Acked-by: Mark Michelson
>
>
The local_datapaths are populated by iterating through
all available port bindings or new ones added during I-C.
The port bindings are not ordered, it might happen that
the order between engine runs are different. This can cause
the prefix delegation shash to be with NULL local_datapath.
Even in
If one of the permutations failed, others running after
that would also fail because of leftover dhcpd running.
Make sure that dhcpd is killed if it's still running
since previous test.
Reported-at: https://bugzilla.redhat.com/2108726
Signed-off-by: Ales Musil
---
tests/system-ovn.at | 7
Ales Musil (2):
system-tests: Reduce flakiness of IPv6 prefix delegation
controller: Fix IPv6 prefix delegation
controller/binding.c| 35 ---
controller/ovn-controller.c | 8
controller/ovn-controller.h | 6 --
controller/pinctrl.c
Hello Eli,
Eli Britstein via dev writes:
> A connection is established if we see packets from both directions.
> The cited commit [1] fixed the issue of sending twice in one direction,
> but still an issue if more than that.
> Fix it.
>
The patch LGTM.
Just a very minor nit: I guess "[1]"
On 25 Jul 2022, at 10:19, David Marchand wrote:
> On my Fedora 36, the test with enabled offloads often fails with one of
> those ping failing.
> By chance (?), the previous tcpdumps are not stopped and I can see for
> example:
> 10:04:02.534492 IP 10.1.1.1 > 10.1.1.2: ICMP echo request, id
On 25 Jul 2022, at 10:25, David Marchand wrote:
> Hi Eelco,
>
> On Wed, Jul 13, 2022 at 10:22 AM Eelco Chaudron wrote:
> [snip]
>> +AT_SETUP([offloads - check_pkt_len action - offloads enabled])
>> +OVS_TRAFFIC_VSWITCHD_START([], [], [-- set Open_vSwitch .
>> other_config:hw-offload=true])
Hi Eelco,
On Wed, Jul 13, 2022 at 10:22 AM Eelco Chaudron wrote:
[snip]
> +AT_SETUP([offloads - check_pkt_len action - offloads enabled])
> +OVS_TRAFFIC_VSWITCHD_START([], [], [-- set Open_vSwitch .
> other_config:hw-offload=true])
> +
> +ADD_NAMESPACES(at_ns1, at_ns2, at_ns3, at_ns4)
> +
>
On my Fedora 36, the test with enabled offloads often fails with one of
those ping failing.
By chance (?), the previous tcpdumps are not stopped and I can see for
example:
10:04:02.534492 IP 10.1.1.1 > 10.1.1.2: ICMP echo request, id 62835, seq 2,
length 72
10:04:02.639443 IP 10.1.1.1 > 10.1.1.2:
44 matches
Mail list logo
