Re: [ovs-dev] [PATCH ovn] extend-table: Fix table ID double allocation after OVS restart.

2022-07-28 Thread Han Zhou
On Thu, Jul 28, 2022 at 1:34 PM Numan Siddique wrote: > > On Wed, Jul 27, 2022 at 6:18 PM Han Zhou wrote: > > > > There were problems observed occasionally after OVS restart, the > > OVS flow bundle installation from ovn-controller was failed because of > > "GROUP_EXISTS" error, which end up

Re: [ovs-dev] [PATCH ovn] extend-table: Fix table ID double allocation after OVS restart.

2022-07-28 Thread Numan Siddique
On Wed, Jul 27, 2022 at 6:18 PM Han Zhou wrote: > > There were problems observed occasionally after OVS restart, the > OVS flow bundle installation from ovn-controller was failed because of > "GROUP_EXISTS" error, which end up with missing flows/groups/meters > in OVS until ovn-controller is

[ovs-dev] [PATCH] system-offloads-traffic: Fix waiting for netcat indefinitely.

2022-07-28 Thread Ilya Maximets
$NC_EOF_OPT should be used to avoid some netcat implementations to wait indefinitely. This fixes the check-offloads testsuite hanging in Ubuntu 22.04. Fixes: 5660b89a309d ("dpif-netlink: Offloading meter to tc police action") Signed-off-by: Ilya Maximets --- tests/system-offloads-traffic.at |

[ovs-dev] [PATCH net-next 2/2] openvswitch: Fix overreporting of drops in dropwatch

2022-07-28 Thread Mike Pattrick
Currently queue_userspace_packet will call kfree_skb for all frames, whether or not an error occurred. This can result in a single dropped frame being reported as multiple drops in dropwatch. This patch will consume the skbs instead. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2109957

[ovs-dev] [PATCH net-next 1/2] openvswitch: Fix double reporting of drops in dropwatch

2022-07-28 Thread Mike Pattrick
Frames sent to userspace can be reported as dropped in ovs_dp_process_packet, however, if they are dropped in the netlink code then netlink_attachskb will report the same frame as dropped. This patch checks for error codes which indicate that the frame has already been freed. Bugzilla:

[ovs-dev] [PATCH] dpif-netlink: Fix incorrect bit shift in compat mode.

2022-07-28 Thread Ilya Maximets
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior in lib/dpif-netlink.c:1077:40: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' #0 0x73fc31 in dpif_netlink_port_add_compat lib/dpif-netlink.c:1077:40 #1 0x73fc31 in dpif_netlink_port_add

[ovs-dev] [PATCH] test-ovsdb: Fix false-positive leaks from LeakSanitizer.

2022-07-28 Thread Ilya Maximets
LeakSanitizer for some reason reports these json objects as leaked, even though we do have references to them at the moment ovs_fatal() called from check_ovsdb_error(). Previously it complained only with -O2, but with newer versions of clang/llvm it started complaining even with -O1. For

Re: [ovs-dev] [PATCH 4/4] debian: Fix incorrect linkage of the python C extension.

2022-07-28 Thread David Marchand
On Thu, Jul 28, 2022 at 5:00 PM Frode Nordahl wrote: > > > This is only a suggestion to avoid adding too many -Wl options as they > > > stack up if you are not careful. > > > > I see. Though, it is probably not a big concern for this particular > > use-case. > > > > I can replace '-Wl,-Bstatic

Re: [ovs-dev] [PATCH 4/4] debian: Fix incorrect linkage of the python C extension.

2022-07-28 Thread Frode Nordahl
On Thu, Jul 28, 2022 at 3:17 PM Ilya Maximets wrote: > > On 7/27/22 23:02, David Marchand wrote: > > On Mon, Jul 25, 2022 at 2:29 PM Ilya Maximets wrote: > >> > >> Current version of debian/rules simply passes the libopenvswitch.a > >> as a command line argument via LDFLAGS, but that doesn't

Re: [ovs-dev] [PATCH ovn] controller: physical: fix regression for container ports

2022-07-28 Thread Ihar Hrachyshka
Oops, sorry about that. This should be backported to 22.06. Acked-By: Ihar Hrachyshka wrote: > > After commit 'd07e5f99d ("Introduce match_outport_dp_and_port_keys > in physical.c")' it is not longer possible to ping a parent port from > container one. > > Reported-at:

[ovs-dev] [PATCH ovn] controller: physical: fix regression for container ports

2022-07-28 Thread Lorenzo Bianconi
After commit 'd07e5f99d ("Introduce match_outport_dp_and_port_keys in physical.c")' it is not longer possible to ping a parent port from container one. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2105901 Fixes: d07e5f99d ("Introduce match_outport_dp_and_port_keys in physical.c")

Re: [ovs-dev] [PATCH 4/4] debian: Fix incorrect linkage of the python C extension.

2022-07-28 Thread Ilya Maximets
On 7/27/22 23:02, David Marchand wrote: > On Mon, Jul 25, 2022 at 2:29 PM Ilya Maximets wrote: >> >> Current version of debian/rules simply passes the libopenvswitch.a >> as a command line argument via LDFLAGS, but that doesn't actually >> lead to this library being statically linked into python

Re: [ovs-dev] [PATCH v2] revalidator: add a USDT probe after evaluation when flows are deleted.

2022-07-28 Thread Eelco Chaudron
On 28 Jul 2022, at 13:57, Eelco Chaudron wrote: > On 27 Jul 2022, at 16:48, Kevin Sprague wrote: > >> During normal operations, it is useful to understand when a particular flow >> gets removed from the system. This can be useful when debugging performance >> issues tied to ofproto flow

Re: [ovs-dev] [PATCH v2] revalidator: add a USDT probe after evaluation when flows are deleted.

2022-07-28 Thread Eelco Chaudron
On 27 Jul 2022, at 16:48, Kevin Sprague wrote: > During normal operations, it is useful to understand when a particular flow > gets removed from the system. This can be useful when debugging performance > issues tied to ofproto flow changes, trying to determine deployed traffic > patterns, or

[ovs-dev] [PATCH RFC] ofproto-dpif-xlate: Optimize the clone for patch ports

2022-07-28 Thread Ales Musil
When the packet was traveling through patch port boundary OvS would check if any of the actions is reversible, if not it would clone the packet. However, the check was only at the first level of the second bridge. That caused some issues when the packet had gone through more actions, some of them

Re: [ovs-dev] [PATCH ovn] tests: enable and fix vif-provider test scenario

2022-07-28 Thread Frode Nordahl
Hello, Ihar, On Thu, Jul 28, 2022 at 1:28 AM Ihar Hrachyshka wrote: > > Signed-off-by: Ihar Hrachyshka > --- > controller/test-vif-plug.c | 2 +- > tests/ovn-vif-plug.at | 2 +- > tests/testsuite.at | 1 + > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git