On Fri, Jul 29, 2022 at 10:38:36PM +0200, Ilya Maximets wrote:
> OVS kernel datapath and TC are parsing IPv6 fragments differently.
> For IPv6 later fragments, according to the original design [1], OVS
> always sets nw_proto=44 (IPPROTO_FRAMENT), regardless of the type
> of the L4 protocol.
>
>
On 8/4/22 19:51, Ilya Maximets wrote:
> On 7/13/22 22:47, Mike Pattrick wrote:
>> On Tue, Jun 7, 2022 at 11:00 AM Salem Sol wrote:
>>>
>>> In case of modifying an IPv6 packet src/dst address the L4 checksum should
>>> be
>>> recalculated only for the first frag. Currently it's done for all
On Thu, Aug 4, 2022 at 10:12 AM Mark Michelson wrote:
>
> This is a backport of Han Zhou's patch series "Avoid unnecessary
> deletion & recreation during restart" for branch-21.12. The original
> series can be found at
> https://patchwork.ozlabs.org/project/ovn/list/?series=311230 .
>
> Apologies
On 8/4/22 17:56, Dumitru Ceara wrote:
> On 8/4/22 17:51, Ilya Maximets wrote:
>> On 8/4/22 17:47, Dumitru Ceara wrote:
>>> On 8/4/22 16:33, Mike Pattrick wrote:
On Thu, Aug 4, 2022 at 9:56 AM Ilya Maximets wrote:
>
> With just released flake8 5.0 we're getting a bunch of E275 errors:
On 7/29/22 16:30, Ilya Maximets wrote:
> Emerged from Roi's suggestion while discussing tunnel offload fixes.
> It will probably make sense to backport these down to 2.17 as it is
> debug-only and 2.17 will be our new LTS.
>
> Ilya Maximets (3):
> dynamic-string: Add function for a sparse hex
On 8/3/22 16:58, Mike Pattrick wrote:
> On Thu, Jul 28, 2022 at 2:27 PM Ilya Maximets wrote:
>>
>> $NC_EOF_OPT should be used to avoid some netcat implementations
>> to wait indefinitely.
>>
>> This fixes the check-offloads testsuite hanging in Ubuntu 22.04.
>>
>> Fixes: 5660b89a309d
On 8/3/22 17:28, Mike Pattrick wrote:
> On Thu, Jul 28, 2022 at 11:43 AM Ilya Maximets wrote:
>>
>> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior in
>> lib/dpif-netlink.c:1077:40: runtime error:
>>left shift of 1 by 31 places cannot be represented in type 'int'
>>
>> #0
On 8/2/22 09:20, Pai G, Sunil wrote:
>
>
>> -Original Message-
>> From: dev On Behalf Of Ilya Maximets
>> Sent: Tuesday, July 26, 2022 7:00 PM
>> To: ovs-dev@openvswitch.org
>> Cc: Ilya Maximets
>> Subject: [ovs-dev] [PATCH] checkpatch: Add check for a Fixes tag.
>>
>> A new check for
On 7/11/22 14:24, Mike Pattrick wrote:
> On Wed, Jun 29, 2022 at 11:31 AM Timothy Redaelli
> wrote:
>>
>> On Python 3.12, distutils will be removed and it's currently (3.10+)
>> deprecated (see PEP 632).
>>
>> Since the suggested and simplest replacement is setuptools, this commit
>> replaces
On 7/13/22 22:47, Mike Pattrick wrote:
> On Tue, Jun 7, 2022 at 11:00 AM Salem Sol wrote:
>>
>> In case of modifying an IPv6 packet src/dst address the L4 checksum should be
>> recalculated only for the first frag. Currently it's done for all frags,
>> leading to incorrect reassembled packet
Referenced commit changed policer action type from TC_ACT_UNSPEC (continue)
to TC_ACT_PIPE. However, since neither TC hardware offload layer nor mlx5
driver at the time validated action type and always assumed 'continue', the
breakage wasn't caught until later validation code was added. The change
On Thu 04 Aug 2022 at 19:12, Ilya Maximets wrote:
> On 8/4/22 19:09, 0-day Robot wrote:
>> Bleep bloop. Greetings Vlad Buslov, I am a robot and I have tried out your
>> patch.
>> Thanks for your contribution.
>>
>> I encountered some error that I wasn't expecting. See the details below.
>>
On 8/4/22 19:09, 0-day Robot wrote:
> Bleep bloop. Greetings Vlad Buslov, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> git-am:
> error: Failed to merge in the changes.
FYI,
Bleep bloop. Greetings Vlad Buslov, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
git-am:
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch' to see the failed
On Thu 04 Aug 2022 at 10:24, Ilya Maximets wrote:
> On 8/4/22 09:52, Simon Horman wrote:
>> On Thu, Aug 04, 2022 at 09:33:15AM +0200, Ilya Maximets wrote:
>>> On 8/4/22 09:18, Simon Horman wrote:
On Wed, Aug 03, 2022 at 12:32:46PM +0200, Vlad Buslov wrote:
> Referenced commit changed
Referenced commit changed policer action type from TC_ACT_UNSPEC (continue)
to TC_ACT_PIPE. However, since neither TC hardware offload layer nor mlx5
driver at the time validated action type and always assumed 'continue', the
breakage wasn't caught until later validation code was added. The change
On Thu 04 Aug 2022 at 08:52, Simon Horman wrote:
> On Thu, Aug 04, 2022 at 09:33:15AM +0200, Ilya Maximets wrote:
>> On 8/4/22 09:18, Simon Horman wrote:
>> > On Wed, Aug 03, 2022 at 12:32:46PM +0200, Vlad Buslov wrote:
>> >> Referenced commit changed policer action type from TC_ACT_UNSPEC
>> >>
Transaction history is used to construct database updates for clients.
But if the row didn't change it will never be used for monitor updates,
because ovsdb_monitor_changes_classify() will always return
OVSDB_CHANGES_NO_EFFECT. So, ovsdb_monitor_history_change_cb()
will never add it to the
Some of the CTA_PROTOINFO_TCP nested attributes are not always
included in the received message, but the parsing logic considers them
as required, failing in case they are not found.
This was observed while monitoring some connections by reading the
events sent by conntrack:
./ovstest
This patch avoids to show flags_orig/flags_reply key if they have no value.
E.g., the following:
NEW tcp,orig=([...]),reply=([...]),id=1800618864,
status=CONFIRMED|SRC_NAT_DONE|DST_NAT_DONE,timeout=120,
protoinfo=(state_orig=SYN_SENT,state_reply=SYN_SENT,wscale_orig=7,
On 8/4/22 17:51, Ilya Maximets wrote:
> On 8/4/22 17:47, Dumitru Ceara wrote:
>> On 8/4/22 16:33, Mike Pattrick wrote:
>>> On Thu, Aug 4, 2022 at 9:56 AM Ilya Maximets wrote:
With just released flake8 5.0 we're getting a bunch of E275 errors:
On 8/4/22 17:47, Dumitru Ceara wrote:
> On 8/4/22 16:33, Mike Pattrick wrote:
>> On Thu, Aug 4, 2022 at 9:56 AM Ilya Maximets wrote:
>>>
>>> With just released flake8 5.0 we're getting a bunch of E275 errors:
>>>
>>> utilities/bugtool/ovs-bugtool.in:959:23: E275 missing whitespace after
>>>
Bleep bloop. Greetings Mohammad Heib, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 90 characters long (recommended limit is 79)
#38 FILE:
On 8/4/22 16:33, Mike Pattrick wrote:
> On Thu, Aug 4, 2022 at 9:56 AM Ilya Maximets wrote:
>>
>> With just released flake8 5.0 we're getting a bunch of E275 errors:
>>
>> utilities/bugtool/ovs-bugtool.in:959:23: E275 missing whitespace after
>> keyword
>> tests/test-ovsdb.py:623:11: E275
On Thu, Aug 4, 2022 at 5:23 PM Numan Siddique wrote:
> On Tue, Jul 26, 2022 at 10:13 AM Ihar Hrachyshka
> wrote:
> >
> > Acked-By: Ihar Hrachyshka
> >
> > On Wed, Jul 20, 2022 at 4:50 AM Ales Musil wrote:
> > >
>
> Hi Ales,
>
> I couldn't get a chance to thoroughly review the entire series,
Ovn unit tests supported matrix size has been increased
after adding support to monitor_all and northd_parallelization
options recently, and that increased the execution time of the ovn-ci jobs.
This patch aims to reduce the execution time of those jobs by splitting
them into smaller jobs that
On Tue, Jul 26, 2022 at 10:13 AM Ihar Hrachyshka wrote:
>
> Acked-By: Ihar Hrachyshka
>
> On Wed, Jul 20, 2022 at 4:50 AM Ales Musil wrote:
> >
Hi Ales,
I couldn't get a chance to thoroughly review the entire series, but
overall it looks fine to me.
I've a few comments in this patch.
> >
On 8/4/22 16:57, Paul Blakey wrote:
> On 29/07/2022 17:53, Ilya Maximets wrote:
>> @@ -1431,6 +1434,19 @@ parse_put_flow_set_action(struct tc_flower *flower,
>> struct tc_action *action,
>> action->encap.ttl = nl_attr_get_u8(tun_attr);
>> }
>> break;
>> +
On 8/2/22 09:13, Roi Dayan wrote:
>
>
> On 2022-08-02 9:53 AM, Roi Dayan wrote:
>>
>>
>> On 2022-08-01 9:31 AM, Roi Dayan wrote:
>>>
>>>
>>> On 2022-07-29 5:53 PM, Ilya Maximets wrote:
Current offloading code supports only limited number of tunnel keys
and silently ignores everything
Bleep bloop. Greetings Igor Zhukov, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 88 characters long (recommended limit is 79)
#25 FILE:
From: Igor Zhukov
Docs:
https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value
Test: https://github.com/fsb4000/ovn/actions and https://imgur.com/a/mUBQWSO
Signed-off-by: Igor Zhukov
---
.github/workflows/ovn-kubernetes.yml | 2 +-
On 29/07/2022 17:53, Ilya Maximets wrote:
Current offloading code supports only limited number of tunnel keys
and silently ignores everything it doesn't understand. This is
causing, for example, offloaded ERSPAN tunnels to not work, because
flow is offloaded, but ERSPAN options are not
On Thu, Aug 4, 2022 at 9:56 AM Ilya Maximets wrote:
>
> With just released flake8 5.0 we're getting a bunch of E275 errors:
>
> utilities/bugtool/ovs-bugtool.in:959:23: E275 missing whitespace after
> keyword
> tests/test-ovsdb.py:623:11: E275 missing whitespace after keyword
>
On 7/25/22 23:34, Han Zhou wrote:
> In some cases we need to know if ovn-controller started long enough and
> has enough iterations of input processing, primarily to ensure it has
> downloaded and handled a complete initial view of the SB DB (and of
> course the local OVS DB), so that it won't
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#136 FILE: controller/ofctrl.c:2433:
* XXX:
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line is 84 characters long (recommended limit is 79)
#321 FILE:
From: Han Zhou
Now in ofctrl we wait in S_WAIT_BEFORE_CLEAR for the initial flow
compute to complete before clearing the existing flows, to reduce the
data plane down time during ovn-controller restart. However, the flow
installation takes a long time when the flow number is huge, which still
This is a backport of Han Zhou's patch series "Avoid unnecessary
deletion & recreation during restart" for branch-21.12. The original
series can be found at
https://patchwork.ozlabs.org/project/ovn/list/?series=311230 .
Apologies if I did not handle the sign-offs on the commits correctly.
I'm not
From: Han Zhou
Move the group changes to the same bundle as the OF flow changes.
The steps in ofctrl_put were:
- add groups
- add meters
- bundle
- change flows
- delete groups
- delete meters
Now it becomes:
- add meters
- bundle
- add groups
- change flows
-
From: Han Zhou
Whenever OpenFlow connection between ovn-controller and OVS is
connected/reconnected, typically during ovn-controller/OVS
restart/upgrade, ovn-controller would:
1. clears all the existing flows after the initial hand-shaking
2. compute the new flows
3. install the new flows to
From: Han Zhou
In theory it is possible that ovn-controller tried to install flows by
calling ofctrl_put() while ofctrl is at a state other than
S_UPDATE_FLOWS thus not able to install. So, when entering S_UPDATE_FLOWS,
we should immediately wakeup the main loop so that any pending flows
can be
On 7/25/22 23:34, Han Zhou wrote:
> Also remove the reset mechanism when DB is reconnected, because at DB
> reconnection the data in IDL would not reset.
>
> Signed-off-by: Han Zhou
> ---
Hi Han,
I noticed that with this change the "VIF plugging" test starts failing
when running with
With just released flake8 5.0 we're getting a bunch of E275 errors:
utilities/bugtool/ovs-bugtool.in:959:23: E275 missing whitespace after keyword
tests/test-ovsdb.py:623:11: E275 missing whitespace after keyword
python/setup.py:105:8: E275 missing whitespace after keyword
Yes, some tests needed. I will try to test later today.
> On 8/4/22 15:19, Igor Zhukov wrote:
>
>> Hi. Yes, I confirm.
>> I'm sorry :(
>
> No problem. :)
>
>> Probably removing
>> `|| github.ref`
>> will help.
>
> Makes sense to me to limit it to PRs. But what would be the generated
> group
On 8/4/22 15:19, Igor Zhukov wrote:
> Hi. Yes, I confirm.
> I'm sorry :(
No problem. :)
>
> Probably removing
> `|| github.ref`
> will help.
Makes sense to me to limit it to PRs. But what would be the generated
group name for a plain push event (no PR)?
Thanks,
Dumitru
>
>> Hi guys,
>>
Hi. Yes, I confirm.
I'm sorry :(
Probably removing
`|| github.ref`
will help.
> Hi guys,
>
> It seems to me that this is breaking a bit the patchwork + ovsrobot
> workflow. For example, for a series of patches the robot will push them
> one by one, to trigger test runs with each individual
Hi guys,
It seems to me that this is breaking a bit the patchwork + ovsrobot
workflow. For example, for a series of patches the robot will push them
one by one, to trigger test runs with each individual patch.
Taking a random patch series as example:
On Thu, Aug 04, 2022 at 09:59:24AM +0100, Simon Horman wrote:
> On Thu, Aug 04, 2022 at 10:24:52AM +0200, Ilya Maximets wrote:
> > On 8/4/22 09:52, Simon Horman wrote:
> > > On Thu, Aug 04, 2022 at 09:33:15AM +0200, Ilya Maximets wrote:
> > >> On 8/4/22 09:18, Simon Horman wrote:
...
> > >>> I'd
On Thu, Aug 04, 2022 at 10:24:52AM +0200, Ilya Maximets wrote:
> On 8/4/22 09:52, Simon Horman wrote:
> > On Thu, Aug 04, 2022 at 09:33:15AM +0200, Ilya Maximets wrote:
> >> On 8/4/22 09:18, Simon Horman wrote:
> >>> On Wed, Aug 03, 2022 at 12:32:46PM +0200, Vlad Buslov wrote:
> Referenced
On 8/4/22 09:52, Simon Horman wrote:
> On Thu, Aug 04, 2022 at 09:33:15AM +0200, Ilya Maximets wrote:
>> On 8/4/22 09:18, Simon Horman wrote:
>>> On Wed, Aug 03, 2022 at 12:32:46PM +0200, Vlad Buslov wrote:
Referenced commit changed policer action type from TC_ACT_UNSPEC (continue)
to
On 8/3/22 16:43, Ilya Maximets wrote:
> Some CMSes, like ovn-kubernetes, tend to create load balancers attached
> to a big number of logical switches or routers. For each of these
> load balancers northd creates a record in Load_Balancer table of the
> Southbound database with all the logical
On Thu, Aug 04, 2022 at 09:33:15AM +0200, Ilya Maximets wrote:
> On 8/4/22 09:18, Simon Horman wrote:
> > On Wed, Aug 03, 2022 at 12:32:46PM +0200, Vlad Buslov wrote:
> >> Referenced commit changed policer action type from TC_ACT_UNSPEC (continue)
> >> to TC_ACT_PIPE. However, since neither TC
On 8/4/22 09:18, Simon Horman wrote:
> On Wed, Aug 03, 2022 at 12:32:46PM +0200, Vlad Buslov wrote:
>> Referenced commit changed policer action type from TC_ACT_UNSPEC (continue)
>> to TC_ACT_PIPE. However, since neither TC hardware offload layer nor mlx5
>> driver at the time validated action
On Wed, Aug 03, 2022 at 12:32:46PM +0200, Vlad Buslov wrote:
> Referenced commit changed policer action type from TC_ACT_UNSPEC (continue)
> to TC_ACT_PIPE. However, since neither TC hardware offload layer nor mlx5
> driver at the time validated action type and always assumed 'continue', the
>
54 matches
Mail list logo
