Re: [ovs-dev] [PATCH ovn v2 4/4] vif-plug.c: Use daemon_started_recently() to replace the prime counter.

2022-08-05 Thread Han Zhou
On Thu, Aug 4, 2022 at 7:09 AM Dumitru Ceara wrote: > > On 7/25/22 23:34, Han Zhou wrote: > > Also remove the reset mechanism when DB is reconnected, because at DB > > reconnection the data in IDL would not reset. > > > > Signed-off-by: Han Zhou > > --- > > Hi Han, > > I noticed that with this

Re: [ovs-dev] [PATCH ovn v2 2/4] ovn-controller: Add a generic way to check if the daemon started recently.

2022-08-05 Thread Han Zhou
On Thu, Aug 4, 2022 at 7:24 AM Dumitru Ceara wrote: > > On 7/25/22 23:34, Han Zhou wrote: > > In some cases we need to know if ovn-controller started long enough and > > has enough iterations of input processing, primarily to ensure it has > > downloaded and handled a complete initial view of the

Re: [ovs-dev] [PATCH] system-traffic: Fix IPv4 fragmentation test sequence for check-kernel.

2022-08-05 Thread Paolo Valerio
Ilya Maximets writes: > On 8/5/22 17:08, Paolo Valerio wrote: >> The following test sequence: >> >> conntrack - IPv4 fragmentation incomplete reassembled packet >> conntrack - IPv4 fragmentation with fragments specified >> >> leads to a systematic failure of the latter test on the kernel >>

Re: [ovs-dev] [PATCH ovn] ofctrl.c: mff_ovn_geneve should be available at state WAIT_BEFORE_CLEAR.

2022-08-05 Thread Han Zhou
On Tue, Aug 2, 2022 at 9:06 AM Numan Siddique wrote: > > On Wed, Jul 27, 2022 at 9:06 PM Han Zhou wrote: > > > > When introducing the feature ovn-ofctrl-wait-before-clear, a new state > > WAIT_BEFORE_CLEAR is added before CLEAR_FLOWS. In the WAIT_BEFORE_CLEAR > > state the mff_ovn_geneve is

Re: [ovs-dev] [PATCH ovn 4/5] debian: Update debian package source.

2022-08-05 Thread Frode Nordahl
Ilya and Numan, I preemptively added your names to the commit message because the patch contains your work as detailed in the commit message. I hope this is ok. On Fri, Aug 5, 2022 at 10:35 PM Frode Nordahl wrote: > > Update debian package source from Debian and Ubuntu. > >

[ovs-dev] [PATCH ovn 4/5] debian: Update debian package source.

2022-08-05 Thread Frode Nordahl
Update debian package source from Debian and Ubuntu. debian/ovn-common.logrotate comes from the RHEL packaging in this tree, and author is credited below. The debian/automake.mk tricks to generate the copyright file while building came from the work on the debian packaging in openvswitch and

[ovs-dev] [PATCH ovn 2/5] debian: Archive the debian package source.

2022-08-05 Thread Frode Nordahl
In an effort to sync the Debian, Ubuntu and upstream package soruces we archive the now historic one from the upstream archive. A updated packaging source will follow in subsequent patches in this series. Signed-off-by: Frode Nordahl --- debian/.gitignore | 14 -

[ovs-dev] [PATCH ovn 5/5] ci: Add jobb for building the deb package.

2022-08-05 Thread Frode Nordahl
Signed-off-by: Frode Nordahl --- .ci/linux-build.sh | 33 + .ci/linux-prepare.sh | 6 + .github/workflows/test.yml | 49 ++ 3 files changed, 88 insertions(+) diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index

[ovs-dev] [PATCH ovn 1/5] treewide: Fix various typos in manual pages

2022-08-05 Thread Frode Nordahl
As reported by Debian lintian. Signed-off-by: Frode Nordahl --- controller/ovn-controller.8.xml | 2 +- northd/ovn-northd.8.xml | 24 ovn-architecture.7.xml | 6 +++--- ovn-ic-sb.xml | 2 +- ovn-nb.xml | 4 ++--

[ovs-dev] [PATCH ovn 3/5] checkpatch Ignore line length and leading whitespace for debian/*.

2022-08-05 Thread Frode Nordahl
Similar to https://github.com/openvswitch/ovs/commit/9f4f2bb7dc Signed-off-by: Frode Nordahl --- utilities/checkpatch.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index ffb873111..8a4a84398 100755 ---

[ovs-dev] [PATCH ovn 0/5] debian: Update debian package source.

2022-08-05 Thread Frode Nordahl
Debian and Ubuntu is merging their package sources and we have also been helping out refreshing the debian package source in the openvswitch tree [0]. This series follows on the back of that work and provides a similar update to the OVN tree. 0:

Re: [ovs-dev] OVN 22.09 Soft Freeze 5 August, 2022

2022-08-05 Thread Mark Michelson
On 8/5/22 12:36, Dumitru Ceara wrote: On 7/29/22 17:50, Mark Michelson wrote: Hi everyone, Hi Mark, Soft freeze for the OVN 22.09.0 release is in one week, 5 August. As a reminder, soft freeze is the deadline for new feature patches to be posted for review. The features do not need to be

Re: [ovs-dev] [PATCH] system-traffic: Fix incorrect neigh entry in ipv6 header modification test.

2022-08-05 Thread Ilya Maximets
On 8/5/22 20:32, Aaron Conole wrote: > Ilya Maximets writes: > >> The permanent neighbor entry for fc00::1 is added into a wrong >> namespace, so in order to reply to a ping from at_ns1, the >> address of fc00::1 has to be discovered. > > This is strange - how did it end up in wrong namespace?

Re: [ovs-dev] [PATCH] system-traffic: Fix incorrect neigh entry in ipv6 header modification test.

2022-08-05 Thread Aaron Conole
Ilya Maximets writes: > The permanent neighbor entry for fc00::1 is added into a wrong > namespace, so in order to reply to a ping from at_ns1, the > address of fc00::1 has to be discovered. This is strange - how did it end up in wrong namespace? Is it a race with the veth setup? I guess we

Re: [ovs-dev] [PATCH] system-traffic: Don't run IPv6 header modification test on kernels < 5.19.

2022-08-05 Thread Aaron Conole
Ilya Maximets writes: > OVS kernel module is incorrectly updating checksums while changing > IPv6 fields of later fragments that doesn't really have L4 headers. > > This makes the 'ping6 between two ports with header modify' test > fail on most of the distribution kernels. > > The issue got

Re: [ovs-dev] [PATCH] system-traffic: Fix incorrect neigh entry in ipv6 header modification test.

2022-08-05 Thread Salem Sol via dev
LGTM! Thanks for the catch. > -Original Message- > From: Ilya Maximets > Sent: Friday, 5 August 2022 20:51 > To: ovs-dev@openvswitch.org > Cc: Mike Pattrick ; Salem Sol ; > Aaron Conole ; Michael Phelan > ; Ilya Maximets > Subject: [PATCH] system-traffic: Fix incorrect neigh entry in

[ovs-dev] [PATCH] system-traffic: Fix incorrect neigh entry in ipv6 header modification test.

2022-08-05 Thread Ilya Maximets
The permanent neighbor entry for fc00::1 is added into a wrong namespace, so in order to reply to a ping from at_ns1, the address of fc00::1 has to be discovered. Interfaces are attached to OVS and we're removing flows that can forward ND requests after initial setup. In case ND request wasn't

Re: [ovs-dev] OVN 22.09 Soft Freeze 5 August, 2022

2022-08-05 Thread Dumitru Ceara
On 7/29/22 17:50, Mark Michelson wrote: > Hi everyone, > Hi Mark, > Soft freeze for the OVN 22.09.0 release is in one week, 5 August. As a > reminder, soft freeze is the deadline for new feature patches to be > posted for review. The features do not need to be merged by this date, > they just

[ovs-dev] [RFC PATCH ovn 5/5] controller: Add Template_Var <- LB references.

2022-08-05 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- controller/lflow.c | 72 ++- controller/lflow.h |1 + controller/ovn-controller.c | 21 + lib/lb.c|7 ++-- lib/lb.h|3 +- 5 files

[ovs-dev] [RFC PATCH ovn 4/5] lb: Support using templates.

2022-08-05 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- TODO: - No support for LB health check if the LB is templated. - No support for VIP ARP responder if the LB is templated. - No support for routed VIPs if the LB is templated. - No 'ovn-nbctl lb-*' commands support for templated LBs. Signed-off-by: Dumitru Ceara

[ovs-dev] [RFC PATCH ovn 3/5] controller: Make resource references more generic.

2022-08-05 Thread Dumitru Ceara
Signed-off-by: Dumitru Ceara --- TODO: - Rename resource references to make it clear that they're not only about lflows. --- controller/lflow.c | 108 +++ controller/lflow.h | 95 --

[ovs-dev] [RFC PATCH ovn 2/5] controller: Add support for templated actions and matches.

2022-08-05 Thread Dumitru Ceara
Expand SB.Template_Var records in two stages: 1. first expand them to local values in match/action strings 2. then reparse the expanded strings For the case when a lflow references a Template_Var also track references (similar to the ones maintained for multicast groups, address sets,

[ovs-dev] [RFC PATCH ovn 1/5] Add NB and SB Template_Var tables.

2022-08-05 Thread Dumitru Ceara
Propagate the contents of the NB table to the Southbound. Signed-off-by: Dumitru Ceara --- TODO: - Document the new Template_Var tables. --- lib/automake.mk |2 ++ lib/template-var.c | 41 + lib/template-var.h | 28

[ovs-dev] [RFC PATCH ovn 0/5] Add OVN component templates.

2022-08-05 Thread Dumitru Ceara
Sometimes network components are compute node-specific. Sometimes such components are replicated, almost identically, for multiple nodes in the cluster. One such example is the case of Kubernetes NodePort services which translate (in the ovn-kubernetes case) to Load_Balancer objects being

Re: [ovs-dev] [ovs-build] |fail| pw1664033 system-traffic: Don't run IPv6 header modification test on kernels < 5.19.

2022-08-05 Thread Ilya Maximets
On 8/5/22 17:17, Phelan, Michael wrote: >> -Original Message- >> From: Ilya Maximets >> Sent: Friday 5 August 2022 16:00 >> To: Phelan, Michael >> Cc: i.maxim...@ovn.org; Stokes, Ian ; Aaron Conole >> ; ovs-dev >> Subject: Re: [ovs-build] |fail| pw1664033 [ovs-dev] system-traffic: Don't

Re: [ovs-dev] [ovs-build] |fail| pw1664033 system-traffic: Don't run IPv6 header modification test on kernels < 5.19.

2022-08-05 Thread Phelan, Michael
> -Original Message- > From: Ilya Maximets > Sent: Friday 5 August 2022 16:00 > To: Phelan, Michael > Cc: i.maxim...@ovn.org; Stokes, Ian ; Aaron Conole > ; ovs-dev > Subject: Re: [ovs-build] |fail| pw1664033 [ovs-dev] system-traffic: Don't run > IPv6 header modification test on kernels

Re: [ovs-dev] [PATCH] system-traffic: Fix IPv4 fragmentation test sequence for check-kernel.

2022-08-05 Thread Ilya Maximets
On 8/5/22 17:08, Paolo Valerio wrote: > The following test sequence: > > conntrack - IPv4 fragmentation incomplete reassembled packet > conntrack - IPv4 fragmentation with fragments specified > > leads to a systematic failure of the latter test on the kernel > datapath (linux). Multiple

[ovs-dev] [PATCH] system-traffic: Fix IPv4 fragmentation test sequence for check-kernel.

2022-08-05 Thread Paolo Valerio
The following test sequence: conntrack - IPv4 fragmentation incomplete reassembled packet conntrack - IPv4 fragmentation with fragments specified leads to a systematic failure of the latter test on the kernel datapath (linux). Multiple executions of the former may also lead to multiple

Re: [ovs-dev] [ovs-build] |fail| pw1664033 system-traffic: Don't run IPv6 header modification test on kernels < 5.19.

2022-08-05 Thread Ilya Maximets
On 8/5/22 16:29, Phelan, Michael wrote: >> -Original Message- >> From: Ilya Maximets >> Sent: Friday 5 August 2022 15:08 >> To: Phelan, Michael >> Cc: i.maxim...@ovn.org; Stokes, Ian ; Aaron Conole >> ; ovs-dev >> Subject: Re: [ovs-build] |fail| pw1664033 [ovs-dev] system-traffic: Don't

Re: [ovs-dev] [ovs-build] |fail| pw1664033 system-traffic: Don't run IPv6 header modification test on kernels < 5.19.

2022-08-05 Thread Phelan, Michael
> -Original Message- > From: Ilya Maximets > Sent: Friday 5 August 2022 15:08 > To: Phelan, Michael > Cc: i.maxim...@ovn.org; Stokes, Ian ; Aaron Conole > ; ovs-dev > Subject: Re: [ovs-build] |fail| pw1664033 [ovs-dev] system-traffic: Don't run > IPv6 header modification test on kernels

Re: [ovs-dev] [PATCH v2 1/5] netdev-offload-tc: Fix the mask for tunnel metadata length.

2022-08-05 Thread Marcelo Leitner
On Fri, Jul 29, 2022 at 04:53:15PM +0200, Ilya Maximets wrote: > @@ -606,8 +606,9 @@ flower_tun_opt_to_match(struct match *match, struct > tc_flower *flower) > len -= sizeof(struct geneve_opt) + opt->length * 4; > } > > -match->wc.masks.tunnel.metadata.present.len = > -

Re: [ovs-dev] [ovs-build] |fail| pw1664033 system-traffic: Don't run IPv6 header modification test on kernels < 5.19.

2022-08-05 Thread Ilya Maximets
On 8/5/22 15:59, Phelan, Michael wrote: > Hey Ilya, > I've tried recreating the test failure but haven't had any success so I'm not > sure why exactly this test failed on the CI run. I did notice that it also > failed on another CI run with the output here: >

Re: [ovs-dev] [ovs-build] |fail| pw1664033 system-traffic: Don't run IPv6 header modification test on kernels < 5.19.

2022-08-05 Thread Phelan, Michael
Hey Ilya, I've tried recreating the test failure but haven't had any success so I'm not sure why exactly this test failed on the CI run. I did notice that it also failed on another CI run with the output here: https://mail.openvswitch.org/pipermail/ovs-build/2022-August/024240.html. It looks

Re: [ovs-dev] [ovs-build] |fail| pw1664033 system-traffic: Don't run IPv6 header modification test on kernels < 5.19.

2022-08-05 Thread Ilya Maximets
On 8/5/22 14:51, Ilya Maximets wrote: > On 8/5/22 14:44, ovs_jenk...@intel.com wrote: >> Test-Label: intel-ovs-compilation >> Test-Status: fail >> http://patchwork.ozlabs.org/api/patches/1664033/ >> >> AVX-512_compilation: failed >> DPLCS Test: fail >> DPIF Test: success >> MFEX Test: success

Re: [ovs-dev] [PATCH branch-2.17 RESEND] netdev-linux: set correct action for packets that passed policer

2022-08-05 Thread Simon Horman
On Fri, Aug 05, 2022 at 11:57:28AM +0100, Simon Horman wrote: > On Thu, Aug 04, 2022 at 07:40:50PM +0200, Vlad Buslov wrote: > > Referenced commit changed policer action type from TC_ACT_UNSPEC (continue) > > to TC_ACT_PIPE. However, since neither TC hardware offload layer nor mlx5 > > driver at

Re: [ovs-dev] [PATCH v3 1/1] packets: Re-calculate IPv6 checksum only for first frag upon modify.

2022-08-05 Thread Ilya Maximets
On 8/5/22 00:33, Ilya Maximets wrote: > On 8/4/22 19:51, Ilya Maximets wrote: >> On 7/13/22 22:47, Mike Pattrick wrote: >>> On Tue, Jun 7, 2022 at 11:00 AM Salem Sol wrote: In case of modifying an IPv6 packet src/dst address the L4 checksum should be recalculated only for the

Re: [ovs-dev] [PATCH ovn]OVN-CI: ovn unit tests run in parallel jobs.

2022-08-05 Thread Dumitru Ceara
On 8/4/22 17:32, Mohammad Heib wrote: > Ovn unit tests supported matrix size has been increased > after adding support to monitor_all and northd_parallelization > options recently, and that increased the execution time of the ovn-ci jobs. > > This patch aims to reduce the execution time of those

[ovs-dev] [PATCH] system-traffic: Don't run IPv6 header modification test on kernels < 5.19.

2022-08-05 Thread Ilya Maximets
OVS kernel module is incorrectly updating checksums while changing IPv6 fields of later fragments that doesn't really have L4 headers. This makes the 'ping6 between two ports with header modify' test fail on most of the distribution kernels. The issue got indirectly fixed in latest 5.19 with

Re: [ovs-dev] [PATCH v2 4/5] netdev-offload-tc: Fix ignoring unknown tunnel keys.

2022-08-05 Thread Roi Dayan via dev
On 2022-08-04 6:20 PM, Ilya Maximets wrote: On 8/2/22 09:13, Roi Dayan wrote: On 2022-08-02 9:53 AM, Roi Dayan wrote: On 2022-08-01 9:31 AM, Roi Dayan wrote: On 2022-07-29 5:53 PM, Ilya Maximets wrote: Current offloading code supports only limited number of tunnel keys and silently

Re: [ovs-dev] [PATCH branch-2.17 RESEND] netdev-linux: set correct action for packets that passed policer

2022-08-05 Thread Simon Horman
On Thu, Aug 04, 2022 at 07:40:50PM +0200, Vlad Buslov wrote: > Referenced commit changed policer action type from TC_ACT_UNSPEC (continue) > to TC_ACT_PIPE. However, since neither TC hardware offload layer nor mlx5 > driver at the time validated action type and always assumed 'continue', the >

[ovs-dev] [PATCH] bridge: Prevent use-after-free with iface struct

2022-08-05 Thread Ales Musil
Insert the newly created iface into bridge ifaces hmap only when ofp_port is not OFPP_NONE. Reported-by: Dumitru Ceara Signed-off-by: Ales Musil --- vswitchd/bridge.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index

[ovs-dev] ovs-vswitchd: Use-after-free reported by AddressSanitizer.

2022-08-05 Thread Dumitru Ceara
Hi all, While testing some OVN changes I noticed a use after free in ovs-vswitchd code. I didn't really get a chance to look into it but I shared below what AddressSanitizer reported when running the OVN system tests (make check-kernel). For reference, this is with the latest OVS submodule

Re: [ovs-dev] [PATCH ovn] Cancel previous runs in the PR when you push new commits

2022-08-05 Thread Igor Zhukov
Yesterday I created a patch: https://patchwork.ozlabs.org/project/ovn/patch/20220804145543.8294-1-fsb4...@yandex.ru/ I hope it solves all the problems. Maybe I should have written to this thread right away, because you might not see > On 8/4/22 15:19, Igor Zhukov wrote: > >> Hi. Yes, I

Re: [ovs-dev] OVSDB echo requests/replies in a background thread: should we?

2022-08-05 Thread Han Zhou
On Thu, Jun 30, 2022 at 12:55 PM Mark Michelson wrote: > > Hi OVS and OVN devs, > > The OVN team has considered the idea of moving inactivity probes (i.e. > OVSDB echo requests/replies) into a background thread. > > OVN logical networks can be very large, meaning that ovn components such > as