[ovs-dev] [PATCH] utilities/ovs-tcpdump.in: Fix not destroy mirror (Daniel Ding)

If ovs-tcpdump received HUP or TERM signal, mirror and mirror interface should be destroyed. This often happens, when controlling terminal is closed, like ssh session closed, and other users use kill to terminate it. Signed-off-by: Daniel Ding --- utilities/ovs-tcpdump.in | 12 1

Re: [ovs-dev] [PATCH net-next v2 1/3] openvswitch: allow specifying ifindex of new interfaces

On Tue, 23 Aug 2022 16:50:21 +0300 Andrey Zhadchenko wrote: > > Are you 100% sure that all user space making this call initializes > > dp_ifindex to 0? There is no validation in the kernel today that > > the field is not garbage as far as I can tell. > > > > If you are sure, please add the

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't enable conditional monitoring until connected.

On Tue, Aug 23, 2022 at 7:15 AM Han Zhou wrote: > > > > On Tue, Aug 23, 2022 at 6:45 AM Ilya Maximets wrote: > > > > On 8/22/22 19:39, Han Zhou wrote: > > > > > > > > > On Mon, Aug 22, 2022 at 3:33 AM Ilya Maximets mailto:i.maxim...@ovn.org>> wrote: > > >> > > >> On 8/22/22 12:21, Dumitru Ceara

[ovs-dev] [PATCH net] openvswitch: fix memory leak at failed datapath creation

ovs_dp_cmd_new()->ovs_dp_change()->ovs_dp_set_upcall_portids() allocates array via kmalloc. If for some reason new_vport() fails during ovs_dp_cmd_new() dp->upcall_portids must be freed. Add missing kfree. Kmemleak example: unreferenced object 0x88800c382500 (size 64): comm "dump_state",

[ovs-dev] [PATCH ovn] northd: Don't get stuck in the STATE_INIT_HASH_SIZES state.

After removing the possibility of disabling logical datapath groups the above mentioned state should only be relevant when ovn-northd is started with more than one lflow processing threads (--n-threads > 1), to avoid a very inefficient first lflow processing run due to a suboptimally sized hmap.

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't enable conditional monitoring until connected.

On Tue, Aug 23, 2022 at 6:45 AM Ilya Maximets wrote: > > On 8/22/22 19:39, Han Zhou wrote: > > > > > > On Mon, Aug 22, 2022 at 3:33 AM Ilya Maximets mailto:i.maxim...@ovn.org>> wrote: > >> > >> On 8/22/22 12:21, Dumitru Ceara wrote: > >> > Hi Ilya, > >> > > >> > On 8/22/22 11:19, Ilya Maximets

Re: [ovs-dev] [PATCH net-next v2 1/3] openvswitch: allow specifying ifindex of new interfaces

Thanks for the review! On 8/23/22 04:37, Jakub Kicinski wrote: On Fri, 19 Aug 2022 18:30:42 +0300 Andrey Zhadchenko wrote: CRIU is preserving ifindexes of net devices after restoration. However, current Open vSwitch API does not allow to target ifindex, so we cannot correctly restore OVS

Re: [ovs-dev] [PATCH ovn] ovn-controller: Don't enable conditional monitoring until connected.

On 8/22/22 19:39, Han Zhou wrote: > > > On Mon, Aug 22, 2022 at 3:33 AM Ilya Maximets > wrote: >> >> On 8/22/22 12:21, Dumitru Ceara wrote: >> > Hi Ilya, >> > >> > On 8/22/22 11:19, Ilya Maximets wrote: >> >> daemon_started_recently() concept is flawed in terms that

Re: [ovs-dev] [PATCH ovn 2/3] ovn-controller: Track OVSDB column open_vswitch:external_ids.

Hi Han, On 8/23/22 06:44, Han Zhou wrote: > On Tue, Jul 5, 2022 at 3:41 PM Han Zhou wrote: >> >> The column was not tracked before while it should. The column includes >> many ovn-controller global configurations that could impact the way >> flows are computed. It worked before because lots of

Re: [ovs-dev] [PATCH] netdev-offload-tc: Parse tunnel options only for geneve ports.

On 19 Aug 2022, at 21:51, Ilya Maximets wrote: > Cited commit correctly fixed the issue of incorrect reporting > of zero-length geneve option matches as wildcarded. But as a > side effect, exact match on the metadata length was added to > every tunnel flow match, even if the tunnel is not

Re: [ovs-dev] [PATCH] tc: Fix stats dump when using same meter table

On 15 Aug 2022, at 11:49, Simon Horman wrote: > From: Tianyu Yuan > > When we apply meter police on both directions of TCP traffic, the > dumped stats is shown same (as shown below). This issue is introduced > by modifying the stats update strategy. > >

[ovs-dev] [PATCH ovn] controller: fix potential segmentation violation when removing ports

If a logical switch port is added and connected to a logical router port (through options: router-port) before the router port is created, then this might cause further issues such as segmentation violation when the switch and router ports are deleted. Signed-off-by: Xavier Simonart ---

Re: [ovs-dev] [PATCH] mac-learning: Fix learned fdb entries are not age out issue.

On 3 Aug 2022, at 15:52, lin huang wrote: > Hi Vasu & Eelco, > > Pls review my patch. Just returned from PTO, will try to add this to my next week’s list of things to review. //Eelco >> -Original Message- >> From: lin huang >> Sent: Friday, July 29, 2022 7:17 PM >> To: