Re: [ovs-dev] stateless acl on ovn-k8s interface

Hi, Numan: On Thursday, September 15, 2022 at 08:38:26 AM PDT, Numan Siddique wrote: On Tue, Sep 13, 2022 at 6:41 PM venugopal iyer via dev wrote: > > Hi, Han, Numan: > While testing a use case in our ovn-k8s cluster we ran into an issue where > wecouldn't  effectively use stateless

Re: [ovs-dev] [PATCH ovn] northd: Use bitmaps instead of exclusive hash map for datapath groups.

On 9/16/22 12:10, Numan Siddique wrote: On Fri, Sep 16, 2022 at 11:59 AM Numan Siddique wrote: On Tue, Sep 13, 2022 at 7:34 AM Ilya Maximets wrote: Every time a new logical flow is created, ovn-northd creates an exclusive hash map to collect all the datapaths this logical flow is

Re: [ovs-dev] [PATCH ovn] controller: flush associated conntrack zone on PB release

Thanks Mark. Regards, Vladislav Odintsov > On 16 Sep 2022, at 18:19, Mark Michelson wrote: > > Hi, > > Acked-by: Mark Michelson > > In the interest of getting this merged into 22.09 before its impending > release, I have gone ahead and backported this to branch-22.09 and > branch-22.06,

Re: [ovs-dev] [PATCH ovn] northd: Use bitmaps instead of exclusive hash map for datapath groups.

On Fri, Sep 16, 2022 at 11:59 AM Numan Siddique wrote: > > On Tue, Sep 13, 2022 at 7:34 AM Ilya Maximets wrote: > > > > Every time a new logical flow is created, ovn-northd creates an > > exclusive hash map to collect all the datapaths this logical flow is > > applicable to. While adding a new

Re: [ovs-dev] [PATCH ovn branch-22.09 2/2] Prepare for 22.09.1.

On Fri, Sep 16, 2022 at 11:38 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS

Re: [ovs-dev] [PATCH ovn branch-22.09 1/2] Set release date for 22.09.0.

On Fri, Sep 16, 2022 at 11:38 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique I'm sure you're already aware of it (but just as a reminder) that this patch should also be merged to the main branch. Thanks Numan > --- > NEWS | 2 +- >

Re: [ovs-dev] [PATCH ovn branch-22.03] Allow for setting the Next server IP in the DHCP header

On Mon, Aug 22, 2022 at 3:46 PM Mark Michelson wrote: > > From: Lucas Alvares Gomes > > In order to PXE boot a baremetal server using the OVN DHCP server we > need to allow users to set the "next-server" (siaddr) [0] field in the > DHCP header. > > While investigating this issue by comparing the

Re: [ovs-dev] [PATCH] lib: Add support for sets of UUIDs.

Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Inappropriate bracing around statement #194 FILE: lib/uuidset.h:39: HMAP_FOR_EACH

Re: [ovs-dev] [PATCH ovn] northd: Use bitmaps instead of exclusive hash map for datapath groups.

On Tue, Sep 13, 2022 at 7:34 AM Ilya Maximets wrote: > > Every time a new logical flow is created, ovn-northd creates an > exclusive hash map to collect all the datapaths this logical flow is > applicable to. While adding a new datapath to existing logical flow > hmapx will perform a lookup by

Re: [ovs-dev] Question about moving the uuidset implementation from OVN to OVS

On 9/16/22 17:04, Ben Pfaff wrote: > On Fri, Sep 16, 2022 at 5:30 AM Dumitru Ceara wrote: >> I'd like to post an OVS patch to add this along with some more helpers >> (see below) but I have a couple of questions: >> >> 1. What's the correct/desired way of maintaining authorship in this >> case?

[ovs-dev] [PATCH] lib: Add support for sets of UUIDs.

Part of the uuidset implementation is taken from the OVN codebase where it was added via commit 0e77b3bcbfe2 ("ovn-northd-ddlog: New implementation of ovn-northd based on ddlog."). We now extend that, adding a few helpers and tests. Co-authored-by: Leonid Ryzhyk Signed-off-by: Leonid Ryzhyk

[ovs-dev] [PATCH ovn branch-22.09 2/2] Prepare for 22.09.1.

Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index ef6a99fed..0392d8d23 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v22.09.1 - xx xxx

[ovs-dev] [PATCH ovn branch-22.09 0/2] Release patches for v22.09.0.

Mark Michelson (2): Set release date for 22.09.0. Prepare for 22.09.1. NEWS | 5 - configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 12 insertions(+), 3 deletions(-) -- 2.37.2 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-22.09 1/2] Set release date for 22.09.0.

Signed-off-by: Mark Michelson --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 4e2f18472..ef6a99fed 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -OVN v22.09.0 - xx xxx +OVN v22.09.0 - 16 Sep 2022

Re: [ovs-dev] [PATCH ovn] ovn-controller: fix a crash when deleting a port claimed when sb was ro

Thanks Xavier, Acked-by: Mark Michelson In the interest of getting 22.09 released today, I have merged this to main, branch-22.09, branch-22.06, and branch-22.03 already. On 9/16/22 04:41, Xavier Simonart wrote: When SB is read-only when a port needs to be claimed, the claim of the port is

Re: [ovs-dev] [PATCH ovn] controller: flush associated conntrack zone on PB release

Hi, Acked-by: Mark Michelson In the interest of getting this merged into 22.09 before its impending release, I have gone ahead and backported this to branch-22.09 and branch-22.06, and branch-22.03. Thanks! On 9/7/22 06:04, Vladislav Odintsov wrote: This patch adds conntrack zone flush

Re: [ovs-dev] [PATCH ovn v3] northd: drop traffic to disabled LSPs in ingress pipeline

Hi, Acked-by: Mark Michelson In the interest of getting this merged into 22.09 before its impending release, I have gone ahead and backported this to branch-22.09 and branch-22.06. I attempted to backport this to branch-22.03 but there were conflicts. If you could post a branch-22.03

Re: [ovs-dev] [ovn] Fixes before 22.09.0

On 9/14/22 05:31, Vladislav Odintsov wrote: Hi, Gentle ping. +1 bugfix here: https://patchwork.ozlabs.org/project/ovn/patch/20220912221104.2679484-1-odiv...@gmail.com/ Regards, Vladislav Odintsov

Re: [ovs-dev] Question about moving the uuidset implementation from OVN to OVS

On Fri, Sep 16, 2022 at 5:30 AM Dumitru Ceara wrote: > I'd like to post an OVS patch to add this along with some more helpers > (see below) but I have a couple of questions: > > 1. What's the correct/desired way of maintaining authorship in this > case? I can keep all original authors and add my

Re: [ovs-dev] [PATCH] m4: test avx512 for x86 only

> -Original Message- > From: lic...@chinatelecom.cn > Sent: Friday, September 16, 2022 10:56 AM > To: d...@openvswitch.org; Van Haaren, Harry > Cc: Cheng Li > Subject: [PATCH] m4: test avx512 for x86 only > > 'as' command of arm version may don't support option '--64', this > patch is

Re: [ovs-dev] [PATCH] dpdk: Use DPDK 21.11.2 release.

Hey Maxime/Kevin, I have posted a single patch for updating to 21.11.2 directed for master. The link to the patch is: http://patchwork.ozlabs.org/project/openvswitch/patch/20220916142321.960856-1-michael.phe...@intel.com/. I have added some notes in the NEWS file and commit message on the

Re: [ovs-dev] [v2] dpdk: Use DPDK 21.11.2 release.

Bleep bloop. Greetings Michael Phelan, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 102 characters long (recommended limit is 79) #113 FILE: NEWS:19:

[ovs-dev] [v2] dpdk: Use DPDK 21.11.2 release.

Update OVS CLI and relevant documentation to use DPDK 21.11.2. DPDK 21.11.2 contains fixes for the CVEs listed below: CVE-2022-28199 [1] CVE-2022-2132 [2] A bug was introduced in DPDK 21.11.1 by the commit 01e3dee29c02 ("vhost: fix unsafe vring addresses modifications"). This bug can cause a

Re: [ovs-dev] [PATCH ovn v3 0/4] northd: Optimize preparation of load balancers.

On 9/15/22 18:09, Numan Siddique wrote: On Tue, Sep 13, 2022 at 1:19 PM Han Zhou wrote: On Mon, Sep 12, 2022 at 3:25 AM Dumitru Ceara wrote: On 9/9/22 23:32, Ilya Maximets wrote: Re-compute of 'northd' node in ovn-northd may take almost half of the total processing time in case there is a

Re: [ovs-dev] [PATCH] tests: fix reference output for meter offload stats

On 16 Sep 2022, at 15:11, Ilya Maximets wrote: > On 9/16/22 11:25, Eelco Chaudron wrote: >> >> >> On 16 Sep 2022, at 4:25, Tianyu Yuan wrote: >> >>> On 9/16/22 10:14, Ilya Maximets wrote: On 9/15/22 13:38, Tianyu Yuan wrote: > > On 9/15/22 19:28, Ilya Maximets wrote: >> On

Re: [ovs-dev] [PATCH v2 2/2] bond: Avoid deadlock while updating post recirculation rules.

On 9/16/22 06:24, Mike Pattrick wrote: > On Tue, Sep 13, 2022 at 3:10 PM Ilya Maximets wrote: >> >> If the PACKET_OUT from controller ends up with sending packet to >> a bond interface, the main thread will take locks in the following >> order: >> handle_openflow >> --> take ofproto_mutex >>

Re: [ovs-dev] [PATCH v2] test-list: Fix false-positive build failure with GCC 12.

On 9/15/22 15:06, Eelco Chaudron wrote: > > > On 15 Sep 2022, at 14:17, Ilya Maximets wrote: > >> GCC 12.2.1 on Fedora 36 generates the following false-positive >> warning that is treated as error with -Werror: >> >> tests/test-list.c: In function 'test_list_construction': >>

Re: [ovs-dev] [PATCH ovn 1/2] tests: Fix tests/check_acl_log.py outputs.

On 9/9/22 03:15, Dumitru Ceara wrote: On 8/19/22 15:17, Mark Michelson wrote: Thanks for fixing my janky code, Dumitru :) Acked-by: Mark Michelson Thanks Mark for the review! Any chance we can get this merged to main and all stable branches down to 22.03 LTS? It's not a feature, it's

Re: [ovs-dev] [PATCH] tests: fix reference output for meter offload stats

On 9/16/22 11:25, Eelco Chaudron wrote: > > > On 16 Sep 2022, at 4:25, Tianyu Yuan wrote: > >> On 9/16/22 10:14, Ilya Maximets wrote: >>> On 9/15/22 13:38, Tianyu Yuan wrote: On 9/15/22 19:28, Ilya Maximets wrote: > On 9/14/22 16:19, Simon Horman wrote: >> From: Tianyu Yuan

Re: [ovs-dev] Question about moving the uuidset implementation from OVN to OVS

On 9/16/22 14:30, Dumitru Ceara wrote: > Hi Ben, > > I was working on adding some OVN code and I realized I needed a uuidset > implementation. OVN code already has a couple custom structures that do > that but it turns out (thanks Ilya for pointing it out) we actually have > an almost complete

Re: [ovs-dev] Question about moving the uuidset implementation from OVN to OVS

Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Dumitru Ceara needs to sign off. ERROR: Inappropriate bracing around statement

[ovs-dev] Question about moving the uuidset implementation from OVN to OVS

Hi Ben, I was working on adding some OVN code and I realized I needed a uuidset implementation. OVN code already has a couple custom structures that do that but it turns out (thanks Ilya for pointing it out) we actually have an almost complete explicit uuidset implementation in

Re: [ovs-dev] [PATCH 1/2] dpif-netdev/dpcls: Specialize more subtable signatures.

> -Original Message- > From: Ilya Maximets > Sent: Friday 26 August 2022 19:43 > To: Ferriter, Cian ; ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org > Subject: Re: [ovs-dev] [PATCH 1/2] dpif-netdev/dpcls: Specialize more > subtable signatures. > > On 8/25/22 16:45, Cian Ferriter

[ovs-dev] [PATCH 2/2] dpif-netdev/mfex: Add AVX512 NVGRE traffic profiles.

A typical NVGRE encapsulated packet starts with the ETH/IP/GRE protocols. Miniflow extract will parse just the ETH and IP headers. The GRE header will be processed later as part of the pop action. Add support for parsing the ETH/IP headers in this scenario. Signed-off-by: Cian Ferriter ---

[ovs-dev] [PATCH 1/2] dpif-netdev/dpcls: Specialize 8, 1 and 5, 2 signatures.

The subtable signatures being specialized here were found in an NVGRE tunnel scenario. Signed-off-by: Cian Ferriter --- v2: * Improve commit title. --- lib/dpif-netdev-lookup-avx512-gather.c | 4 lib/dpif-netdev-lookup-generic.c | 4 2 files changed, 8 insertions(+) diff

[ovs-dev] [PATCH 0/2] Enable AVX512 NVGRE optimizations.

This patchset adds AVX512 specialization for the NVGRE tunneling scenario. It adds both an MFEX implementation for parsing the outer header of a typical NVGRE packet and specialized DPCLS subtable signatures for the lookups on both outer and inner headers. v2: * Improve patch 1/2 commit title.

[ovs-dev] [PATCH] m4: test avx512 for x86 only

'as' command of arm version may don't support option '--64', this patch is to move the avx512 test into x86 branch to avoid this. Signed-off-by: Cheng Li --- m4/openvswitch.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4 index

Re: [ovs-dev] [PATCH] tests: fix reference output for meter offload stats

On 16 Sep 2022, at 4:25, Tianyu Yuan wrote: > On 9/16/22 10:14, Ilya Maximets wrote: >> On 9/15/22 13:38, Tianyu Yuan wrote: >>> >>> On 9/15/22 19:28, Ilya Maximets wrote: On 9/14/22 16:19, Simon Horman wrote: > From: Tianyu Yuan > > Since dd9881ed55e6 ("tc: Fix stats dump

[ovs-dev] [PATCH ovn] controller: Restore MAC and vlan for DVR scenario

When traffic originated from router port the MAC, in DVR setup, the router MAC was replaced by one specified in "ovn-chassis-mac-mappings" option. Along with that the vlan tag of the localnet port was pushed. When the traffic unicast it didn't cause any issue, however during l2 flooding, which

[ovs-dev] [PATCH ovn branch-22.03] northd: Do not report WARN for empty requested-chassis

Reported-at: https://bugzilla.redhat.com/2126400 Signed-off-by: Ales Musil --- This patch should be applied only to 22.03 and below, because it was fixed as side effect of RFE on 22.06, 22.09 and main [0]. [0] https://github.com/ovn-org/ovn/commit/eaf9832be248daca6d96202d504cc789d6dfec6d ---

[ovs-dev] [PATCH ovn] ovn-controller: fix a crash when deleting a port claimed when sb was ro

When SB is read-only when a port needs to be claimed, the claim of the port is delayed until SB becomes writable. However, if that port gets deleted while ovn-controller is waiting for SB to become writable, the claim will crash ovn-controller Signed-off-by: Xavier Simonart ---

[ovs-dev] [PATCH] ovsdb-idl: Preserve references for rows deleted in same IDL as their insertion.

Considering two DB rows, 'a' from table A and 'b' from table B (with column 'ref_a' a reference to table A): a = {A._uuid=} b = {B._uuid=, B.ref_a=} Assuming both records are inserted in the IDL client's in-memory view of the database, if row 'b' is also deleted in the same transaction, it should

[ovs-dev] [PATCH v2 1/1] datapath-windows: Alg support for ftp and tftp in conntrack

From: ldejing This patch mainly support alg field in ct action when process ftp/tftp traffic. Tftp with alg mainly parse the tftp packet (IPv4/IPv6), extract connect info from the tftp packet and create the related connection. For ftp, previous version has supported process of ftp traffic.