Re: [ovs-dev] [PATCH net] openvswitch: add nf_ct_is_confirmed check before assigning the helper

2022-10-12 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Thu, 6 Oct 2022 15:45:02 -0400 you wrote: > A WARN_ON call trace would be triggered when 'ct(commit, alg=helper)' > applies on a confirmed connection: > > WARNING: CPU: 0 PID: 1251 at

Re: [ovs-dev] [PATCH v1 3/5] treewide: use get_random_u32() when possible

2022-10-12 Thread Joe Perches
On Wed, 2022-10-12 at 21:29 +, David Laight wrote: > From: Joe Perches > > Sent: 12 October 2022 20:17 > > > > On Wed, 2022-10-05 at 23:48 +0200, Jason A. Donenfeld wrote: > > > The prandom_u32() function has been a deprecated inline wrapper around > > > get_random_u32() for several releases

Re: [ovs-dev] [PATCH v1 3/5] treewide: use get_random_u32() when possible

2022-10-12 Thread David Laight
From: Joe Perches > Sent: 12 October 2022 20:17 > > On Wed, 2022-10-05 at 23:48 +0200, Jason A. Donenfeld wrote: > > The prandom_u32() function has been a deprecated inline wrapper around > > get_random_u32() for several releases now, and compiles down to the > > exact same code. Replace the

Re: [ovs-dev] [PATCH v1 3/5] treewide: use get_random_u32() when possible

2022-10-12 Thread Joe Perches
On Wed, 2022-10-05 at 23:48 +0200, Jason A. Donenfeld wrote: > The prandom_u32() function has been a deprecated inline wrapper around > get_random_u32() for several releases now, and compiles down to the > exact same code. Replace the deprecated wrapper with a direct call to > the real function.

Re: [ovs-dev] [PATCH ovn] controller: Remove unused shash from update_ct_zone

2022-10-12 Thread Mark Michelson
Wow, this shash has been unused since branch-21.06 . Good find! Acked-by: Mark Michelson On 10/12/22 04:07, Ales Musil wrote: Signed-off-by: Ales Musil --- controller/ovn-controller.c | 4 1 file changed, 4 deletions(-) diff --git a/controller/ovn-controller.c

Re: [ovs-dev] [PATCH ovn 3/3] northd: rely on new actions for lb affinity

2022-10-12 Thread Mark Michelson
Hi Lorenzo, Please add documentation to ovn-nb.xml for the new affinity_timeout option. I have more comments below. On 10/4/22 09:02, Lorenzo Bianconi wrote: Rely on the following new actions in order to introduce affinity timeout support to load-balancer sessions: - commit_lb_aff -

Re: [ovs-dev] [PATCH ovn 2/3] actions: introduce chk_lb_aff action

2022-10-12 Thread Mark Michelson
I found just one tiny grammatical problem in this one. Otherwise, Acked-by: Mark Michelson On 10/4/22 09:02, Lorenzo Bianconi wrote: chk_lb_aff action checks if the packet under consideration matches the new flow in table OFTABLE_CHK_LB_AFFINITY. If so, then the 1-bit destination register is

Re: [ovs-dev] [PATCH ovn 1/3] actions: introduce commit_lb_aff action

2022-10-12 Thread Mark Michelson
On 10/4/22 09:02, Lorenzo Bianconi wrote: commit_lb_aff action translates to an openflow "learn" action that inserts a new flow in the OFTABLE_CHK_LB_AFFINITY table. The new flow is used to match on the the 5-tuple and set REGBIT_KNOWN_LB_SESSION bit. Moreover the new flow stores backend IP and

Re: [ovs-dev] [PATCH ovn 0/3] Introduce lb affinity timeout support

2022-10-12 Thread Mark Michelson
Hi Lorenzo, Is load balancer affinity intended to work with a) Load balancers that do not specify a protocol? b) Load balancers that do not specify a VIP port? c) Load balancers that do not specify a backend port? On 10/4/22 09:02, Lorenzo Bianconi wrote: Introduce load-balancer affinity

[ovs-dev] [syzbot] WARNING in ovs_dp_reset_user_features

2022-10-12 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git... git tree: upstream console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de04288 kernel config: https://syzkaller.appspot.com/x/.config?x=7579993da6496f03

[ovs-dev] [syzbot] WARNING in ovs_dp_cmd_new (2)

2022-10-12 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git... git tree: upstream console+strace: https://syzkaller.appspot.com/x/log.txt?x=1112f08a88 kernel config: https://syzkaller.appspot.com/x/.config?x=1b85abe77fd80fd6

Re: [ovs-dev] [PATCH] github: Update versions of action dependencies.

2022-10-12 Thread Ilya Maximets
On 10/12/22 12:05, David Marchand wrote: > On Wed, Oct 12, 2022 at 11:19 AM Ilya Maximets wrote: >> >> checkout@v2 and setup-python@v2 are using outdated Node.js 12 >> which is now deprecated in GHA [1], so these actions will stop >> working soon. >> >> Updating to most recent major versions with

Re: [ovs-dev] [PATCH v7 0/9] DPIF + MFEX Inner AVX512

2022-10-12 Thread Ferriter, Cian
Hi Eelco, Thanks for reaching out, here's our priority list: 1. Actions IPv6. Currently at v3. http://patchwork.ozlabs.org/project/openvswitch/patch/20220926132946.1767182-1-emma.f...@intel.com/ 2. DPIF Recirc AVX512. Currently at v7.

[ovs-dev] [PATCH v2] ct-dpif: Replace ct_dpif_format_flags() with format_flags_masked().

2022-10-12 Thread Paolo Valerio
This patch removes ct_dpif_format_flags() in favor of the existing format_flags_masked(). This has the extra bonus of showing keys with empty values as "key=0", instead of showing "key=". E.g., the following: NEW tcp,orig=([...]),reply=([...]),id=1800618864,

Re: [ovs-dev] [PATCH v7 0/9] DPIF + MFEX Inner AVX512

2022-10-12 Thread Eelco Chaudron
Hi Cian, et al. I’m still planning to review all the AVX512-related patches that intel people have out, but I’m a bit short on time. My next step is to review this set, or are there any other sets that you want to be reviewed first? Even better would be a priority list that I can work down.

Re: [ovs-dev] [branch-2.16, v2] dpdk: Use DPDK 20.11.6 release.

2022-10-12 Thread David Marchand
On Tue, Sep 27, 2022 at 1:03 AM Ilya Maximets wrote: > On 9/23/22 15:46, David Marchand wrote: > > On Fri, Sep 23, 2022 at 2:43 PM Kevin Traynor wrote: > >> > >> On 22/09/2022 13:40, Michael Phelan wrote: > >>> Update OVS CLI and relevant documentation to use DPDK 20.11.6. > >>> > >>> A bug was

Re: [ovs-dev] [PATCH v6 0/9] DPIF + MFEX Inner AVX512

2022-10-12 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Thursday 6 October 2022 11:24 > To: ovs-dev@openvswitch.org > Cc: echau...@redhat.com; i.maxim...@ovn.org; Ferriter, Cian > ; Stokes, Ian > ; f...@sysclose.org; Van Haaren, Harry > ; Amber, Kumar > > Subject: [PATCH v6 0/9] DPIF +

Re: [ovs-dev] [PATCH v7 6/9] dpif-mfex: Modify set/get MFEX commands to include inner.

2022-10-12 Thread Pai G, Sunil
> v7: > * Reword bridge.rst documentation to better explain the use of the > -recirc option and provide examples. This is all based on feedback > from Sunil. > --- > Documentation/topics/dpdk/bridge.rst | 32 ++-- > lib/dpif-netdev-private-extract.c| 23

Re: [ovs-dev] [PATCH net] openvswitch: add nf_ct_is_confirmed check before assigning the helper

2022-10-12 Thread Aaron Conole
Xin Long writes: > A WARN_ON call trace would be triggered when 'ct(commit, alg=helper)' > applies on a confirmed connection: > > WARNING: CPU: 0 PID: 1251 at net/netfilter/nf_conntrack_extend.c:98 > RIP: 0010:nf_ct_ext_add+0x12d/0x150 [nf_conntrack] > Call Trace: > >

[ovs-dev] [PATCH v7 9/9] mfex-avx512: Add support for tunnel packets in avx512 MFEX.

2022-10-12 Thread Cian Ferriter
From: Kumar Amber This patch adds the necessary support to avx512 mfex to support handling of tunnel packet type. Signed-off-by: Kumar Amber Acked-by: Cian Ferriter Acked-by: Sunil Pai G --- lib/dpif-netdev-avx512.c | 32 ++--- lib/dpif-netdev-extract-avx512.c | 206

[ovs-dev] [PATCH v7 8/9] mfex-study: Modify study func to select outer and inner MFEX funcs.

2022-10-12 Thread Cian Ferriter
From: Kumar Amber The MFEX study function is split into outer and inner to allow for independent selection and studying of packets in outer and inner flows to different ISA optimized miniflow extract implementations. Signed-off-by: Kumar Amber Acked-by: Cian Ferriter Acked-by: Sunil Pai G

[ovs-dev] [PATCH v7 6/9] dpif-mfex: Modify set/get MFEX commands to include inner.

2022-10-12 Thread Cian Ferriter
From: Kumar Amber The set command is modified to allow the user to select different implementations for processing inner packets. Also, the get command is modified to indicate both inner and outer MFEX implementation in use. $ ovs-appctl dpif-netdev/miniflow-parser-set -pmd 3 study 1024 -recirc

[ovs-dev] [PATCH v7 5/9] dpif-netdev: Add function pointer for dpif re-circulate.

2022-10-12 Thread Cian Ferriter
From: Kumar Amber This patch adds support for selecting the recirculation implementation based on the DPIF implementation. Signed-off-by: Kumar Amber Signed-off-by: Cian Ferriter Co-authored-by: Cian Ferriter Acked-by: Sunil Pai G --- lib/dpif-netdev-private-dpif.c | 73

[ovs-dev] [PATCH v7 7/9] dpif-mfex: Change MFEX fn pointer prototype to include md_is_valid.

2022-10-12 Thread Cian Ferriter
From: Kumar Amber The md_is_valid parameter is passed from DPIF to MFEX to allow MFEX functions to detect the tunneling and decide the processing of Inner packets in static predictable branches. Signed-off-by: Kumar Amber Acked-by: Cian Ferriter Acked-by: Sunil Pai G ---

[ovs-dev] [PATCH v7 4/9] dpif-netdev-avx512: Add inner packet handling to dpif.

2022-10-12 Thread Cian Ferriter
From: Kumar Amber This patch adds the necessary changes required to support tunnel packet types in avx512 dpif. Signed-off-by: Kumar Amber Signed-off-by: Cian Ferriter Co-authored-by: Cian Ferriter Acked-by: Sunil Pai G --- lib/dpif-netdev-avx512.c | 38

[ovs-dev] [PATCH v7 3/9] dpif-netdev-avx512: Refactor avx512 dpif and create new APIs.

2022-10-12 Thread Cian Ferriter
From: Kumar Amber Create new APIs for the avx512 DPIF, enabling one baseline common code to be specialized into DPIF implementations for "outer" processing, and "recirc" processing. Signed-off-by: Kumar Amber Signed-off-by: Cian Ferriter Co-authored-by: Cian Ferriter Acked-by: Sunil Pai G

[ovs-dev] [PATCH v7 1/9] dpif-netdev: Refactor per thread recirc data allocation.

2022-10-12 Thread Cian Ferriter
From: Kumar Amber The refactor allows us to use *recirc_depth_get() to obtain the depth across ovs which was previously limited to only dpif-netdev.c. The patch enables the use of recirc_depth_get() function in avx512 dpif. Signed-off-by: Kumar Amber Signed-off-by: Cian Ferriter

[ovs-dev] [PATCH v7 2/9] dpif-netdev: Refactor hash function to own header.

2022-10-12 Thread Cian Ferriter
From: Kumar Amber The refactor allows us to use hash function accross multiple files which was earlier restricted to dpif-netdev.c only. This patch enables the use of the hash function in avx512 dpif. Signed-off-by: Kumar Amber Signed-off-by: Cian Ferriter Co-authored-by: Cian Ferriter

[ovs-dev] [PATCH v7 0/9] DPIF + MFEX Inner AVX512

2022-10-12 Thread Cian Ferriter
This Series of Patchsets introduce the Optimizations for supporting tunneled packets in DPIF and MFEX. Along with the optimization various refactoring of scalar path is done to be used accross without duplication. Over the Tests we have observed a gain of approximate 20~25% gain in performance

Re: [ovs-dev] [PATCH] github: Update versions of action dependencies.

2022-10-12 Thread David Marchand
On Wed, Oct 12, 2022 at 11:19 AM Ilya Maximets wrote: > > checkout@v2 and setup-python@v2 are using outdated Node.js 12 > which is now deprecated in GHA [1], so these actions will stop > working soon. > > Updating to most recent major versions with Node.js 16. > This stops GHA from throwing

[ovs-dev] [PATCH] github: Update versions of action dependencies.

2022-10-12 Thread Ilya Maximets
checkout@v2 and setup-python@v2 are using outdated Node.js 12 which is now deprecated in GHA [1], so these actions will stop working soon. Updating to most recent major versions with Node.js 16. This stops GHA from throwing warnings in every build. While at it, also updating cache and

[ovs-dev] [PATCH ovn] controller: Remove unused shash from update_ct_zone

2022-10-12 Thread Ales Musil
Signed-off-by: Ales Musil --- controller/ovn-controller.c | 4 1 file changed, 4 deletions(-) diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c index 9969d317f..8895c7a2b 100644 --- a/controller/ovn-controller.c +++ b/controller/ovn-controller.c @@ -667,7 +667,6 @@

[ovs-dev] [PATCH v4] ofproto-dpif-xlate: Update tunnel neighbor when receive garp

2022-10-12 Thread Han Ding
OVS now just allow the ARP Relpy whitch the destination address is matched against the known xbridge addresses to udpate tunnel neighbor. So when ovs receive the gratuitous ARP from underlay gateway which the source address and destination address are all gateway IP, tunnel neighbor will not be