Re: [ovs-dev] [PATCH ovn 6/8] lb: Support using templates.

2022-10-21 Thread Han Zhou
On Fri, Oct 21, 2022 at 1:00 AM Dumitru Ceara wrote: > > On 10/21/22 07:47, Han Zhou wrote: > > On Fri, Sep 30, 2022 at 7:02 AM Dumitru Ceara wrote: > >> > >> Allow the CMS to configure template LBs. The following configurations are > >> supported: > >> - VIPs of the form:

[ovs-dev] [PATCH v3 ovn] northd: add the capability to inherit logical routers lbs groups on logical switches

2022-10-21 Thread Lorenzo Bianconi
Similar to single load balancers, add the capability to automatically deploy a load-balancer group on each logical-switch connected to a logical router where the load-balancer group has been installed by the CMS. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2125310 Signed-off-by:

[ovs-dev] [PATCH ovn] ovn-controller: Fix some issues with CT zone assignment.

2022-10-21 Thread Mark Michelson
An issue was filed where CT zone 0 was assigned to both a logical router SNAT and to a logical port. CT zone 0 is typically "reserved" and not assigned by ovn-controller; however, since SNAT zones are configurable, it is possible for ovn-controller to assign this zone at the CMS's request. This

Re: [ovs-dev] [PATCH v2] ovs-thread: Detect changes in number of cpus

2022-10-21 Thread Mike Pattrick
On Fri, Sep 30, 2022 at 11:31 AM Adrian Moreno wrote: > > Currently, things like the number of handler and revalidator threads are > calculated based on the number of available CPUs. However, this number > is considered static and only calculated once, hence ignoring events > such as cpus being

Re: [ovs-dev] [PATCH v4 ovn 3/3] northd: rely on new actions for lb affinity

2022-10-21 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 96 characters long (recommended limit is 79) #199 FILE:

[ovs-dev] [PATCH v6] revalidator: add a USDT probe after evaluation when flows are deleted.

2022-10-21 Thread Kevin Sprague
During normal operations, it is useful to understand when a particular flow gets removed from the system. This can be useful when debugging performance issues tied to ofproto flow changes, trying to determine deployed traffic patterns, or while debugging dynamic systems where ports come and go.

[ovs-dev] [PATCH v4 ovn 3/3] northd: rely on new actions for lb affinity

2022-10-21 Thread Lorenzo Bianconi
Rely on the following new actions in order to introduce affinity timeout support to load-balancer sessions: - commit_lb_aff - chk_lb_aff Introduce the following tables in switch and router pipelines respectively: - S_SWITCH_IN_LB_AFF_CHECK - S_SWITCH_IN_LB_AFF_LEARN - S_ROUTER_IN_LB_AFF_CHECK -

[ovs-dev] [PATCH v4 ovn 2/3] actions: introduce chk_lb_aff action

2022-10-21 Thread Lorenzo Bianconi
chk_lb_aff action checks if the packet under consideration matches the new flow in table OFTABLE_CHK_LB_AFFINITY. If so, then the 1-bit destination register is set to 1. chk_lb_aff will be used to add affinity timeout support to load balancer connections. Acked-by: Mark Michelson Signed-off-by:

[ovs-dev] [PATCH v4 ovn 1/3] actions: introduce commit_lb_aff action

2022-10-21 Thread Lorenzo Bianconi
commit_lb_aff action translates to an openflow "learn" action that inserts a new flow in the OFTABLE_CHK_LB_AFFINITY table. The new flow is used to match on the the 5-tuple and set REGBIT_KNOWN_LB_SESSION bit. Moreover the new flow stores backend IP and port in register REG4 and REG8[0..15]

[ovs-dev] [PATCH v4 ovn 0/3] Introduce lb affinity timeout support

2022-10-21 Thread Lorenzo Bianconi
Introduce load-balancer affinity timeout in order to dnat connections received from the same client to a given load-balancer to the same backend if received in the affinity timeslot specified by the CMS. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2127959 Changes since v3: - add

Re: [ovs-dev] [PATCH v1 1/1] lib: Correct the stats of packet_count and byte_count on Windows

2022-10-21 Thread Wilson Peng via dev
Hi, Ilya, Thanks for the comments. V2 patch is sent out for review. And It is also verified on Windows with the v2 patch. Regards Wilson From: Ilya Maximets Date: Thursday, October 20, 2022 at 19:31 To: Wilson Peng , d...@openvswitch.org Cc: i.maxim...@ovn.org , Wilson Peng Subject: Re:

[ovs-dev] [PATCH v2 1/1] lib: Correct the stats of packet_count and byte_count on Windows

2022-10-21 Thread Wilson Peng
From: Wilson Peng The stats is got via function call ofputil_decode_flow_stats_reply() and for OpenFlow15 it will also call oxs_pull_entry__(). Currently we found on Windows the counter is incorrect. From the output below, it is incorrect for the n_bytes counter via OpenFlow15 on CMD ovs-ofctl

Re: [ovs-dev] [PATCH v3] netdev-dpdk: add control plane protection support

2022-10-21 Thread 0-day Robot
Bleep bloop. Greetings Robin Jarry, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #145 FILE:

[ovs-dev] [PATCH v3] netdev-dpdk: add control plane protection support

2022-10-21 Thread Robin Jarry
Some control protocols are used to maintain link status between forwarding engines (e.g. LACP). When the system is not sized properly, the PMD threads may not be able to process all incoming traffic from the configured Rx queues. When a signaling packet of such protocols is dropped, it can cause

[ovs-dev] [PATCH] odp-util: Add missing comma in format_odp_conntrack_action()

2022-10-21 Thread Paolo Valerio
If OVS_CT_ATTR_TIMEOUT is included, the resulting output is the following: actions:ct(commit,timeout=1nat(src=10.1.1.240)) Fix it by trivially adding a trailing ',' to timeout as well. Signed-off-by: Paolo Valerio --- lib/odp-util.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [ovs-dev] [PATCH] netdev-linux: Allow meter to work in tc software datapath

2022-10-21 Thread Baowen Zheng
On October 20, 2022 7:54 PM, Ilya wrote: >On 10/19/22 10:20, Simon Horman wrote: >> On Tue, Oct 11, 2022 at 11:35:27AM +0200, Simon Horman wrote: >>> From: Baowen Zheng >>> >>> Add tc action flags when adding police action to offload meter table. >>> >>> There is a restriction that the flag of

Re: [ovs-dev] [RFC PATCH ovn] northd, controller: Commit flows dropped by ACLs in a separate CT zone

2022-10-21 Thread Dumitru Ceara
On 10/20/22 17:34, Abhiram Sangana wrote: > Hi Dumitru, > > Can you please check if the implementation for the proposal looks ok? > Will send out v1 with the review comments and tests. > Also, any ideas how we can selectively create new drop zones for ports. > Currently, I am assigning a new zone

Re: [ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-21 Thread Ales Musil
On Fri, Oct 21, 2022 at 10:37 AM Ales Musil wrote: > Run ovs_list_init on list_node from desired flow. > Not doing that can potentially cause crash on > ovs_assert(ovs_list_is_empty(>list_node)) > this might happen when we have conditional monitoring > enabled and have some flow like below being

Re: [ovs-dev] [PATCH v2] netdev-linux: Allow meter to work in tc software datapath when tc-policy is specified

2022-10-21 Thread 0-day Robot
References: <20221021091031.52856-1-simon.hor...@corigine.com> Bleep bloop. Greetings Simon Horman, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected

[ovs-dev] [PATCH v2] netdev-linux: Allow meter to work in tc software datapath when tc-policy is specified

2022-10-21 Thread Simon Horman
From: Baowen Zheng Add tc action flags when adding police action to offload meter table. There is a restriction that the flag of skip_sw/skip_hw should be same for filter rule and the independent created tc actions the rule uses. In this case, if we configure the tc-policy as skip_hw, filter

Re: [ovs-dev] [PATCH] mac-learning: Fix learned fdb entries not age out issue.

2022-10-21 Thread Eelco Chaudron
On 20 Oct 2022, at 17:06, mit...@outlook.com wrote: > From: Lin Huang > > After user add a static fdb entry, the get_lru() function will always return > the static fdb entry. That's normal fdb entries will not age out through > mac_learning_run(). > > Fix the issue by modify the get_lru()

[ovs-dev] [PATCH ovn] controller: Init list_node again after removal from list

2022-10-21 Thread Ales Musil
Run ovs_list_init on list_node from desired flow. Not doing that can potentially cause crash on ovs_assert(ovs_list_is_empty(>list_node)) this might happen when we have conditional monitoring enabled and have some flow like below being processed by ofctrl in a single run. flowA is removed, flowA

Re: [ovs-dev] [PATCH ovn branch-22.09] ovs: Bump submodule to tip of branch-3.0 and add related test

2022-10-21 Thread Dumitru Ceara
On 10/20/22 17:12, Han Zhou wrote: > +1 Thanks for the sign! :) > > On Thu, Oct 20, 2022 at 8:05 AM Dumitru Ceara wrote: > >> On 10/20/22 14:23, Xavier Simonart wrote: >>> Specifically for: >>> e379e42d47f8 ("ovsdb-idl: Preserve references for rows deleted in same >> IDL run as their

Re: [ovs-dev] [PATCH ovn 5/8] controller: Add support for templated actions and matches.

2022-10-21 Thread Dumitru Ceara
On 10/21/22 08:00, Han Zhou wrote: > On Fri, Oct 7, 2022 at 1:26 AM Dumitru Ceara wrote: >> >> On 10/7/22 04:03, Han Zhou wrote: >>> On Fri, Sep 30, 2022 at 7:02 AM Dumitru Ceara wrote: Expand SB.Template_Var records in two stages: 1. first expand them to local values in

Re: [ovs-dev] [PATCH ovn 6/8] lb: Support using templates.

2022-10-21 Thread Dumitru Ceara
On 10/21/22 07:47, Han Zhou wrote: > On Fri, Sep 30, 2022 at 7:02 AM Dumitru Ceara wrote: >> >> Allow the CMS to configure template LBs. The following configurations are >> supported: >> - VIPs of the form: ^vip_variable[:^port_variable|:port] >> - Backends of the form: >> >

[ovs-dev] [PATCH v8 1/2] ofproto-dpif-xlate: Extract the freezing processing into a function

2022-10-21 Thread Ales Musil
Through out the code there is the same pattern that occurs in regards to to finish_freezing when ctx->freezing=true or xlate_action_set when ctx->freezing=false. Extract it to common function that is called from those places instead. Acked-by: Eelco Chaudron Signed-off-by: Ales Musil --- v8:

[ovs-dev] [PATCH v8 2/2] ofproto-dpif-xlate: Optimize the clone for patch ports

2022-10-21 Thread Ales Musil
When the packet was traveling through patch port boundary OvS would check if any of the actions is reversible, if not it would clone the packet. However, the check was only at the first level of the second bridge. That caused some issues when the packet had gone through more actions, some of them

Re: [ovs-dev] [PATCH v7 2/2] ofproto-dpif-xlate: Optimize the clone for patch ports

2022-10-21 Thread Ales Musil
On Thu, Oct 20, 2022 at 4:43 PM Eelco Chaudron wrote: > > > On 20 Oct 2022, at 15:53, Ales Musil wrote: > > > On Thu, Oct 20, 2022 at 3:41 PM Eelco Chaudron > wrote: > > > >> > >> > >> On 18 Oct 2022, at 19:34, Ales Musil wrote: > >> > >>> When the packet was traveling through patch port

Re: [ovs-dev] [PATCH ovn 5/8] controller: Add support for templated actions and matches.

2022-10-21 Thread Han Zhou
On Fri, Oct 7, 2022 at 1:26 AM Dumitru Ceara wrote: > > On 10/7/22 04:03, Han Zhou wrote: > > On Fri, Sep 30, 2022 at 7:02 AM Dumitru Ceara wrote: > >> > >> Expand SB.Template_Var records in two stages: > >> 1. first expand them to local values in match/action strings > >> 2. then reparse the