On Thu, 26 Jan 2023 16:22:05 +0100 Luca Ceresoli wrote:
> Fix typos and add the following to the scripts/spelling.txt:
>
> exsits||exists
>
> Signed-off-by: Luca Ceresoli
You need to split this up per subsystem, I reckon :(
___
dev mailing list
David Marchand writes:
> Let's enhance our coverage in the CI and run DPDK system tests.
>
> A few DPDK drivers are enabled in DPDK compilation.
>
> Put DPDK build in $PATH for dpdk-testpmd to be available.
> sudo drops PATH= updates and -E does not seem to preserve this variable.
> Pass
David Marchand writes:
> dpdk-testpmd does not need hugetlbfs backing as we don't require
> multiprocess support in OVS unit tests.
> Plus, there is no need for explicitly reserving more memory than what
> testpmd would actually need at runtime.
>
> Switch to --in-memory, use dynamic allocations
David Marchand writes:
> Rather than copy/paste everywhere, introduce helpers to control
> testpmd runs.
> Rely on --stats-period (which outputs port stats every n seconds) so that
> testpmd keeps running without expecting any user input.
>
> Signed-off-by: David Marchand
> ---
Thanks for this
On 1/24/23 14:01, Eelco Chaudron wrote:
> With some datapaths, read TC, it takes a bit longer to update the
> OpenFlow statistics. Rather than adding an additional delay, try
> to read the counters multiple times until we get the desired value.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi
On 1/24/23 13:59, Eelco Chaudron wrote:
> If a tc flow was installed but has not yet been used, report it as such.
>
> In addition, add a delay to the "IGMP - flood under normal action" test
> case to make it work with many repetitions. This delay is also present
> in other ICMP/IGMP tests.
>
Hello Kevin,
On Tue, Jan 24, 2023 at 5:00 AM Kevin Traynor wrote:
>
> pmd-perf-show with pmd-perf-metrics=true displays a histogram
> with averages. However, averages were not displayed when there
> is no iterations.
>
> They will be all zero so it is not hiding useful information
> but the
On 1/26/23 22:32, Ilya Maximets wrote:
> On 1/24/23 13:57, Eelco Chaudron wrote:
>> tc does not support conntrack ALGs. Even worse, with tc enabled, they
>> should not be used/configured at all. This is because even though TC
>> will ignore the rules with ALG configured, i.e., they will flow
On 1/24/23 13:57, Eelco Chaudron wrote:
> tc does not support conntrack ALGs. Even worse, with tc enabled, they
> should not be used/configured at all. This is because even though TC
> will ignore the rules with ALG configured, i.e., they will flow through
> the kernel module, return traffic might
On 1/24/23 13:56, Eelco Chaudron wrote:
> The revalidator/purge commands in the system test cases sometimes
> get called immediately after a partial test is completed. This
> could cause the revalidator thread to log an error that it can
> not find/delete a flow due to the slower flow installation
Logical flow matches that always evaluate to false should never be
programmed by ovn-northd (or as ACLs). If that's the case, log a
warning.
Note: matches that cannot be parsed because they refer to empty
or non existent port_groups/address_sets/templates don't generate
a valid expression
Hi Kevin,
On Tue, Jan 24, 2023 at 5:00 AM Kevin Traynor wrote:
>
> Some stats in pmd-perf-show don't check for divide by zero
> which results in not a number (-nan).
>
> This is a normal case for some of the stats when there are
> no Rx queues assigned to the PMD thread core.
>
> It is not
On 1/24/23 13:57, Eelco Chaudron wrote:
> Flush datapath flows as TC flows take some more time to be flushed out.
> The flush speeds this up.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
> ---
> tests/system-offloads.at |2 --
> tests/system-traffic.at |6 ++
> 2 files
On 1/24/23 13:57, Eelco Chaudron wrote:
> This change fixes the "conntrack - floating" test for the TC
> offload case. In this scenario, the connection might move to
> CLOSE_WAIT, which would fail the test as it only accepts
> TIME_WAIT. However, both indicate the connection was
> established, so
On 1/24/23 13:56, Eelco Chaudron wrote:
> This patch adds a delay before dumping the conntrack table because with
> tc it takes a bit longer before it gets synced.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
> ---
> tests/system-common-macros.at |3 +
> tests/system-offloads.at
On 1/24/23 13:56, Eelco Chaudron wrote:
> tc was not setting the OVS_CT_ATTR_FORCE_COMMIT flag when a forced
> commit was requested. This patch will fix this.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
> ---
Should this have:
Fixes: 576126a931cd ("netdev-offload-tc: Add conntrack
On 1/24/23 13:47, Eelco Chaudron wrote:
> TC flower does not allow the push of the implicit null labels (RFC3032).
> Avoid the use of such labels in the MPLS test cases.
Do they cause test failures or OVS just falls back to the kernel datapath?
Best regards, Ilya Maximets.
On 1/24/23 13:45, Eelco Chaudron wrote:
> Include and run the system-traffic.at tests as part of the system offload
> testsuite. Exclude all the tests that will not run without any special
> modifications.
>
> Signed-off-by: Eelco Chaudron
> Acked-by: Roi Dayan
> ---
> tests/automake.mk
On 1/24/23 14:01, Eelco Chaudron wrote:
> The goal was to run 200 successful tc tests in a row. To do this the
> following was run:
>
> for i in {1..200}; do make check-offloads || break; \
> echo "ALL_200_OK: $i"; done;
Hi, Eelco.
Thanks for all the work! The patch set is fine in
On Thu, Jan 26, 2023 at 06:21:34PM +0100, Eelco Chaudron wrote:
>
>
> On 26 Jan 2023, at 17:58, Simon Horman wrote:
>
> > On Tue, Jan 24, 2023 at 02:01:19PM +0100, Eelco Chaudron wrote:
> >> With some datapaths, read TC, it takes a bit longer to update the
> >> OpenFlow statistics. Rather than
On Thu, Jan 26, 2023 at 06:29:44PM +0100, Eelco Chaudron wrote:
>
>
> On 26 Jan 2023, at 17:52, Simon Horman wrote:
>
> > On Tue, Jan 24, 2023 at 01:42:57PM +0100, Eelco Chaudron wrote:
> >> This series makes it possible to include system-traffic.at tests into
> >> "make check-offloads" tests.
On 26 Jan 2023, at 17:52, Simon Horman wrote:
> On Tue, Jan 24, 2023 at 01:42:57PM +0100, Eelco Chaudron wrote:
>> This series makes it possible to include system-traffic.at tests into
>> "make check-offloads" tests.
>>
>> The last patch of the series explains which tests are still not passing
On 26 Jan 2023, at 17:58, Simon Horman wrote:
> On Tue, Jan 24, 2023 at 02:01:19PM +0100, Eelco Chaudron wrote:
>> With some datapaths, read TC, it takes a bit longer to update the
>> OpenFlow statistics. Rather than adding an additional delay, try
>> to read the counters multiple times until
+Cc Roi
On Thu 26 Jan 2023 at 04:33, Marcelo Ricardo Leitner
wrote:
> On Thu, Jan 26, 2023 at 04:23:39AM -0800, Marcelo Ricardo Leitner wrote:
>> +Cc Chris, Paul and Vlad.
>>
>> On Thu, Jan 26, 2023 at 11:08:02AM +0100, Eelco Chaudron wrote:
>> > A long long time ago, an effort was made to make
On Tue, Jan 24, 2023 at 02:01:19PM +0100, Eelco Chaudron wrote:
> With some datapaths, read TC, it takes a bit longer to update the
> OpenFlow statistics. Rather than adding an additional delay, try
> to read the counters multiple times until we get the desired value.
>
> Signed-off-by: Eelco
On Tue, Jan 24, 2023 at 01:42:57PM +0100, Eelco Chaudron wrote:
> This series makes it possible to include system-traffic.at tests into
> "make check-offloads" tests.
>
> The last patch of the series explains which tests are still not passing
> and might need some more work.
>
> I'll try to work
Fix typos and add the following to the scripts/spelling.txt:
exsits||exists
Signed-off-by: Luca Ceresoli
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 2 +-
net/openvswitch/flow_table.c | 2 +-
scripts/spelling.txt | 1 +
sound/soc/fsl/fsl-asoc-card.c
On Thu, Jan 26, 2023 at 04:23:39AM -0800, Marcelo Ricardo Leitner wrote:
> +Cc Chris, Paul and Vlad.
>
> On Thu, Jan 26, 2023 at 11:08:02AM +0100, Eelco Chaudron wrote:
> > A long long time ago, an effort was made to make tc flower
> > rtnl_lock() free. However, on the OVS part we forgot to add
>
+Cc Chris, Paul and Vlad.
On Thu, Jan 26, 2023 at 11:08:02AM +0100, Eelco Chaudron wrote:
> A long long time ago, an effort was made to make tc flower
> rtnl_lock() free. However, on the OVS part we forgot to add
> the TCA_KIND "flower" attribute, which tell the kernel to skip
> the lock. This
On 1/25/23 17:35, Vladislav Odintsov wrote:
>
>
> Regards,
> Vladislav Odintsov
>
>> On 25 Jan 2023, at 19:16, Ilya Maximets wrote:
>>
>> On 1/25/23 16:15, Vladislav Odintsov wrote:
>>> Hi,
>>>
>>> I’m a bit confused about linux unix socket files permissions, created by
>>> ovs daemons.
>>>
A long long time ago, an effort was made to make tc flower
rtnl_lock() free. However, on the OVS part we forgot to add
the TCA_KIND "flower" attribute, which tell the kernel to skip
the lock. This patch corrects this by adding the attribute for
the delete and get operations.
Signed-off-by: Eelco
31 matches
Mail list logo
