Re: [ovs-dev] [External] Re: [PATCH v4] utilities/ofctl: add-meters for save and restore

2023-03-03 Thread Wan Junjie
Hi Simon, Thanks for the review. On Fri, Mar 3, 2023 at 11:06 PM Simon Horman wrote: > > On Wed, Mar 01, 2023 at 04:05:17PM +0800, Wan Junjie wrote: > > put dump-meters' result in one line so add-meters can handle. > > save and restore meters when restart ovs. > > bundle functions are not

[ovs-dev] [PATCH ovn] controller: Use ofctrl_add_flow for CT SNAT hairpin flows.

2023-03-03 Thread Ilya Maximets
We no longer use conjunctions for these flows, so no need to try to append them. Fixes: c2f968235241 ("controller: Fix hairpin SNAT flow explosion if hairpin_snat_ip is set.") Signed-off-by: Ilya Maximets --- controller/lflow.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-)

Re: [ovs-dev] [PATCH v5 1/2] ofproto-dpif-upcall: Reset ukey's last stats value if the datapath changed.

2023-03-03 Thread Ilya Maximets
On 2/27/23 16:29, Eelco Chaudron wrote: > When the ukey's action set changes, it could cause the flow to use a > different datapath, for example, when it moves from tc to kernel. > This will cause the the cached previous datapath statistics to be used. > > This change will reset the cached

Re: [ovs-dev] [PATCH v5] ofproto-dpif-upcall: Wait for valid hw flow stats before applying min-revalidate-pps

2023-03-03 Thread Ilya Maximets
On 2/27/23 15:58, Eelco Chaudron wrote: > Depending on the driver implementation, it can take from 0.2 seconds > up to 2 seconds before offloaded flow statistics are updated. This is > true for both TC and rte_flow-based offloading. This is causing a > problem with min-revalidate-pps, as old

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-03-03 Thread Mike Pattrick
On Fri, Mar 3, 2023 at 12:31 PM Adrian Moreno wrote: > > Hi Mike, > > I've gone though this patch and have some minor style comments and nits. I've > also played a bit with it and run it through valgrind and looks solid. > > On 12/8/22 17:22, Mike Pattrick wrote: > > Several xlate actions used in

Re: [ovs-dev] [PATCH ovn branch-23.03 2/2] Prepare for 23.03.1.

2023-03-03 Thread Mark Michelson
Thanks for the ACKs Dumitru. I pushed the changes and tagged v23.03.0 . On 3/3/23 11:06, Dumitru Ceara wrote: On 3/3/23 16:42, Mark Michelson wrote: Signed-off-by: Mark Michelson --- Acked-by: Dumitru Ceara Regards, Dumitru ___ dev mailing

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Reduce stack usage in recursive xlate functions

2023-03-03 Thread Adrian Moreno
Hi Mike, I've gone though this patch and have some minor style comments and nits. I've also played a bit with it and run it through valgrind and looks solid. On 12/8/22 17:22, Mike Pattrick wrote: Several xlate actions used in recursive translation currently store a large amount of

Re: [ovs-dev] [PATCH ovn branch-23.03 2/2] Prepare for 23.03.1.

2023-03-03 Thread Dumitru Ceara
On 3/3/23 16:42, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara Regards, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn branch-23.03 1/2] Set release date for 23.03.0.

2023-03-03 Thread Dumitru Ceara
On 3/3/23 16:42, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- Acked-by: Dumitru Ceara Regards, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn branch-23.03 1/2] Set release date for 23.03.0.

2023-03-03 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index bb0e27bd5..5e8aed06d 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -OVN v23.03.0 - xx xxx +OVN v23.03.0 - 03 Mar 2023

[ovs-dev] [PATCH ovn branch-23.03 0/2] Release patches for v23.03.0.

2023-03-03 Thread Mark Michelson
Mark Michelson (2): Set release date for 23.03.0. Prepare for 23.03.1. NEWS | 5 - configure.ac | 2 +- debian/changelog | 8 +++- 3 files changed, 12 insertions(+), 3 deletions(-) -- 2.38.1 ___ dev mailing list

[ovs-dev] [PATCH ovn branch-23.03 2/2] Prepare for 23.03.1.

2023-03-03 Thread Mark Michelson
Signed-off-by: Mark Michelson --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 5e8aed06d..360d4d63e 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +OVN v23.03.1 - xx xxx

[ovs-dev] [PATCH] dpdk: Allow retaining CAP_SYS_RAWIO privileges

2023-03-03 Thread Aaron Conole
Open vSwitch generally tries to let the underlying operating system managed the low level details of hardware, for example DMA mapping, bus arbitration, etc. However, when using DPDK, the underlying operating system yields control of many of these details to userspace for management. In the case

Re: [ovs-dev] [PATCH v2 2/2] ci: Run tc offload tests in GitHub Actions.

2023-03-03 Thread Simon Horman
On Tue, Feb 28, 2023 at 04:52:15PM +0100, Eelco Chaudron wrote: > Run "make check-offloads" as part of the GitHub actions tests. > > This test was run 25 times using GitHub actions, and the > failing rerun test cases where excluded. There are quite some > first-run failures, but unfortunately,

Re: [ovs-dev] [PATCH v4] utilities/ofctl: add-meters for save and restore

2023-03-03 Thread Simon Horman
On Wed, Mar 01, 2023 at 04:05:17PM +0800, Wan Junjie wrote: > put dump-meters' result in one line so add-meters can handle. > save and restore meters when restart ovs. > bundle functions are not implemented in this patch. > > Signed-off-by: Wan Junjie > > --- > v4: > code refactor according to

Re: [ovs-dev] [PATCH v7 1/2] ofp, dpif: Allow CT flush based on partial match

2023-03-03 Thread Roi Dayan via dev
On 01/03/2023 14:01, Ales Musil wrote: > On Wed, Mar 1, 2023 at 12:34 PM Roi Dayan wrote: > >> >> >> On 01/03/2023 12:53, Roi Dayan via dev wrote: >>> >>> >>> On 16/01/2023 13:45, Ales Musil wrote: Currently, the CT can be flushed by dpctl only by specifying the whole 5-tuple. This

Re: [ovs-dev] [PATCH ovn v2] northd, controller: Commit flows dropped by ACLs to conntrack

2023-03-03 Thread Abhiram Sangana
> On 13 Feb 2023, at 16:35, Abhiram Sangana wrote: > > This patch adds support to commit connections dropped/rejected by > ACLs to the connection tracking table. Dropped connections are > committed to conntrack only if NB_Global options:ct_commit_acl_drop > is set to true (false by default)

Re: [ovs-dev] [PATCH v8] netdev-offload-tc: del ufid mapping if device not exist

2023-03-03 Thread Eelco Chaudron
On 2 Mar 2023, at 8:57, Faicker Mo wrote: > The device may be deleted and added with ifindex changed. > The tc rules on the device will be deleted if the device is deleted. > The func tc_del_filter will fail when flow del. The mapping of > ufid to tc will not be deleted. > The traffic will

Re: [ovs-dev] [PATCH ovn v2 0/3] northd: Optimize parsing of LSP addresses.

2023-03-03 Thread Dumitru Ceara
On 3/2/23 15:50, Mark Michelson wrote: > On 3/2/23 09:45, Simon Horman wrote: >> On Thu, Mar 02, 2023 at 02:14:24PM +0100, Dumitru Ceara wrote: >>> On 3/2/23 14:11, Ilya Maximets wrote: This patch set optimizes usage of string operations and avoids parsing same LSP addresses multiple

Re: [ovs-dev] [PATCH 1/1] usdt-scripts: use ebpf to track upcall_cost

2023-03-03 Thread Eelco Chaudron
On 3 Mar 2023, at 11:45, Adrian Moreno wrote: > On 3/3/23 11:33, Eelco Chaudron wrote: >> >> >> On 27 Feb 2023, at 15:29, Ilya Maximets wrote: >> >>> On 2/24/23 11:41, Adrián Moreno wrote: From: Adrian Moreno This is basically a rewrite of the upcall_cost.py script moving some

Re: [ovs-dev] [PATCH 1/1] usdt-scripts: use ebpf to track upcall_cost

2023-03-03 Thread Adrian Moreno
On 3/3/23 11:33, Eelco Chaudron wrote: On 27 Feb 2023, at 15:29, Ilya Maximets wrote: On 2/24/23 11:41, Adrián Moreno wrote: From: Adrian Moreno This is basically a rewrite of the upcall_cost.py script moving some of it's functionality to the ebpf programs. These are the main changes:

Re: [ovs-dev] [PATCH 1/1] usdt-scripts: use ebpf to track upcall_cost

2023-03-03 Thread Adrian Moreno
On 2/27/23 15:29, Ilya Maximets wrote: On 2/24/23 11:41, Adrián Moreno wrote: From: Adrian Moreno This is basically a rewrite of the upcall_cost.py script moving some of it's functionality to the ebpf programs. These are the main changes: * Correlation of kernel upcall <-> userspace recv

Re: [ovs-dev] [PATCH 1/1] usdt-scripts: use ebpf to track upcall_cost

2023-03-03 Thread Eelco Chaudron
On 27 Feb 2023, at 15:29, Ilya Maximets wrote: > On 2/24/23 11:41, Adrián Moreno wrote: >> From: Adrian Moreno >> >> This is basically a rewrite of the upcall_cost.py script moving some of >> it's functionality to the ebpf programs. These are the main changes: >> >> * Correlation of kernel

Re: [ovs-dev] ovn: Handling of arp/nd learning on logical switches

2023-03-03 Thread Olaf Seibert via dev
Tangentially related to this: I was trying to detect when the problem with the "too many resubmits" occurs, for alerting purposes. Some light examination of the source of ovs suggested that the coverage counter "drop_action_too_many_resubmit" corresponds to the error

Re: [ovs-dev] [PATCH v6 5/5] route-table: Retrieving the preferred source address from Netlink.

2023-03-03 Thread Eelco Chaudron
On 2 Mar 2023, at 7:34, Nobuhiro MIKI wrote: > We can use the "ip route add ... src ..." command to set the preferred > source address for each entry in the kernel FIB. OVS has a mechanism to > cache the FIB, but the preferred source address is ignored and > calculated with its own logic. This

Re: [ovs-dev] [PATCH v6 4/5] ovs-router: Introduce src option in ovs/route/add command.

2023-03-03 Thread Eelco Chaudron
On 2 Mar 2023, at 7:34, Nobuhiro MIKI wrote: > When adding a route with ovs/route/add command, the source address > in "ovs_router_entry" structure is always the FIRST address that the > interface has. See "ovs_router_get_netdev_source_address" > function for more information. > > If an

Re: [ovs-dev] [PATCH v6 3/5] ofproto: Fix mam page for tunnel related commands.

2023-03-03 Thread Eelco Chaudron
On 2 Mar 2023, at 7:34, Nobuhiro MIKI wrote: > Fixed the manual page to indicate that both IPv4/IPv6 > are supported. Also added missing pkt_mark on one side > and fixed the "gw" and "bridge" notation quirks. > > Reviewed-by: Simon Horman > Signed-off-by: Nobuhiro MIKI > --- >

Re: [ovs-dev] [PATCH v6 2/5] ovs-router: Cleanup parser for ovs/route/add command.

2023-03-03 Thread Eelco Chaudron
On 2 Mar 2023, at 7:34, Nobuhiro MIKI wrote: > This patch cleans up the parser to accept pkt_mark and gw in any order. > > pkt_mark and gw are normally expected to be specified exactly once. > However, as with other tools, if specified multiple times, the last > specification is used. Also,

Re: [ovs-dev] [PATCH v6 1/5] netdev-dummy: Support multiple IP addresses.

2023-03-03 Thread Eelco Chaudron
On 2 Mar 2023, at 7:34, Nobuhiro MIKI wrote: > This is useful in test cases where multiple IPv4/IPv6 addresses > are assigned together. > > Acked-by: Eelco Chaudron > Reviewed-by: Simon Horman > Signed-off-by: Nobuhiro MIKI > --- This patch still looks good with the additional changes!

[ovs-dev] ovn: Handling of arp/nd learning on logical switches

2023-03-03 Thread Felix Hüttner via dev
Hello everyone, We had a discussion on ovs-discuss that we wanted to bring here [1]: Assume a physical network connected to a OVN Logical_Switch and then multiple Logical_Routers like so: ++ | Logical Router | | lr001 +-+ ++ | |